)]}' { "commit": "c75a639cd07758f9fe6afc86fef0ce9150d0f3cf", "tree": "716aceb96a10673b0117bd8d6d3b64d0a0d54ed2", "parents": [ "9a351449e7cf4bf0ae6cf838e3b431b7934eda9a" ], "author": { "name": "Andrew Lamb", "email": "andrewlamb@chromium.org", "time": "Fri Feb 14 20:08:14 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Feb 18 19:11:12 2020" }, "message": "Add common_checks dir and call from checker.\n\n- Checker attempts to discover checks in 3 places:\n1. common_checks dir.\n2. Project repo.\n3. Program repo.\n\n- Add basic ConstraintSuite that checks ids are\nconsistent as an example.\n\n- Right now just fail a check by throwing an\nerror and do basic logging when a check is run.\nLogging and failure handling can be improved in\nthe future.\n\n- Also added an exclude_pattern arg to\ndiscover_suites to allow excluding tests. If tests\nimport a constraint suite, the suite would be\ndefined twice, and run twice.\n\nBUG\u003dchromium:1051187\nTEST\u003dpayload_utils/checker.py \\\n--program ../program/volteer \\\n--project ../project/volteer/volteer\nTEST\u003dpython unittests\n\nChange-Id: Ida593429f5bbb85d23027db7db27f4f2f1e3f781\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/config/+/2056867\nCommit-Queue: Andrew Lamb \u003candrewlamb@chromium.org\u003e\nTested-by: Andrew Lamb \u003candrewlamb@chromium.org\u003e\nReviewed-by: David Burger \u003cdburger@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "c0ab2750aa09c7bbd6e1b24686a2442f86409613", "old_mode": 33261, "old_path": "payload_utils/checker.py", "new_id": "64ae6253b1641256c313d7795cf44cec8fa380f6", "new_mode": 33261, "new_path": "payload_utils/checker.py" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391", "new_mode": 33188, "new_path": "payload_utils/checker/common_checks/__init__.py" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "dc3039c7e1183afc463442c4e89e47838931c30e", "new_mode": 33188, "new_path": "payload_utils/checker/common_checks/check_ids.py" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "37b8db477b3e54bf94aeebb4287675e8a39c66a9", "new_mode": 33188, "new_path": "payload_utils/checker/common_checks/check_ids_test.py" }, { "type": "modify", "old_id": "565b1c385bc00439dd1b5de46bb7368bb0885ffd", "old_mode": 33188, "old_path": "payload_utils/checker/constraint_suite.py", "new_id": "b8de3f78e1d3b4599491882f49c6da837409d284", "new_mode": 33188, "new_path": "payload_utils/checker/constraint_suite.py" }, { "type": "modify", "old_id": "1c27f45fd0c9af0f6927bc38e8145bbd6f20ab9a", "old_mode": 33188, "old_path": "payload_utils/checker/constraint_suite_discovery.py", "new_id": "d781460f422608a56e3f3681eae7e44c930e6926", "new_mode": 33188, "new_path": "payload_utils/checker/constraint_suite_discovery.py" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "0b1bca81b887f0f185ed89b2bf093e90b4c9f705", "new_mode": 33188, "new_path": "payload_utils/checker/testdata/README" }, { "type": "rename", "old_id": "566407dafb242fd761b8c706e46b6a63281134aa", "old_mode": 33188, "old_path": "payload_utils/checker/testdata/check_test_example1.py", "new_id": "566407dafb242fd761b8c706e46b6a63281134aa", "new_mode": 33188, "new_path": "payload_utils/checker/testdata/check_example1.py", "score": 100 }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "4d51383311fe1d225b69f8e0bdde3f9d5b228238", "new_mode": 33188, "new_path": "payload_utils/checker/testdata/check_example1_test.py" }, { "type": "rename", "old_id": "3288a635f066a79a4cb289d847fb099dffce468c", "old_mode": 33188, "old_path": "payload_utils/checker/testdata/check_test_example2.py", "new_id": "3288a635f066a79a4cb289d847fb099dffce468c", "new_mode": 33188, "new_path": "payload_utils/checker/testdata/check_example2.py", "score": 100 } ] }