Google Git
Sign in
chromium / chromiumos / docs / 2a6fee7a3d6066af1a1e0420a7c5f066f1cfbca7
commit2a6fee7a3d6066af1a1e0420a7c5f066f1cfbca7[log] [tgz]
authorBen Chan <benchan@chromium.org>Mon Oct 09 22:41:12 2017
committerchrome-bot <chrome-bot@chromium.org>Tue Oct 10 03:07:57 2017
tree28b2aa59d623d268d1ec79290ff77562156c7bfe
parentd352c44e385f3a46a5aad6d3f247c5cc18efb012 [diff]
docs: use std::make_unique instead of base::MakeUnique in example

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG=chromium:769107
TEST=None

Change-Id: I07607d8242e37f64d86a7ee1a8478db819a3e0e0
Reviewed-on: https://chromium-review.googlesource.com/707894
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
1 file changed
tree: 28b2aa59d623d268d1ec79290ff77562156c7bfe
  1. chrome_commit_pipeline.md
  2. cros_commit_pipeline.md
  3. cros_vm.md
  4. dbus_best_practices.md
  5. development_basics.md
  6. README.md
  7. rust_on_cros.md
  8. sandboxing.md
  9. simple_chrome_workflow.md
  10. unit_tests.md
README.md

Chromium OS docs

This directory contains public Chromium OS project documentation that is automatically rendered by Gitiles. The docs are written in Gitiles-flavored Markdown.

General guidelines

See the Chromium documentation guidelines and Chromium documentation best practices.

Style guide

Markdown documents must follow the style guide.

Making changes

This repository is managed by the repo tool, so you can make changes to it using the same techniques that you'd use for any other repositories in the project. Feel free to bypass the commit queue and commit changes immediately after they are reviewed.

Making changes without repo

You can also make changes to this repository without using the repo tool. This comes in handy when you don't have a Chromium OS checkout:

git clone https://chromium.googlesource.com/chromiumos/docs
curl -Lo .git/hooks/commit-msg https://gerrit-review.googlesource.com/tools/hooks/commit-msg
chmod +x .git/hooks/commit-msg
cd docs
git checkout -b changes
(make some changes)
git commit -a
git push origin HEAD:refs/for/master

The above steps will upload a patch to chromium-review.googlesource.com where you can get your patch reviewed, and submit.

Previewing changes

You can preview your local changes using md_browser:

# at top of Chromium OS checkout
./chromium/src/tools/md_browser/md_browser.py -d docs

Then browse to e.g. http://localhost:8080/README.md.

To review someone else's changes, apply them locally first, or just click the gitiles link near the top of a Gerrit file diff page.