commit 55604ba5f4656c70f961b3f7b2a70f5237e7f524
author Paul Hobbs <phobbs@google.com> Fri Apr 20 20:22:13 2018
committer Paul Hobbs <phobbs@google.com> Sun Apr 22 01:08:15 2018
tree 02af06508e8c6e0a71896ee0d49456b444578349
parent 5b4a952c42ce4822bdc9bf007ce2fea6b044afc0

Add trivial pre-cq e2e test

BUG=chromium:835076
TEST=main_test

Change-Id: I8aae58cd86123925168bbf6f3990ea50c6c3a843

main_test.py

diff --git a/main_test.py b/main_test.py
index 3dd6f68..0a40b33 100644
--- a/main_test.py
+++ b/main_test.py
@@ -15,7 +15,7 @@
 from chromite.lib import cidb
 from chromite.lib import constants
 from chromite.lib import gerrit
-from google.cloud import datastore
+from google.cloud import datastore  # pylint: disable=E0611,import-error
 import pytest
 import mock
 
@@ -58,8 +58,8 @@
   return helper
 
 
-def _CQCronTest(client, cidb_conn,
-                datastore_client, change_details_map):
+def _CronTest(client, cidb_conn, datastore_client, change_details_map,
+              endpoint='cq'):
   """Patches services with side-effects.
 
   Args:
@@ -68,17 +68,18 @@
     datastore_client: A fake datastore.Client
     change_details_map: A Dict[int, object] mapping change numbers to change
         details responses from the gerrit API.
+    endpoint: /cron/exonerate/<endpoint> to call, defaults to 'cq'
 
   Returns:
-    The JSON response from /cron/exonerate/cq
+    The JSON response from |endpoint|
   """
   with mock.patch.object(datastore, 'Client', return_value=datastore_client),\
-       mock.patch.object(cidb, 'CIDBConnection', return_value=cidb_conn),\
-       mock.patch.object(gerrit, 'GetGerritHelper',
-                   return_value=_GerritHelper(change_details_map)),\
-       _PatchDatetime():
+      mock.patch.object(cidb, 'CIDBConnection', return_value=cidb_conn),\
+      mock.patch.object(gerrit, 'GetGerritHelper',
+          return_value=_GerritHelper(change_details_map)),\
+      _PatchDatetime():
     response = client.get(
-        '/cron/exonerate/cq',
+        '/cron/exonerate/' + endpoint,
         headers={main.APPENGINE_CRON_HEADER: 'true'})
   return json.loads(response.get_data(as_text=True))
 
@@ -93,9 +94,14 @@
 
 
 def TestEmptyDatabase(client, cidb_conn, datastore_client):
+  """Endpoints should succeed, but do nothing when the databases are empty."""
   change_details_map = {}
-  response = _CQCronTest(client, cidb_conn, datastore_client,
-                         change_details_map)
+  response = _CronTest(client, cidb_conn, datastore_client, change_details_map)
+  assert response['exonerated'] == []
+
+  response = _CronTest(
+      client, cidb_conn, datastore_client, change_details_map,
+      endpoint='pre-cq')
   assert response['exonerated'] == []
 
 
@@ -128,8 +134,11 @@
       'timestamp': '2017-01-01 00:00:00'
   })
 
-  response = _CQCronTest(client, cidb_conn, datastore_client,
-                         change_details_map)
+  response = _CronTest(client, cidb_conn, datastore_client, change_details_map)
+  assert response['exonerated'] == []
+
+  response = _CronTest(client, cidb_conn, datastore_client, change_details_map,
+                       endpoint='pre-cq')
   assert response['exonerated'] == []
 
 
@@ -162,6 +171,9 @@
       'timestamp': '2017-01-01 00:00:00'
   })
 
-  response = _CQCronTest(client, cidb_conn, datastore_client,
-                         change_details_map)
+  response = _CronTest(client, cidb_conn, datastore_client, change_details_map)
   assert response['exonerated'] == [[list(patch), build_id]]
+
+  response = _CronTest(client, cidb_conn, datastore_client, change_details_map,
+                       endpoint='pre-cq')
+  assert response['exonerated'] == []