commit 439eba782bde9d318d74d5924a304b245842160b
author David Burger <dburger@chromium.org> Wed Nov 21 21:27:47 2018
committer chrome-bot <chrome-bot@chromium.org> Fri Nov 30 00:08:59 2018
tree 0eacd5246bcb3d8161f3cb456d18b9120afd2598
parent 55604ba5f4656c70f961b3f7b2a70f5237e7f524

Remove waterfall parameter from InsertBuild calls in tests

Per the change in http://crrev.com/c/1347298 remove the waterfall
parameter from calls to InsertBuild.

TEST=cros tryjob -g "1347298 1347299 1347393 1347392 1347391" chromeos-infra-unittests-pre-cq
BUG=chromium:836551
CQ-DEPEND=CL:1347298

Change-Id: Idcb9ffb27c5466158820624e0c95e651a4c74f55
Reviewed-on: https://chromium-review.googlesource.com/1347392
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

exonerator/innocent_cls_cq_test.py

diff --git a/exonerator/innocent_cls_cq_test.py b/exonerator/innocent_cls_cq_test.py
index c8be0e3..f47cb0d 100644
--- a/exonerator/innocent_cls_cq_test.py
+++ b/exonerator/innocent_cls_cq_test.py
@@ -49,7 +49,6 @@
 
   default_build_values = {
       'builder_name': 'my builder',
-      'waterfall': 'chromiumos',
       'build_config': 'a build config',
       'bot_hostname': 'bot hostname',
   }

exonerator/innocent_cls_precq_test.py

diff --git a/exonerator/innocent_cls_precq_test.py b/exonerator/innocent_cls_precq_test.py
index 3723ab6..24c7f03 100644
--- a/exonerator/innocent_cls_precq_test.py
+++ b/exonerator/innocent_cls_precq_test.py
@@ -62,8 +62,7 @@
     """Creates rows in cidb for a finalized BAD_CL annotation."""
     self.build_ids.append(
         self.db.InsertBuild(
-            'test_build', 'waterfall', 2, 'test_build', 'hostname',
-            status=status))
+            'test_build', 2, 'test_build', 'hostname', status=status))
     action_picked_up = clactions.CLAction.FromGerritPatchAndAction(
         GerritPatchTuple(cl_number, 1, True),
         constants.CL_ACTION_PICKED_UP)
@@ -82,8 +81,7 @@
   def _InsertSanityBuild(self, status):
     self.build_ids.append(
         self.db.InsertBuild(
-            'test_build', 'waterfall', 1, 'test_build', 'hostname',
-            status=status))
+            'test_build', 1, 'test_build', 'hostname', status=status))
     now = datetime.datetime.now() + datetime.timedelta(seconds=1)
     self.build_requests.append(
         build_requests.BuildRequest(
@@ -109,7 +107,7 @@
     """If the CL was picked up after the failure, we don't exonerate."""
     self._InsertSanityBuild(constants.BUILDER_STATUS_FAILED)
     new_build_id = self.db.InsertBuild(
-        'test_build', 'waterfall', 1, 'test_build', 'hostname',
+        'test_build', 1, 'test_build', 'hostname',
         status=constants.BUILDER_STATUS_PASSED)
     new_action = clactions.CLAction.FromGerritPatchAndAction(
         GerritPatchTuple(1234, 1, True),

main_test.py

diff --git a/main_test.py b/main_test.py
index 0a40b33..08d8686 100644
--- a/main_test.py
+++ b/main_test.py
@@ -26,7 +26,6 @@
 
 _DEFAULT_BUILD_VALUES = {
     'builder_name': 'my builder',
-    'waterfall': 'chromiumos',
     'build_config': 'a build config',
     'bot_hostname': 'bot hostname',
 }