Google Git
Sign in
chromium / chromiumos / infra / cl_exonerator / 439eba782bde9d318d74d5924a304b245842160b
commit439eba782bde9d318d74d5924a304b245842160b[log] [tgz]
authorDavid Burger <dburger@chromium.org>Wed Nov 21 21:27:47 2018
committerchrome-bot <chrome-bot@chromium.org>Fri Nov 30 00:08:59 2018
tree0eacd5246bcb3d8161f3cb456d18b9120afd2598
parent55604ba5f4656c70f961b3f7b2a70f5237e7f524 [diff]
Remove waterfall parameter from InsertBuild calls in tests

Per the change in http://crrev.com/c/1347298 remove the waterfall
parameter from calls to InsertBuild.

TEST=cros tryjob -g "1347298 1347299 1347393 1347392 1347391" chromeos-infra-unittests-pre-cq
BUG=chromium:836551
CQ-DEPEND=CL:1347298

Change-Id: Idcb9ffb27c5466158820624e0c95e651a4c74f55
Reviewed-on: https://chromium-review.googlesource.com/1347392
Commit-Ready: David Burger <dburger@chromium.org>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
3 files changed
tree: 0eacd5246bcb3d8161f3cb456d18b9120afd2598
  1. bin/
  2. exonerator/
  3. flex_ts_mon/
  4. testing_utils/
  5. chromite ⇨ ../../chromite
  6. pylintrc ⇨ ../../chromite/pylintrc
  7. .gitignore
  8. app.yaml
  9. config.py
  10. cron.yaml
  11. debug_routes.py
  12. debug_routes_test.py
  13. deploy_app.py
  14. gunicorn.conf.py
  15. main.py
  16. main_test.py
  17. Pipfile
  18. Pipfile.lock
  19. PRESUBMIT.cfg
  20. pytest.ini
  21. README.md
README.md

CL Exonerator

https://chromium.googlesource.com/chromiumos/infra/cl_exonerator

Purpose:

This app finds CLs which were incorrectly blamed for a CQ failure, and re-marks them as CQ-ready. It does this by polling cidb‘s buildMessageTable for finalize messages, then finds CLs which were blamed in the build’s annotatations and marks them as CQ+1 in Gerrit (if they haven't already been).

Credentials

Create a “creds” folder, then:

  • For local development, run “cros cidbcreds --folder=creds/cidb” to fetch the readonly credentials.

  • For deploying to production, see go/cros-cidb-admin and get the prod_cidb_gen2_annotator credentials.

Development

Local deployment is done by creating a virtualenv with pipenv:

# pipsi is a nice python utility for installing other python scripts in their
# own virtualenvs, so you don't get version conflicts between the various
# scripts installed on your system.
sudo `which pip` install pipsi
pipsi install pipenv
pipenv install --dev
pipenv shell

Tests are run with pytest:

pipenv run pytest exonerator

Start a development server with bin/local_server and run curl -u admin http://localhost:8080/cls?type=pending to see a list of pending CLs.

Deployment

CL-Exonerator is deployed to the google.com:chromiumos-cl-exonerator project. Before deploying, make sure you have activated it as your default project with gcloud:

gcloud config set project chromiumos-cl-exonerator

Then deploy with the ./deploy_app script:

pipenv shell
./deploy_app
  • Debug environment:

Run ./deploy_app --debug=True after copying or symlinking debug_cidbi_gen2_bot creds into ./creds/cidb.dbg (see the [Credentials][#Credentials] section)

  • Production:

Run “./deploy_app” after copying or symlinking prod_cidb_gen2_bot creds into “./creds/cidb”.