commit | 44f3b8fb05a75d90a0d607d171f732f84e3ad4b8 | [log] [tgz] |
---|---|---|
author | Tim Bain <tbain@google.com> | Fri May 10 18:08:06 2024 |
committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 10 19:22:36 2024 |
tree | a08863e5c088f406eba28d639b1d77901725c465 | |
parent | fdb4c6561e9eba8f604af7fa187b7850fddf8076 [diff] |
Revert "[Refactoring] Change `address` to `hostname` when a user updates" This reverts commit 55980c44ef6286ac60eab6f2322a54fef8ed0f57. Reason for revert: Broke https://autoroll.skia.org/r/cros-proto-infra-autoroll. Editing fields in a proto that's been merged is almost never safe. Deprecate the old fields and create new ones, don't rename. Original change's description: > [Refactoring] Change `address` to `hostname` when a user updates > the pools. Change `addresses` to `hostnames` when a user adds the pool. > > BUG=None > Test=manual > > Change-Id: I3299c05da061d063a0772b25ea37dbb8124f5f8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/infra/proto/+/5376385 > Reviewed-by: Michal Matyjek <mmatyjek@google.com> > Commit-Queue: Michal Matyjek <mmatyjek@google.com> BUG=None Change-Id: I25fc2b76346d36fc0b140aa8191ab5adc572a6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/infra/proto/+/5532301 Auto-Submit: Tim Bain <tbain@google.com> Reviewed-by: Michal Matyjek <mmatyjek@google.com> Commit-Queue: Michal Matyjek <mmatyjek@google.com>
This repository exists in two locations in the tree: infra/proto
, and chromite/infra/proto
. The infra/proto
repository is always at ToT, while the chromite/infra/proto
checkout is branched to allow the proto there to (more) accurately reflect the version of the proto the Build API is using.
When making changes to the proto that you need to test in the Build API, you will need ensure the changes are applied to the chromite/infra/proto
checkout. Chromite generates its proto bindings from the chromite/infra/proto
repo.