| <?xml version="1.0" encoding="utf-8"?><manifest revision="85a6c0b735cec782df25aead16b312fd6618ca5d"> |
| <notice>Your sources have been sync'd successfully.</notice> |
| <remote fetch="https://android.googlesource.com" name="aosp" review="https://android-review.googlesource.com"/> |
| <remote alias="cros" fetch="https://chromium.googlesource.com/" name="chromium"/> |
| <remote fetch="https://chromium.googlesource.com" name="cros" review="https://chromium-review.googlesource.com"/> |
| <default remote="cros" revision="refs/heads/master" sync-j="8"/> |
| <project name="aosp/platform/external/libchrome" path="src/aosp/external/libchrome" revision="084fa8eb1895be216dbc4170886922ec99612381" upstream="refs/heads/master"/> |
| <project name="aosp/platform/external/modp_b64" path="src/third_party/modp_b64" revision="99dc13926931cedfd2e4e582c33ef657d0645c5c" upstream="refs/heads/master"/> |
| <project name="aosp/platform/system/core/libsync" path="src/aosp/system/libsync" revision="f4f4387b6bf2387efbcfd1453af4892e8982faf6" upstream="refs/heads/master"/> |
| <project groups="devserver" name="aosp/platform/system/update_engine" path="src/aosp/system/update_engine" revision="73733a0bd4162229c194dbd365b9d4c4e768ec2c" upstream="refs/heads/master"/> |
| <project name="apps/libapps" path="src/third_party/libapps" revision="99b17e298959d22715d8230fef09967b0efa6608" upstream="refs/heads/master"> |
| <annotation name="branch-mode" value="pin"/> |
| </project> |
| <project name="chromium/deps/libmtp" path="chromium/src/third_party/libmtp" remote="chromium" revision="4f4fad584e9c2735af5131f15b697376a3327de5" upstream="refs/heads/master"/> |
| <project groups="minilayout,buildtools,labtools" name="chromium/llvm-project/cfe/tools/clang-format" path="src/chromium/src/buildtools/clang_format/script" remote="chromium" revision="a3caf45a3f9302ce616f08bd7fd0412f3d97e862" upstream="refs/heads/master"/> |
| <project groups="minilayout,buildtools,labtools" name="chromium/src/buildtools" path="src/chromium/src/buildtools" remote="chromium" revision="218cb3d12efc52e79dbaf9f8d52d721d8b5a45a7" upstream="refs/heads/master"/> |
| <project name="chromium/src/third_party/Python-Markdown" path="src/chromium/src/third_party/Python-Markdown" remote="chromium" revision="b08af21eb795e522e1b972cb85bff59edb1ae209" upstream="refs/heads/master"/> |
| <project name="chromium/src/tools/md_browser" path="src/chromium/src/tools/md_browser" remote="chromium" revision="e9462696241f3ca832890473173e03e7bcfe6adc" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,labtools" name="chromium/tools/depot_tools" remote="chromium" revision="80a1cf66b83c394c911b14312274b26dba888ae0"/> |
| <project groups="minilayout,firmware,buildtools,chromeos-admin,labtools,sysmon,devserver" name="chromiumos/chromite" path="chromite" revision="de64cb214d81c5af372b16e1f51c415f851358f6" upstream="refs/heads/master"> |
| <copyfile dest="AUTHORS" src="AUTHORS"/> |
| <copyfile dest="LICENSE" src="LICENSE"/> |
| </project> |
| <project name="chromiumos/containers/cros-container-guest-tools" path="src/platform/container-guest-tools" revision="7dac7e929dfb253c29630da2dcc5cd98b36443d8" upstream="refs/heads/master"/> |
| <project name="chromiumos/docs" path="docs" revision="88cf2dfe3a7f1855047b929441b5d554269261cc" upstream="refs/heads/master"/> |
| <project name="chromiumos/graphyte" path="src/platform/graphyte" revision="7ea5c995be1ba3ff1a39e5e63fdee4b57c6434e5" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/bad_cl_detector" path="infra/bad_cl_detector" revision="08bb5589019bbaae1039240ce347cdc3ed05f43a" upstream="refs/heads/master"/> |
| <project groups="chromeos-admin" name="chromiumos/infra/ci_results_archiver" path="infra/ci_results_archiver" revision="4493ad78616152e22672ed245b72806c56cfef0d" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/cl_exonerator" path="infra/cl_exonerator" revision="439eba782bde9d318d74d5924a304b245842160b" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/cl_status_viewer" path="infra/cl_status_viewer" revision="6bda7c611af03cb53db2afa190e0a81ce6d37169" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/distfiles_updater" path="infra/distfiles_updater" revision="2d1aa33972b2028d19a288baaacee9b2cd8644f7" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/dummies/general-sandbox" path="infra/dummies/general-sandbox" revision="ab009ffebb68a58f37779bddfba5f1a08ef174ae" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/dummies/merge-sandbox" path="infra/dummies/merge-sandbox" revision="651c1f3b89c112222f5dae2f79091421543dd4ee" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/logstock" path="infra/logstock" revision="ef7fe408b9feee9a3664b36f0176fcacd27bf703" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/lucifer" path="infra/lucifer" revision="5a0a3591573b7716fe8c2fe24aba0dff23d2ba69" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/proto" path="chromite/infra/proto" revision="eb49fd0099e80adf617b13ed560304f28f7d8226" upstream="refs/heads/master"> |
| <annotation name="branch-mode" value="tot"/> |
| </project> |
| <project groups="chromeos-admin" name="chromiumos/infra/recipes" path="infra/recipes" revision="cffb6b6642404cf72ac10b757872e5c647b6402c" upstream="refs/heads/master"> |
| <annotation name="branch-mode" value="tot"/> |
| </project> |
| <project groups="chromeos-admin,labtools" name="chromiumos/infra/skylab_inventory" path="infra/skylab_inventory" revision="47a7495453815b77df3f2af6d716fbeff41f308b" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/suite_scheduler" path="infra/suite_scheduler" revision="fa71d23340b5b70b60d34555c8eb46b1be08deb2" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/test_analyzer" path="infra/test_analyzer" revision="7b0a71303075b11ce506fe6c34477a139c02236e" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,chromeos-admin,labtools,sysmon,devserver" name="chromiumos/infra_virtualenv" path="infra_virtualenv" revision="bd33427afb37ec05127792091ffc87bfefb48121" upstream="refs/heads/master"/> |
| <project name="chromiumos/manifest" path="manifest" revision="79ad8adebe6ec1b58186d157cdd955a0b8a77fc8" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware" name="chromiumos/overlays/board-overlays" path="src/overlays" revision="b42b124a8ca4225c57710eee7e4a6389ffd20bcd" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,labtools" name="chromiumos/overlays/chromiumos-overlay" path="src/third_party/chromiumos-overlay" revision="120ed40643a19e570f90c309252394ddb6f6cdef" sync-c="true" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,labtools" name="chromiumos/overlays/eclass-overlay" path="src/third_party/eclass-overlay" revision="a5efe27269b01dc24e8796aea915e6a53d456d88" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,labtools" name="chromiumos/overlays/portage-stable" path="src/third_party/portage-stable" revision="f9acd99bd71723d3d356ab9568a58d49efe08a0f" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/assets" path="src/platform/assets" revision="bf50279068621fa7edd8811dc8abfa01997d2c3c" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/audiotest" path="src/platform/audiotest" revision="8038158371ba934e0da7c09dedf628b9a45e566b" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/battery_updater" path="src/platform/battery_updater" revision="32463c6de8e8c98d4b1711937bc7678afc121a85" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/bisect-kit" path="src/platform/bisect-kit" revision="c5574bcb50dcf6a0dd3fad86caf4df609987d94a" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/bmpblk" path="src/platform/bmpblk" revision="4c5580d67490e0507a216ddefb6e7b6231bc330e" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/bootcache" path="src/platform/bootcache" revision="ebe3a0995e90026433ffc62b7aeed6cad1f28694" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/btsocket" path="src/platform/btsocket" revision="300354e5d74418c8e03737ca9029c64d9297a28d" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/cfm-device-monitor" path="src/platform/cfm-device-monitor" revision="309aa554f9142ea76fadbeb9571eed7b1e8b655a" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/chameleon" path="src/platform/chameleon" revision="75d7cf12830308aa3ca32a74690204e40bbb7540" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/chromiumos-assets" path="src/platform/chromiumos-assets" revision="fd4e8eef335ceaca7adf53a83f5e13e00e09101c" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/cobble" path="src/platform/cobble" revision="3d2b9922e81cce898d4f09306563d3ca9d32c67e" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools" name="chromiumos/platform/crostestutils" path="src/platform/crostestutils" revision="bd91ec0c142fe5d9615477eaf3667bb5dc37c326" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,labtools" name="chromiumos/platform/crosutils" path="src/scripts" revision="9af21f5b87c9c2b63b3b0d5b1122b37840af8bc8" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/crosvm" path="src/platform/crosvm" revision="0a367518b69292c164db13a3ac81cab5bff9ee39" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/depthcharge" path="src/platform/depthcharge" revision="4037d6adc5c526f89a220736206f82afdafed951" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,devserver" name="chromiumos/platform/dev-util" path="src/platform/dev" revision="97ed37f76bdad68a85d0dab5b2c584c997553f50" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/dm-verity" path="src/platform/verity" revision="240acaa806e64238b0fda54b478209b6aec430b3" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/drm-tests" path="src/platform/drm-tests" revision="ab04f3ea3bf118f1bc7740d80f007320d1b68eaa" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/ec" path="src/platform/ec" revision="d0a350e6691a9d93138051e2aa00e0d6c26151b5" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/experimental" path="src/platform/experimental" revision="bcc00ca58726d9cf774c56005715a5ee330da045" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/factory" path="src/platform/factory" revision="1fae0502289da1e7cc8baa6273e0f89c74a58f85" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/factory_installer" path="src/platform/factory_installer" revision="da13c01c9c2296a258511bff10ce1a76a153e548" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/firmware" path="src/platform/firmware" revision="b2c29757b90133e8e6315800a1afdeafe4a2bc5a" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/frecon" path="src/platform/frecon" revision="83776b7bc992b0e43e95c5b94885a3ce4d7d6c00" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/gestures" path="src/platform/gestures" revision="113de4bb26e228fd74c74cadb3a9a1272e11df5b" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/glbench" path="src/platform/glbench" revision="cca28de19ca10edce5e38d29056a9b7f5677989a" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/go-seccomp" path="src/platform/go-seccomp" revision="613458c0e3c589e52e7f093288ef1d2ba57a9ff7" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/google-breakpad" path="src/third_party/breakpad" revision="83772463d01e5728b834a4040729545adaeaa1e4" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/initramfs" path="src/platform/initramfs" revision="e043793ce4968d66e0abfc27e4be9c976ba2ccb6" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/inputcontrol" path="src/platform/inputcontrol" revision="8826acba1c4e13b6318ae6d1d4b49633d1b55aba" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/jabra_vold" path="src/platform/jabra_vold" revision="8830911158ae632b7626d0ebe33248e66ffaeef3" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/libevdev" path="src/platform/libevdev" revision="23f8ea74685ea0a03be8649ca33d5664bc789393" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/microbenchmarks" path="src/platform/microbenchmarks" revision="518003bc070970f25b9ab97c0560d762846c5e65" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/minigbm" path="src/platform/minigbm" revision="582bdbf1d78513445e5035fe594c600f69bc7332" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/moblab" path="src/platform/moblab" revision="0dcebfc00945fdbbc12825e61bbe97448a8004f3" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/mosys" path="src/platform/mosys" revision="8c54cc8bdd56dcbb6b9fa7d126ec8f7ac4d2784f" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/mttools" path="src/platform/mttools" revision="146a68465feb9039602bcaa508ef3fea8e8f926a" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/newblue" path="src/platform/newblue" revision="33b23423f43776207e396c15388f39f441b94564" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/punybench" path="src/platform/punybench" revision="16bc496a97c027147453e7d675ae2f9147352b31" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/tast" path="src/platform/tast" revision="20c6b05dacb147a9454393316e8fc16640910004" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/tast-tests" path="src/platform/tast-tests" revision="e6ed299e4150577c988867a4640b8347b5e656ff" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/touch_firmware_test" path="src/platform/touch_firmware_test" revision="bafba938ff65099158b04ca718b1e77a0e43c5c4" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/touch_updater" path="src/platform/touch_updater" revision="3ac8af5cc26da99eb716c7a93c73e652c2c0648a" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/touchbot" path="src/platform/touchbot" revision="9546ffbb37d5fef191ad1607eeb0b76a6f3a9872" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/touchpad-tests" path="src/platform/touchpad-tests" revision="1da5e64a092a5d973b503050a3959314bb40eba0" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/tpm" path="src/third_party/tpm" revision="0cba6cadd1bea1ce3717779201d594c4c9131dc2" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/tpm_lite" path="src/platform/tpm_lite" revision="db50af69b91bc1cffde13740c23aed72883fbc45" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/tremplin" path="src/platform/tremplin" revision="42d020e1b9c64d146390c97b14e415600473fd84" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/uboot-env" path="src/platform/uboot-env" revision="ab10366ee27959666b94a638858032c91c3c5e10" upstream="refs/heads/master"/> |
| <project groups="firmware,buildtools" name="chromiumos/platform/vboot_reference" path="src/platform/vboot_reference" revision="b720a103b75ac1516736e57930407e2e0e9bb669" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/vkbench" path="src/platform/vkbench" revision="13960bea358f67210b1902be4c108b9cab7e50c9" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/vpd" path="src/platform/vpd" revision="4649d42d10a7fa32f18da7e77e019891d1d7d940" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/webplot" path="src/platform/webplot" revision="bbd5ea22ef9f8e109e363b26958d9a2fc8921f0f" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/xorg-conf" path="src/platform/xorg-conf" revision="2e6b8235cf8f6cfbd5a07e33407fa6bfde6866b4" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform2" path="src/platform2" revision="3af1db1877797c96512473bfd3477709a15d8d42" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,labtools" name="chromiumos/repohooks" path="src/repohooks" revision="29ae950ae24ea840ca8e85822c45b3c634a4a90c" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/adhd" path="src/third_party/adhd" revision="af817d93d4426e663649332e7812654e333cb6d3" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/android_mtdutils" path="src/third_party/android_mtdutils" revision="9bcfc3ee238f16925e9aaa4573129784ebb397e7" upstream="chromeos"/> |
| <project name="chromiumos/third_party/arm-trusted-firmware" path="src/third_party/arm-trusted-firmware" revision="fe77b53e32692fc5d35df208e2b3d21a28f6228b" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/atheros" path="src/third_party/atheros" revision="52a5bdaa8930c14ee42518354de3e5ec09911c6b" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/atrusctl" path="src/third_party/atrusctl" revision="3b95df756c09bd8bb6f37ca9389a75ae7b3cc46b" upstream="refs/heads/master"/> |
| <project groups="buildtools,labtools,devserver" name="chromiumos/third_party/autotest" path="src/third_party/autotest/files" revision="91660ed8df73a8d1f4064922f3fed05ac6e30651" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/aver-updater" path="src/third_party/aver-updater" revision="cf3337b0918e15755782d8f3b11691e04f1ddc40" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/bluez" path="src/third_party/bluez" revision="1f5d4fca5bf6f7b4c89143cf9c4359517ff8e71b" upstream="refs/heads/chromeos-5.44"/> |
| <project groups="firmware" name="chromiumos/third_party/bootstub" path="src/third_party/bootstub" revision="6697fe6404055443d7c754b365907a0604f14111" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/broadcom" path="src/third_party/broadcom" revision="4070e7161f2f1a1a22027a744eb868500688f0b6" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/cbootimage" path="src/third_party/cbootimage" revision="b7d5b2d6a6dd05874d86ee900ff441d261f9034c" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/coreboot" path="src/third_party/coreboot" revision="af7e76eaf8c0bd4cfe3c15bb4986ce621bb79dc8" upstream="refs/heads/chromeos-2016.05"/> |
| <project groups="firmware" name="chromiumos/third_party/coreboot/blobs" path="src/third_party/coreboot/3rdparty/blobs" revision="678b4c4a81069bb6e10e2e59f5374b83d727cd2b" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/cros-adapta" path="src/third_party/cros-adapta" revision="eb6d8c1832b9181926df107faf41a80887fd982c" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/cryptoc" path="src/third_party/cryptoc" revision="b256f3941b8de4987d75eaa7df7bd8566cec2ef1" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/cups" path="src/third_party/cups" revision="65a08c6cb204ad0a8ab5128ac24a00226b24a73d" upstream="refs/heads/cups-2-2-8"/> |
| <project name="chromiumos/third_party/daisydog" path="src/third_party/daisydog" revision="5f4302621d8e011edbd83858b0c3183e29f842b5" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/dbus-cplusplus" path="src/third_party/dbus-c++" revision="907f6244dc1c4c3f58a809147d348eccbb932631" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/dbus-spy" path="src/third_party/dbus-spy" revision="0e04421c73b24536de7fcc1886da469d8b7a2a41" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/displaylink-updater" path="src/third_party/displaylink-updater" revision="a52808b5995fe2ed481269c8f089358d4b451d5c" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/edk2" revision="ab586ccd21556108662fbd80ab5a429143eac264" upstream="refs/heads/chromeos-2017.08"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/cml/edk2/branch1" revision="49fa59e82e4c6ea798f65fc4e5948eae63ad6e07" upstream="refs/heads/chromeos-cml-branch1"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/cnl/edk2" revision="f71a70e7a4c93a6143d7bad8ab0220a947679697" upstream="refs/heads/chromeos-cnl"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/glk/edk2" revision="f71a70e7a4c93a6143d7bad8ab0220a947679697" upstream="refs/heads/chromeos-glk"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/icl/edk2" revision="8df83bf3e30ada89fc0799859e3de25017dc93ac" upstream="refs/heads/chromeos-icl"/> |
| <project groups="firmware" name="chromiumos/third_party/em100" path="src/third_party/em100" revision="8af5146f4c55a51b0debf81f1cee3c3333aa1505" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/fastrpc" path="src/third_party/fastrpc" revision="2ab40143cc017892b0b89f81c556cb4a80f70e8b" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/flashmap" path="src/third_party/flashmap" revision="7b2f153a7a65bb8f958212c5c5aec0758256465a" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/flashrom" path="src/third_party/flashrom" revision="0c38355cfb6cf59cea7723dbac12d5cc8996588c" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/fwupd" path="src/third_party/fwupd" revision="005c8415092c1035671d79b081e0757e44a36a47" upstream="refs/heads/fwupd-1.2.5"/> |
| <project name="chromiumos/third_party/gdmwimax" path="src/third_party/gdmwimax" revision="e8236b4b2d66b1972e4f84955a238134acd7f6a1" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/gobi3k-sdk" path="src/third_party/gobi3k-sdk" revision="825fc302e0e0ffeb2aa925da70ebc32bc5377c2b" upstream="refs/heads/master"/> |
| <project groups="labtools" name="chromiumos/third_party/hdctools" path="src/third_party/hdctools" revision="b065e671f035cff0aeb9bca59ac864104f3121df" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/hostap" path="src/third_party/wpa_supplicant" revision="a3b1db22d914c6e05825e8a996ffab61376ccfb5" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/hostap" path="src/third_party/wpa_supplicant-2.6" revision="377a4cab2dc98e4c2a1bf0a1ac514f2280cd0ab0" upstream="refs/heads/wpa_supplicant-2.6"/> |
| <project name="chromiumos/third_party/huddly-updater" path="src/third_party/huddly-updater" revision="98010d4e0c0d1ed95b2b08d9e2b51dcde3d18fe3" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.8" revision="a8c6542c05e3d0902f5858fe13b6f0b92d184d83" upstream="refs/heads/chromeos-3.8"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.10" revision="1c8262af7f374ecdb7030a02df98cf8ebc2b6465" upstream="refs/heads/chromeos-3.10"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.14" revision="364604b444fdef06816e33865cc45bab6de41c07" upstream="refs/heads/chromeos-3.14"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.18" revision="7ef56934709a4bddf82221d3ec30002f58b578a3" upstream="refs/heads/chromeos-3.18"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.4" revision="0c2673a71b5a4c1a5b6c0434e620776b170e7882" upstream="refs/heads/chromeos-4.4"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.14" revision="0ddcf7d6aaab7ac9bafee3751a871fd2420a3022" upstream="refs/heads/chromeos-4.14"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.14-mistral" revision="96caac58dd64db5d7e5079c734182e618891b839" upstream="refs/heads/chromeos-4.14-mistral"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.14-gw" revision="3a1219c8e12c9f17bd9714f9730911107951d5ad" upstream="refs/heads/chromeos-4.14-gw"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.19" revision="3a84e3b83ed6b6c4cb78117c54792d90ebf2d266" upstream="refs/heads/chromeos-4.19"/> |
| <project name="chromiumos/third_party/khronos" path="src/third_party/khronos" revision="d41e9e578eef76ebd804f3361eb67fce1009c2b4" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/kvmtool" path="src/third_party/kvmtool" revision="1b159b990afd33c0c2e3b47ebda6dd5cc793dd92" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libc-bench" path="src/third_party/libc-bench" revision="76793dd4b09191a78a78180012718e72d792717f" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libdrm" path="src/third_party/libdrm" revision="b7a7a90336fbb19efb3f91f92b5d964b0dfb7ec2" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libmbim" path="src/third_party/libmbim" revision="6ab7fcefd89faaffc53db0cbe7052dcab9d0c4d8" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libqmi" path="src/third_party/libqmi" revision="79bd4cabc139f013915682bb11dbd0a4d944dc1e" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libqrtr" path="src/third_party/libqrtr" revision="1604a9567beda30fb5d8fd532c0ec8366da8fbbb" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libscrypt" path="src/third_party/libscrypt" revision="b45c53f9418a6eff2c8ed98703a55f96029304b1" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libsigrok" path="src/third_party/libsigrok" revision="199fe31115c76231746f5953271795d58679561c" upstream="refs/heads/chromeos"/> |
| <project name="chromiumos/third_party/libsigrok-cli" path="src/third_party/sigrok-cli" revision="c9edfa218e5a5972531b6f4a3ece8d33a44ae1b5" upstream="refs/heads/chromeos"/> |
| <project name="chromiumos/third_party/libsigrokdecode" path="src/third_party/libsigrokdecode" revision="3279c2825684c7009775b731d0a9e37815778282" upstream="refs/heads/chromeos"/> |
| <project name="chromiumos/third_party/libv4lplugins" path="src/third_party/libv4lplugins" revision="5e6034258146af6be973fb6a5bb6b9d6e7489437" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/linux-firmware" path="src/third_party/linux-firmware" revision="0257a31d8bff95ebd060f1ff300028b0050c4518" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/logitech-updater" path="src/third_party/logitech-updater" revision="658d14909e3231dddedebbd769db36d7a9f6d784" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/ltp" path="src/third_party/ltp" revision="08733aa7d62b171c667d3eb7e299aa7345053fa9" upstream="refs/heads/chromeos-20150119"/> |
| <project name="chromiumos/third_party/marvell" path="src/third_party/marvell" revision="4773273dec5ea6ff8151459a6b63b51dc4bc164d" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/mesa" path="src/third_party/arc-mesa" revision="cabd66b91080171670f0ff546435c12ea6bf540d" upstream="refs/heads/arc-18.2.0-pre1"/> |
| <project name="chromiumos/third_party/mesa" path="src/third_party/mesa" revision="1d363d440f261fbadc1db3c17acc514b7130d505" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/mesa" path="src/third_party/mesa-freedreno" revision="1a93fc382b18ee6d1135952d23f0b6a8aa8cd31f" upstream="refs/heads/chromeos-freedreno"/> |
| <project name="chromiumos/third_party/mesa" path="src/third_party/mesa-img" revision="129178893b2260df22db96327c5ca9c2ce7db046" upstream="refs/heads/mesa-img"/> |
| <project name="chromiumos/third_party/mimo-updater" path="src/third_party/mimo-updater" revision="f173901a2ce769fe95b85123f7be445ac9a083a5" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/mmc-utils" path="src/third_party/mmc-utils" revision="1c55306a49b32bbb8c65e1e5e9d630f6720a6810" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/modemmanager-next" path="src/third_party/modemmanager-next" revision="5b752047977b69618f1b31bd08fd38de6f4f5ba3" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/nfs-ganesha" path="src/third_party/nfs-ganesha" revision="165395bf01548d8a0135357ca4c222b9c0c0acaa" upstream="refs/heads/V2.3-stable"/> |
| <project name="chromiumos/third_party/ntirpc" path="src/third_party/ntirpc" revision="a9fc54d636fc3e5b5f0918769a2e5343c5f0d823" upstream="refs/heads/V1.3.3-cros"/> |
| <project name="chromiumos/third_party/portage_tool" path="src/third_party/portage_tool" revision="82a0776602df5707606de2099b93b8b7b1cc34a1" upstream="refs/heads/chromeos-2.3.49"/> |
| <project groups="minilayout,firmware,buildtools" name="chromiumos/third_party/pyelftools" path="chromite/third_party/pyelftools" revision="af64f6c7b19cdb84226161dd3742a13fd7974cc3" upstream="refs/heads/master-0.22"/> |
| <project name="chromiumos/third_party/realtek-updater" path="src/third_party/realtek-updater" revision="7e603e12fbf9d2a8aeb67f1075fe43dbfaf52f7f" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/rootdev" path="src/third_party/rootdev" revision="8dc336a991e5494e6cc9a0094778fee67f22ed6c" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/seabios" path="src/third_party/seabios" revision="3004147dd3707e600772ec6c5d37beac7f4b8eb4" upstream="refs/heads/chromeos-2014.11.03"/> |
| <project name="chromiumos/third_party/sis-updater" path="src/third_party/sis-updater" revision="4066f05ebae55958e3d193f9177c310b1d480886" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/sound-open-firmware" path="src/third_party/sound-open-firmware" revision="2f3a03f1b0ef5b00e8de4fa5079fb2885fcf66c2" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/sound-open-firmware-tools" path="src/third_party/sound-open-firmware-tools" revision="d8114acdbb7609ebf05825c231f47c5b60a4d0b0" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/sysbios" path="src/third_party/sysbios" revision="33e1db34b8162de72a5e9bbbc44e6bce38978396" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/tlsdate" path="src/third_party/tlsdate" revision="6103fff146d9e434a643a031f7a557fd793c8d08" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/toolchain-utils" path="src/third_party/toolchain-utils" revision="3e36a69f75b86489331e16a5099836ed780303b5" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/tpm-emulator" path="src/third_party/tpm-emulator" revision="310a21ef24ace14b4d6e8095172445494f54ff25" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/tpm2" path="src/third_party/tpm2" revision="ea24233c2bb4f7e4a31aec478d45122fda79739d" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/trousers" path="src/third_party/trousers" revision="64e7adfb13e5da09598907cd17040516a914146b" upstream="refs/heads/master-0.3.13"/> |
| <project name="chromiumos/third_party/u-boot" path="src/third_party/u-boot/files" revision="8084afd71b2989bbb1988488fcb1764202f79b2b" upstream="refs/heads/chromeos-v2018.09"/> |
| <project name="chromiumos/third_party/virglrenderer" path="src/third_party/virglrenderer" revision="584039fdf2f425fb3dd853dd7d77f71531438e26" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/virtual-usb-printer" path="src/third_party/virtual-usb-printer" revision="afbe0b1c43e6e7fbf8e9f010bee357839ba785d2" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/webrtc-apm" path="src/third_party/webrtc-apm" revision="8fd0ded2f954d5deec49cf107e06725d8f45ec3b" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/whining" path="src/third_party/whining" revision="c325abd3eff318af433a1a5667f5d2745f893945" upstream="refs/heads/master"/> |
| <project name="external/git.kernel.org/fs/xfs/xfstests-dev" path="src/third_party/xfstests" revision="f3c1bca7fb257693721e35f1eeaa5552e3c931c6" upstream="refs/heads/master"/> |
| <project groups="buildtools,chromeos-admin,firmware,labtools,minilayout" name="infra/luci/client-py" path="chromite/third_party/swarming.client" remote="chromium" revision="281c390193ec8c02e60279f8dac1b86ac52fa4be"/> |
| <project name="linux-syscall-support" path="src/third_party/breakpad/src/third_party/lss" revision="a89bf7903f3169e6bc7b8efc10a73a7571de21cf"/> |
| <project name="platform/external/bsdiff" path="src/aosp/external/bsdiff" remote="aosp" revision="e36af14afc8c11dc4891294d9c4d997df7f487bf" upstream="refs/heads/master"/> |
| <project name="platform/external/libcxx" path="src/aosp/external/libcxx" remote="aosp" revision="fd86c1f3ed3ce3d1a363d914672b275d7e292b89" upstream="refs/heads/master"/> |
| <project name="platform/external/libcxxabi" path="src/aosp/external/libcxxabi" remote="aosp" revision="1389a8dc482d10684a7b30d0aa4c9c58155113ed" upstream="refs/heads/master"/> |
| <project name="platform/external/libunwind_llvm" path="src/aosp/external/libunwind_llvm" remote="aosp" revision="cc3148bd34f3d0a7bdc2a2c18333bb56d2ae829b" upstream="refs/heads/master"/> |
| <project name="platform/external/minijail" path="src/aosp/external/minijail" remote="aosp" revision="eb42bb786a78ae7c54bb891d80cde55020fc32a7" upstream="refs/heads/master"/> |
| <project name="platform/external/puffin" path="src/aosp/external/puffin" remote="aosp" revision="e8232e11000b467eeb8428df734151361362a9a8" upstream="refs/heads/master"/> |
| <project name="platform/system/keymaster" path="src/aosp/system/keymaster" remote="aosp" revision="a47727e32cd9bbda51d9801e497e8d7b37c705b7" upstream="refs/heads/master"/> |
| <project name="toolchain/binutils" path="src/aosp/toolchain/binutils" remote="aosp" revision="cce69c1b1bfc46de5e1cdd4923f87215c0edb884"/> |
| <project name="toolchain/gcc" path="src/aosp/toolchain/gcc" remote="aosp" revision="ac6128e0a17a52f011797f33ac3e7d6273a9368d"/> |
| <project name="weave/libweave" path="src/weave/libweave" revision="123e1e8827287c515f72e96ef17f39ec4b8dac54" upstream="refs/heads/master"/> |
| <repo-hooks enabled-list="pre-upload" in-project="chromiumos/repohooks"/> |
| <pending_commit branch="chromeos-4.19" change_id="Ia06519f72914b4ecf635f5e07d7f2fd6954617a9" commit="6ea3955f0392e1f341a7bc696fe7ad2ba4edd012" commit_message="UPSTREAM: block, bfq: do not consider interactive queues in srt filtering The speed at which a bfq_queue receives I/O is one of the parameters by which bfq decides whether the queue is soft real-time (i.e., whether the queue contains the I/O of a soft real-time application). In particular, when a bfq_queue remains without outstanding I/O requests, bfq computes the minimum time instant, named soft_rt_next_start, at which the next request of the queue may arrive for the queue to be deemed as soft real time. Unfortunately this filtering may cause problems with a queue in interactive weight raising. In fact, such a queue may be conveying the I/O needed to load a soft real-time application. The latter will actually exhibit a soft real-time I/O pattern after it finally starts doing its job. But, if soft_rt_next_start is updated for an interactive bfq_queue, and the queue has received a lot of service before remaining with no outstanding request (likely to happen on a fast device), then soft_rt_next_start is assigned such a high value that, for a very long time, the queue is prevented from being possibly considered as soft real time. This commit removes the updating of soft_rt_next_start for bfq_queues in interactive weight raising. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 20cd32450bcbec37c6d881b84bdddd8ba047ab01) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: Ia06519f72914b4ecf635f5e07d7f2fd6954617a9 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546272 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546272" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/72/1546272/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="Ief7fae3642aa29beb252a4693c05022d27f815fb" commit="8e332f118b4f3c05a12913682cf94483c2c6a951" commit_message="UPSTREAM: block, bfq: avoid selecting a queue w/o budget To boost throughput on devices with internal queueing and in scenarios where device idling is not strictly needed, bfq immediately starts serving a new bfq_queue if the in-service bfq_queue remains without pending I/O, even if new I/O may arrive soon for the latter queue. Then, if such I/O actually arrives soon, bfq preempts the new in-service bfq_queue so as to give the previous queue a chance to go on being served (in case the previous queue should actually be the one to be served, according to its timestamps). However, the in-service bfq_queue, say Q, may also be without further budget when it remains also pending I/O. Since bfq changes budgets dynamically to fit the needs of bfq_queues, this happens more often than one may expect. If this happens, then there is no point in trying to go on serving Q when new I/O arrives for it soon: Q would be expired immediately after being selected for service. This would only cause useless overhead. This commit avoids such a useless selection. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 218cb897be6940b8d18eec9bcb32eaa28f1ae8ee) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: Ief7fae3642aa29beb252a4693c05022d27f815fb Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546273 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546273" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/73/1546273/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="Ide15b4f3533ef55e3381a3871c11fa9033af0407" commit="8400c39142b4a69b67c1f925632d3a5f2de2e9a0" commit_message="UPSTREAM: block, bfq: make sure queue budgets are not below service received With some unlucky sequences of events, the function bfq_updated_next_req updates the current budget of a bfq_queue to a lower value than the service received by the queue using such a budget. Unfortunately, if this happens, then the return value of the function bfq_bfqq_budget_left becomes inconsistent. This commit solves this problem by lower-bounding the budget computed in bfq_updated_next_req to the service currently charged to the queue. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit f3218ad8c6acc9b874060814d6d3ddf154463ac9) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: Ide15b4f3533ef55e3381a3871c11fa9033af0407 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546274 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546274" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/74/1546274/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="I8e6952da5a8bb67d4f70574def4b5425e54f406a" commit="cdd502f95f5b307111535197575f690159b9bdf8" commit_message="UPSTREAM: block, bfq: remove case of redirected bic from insert_request Before commit 18e5a57d7987 ("block, bfq: postpone rq preparation to insert or merge"), the destination queue for a request was chosen by a different hook than the one that then inserted the request. So, between the execution of the two hooks, the bic of the process generating the request could happen to be redirected to a different bfq_queue. As a consequence, the destination bfq_queue stored in the request could be wrong. Such an event does not need to ba handled any longer. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 03e565e4204c6cf8687d995de5cafd0341503b4e) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: I8e6952da5a8bb67d4f70574def4b5425e54f406a Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546275 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546275" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/75/1546275/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="Ie14794c236b676d48880e24967d51d482a192d61" commit="11a9ec60776336b892499231c07325ae98857ac6" commit_message="UPSTREAM: block, bfq: consider also ioprio classes in symmetry detection In asymmetric scenarios, i.e., when some bfq_queue or bfq_group needs to be guaranteed a different bandwidth than other bfq_queues or bfq_groups, these service guaranteed can be provided only by plugging I/O dispatch, completely or partially, when the queue in service remains temporarily empty. A case where asymmetry is particularly strong is when some active bfq_queues belong to a higher-priority class than some other active bfq_queues. Unfortunately, this important case is not considered at all in the code for detecting asymmetric scenarios. This commit adds the missing logic. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 73d58118498b14e4d2f2391105459b997b586ddc) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: Ie14794c236b676d48880e24967d51d482a192d61 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546276 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546276" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/76/1546276/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="I2a5e8702c838341d4bf8c13d86ed5261eb03ce6f" commit="dc9b0d0da1c1f2f5cc3b7edfe0f94065f4505397" commit_message="UPSTREAM: block, bfq: split function bfq_better_to_idle This is a preparatory commit for commits that need to check only one of the two main reasons for idling. This change should also improve the quality of the code a little bit, by splitting a function that contains very long, non-trivial and little related comments. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 05c2f5c30b3ca2346a5bb7c74b0c9515d8f4fbd2) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: I2a5e8702c838341d4bf8c13d86ed5261eb03ce6f Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546277 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546277" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/77/1546277/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="I699be0fa18fb195e10071832599ed75cea59fbce" commit="bc1cb22801e1a6d888c63ba4585f5fd48fbf712e" commit_message="UPSTREAM: block, bfq: do not plug I/O of in-service queue when harmful If the in-service bfq_queue is sync and remains temporarily idle, then I/O dispatching (from other queues) may be plugged. It may be dome for two reasons: either to boost throughput, or to preserve the bandwidth share of the in-service queue. In the first case, if the I/O of the in-service queue, when it finally arrives, consists only of one small I/O request, then it makes sense to plug even the I/O of the in-service queue. In fact, serving such a small request immediately is likely to lower throughput instead of boosting it, whereas waiting a little bit is likely to let that request grow, thanks to request merging, and become more profitable in terms of throughput (this is likely to happen exactly because the I/O of the queue has been detected to boost throughput). On the opposite end, if I/O dispatching is being plugged only to preserve the bandwidth of the in-service queue, then it would be better not to plug also the I/O of the in-service queue, because such a plugging is likely to cause only loss of bandwidth for the queue. Unfortunately, no distinction is made between the two cases, and the I/O of the in-service queue is always plugged in case just a small I/O request arrives. This commit draws this missing distinction and does not perform harmful plugging. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit ac8b0cb415f3aa9162009d39624501d37031533b) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: I699be0fa18fb195e10071832599ed75cea59fbce Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546278 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546278" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/78/1546278/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="Iaaf48ec296a569ce1d1c1d4203ce4d7073d74d23" commit="fea47c4b1d2231061c68fe6aa761e2885cb9f1dc" commit_message="UPSTREAM: block, bfq: unconditionally plug I/O in asymmetric scenarios bfq detects the creation of multiple bfq_queues shortly after each other, namely a burst of queue creations in the terminology used in the code. If the burst is large, then no queue in the burst is granted - either I/O-dispatch plugging when the queue remains temporarily idle while in service; - or weight raising, because it causes even longer plugging. In fact, such a plugging tends to lower throughput, while these bursts are typically due to applications or services that spawn multiple processes, to reach a common goal as soon as possible. Examples are a "git grep" or the booting of a system. Unfortunately, disabling plugging may cause a loss of service guarantees in asymmetric scenarios, i.e., if queue weights are differentiated or if more than one group is active. This commit addresses this issue by no longer disabling I/O-dispatch plugging for queues in large bursts. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 530c4cbb3c62f9e42dbf39279fb346f2d2ab4dbb) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: Iaaf48ec296a569ce1d1c1d4203ce4d7073d74d23 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546279 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546279" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/79/1546279/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="Iaf04770f4f4f5282ea43d606c025d37b8778d77d" commit="21eb78c4f825b5111a95de63a3ef4b65da7db1cb" commit_message="UPSTREAM: block, bfq: fix sequential rq detection in rate estimation In bfq_update_peak_rate, to check whether an I/O request rq is sequential, only the seek distance of rq w.r.t. the last request dispatched is controlled. This is not sufficient for non-rotational storage, where the size of rq is at least as relevant. This commit adds the missing control. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit d87447d84fe194b0e4f5413b5344dc82cc100711) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: Iaf04770f4f4f5282ea43d606c025d37b8778d77d Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546280 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546280" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/80/1546280/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="Ic52b903e524a9e20d945f40e10b359827bef76ed" commit="7d6d98af1605866e632a96fd9112aa98e5038cc7" commit_message="UPSTREAM: block, bfq: fix queue removal from weights tree bfq maintains an ordered list, through a red-black tree, of unique weights of active bfq_queues. This list is used to detect whether there are active queues with differentiated weights. The weight of a queue is removed from the list when both the following two conditions become true: (1) the bfq_queue is flagged as inactive (2) the has no in-flight request any longer; Unfortunately, in the rare cases where condition (2) becomes true before condition (1), the removal fails, because the function to remove the weight of the queue (bfq_weights_tree_remove) is rightly invoked in the path that deactivates the bfq_queue, but mistakenly invoked *before* the function that actually performs the deactivation (bfq_deactivate_bfqq). This commits moves the invocation of bfq_weights_tree_remove for condition (1) to after bfq_deactivate_bfqq. As a consequence of this move, it is necessary to add a further reference to the queue when the weight of a queue is added, because the queue might otherwise be freed before bfq_weights_tree_remove is invoked. This commit adds this reference and makes all related modifications. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 9dee8b3b057e1da26f85f1842f2aaf3bb200fb94) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: Ic52b903e524a9e20d945f40e10b359827bef76ed Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546281 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546281" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/81/1546281/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="I649c0134c3a18f9d93bd4dae2ad9236005f649c2" commit="6e974e1e8c6d4686b9a1ae69d81d451e6c06532b" commit_message="UPSTREAM: block, bfq: reduce threshold for detecting command queueing bfq simple heuristic from cfq for detecting whether the drive performs command queueing: check whether the average number of in-flight requests is above a given threshold. Unfortunately this heuristic does fail to detect queueing (on drives with queueing) if processes doing I/O are few and issue I/O with a low depth. To reduce false negatives, this commit lowers the threshold. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit a3c92560324bd616deaecb6842b2a0337a80ad8b) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: I649c0134c3a18f9d93bd4dae2ad9236005f649c2 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546282 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546282" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/82/1546282/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="Ib0e65392e29df23f7767a69a24a4886e0e6fbfa0" commit="75b7925858d2cd3fa032d24a499c83afed412963" commit_message="UPSTREAM: block, bfq: port commit "cfq-iosched: improve hw_tag detection" The original commit is commit 1a1238a7dd48 ("cfq-iosched: improve hw_tag detection") and has the following commit message: If active queue hasn't enough requests and idle window opens, cfq will not dispatch sufficient requests to hardware. In such situation, current code will zero hw_tag. But this is because cfq doesn't dispatch enough requests instead of hardware queue doesn't work. Don't zero hw_tag in such case. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit b3c3498112ffafa5f613bb482f9723996bfd5e4f) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: Ib0e65392e29df23f7767a69a24a4886e0e6fbfa0 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546283 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546283" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/83/1546283/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="I57bf18e08ac996acbe2d72920ca951e78b971cf9" commit="5c4ecd3d4fa541344cfb0f4bad37da090d837858" commit_message="UPSTREAM: block, bfq: do not overcharge writes in asymmetric scenarios Writes tend to starve reads. bfq counters this problem by overcharging writes with an inflated service w.r.t. the actual service (number of sector written) they receive. Yet his overcharging is useless, and actually causes unfairness in the opposite direction, when bfq happens to be enforcing strong I/O control. bfq does this enforcing when the scenario is asymmetric, i.e., when some bfq_queue or group of bfq_queues is to be granted a different bandwidth than some other bfq_queue or group of bfq_queues. So, in such a scenario, this commit disables write overcharging. Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 02a6d787f4afc8be2d3d52ab0a1df0c6a2d99e7b) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: I57bf18e08ac996acbe2d72920ca951e78b971cf9 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546284 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546284" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/84/1546284/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="I53962b8c8127cf00b1316a19b8f25aa180a092fc" commit="6ae571b32630029fc5f6cc474702f8e1300e2556" commit_message="UPSTREAM: block, bfq: fix in-service-queue check for queue merging When a new I/O request arrives for a bfq_queue, say Q, bfq checks whether that request is close to (a) the head request of some other queue waiting to be served, or (b) the last request dispatched for the in-service queue (in case Q itself is not the in-service queue) If a queue, say Q2, is found for which the above condition holds, then bfq merges Q and Q2, to hopefully get a more sequential I/O in the resulting merged queue, and thus a possibly higher throughput. Case (b) is checked by comparing the new request for Q with the last request dispatched, assuming that the latter necessarily belonged to the in-service queue. Unfortunately, this assumption is no longer always correct, since commit d0edc2473be9 ("block, bfq: inject other-queue I/O into seeky idle queues on NCQ flash"). When the assumption does not hold, queues that must not be merged may be merged, causing unexpected loss of control on per-queue service guarantees. This commit solves this problem by adding an extra field, which stores the actual last request dispatched for the in-service queue, and by using this new field to correctly check case (b). Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 058fdecc6de7cdecbf4c59b851e80eb2d6c5295f) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: I53962b8c8127cf00b1316a19b8f25aa180a092fc Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1546285 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1546285" owner_email="groeck@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/85/1546285/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.19" change_id="I05d6f1f8e7e87c5a13ef0314bb7a375bd4911f75" commit="dce3ffe404cdb029ebcb4ef45ba01ec0ee052cbd" commit_message="FROMGIT: block/bfq: fix ifdef for CONFIG_BFQ_GROUP_IOSCHED=y Replace BFQ_GROUP_IOSCHED_ENABLED with CONFIG_BFQ_GROUP_IOSCHED. Code under these ifdefs never worked, something might be broken. Fixes: 0471559c2fbd ("block, bfq: add/remove entity weights correctly") Fixes: 73d58118498b ("block, bfq: consider also ioprio classes in symmetry detection") Reviewed-by: Holger Hoffsttte <holger@applied-asynchrony.com> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 42b1bd33dcdef4ffd98f695e188bab82f9fa46d8 git://git.kernel.dk/linux-block.git for-next) BUG=chromium:931295 TEST=Boot with bfq active Change-Id: I05d6f1f8e7e87c5a13ef0314bb7a375bd4911f75 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1555217 Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="1" gerrit_number="1555217" owner_email="groeck@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/17/1555217/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I1b2dbbf9ba57dae7f7192122c9494746dd34c5fd" commit="15002755394e133622cea530a72d64b5aa72e686" commit_message="edition: Update syscall_defines to 2018 edition Separated out of CL:1513058 to make it possible to land parts individually while the affected crate has no other significant CLs pending. This avoids repeatedly introducing non-textual conflicts with new code that adds `use` statements. TEST=cargo check TEST=cargo check --all-features TEST=cargo check --target aarch64-unknown-linux-gnu Change-Id: I1b2dbbf9ba57dae7f7192122c9494746dd34c5fd Reviewed-on: https://chromium-review.googlesource.com/1520068 Commit-Ready: David Tolnay <dtolnay@chromium.org> Tested-by: David Tolnay <dtolnay@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: David Tolnay <dtolnay@chromium.org> " fail_count="0" gerrit_number="1520068" owner_email="dtolnay@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform/crosvm" project_url="https://chromium-review.googlesource.com/chromiumos/platform/crosvm" ref="refs/changes/68/1520068/2" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I0da74e70b03aa6472b084e83fda47d755e8053b7" commit="77c52db24fb057b2db433c88405efa74f5baa84f" commit_message="vm_tools: Expand coverage of cicerone fuzzer to include TremplinListener The current fuzz test only tests commands to the ContainerListener service. This CL extends it to test the TremplinListener service as well. This makes the name cicerone_container_listener_impl_fuzzer somewhat inaccurate, but I think we can live with that. BUG=chromium:927161 TEST=Ran fuzzer Change-Id: I0da74e70b03aa6472b084e83fda47d755e8053b7 Reviewed-on: https://chromium-review.googlesource.com/1554524 Commit-Ready: Fergus Dall <sidereal@google.com> Tested-by: Fergus Dall <sidereal@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> " fail_count="2" gerrit_number="1554524" owner_email="sidereal@google.com" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/24/1554524/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I67a27778cd6e5c77b0003b5bdb33b5af8e92ab5f" commit="40c8ea9d4d842b6814b583b3c86cdaece6bd278c" commit_message="tast-tests: do not test /home/root/<uid-hash> for file contexts Shill is creating directories into it even it's not a bind-mount. The created file is useless in actual world, and create flakiness for testing. This is a quick fix to comment out testing of /home/root/<uid-hash> since the test should only care the situation when the user is logged in and it is a bind-mount. Before confining shill to prevent such file being created, it's better to skip such files to prevent flakiness that blocks CQ. BUG=b:130011394,chromium:950317 TEST=tast run Change-Id: I67a27778cd6e5c77b0003b5bdb33b5af8e92ab5f Reviewed-on: https://chromium-review.googlesource.com/1557293 Commit-Ready: Qijiang Fan <fqj@google.com> Tested-by: Qijiang Fan <fqj@google.com> Reviewed-by: Dan Erat <derat@chromium.org> " fail_count="0" gerrit_number="1557293" owner_email="fqj@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform/tast-tests" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast-tests" ref="refs/changes/93/1557293/1" remote="cros" total_fail_count="0"/><pending_commit branch="chromeos-4.19" change_id="I3e6524558e14ce809de3c2bbf2feafdb085593d0" commit="c5c08b88951840ebe971c616ed1a2ab94aa48da0" commit_message="CHROMIUM: MALI: Fix extra regulator_disable/enable for rk When you try to do a suspend on a Rockchip Chromebook you get an error message in the logs saying that we were unable to disable a regulator. mali ffa30000.gpu: Power off reg 0 failed error = -22 This is because we try to disable our regulator twice. Specifically see that the last line in rk_pm_callback_power_off() turns the regulator off and then we do it again in rk_pm_suspend_callback(). Let's get rid of the extra call and get rid of the matching one in resume. NOTE: without this patch if you do: grep gpu /sys/kernel/debug/regulator/regulator_summary ...at the login screen you will see the gpu regulator toggle between 0 and 1 at first bootup and then after the first suspend/resume it will toggle between 1 and 2. That's because the first "disable" is ignored but then we re-enable it. That means after the first suspend/resume we end up with a persistent count of 1. After this patch the count looks better. Also note that the difference here is mostly academic. The GPU regulator is marked "always on" and is only turned off (due to regulator properties) at suspend time. BUG=chromium:941638 TEST=gpu works both before and after s2r Change-Id: I3e6524558e14ce809de3c2bbf2feafdb085593d0 Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1554994 Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> " fail_count="1" gerrit_number="1554994" owner_email="dianders@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/94/1554994/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I6b189af4c74183175f860849a9f535bc32e801e2" commit="2a43b539c12d47cbe2fcba8a65070b3cd37161a6" commit_message="trunks: Place proto in sysroot Crosvm will use these types to communicate TPM commands to the Trunks daemon -- prototype code in CL:1553674. BUG=chromium:911799 TEST=emerge-nami trunks, confirm that /build/nami/usr/include/chromeos/dbus/trunks/interface.proto exists Change-Id: I6b189af4c74183175f860849a9f535bc32e801e2 Reviewed-on: https://chromium-review.googlesource.com/1553610 Commit-Ready: David Tolnay <dtolnay@chromium.org> Tested-by: David Tolnay <dtolnay@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> " fail_count="1" gerrit_number="1553610" owner_email="dtolnay@chromium.org" pass_count="0" patch_number="1" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/10/1553610/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I557d38172767137c20a108275e0157d9b1f687e6" commit="77cb17973e7f011eb4916a61a7f98d198fb7c672" commit_message="kokoro: Install dbus-1 and dbus protos The trunks interface.proto will be required for the TPM device to communicate TPM commands to the Trunks daemon and receive back TPM responses. BUG=chromium:911799 TEST=kokoro with and without CL:1554982 Change-Id: I557d38172767137c20a108275e0157d9b1f687e6 Reviewed-on: https://chromium-review.googlesource.com/1554879 Commit-Ready: David Tolnay <dtolnay@chromium.org> Tested-by: David Tolnay <dtolnay@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> " fail_count="2" gerrit_number="1554879" owner_email="dtolnay@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform/crosvm" project_url="https://chromium-review.googlesource.com/chromiumos/platform/crosvm" ref="refs/changes/79/1554879/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Ibb78b8254693a68a55780ebea3e895c146a14119" commit="143079f699fbab11101c2cc6c86b7f88843ae2e5" commit_message="edition: Update net_sys and net_util to 2018 edition Separated out of CL:1513058 to make it possible to land parts individually while the affected crate has no other significant CLs pending. This avoids repeatedly introducing non-textual conflicts with new code that adds `use` statements. TEST=cargo check TEST=cargo check --all-features TEST=cargo check --target aarch64-unknown-linux-gnu Change-Id: Ibb78b8254693a68a55780ebea3e895c146a14119 Reviewed-on: https://chromium-review.googlesource.com/1519701 Commit-Ready: David Tolnay <dtolnay@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: David Tolnay <dtolnay@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: David Tolnay <dtolnay@chromium.org> " fail_count="0" gerrit_number="1519701" owner_email="dtolnay@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform/crosvm" project_url="https://chromium-review.googlesource.com/chromiumos/platform/crosvm" ref="refs/changes/01/1519701/2" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="Ifdf954bba5c364eb07dc8457104b087ab56a11e0" commit="130cb2d1802514587c3d9bc6718bc118baec4871" commit_message="tast-tests: Avoid panics in arc.Booted and chrome.LoggedIn. Update the arc.Booted and chrome.LoggedIn preconditions to avoid triggering a panic if they call s.Fatal during Prepare. Previously, both preconditions' Prepare methods deferred a call to chrome.Lock. If Prepare calls s.Fatal, then the stack of the call to chrome.Lock is as follows: at chromiumos/tast/local/chrome.Lock (chrome.go:75) at runtime.call32 (asm_amd64.s:522) at runtime.Goexit (panic.go:397) at chromiumos/tast/testing.(*State).Fatal (state.go:198) chrome.Lock only expects to be called by the arc and chrome packages, so it triggers a panic in this case: Panic: runtime.call32 is not allowed to call chrome.Lock; check the list in chrome.Lock To avoid this, call chrome.Unlock only when it's needed (i.e. before chrome.Chrome.Close will be called) and call chrome.Lock only after it's needed (i.e. after chrome.New returns successfully). BUG=chromium:949857 TEST=manual: added an s.Fatal after chrome.New returns and checked that an additional panic isn't reported; also ran various tests using preconditions Change-Id: Ifdf954bba5c364eb07dc8457104b087ab56a11e0 Reviewed-on: https://chromium-review.googlesource.com/1553611 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> " fail_count="2" gerrit_number="1553611" owner_email="derat@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform/tast-tests" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast-tests" ref="refs/changes/11/1553611/1" remote="cros" total_fail_count="2"/><lkgm version="12058.0.0-rc3"/></manifest> |
