| <?xml version="1.0" encoding="utf-8"?><manifest revision="953ea619801619e2c799e5d528e22be53118d23b"> |
| <notice>Your sources have been sync'd successfully.</notice> |
| <remote fetch="https://android.googlesource.com" name="aosp" review="https://android-review.googlesource.com"/> |
| <remote alias="cros" fetch="https://chromium.googlesource.com/" name="chromium"/> |
| <remote fetch="https://chromium.googlesource.com" name="cros" review="https://chromium-review.googlesource.com"/> |
| <default remote="cros" revision="refs/heads/master" sync-j="8"/> |
| <project name="aosp/platform/external/libchrome" path="src/aosp/external/libchrome" revision="5ca6b5581735fdb7a46249d4eb587aff936434f5" upstream="refs/heads/master"/> |
| <project name="aosp/platform/external/modp_b64" path="src/third_party/modp_b64" revision="afc3e28a3de4a627e3afaf73b4c55ed85c992470" upstream="refs/heads/master"/> |
| <project name="aosp/platform/system/core/libsync" path="src/aosp/system/libsync" revision="f4f4387b6bf2387efbcfd1453af4892e8982faf6" upstream="refs/heads/master"/> |
| <project groups="devserver" name="aosp/platform/system/update_engine" path="src/aosp/system/update_engine" revision="6fc0b88c3139144fb44c89b3ed892e987050ea86" upstream="refs/heads/master"/> |
| <project name="apps/libapps" path="src/third_party/libapps" revision="ff4bfe547cc5bb62a8da9e8c1ab29769b852672b" upstream="refs/heads/master"> |
| <annotation name="branch-mode" value="pin"/> |
| </project> |
| <project name="chromium/deps/libmtp" path="chromium/src/third_party/libmtp" remote="chromium" revision="4f4fad584e9c2735af5131f15b697376a3327de5" upstream="refs/heads/master"/> |
| <project groups="minilayout,buildtools,labtools" name="chromium/llvm-project/cfe/tools/clang-format" path="src/chromium/src/buildtools/clang_format/script" remote="chromium" revision="cd5aff70ee0b0fe27d8cd0a0419e16f628dd688a" upstream="refs/heads/master"/> |
| <project groups="minilayout,buildtools,labtools" name="chromium/src/buildtools" path="src/chromium/src/buildtools" remote="chromium" revision="80b545b427d95ac8996a887fa32ba1d64919792d" upstream="refs/heads/master"/> |
| <project name="chromium/src/third_party/Python-Markdown" path="src/chromium/src/third_party/Python-Markdown" remote="chromium" revision="b08af21eb795e522e1b972cb85bff59edb1ae209" upstream="refs/heads/master"/> |
| <project name="chromium/src/tools/md_browser" path="src/chromium/src/tools/md_browser" remote="chromium" revision="0bfd826f8566a99923e64a782908faca72bc457c" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,labtools" name="chromium/tools/depot_tools" remote="chromium" revision="7639f1999ac1d8992fc4fbb169d164b156d9a7f7"/> |
| <project groups="minilayout,firmware,buildtools,chromeos-admin,labtools,sysmon,devserver" name="chromiumos/chromite" path="chromite" revision="5e4b1bc773108632898be413caa4f9dbf8592f89" upstream="refs/heads/master"> |
| <copyfile dest="AUTHORS" src="AUTHORS"/> |
| <copyfile dest="LICENSE" src="LICENSE"/> |
| </project> |
| <project name="chromiumos/containers/cros-container-guest-tools" path="src/platform/container-guest-tools" revision="a30bd3ea9718194c02575a4e93e33a6675f39bf1" upstream="refs/heads/master"/> |
| <project name="chromiumos/docs" path="docs" revision="25c7ff4e37b741c5bd16eca2df697d97be594f30" upstream="refs/heads/master"/> |
| <project name="chromiumos/graphyte" path="src/platform/graphyte" revision="10d607271aef6033e704ce55cabfef486fdd3211" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/bad_cl_detector" path="infra/bad_cl_detector" revision="08bb5589019bbaae1039240ce347cdc3ed05f43a" upstream="refs/heads/master"/> |
| <project groups="chromeos-admin" name="chromiumos/infra/ci_results_archiver" path="infra/ci_results_archiver" revision="e26eb065275789dcc18c1f7c18c345d52c732bea" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/cl_exonerator" path="infra/cl_exonerator" revision="97ac1d26995b60f5878a70d5bd1fd5b268879aa1" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/cl_status_viewer" path="infra/cl_status_viewer" revision="c83dac930c70348b312188615cf0f080d4903f86" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/distfiles_updater" path="infra/distfiles_updater" revision="2d1aa33972b2028d19a288baaacee9b2cd8644f7" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/dummies/general-sandbox" path="infra/dummies/general-sandbox" revision="88ef977562c7172763ca413a8e74ae9318fb2dd0" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/dummies/merge-sandbox" path="infra/dummies/merge-sandbox" revision="651c1f3b89c112222f5dae2f79091421543dd4ee" upstream="refs/heads/master"/> |
| <project groups="chromeos-admin" name="chromiumos/infra/go" path="infra/go" revision="6446dfef4b55689046395c2db7ba7c35377927fe" upstream="refs/heads/master"> |
| <annotation name="branch-mode" value="tot"/> |
| </project> |
| <project name="chromiumos/infra/logstock" path="infra/logstock" revision="2c820dcfff228f1b9f9cef99173ea4c1cfe215d4" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/lucifer" path="infra/lucifer" revision="c38131e883df682af5a2f415f1f7a21ed0c8e77f" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/proto" path="chromite/infra/proto" revision="366e98250f957efe3329167a2334f54073aff634" upstream="refs/heads/master"> |
| <annotation name="branch-mode" value="tot"/> |
| </project> |
| <project groups="chromeos-admin" name="chromiumos/infra/recipes" path="infra/recipes" revision="55f2be0ff5a9528439f0147f4f63a0c1503f0e0b" upstream="refs/heads/master"> |
| <annotation name="branch-mode" value="tot"/> |
| </project> |
| <project groups="chromeos-admin,labtools" name="chromiumos/infra/skylab_inventory" path="infra/skylab_inventory" revision="c47b8760c5e51cd129ba3e84e0605bb66adf346c" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/suite_scheduler" path="infra/suite_scheduler" revision="703ced29a971a30a6bb5df8d26b19ce869e80b0f" upstream="refs/heads/master"/> |
| <project name="chromiumos/infra/test_analyzer" path="infra/test_analyzer" revision="2b64804e94031c148e5ddf43320229fd81a372db" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,chromeos-admin,labtools,sysmon,devserver" name="chromiumos/infra_virtualenv" path="infra_virtualenv" revision="146d42d1fa94528972ff70dc4c71a17978b67d35" upstream="refs/heads/master"/> |
| <project name="chromiumos/manifest" path="manifest" revision="2a87b9cc622f6d341f06c85c5a8aada73123d43a" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware" name="chromiumos/overlays/board-overlays" path="src/overlays" revision="67bef739cf5ebbc934c209f1c4d51468221f6495" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,labtools" name="chromiumos/overlays/chromiumos-overlay" path="src/third_party/chromiumos-overlay" revision="53baab9da1312d47a64d13b0ea87f022dba3e6f6" sync-c="true" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,labtools" name="chromiumos/overlays/eclass-overlay" path="src/third_party/eclass-overlay" revision="a4789c862a16d53477b467298199f23d77dd96ce" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,labtools" name="chromiumos/overlays/portage-stable" path="src/third_party/portage-stable" revision="4484956b0494217f9355fedc2d0a2957f6e235ee" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/assets" path="src/platform/assets" revision="162626bc0ba60a30c8be8c2ba5f59dd3abe61970" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/audiotest" path="src/platform/audiotest" revision="8723150efd763eee866238846e508c1bdacde7e4" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/battery_updater" path="src/platform/battery_updater" revision="6ff439321073109d6343280da70a4aae6cc51f65" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/bisect-kit" path="src/platform/bisect-kit" revision="99e808f9a94a6d5edbc0e08950409f213a984e36" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/bmpblk" path="src/platform/bmpblk" revision="37317fadbb92ae1edeefa2e349dcbba3265b411f" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/bootcache" path="src/platform/bootcache" revision="6ed1eea32f34b2ef5f0d88ba45eb728186c7458a" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/btsocket" path="src/platform/btsocket" revision="300354e5d74418c8e03737ca9029c64d9297a28d" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/cfm-device-monitor" path="src/platform/cfm-device-monitor" revision="b3ab7026704b6b7cf3f2f61e7a7347b3c3fd3dfd" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/chameleon" path="src/platform/chameleon" revision="06cf9f8114cbec35f6c91d63c42d00e72ca795c8" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/chromiumos-assets" path="src/platform/chromiumos-assets" revision="a5acfbd3dd6cab1b133d84080b22e7b8e6d0e199" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/cobble" path="src/platform/cobble" revision="bae5ccdc16ed42fac1e6596cfb199d06e4c92d3e" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools" name="chromiumos/platform/crostestutils" path="src/platform/crostestutils" revision="ca61bc2c970983a8a730e8d504bee9134240368a" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,labtools" name="chromiumos/platform/crosutils" path="src/scripts" revision="e91616105bc3e0285af3aac834d88ef44d2568fd" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/crosvm" path="src/platform/crosvm" revision="44863792aae915c0bc33155352ade8013144dcd3" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/depthcharge" path="src/platform/depthcharge" revision="dfeb5292901fc4dec96b689e424b5e8855ae82d6" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,devserver" name="chromiumos/platform/dev-util" path="src/platform/dev" revision="33f263a3c2121a03717649341cce9285808a578c" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/dm-verity" path="src/platform/verity" revision="393cd4d510256b0bb2bdd0acd9656105cfd28771" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/drm-tests" path="src/platform/drm-tests" revision="8ed7891f35099bc9d5b8a4164b5ab847d5f1576f" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/ec" path="src/platform/ec" revision="fc9117badbc12cf2eda57287aff0315028cbf210" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/experimental" path="src/platform/experimental" revision="2927fce20adf74b0c9a32a61e3edff894221f283" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/factory" path="src/platform/factory" revision="7065d8e15eb386aab29745f8ca9df1305691dd8e" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/factory_installer" path="src/platform/factory_installer" revision="9552d4cb84d3a85aed6aed4937640e7ebcdd21a0" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/firmware" path="src/platform/firmware" revision="6ef55ba31e8b2fb0c1bce59702284fb0257d45d9" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/frecon" path="src/platform/frecon" revision="755f3ca45df2291121aa8b8a031ca3b52e54d0ef" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/gestures" path="src/platform/gestures" revision="b0854045cbbf0862e60f56e259fb36ff130d8e97" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/glbench" path="src/platform/glbench" revision="414ba8197d43e497a0351a51e1aac8df607a2ff1" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/go-seccomp" path="src/platform/go-seccomp" revision="9f7e7fb007ebfb3070e878526876a039b6add840" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/google-breakpad" path="src/third_party/breakpad" revision="c4b1ec1341369a10694374c62d2c2497f589418a" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/initramfs" path="src/platform/initramfs" revision="e4548fa8ba30c5da7507b643fdc84306e64e39e4" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/inputcontrol" path="src/platform/inputcontrol" revision="4c0c21a9a02024f5c9913c1c7d0f74f100e861d1" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/jabra_vold" path="src/platform/jabra_vold" revision="244d94df6bce89cc6900e44b818aa573090488ae" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/libevdev" path="src/platform/libevdev" revision="231ea3605643c8bac1f997a80442c230d69cbe44" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/microbenchmarks" path="src/platform/microbenchmarks" revision="c7ece0f317b6ef8343f01fc2b07a47cee81c9ba3" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/minigbm" path="src/platform/minigbm" revision="1cbcbfd5f9908f694d3786b03d5a2bf0a5af6b90" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/moblab" path="src/platform/moblab" revision="3d73a0842368d012e0611a738de3f01a4023bf74" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/mosys" path="src/platform/mosys" revision="b1a921fb146641bfc3ee1bbba68d882a0507b916" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/mttools" path="src/platform/mttools" revision="27df4a99ceb8d2d6b5a1838c66fa030fa5943280" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/newblue" path="src/platform/newblue" revision="2fda6e30560464f6e038165cedfaa784b3c6d5ec" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/punybench" path="src/platform/punybench" revision="16bc496a97c027147453e7d675ae2f9147352b31" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/tast" path="src/platform/tast" revision="1f6437acca6a5997377c9120fe3c89cc086b5a3a" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/tast-tests" path="src/platform/tast-tests" revision="22f3489cbc0be4b6abb661106471423c67e2144c" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/touch_firmware_test" path="src/platform/touch_firmware_test" revision="8b455f6fe6b82cf679de9a9b7379147c33025998" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/touch_updater" path="src/platform/touch_updater" revision="26439ebf598270cda056e5ce09203133d47160a9" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/touchbot" path="src/platform/touchbot" revision="9546ffbb37d5fef191ad1607eeb0b76a6f3a9872" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/touchpad-tests" path="src/platform/touchpad-tests" revision="33c9165824594caf35bb39d2a73f67f3eaac62ce" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/platform/tpm" path="src/third_party/tpm" revision="8afebd60c77201ab9eac6e049e4576ed26c6d600" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/tpm_lite" path="src/platform/tpm_lite" revision="dd6ae9f3a223c0a8a89a2e4c10600f7700354a53" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/tremplin" path="src/platform/tremplin" revision="a2cc320d395a4fbb400afd2290802820a5be4932" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/uboot-env" path="src/platform/uboot-env" revision="5ad506f38e25df5361f1ec7892e9b4f201590a64" upstream="refs/heads/master"/> |
| <project groups="firmware,buildtools" name="chromiumos/platform/vboot_reference" path="src/platform/vboot_reference" revision="6373cd57d7c4af79b9cf0b401d24c5dfffde68d4" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/vkbench" path="src/platform/vkbench" revision="13960bea358f67210b1902be4c108b9cab7e50c9" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/vpd" path="src/platform/vpd" revision="345c7067c30583ae0a8478d4114683b07e43d690" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/webplot" path="src/platform/webplot" revision="bbd5ea22ef9f8e109e363b26958d9a2fc8921f0f" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform/xorg-conf" path="src/platform/xorg-conf" revision="570365d36c3235ee4f9e96219cd8e96cd6d5332c" upstream="refs/heads/master"/> |
| <project name="chromiumos/platform2" path="src/platform2" revision="ab0130d4141642ad200d4158ebd2e37c8fbfda97" upstream="refs/heads/master"/> |
| <project groups="minilayout,firmware,buildtools,labtools" name="chromiumos/repohooks" path="src/repohooks" revision="9732e38a5551e4bbcd222d2bbb89ee0fc5c95dee" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/adhd" path="src/third_party/adhd" revision="6b91b7f2edd01eda8f7c6f6c1e6d8387d6ee3394" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/android_mtdutils" path="src/third_party/android_mtdutils" revision="9bcfc3ee238f16925e9aaa4573129784ebb397e7" upstream="refs/heads/chromeos"/> |
| <project name="chromiumos/third_party/arm-trusted-firmware" path="src/third_party/arm-trusted-firmware" revision="464243e4aaf6966ba3fbcece76eba918469f9d45" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/atheros" path="src/third_party/atheros" revision="d00613ad2a05d64a64f61cbf7450fd6c0e671434" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/atrusctl" path="src/third_party/atrusctl" revision="af9682236ee5a11e8900acc3f31165e91da2d95d" upstream="refs/heads/master"/> |
| <project groups="buildtools,labtools,devserver" name="chromiumos/third_party/autotest" path="src/third_party/autotest/files" revision="b7d6b02e35ef877ad2184f8fe72b7c46a902dde7" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/aver-updater" path="src/third_party/aver-updater" revision="cf3337b0918e15755782d8f3b11691e04f1ddc40" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/bluez" path="src/third_party/bluez" revision="ff1f0ac85b3185522d0ae60b0cdef6f73d3f9294" upstream="refs/heads/chromeos-5.44"/> |
| <project groups="firmware" name="chromiumos/third_party/bootstub" path="src/third_party/bootstub" revision="97f36acc1fe9732aa033fca55dd3baac8f3ceb48" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/broadcom" path="src/third_party/broadcom" revision="b146b5319f17fe8f21a608869fba86dccf670076" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/cbootimage" path="src/third_party/cbootimage" revision="b7d5b2d6a6dd05874d86ee900ff441d261f9034c" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/coreboot" path="src/third_party/coreboot" revision="c9a25806779db160f00608e6e3717cca2478a0a3" upstream="refs/heads/chromeos-2016.05"/> |
| <project groups="firmware" name="chromiumos/third_party/coreboot/blobs" path="src/third_party/coreboot/3rdparty/blobs" revision="5368a8c7e3e3aa2dda6aaf69d0c4bc314ca35e3b" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/cros-adapta" path="src/third_party/cros-adapta" revision="eb6d8c1832b9181926df107faf41a80887fd982c" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/cryptoc" path="src/third_party/cryptoc" revision="e05bfa91102dd5137b4027b4f3405e041ffe2c32" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/cups" path="src/third_party/cups" revision="c6054558bdb47735196f50cec16995d58c93bd2f" upstream="refs/heads/cups-2-2-8"/> |
| <project name="chromiumos/third_party/daisydog" path="src/third_party/daisydog" revision="5f4302621d8e011edbd83858b0c3183e29f842b5" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/edk2" revision="e0d276cc82ff8a5b58672235fd90cb4731937208" upstream="refs/heads/chromeos-2017.08"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/cml/edk2/branch1" revision="264551f027e80cd73a4554b431043ff29c6685a8" upstream="refs/heads/chromeos-cml-branch1"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/cnl/edk2" revision="1d24ff60d457f2e8c0457577f3fe8163164dcd99" upstream="refs/heads/chromeos-cnl"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/glk/edk2" revision="b157545b7eac7a0538b1437521f2d3cc2dfdd759" upstream="refs/heads/chromeos-glk"/> |
| <project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/icl/edk2" revision="a5d08a5efcfbddf9b668c945213d806b353ef887" upstream="refs/heads/chromeos-icl"/> |
| <project groups="firmware" name="chromiumos/third_party/em100" path="src/third_party/em100" revision="9fda6741f6ca1db1a01eb42ea7f1d59cd553b9fd" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/fastrpc" path="src/third_party/fastrpc" revision="2ab40143cc017892b0b89f81c556cb4a80f70e8b" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/flashmap" path="src/third_party/flashmap" revision="274688eb2280dba7d1e0afe5a6a77c703624c43f" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/flashrom" path="src/third_party/flashrom" revision="d8c683b2e8104e48b0ee73279e0a55f76a1281b8" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/fwupd" path="src/third_party/fwupd" revision="62d946925a06791cdc54a98fc415081f478528d5" upstream="refs/heads/fwupd-1.2.5"/> |
| <project groups="labtools" name="chromiumos/third_party/hdctools" path="src/third_party/hdctools" revision="f6712b06a75e234c949d45fe642050be87fbaf19" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/hostap" path="src/third_party/wpa_supplicant" revision="18269509f64fc4efe0b3a77a59d0d873ce26511c" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/hostap" path="src/third_party/wpa_supplicant-2.6" revision="361257856e3086eb421804c24376a1d331389897" upstream="refs/heads/wpa_supplicant-2.6"/> |
| <project name="chromiumos/third_party/hostap" path="src/third_party/wpa_supplicant-2.8" revision="6a2e0248bd94e5d27ce74f9950a87298b86949e4" upstream="refs/heads/wpa_supplicant-2.8"/> |
| <project name="chromiumos/third_party/huddly-updater" path="src/third_party/huddly-updater" revision="c56e263f7a1af177863468e473a6b73d7f726d97" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.8" revision="3c029b84856251990814c43c8dca3b6921f9e2c1" upstream="refs/heads/chromeos-3.8"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.10" revision="ba9e83ece52e7927cb71651ca41c698ff1266503" upstream="refs/heads/chromeos-3.10"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.14" revision="773e47c8fd5cd99f324faf3dad2689c636396081" upstream="refs/heads/chromeos-3.14"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.18" revision="64fa113d49e4113dbfe3d6b40b2b9c2e943ec76c" upstream="refs/heads/chromeos-3.18"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.4" revision="e7d6bfe9a6e8187df7956e35b6b2b416ff020a88" upstream="refs/heads/chromeos-4.4"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.14" revision="22d8a8f01612a23c8410531a590d2403ab5a00a8" upstream="refs/heads/chromeos-4.14"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.14-mistral" revision="2f9297b1197fc5c127d6d8f717dc650044dc97e8" upstream="refs/heads/chromeos-4.14-mistral"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.14-gw" revision="c2f81c7e87b072e2dac12cc7b842dc7ea40fb305" upstream="refs/heads/chromeos-4.14-gw"/> |
| <project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.19" revision="63eafc93156a76f6b3a747e2c587dab56e8d55d5" upstream="refs/heads/chromeos-4.19"/> |
| <project name="chromiumos/third_party/khronos" path="src/third_party/khronos" revision="b3d20636223e605ec5bcea0071baf2687381f73a" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/kvmtool" path="src/third_party/kvmtool" revision="1b159b990afd33c0c2e3b47ebda6dd5cc793dd92" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libcamera" path="src/third_party/libcamera" revision="6481c71a618a7b6940cbe4269a33c24f33ddf6be" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libdrm" path="src/third_party/libdrm" revision="728dfa9dbeeb013e5a26c24f4372a16eace99c5e" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libiio" path="src/third_party/libiio" revision="8539d5dcf2d04cfc1985e3272fb20b3109ebb492" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libmbim" path="src/third_party/libmbim" revision="6ab7fcefd89faaffc53db0cbe7052dcab9d0c4d8" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libqmi" path="src/third_party/libqmi" revision="7183ca5142b8246959643edf49e78ea1d3b0d01a" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libqrtr" path="src/third_party/libqrtr" revision="1604a9567beda30fb5d8fd532c0ec8366da8fbbb" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libscrypt" path="src/third_party/libscrypt" revision="e9fe99ea600bc3f2745eaf7c04f38330b04dc80e" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/libsigrok" path="src/third_party/libsigrok" revision="199fe31115c76231746f5953271795d58679561c" upstream="refs/heads/chromeos"/> |
| <project name="chromiumos/third_party/libsigrok-cli" path="src/third_party/sigrok-cli" revision="c9edfa218e5a5972531b6f4a3ece8d33a44ae1b5" upstream="refs/heads/chromeos"/> |
| <project name="chromiumos/third_party/libsigrokdecode" path="src/third_party/libsigrokdecode" revision="3279c2825684c7009775b731d0a9e37815778282" upstream="refs/heads/chromeos"/> |
| <project name="chromiumos/third_party/libv4lplugins" path="src/third_party/libv4lplugins" revision="aac7c20e25b5374fd644ddc7b26f088e71c3bf51" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/linux-firmware" path="src/third_party/linux-firmware" revision="701f823a8063b84d8dfcd178320cde6ab4ce7ff3" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/logitech-updater" path="src/third_party/logitech-updater" revision="658d14909e3231dddedebbd769db36d7a9f6d784" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/ltp" path="src/third_party/ltp" revision="08733aa7d62b171c667d3eb7e299aa7345053fa9" upstream="refs/heads/chromeos-20150119"/> |
| <project name="chromiumos/third_party/marvell" path="src/third_party/marvell" revision="82b4358bb82a8be3eb2ee1723736229acb6e6c03" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/mesa" path="src/third_party/mesa" revision="960a84200ff88afc818280be203886d91087d8f2" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/mesa" path="src/third_party/mesa-debian" revision="e86a9b5bc6add3bbcef9b5d6011911c9eba0d8e5" upstream="refs/heads/debian"/> |
| <project name="chromiumos/third_party/mesa" path="src/third_party/mesa-freedreno" revision="10721ef0b381e439d89a00a522d8dfe33ae8d83d" upstream="refs/heads/chromeos-freedreno"/> |
| <project name="chromiumos/third_party/mesa" path="src/third_party/mesa-img" revision="129178893b2260df22db96327c5ca9c2ce7db046" upstream="refs/heads/mesa-img"/> |
| <project name="chromiumos/third_party/mimo-updater" path="src/third_party/mimo-updater" revision="2ee2d98e2cce58d2ec376aa5a90805399df70505" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/mmc-utils" path="src/third_party/mmc-utils" revision="329c5cade4d639803c0c356da250f8314617956c" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/modemmanager-next" path="src/third_party/modemmanager-next" revision="5b752047977b69618f1b31bd08fd38de6f4f5ba3" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/nfs-ganesha" path="src/third_party/nfs-ganesha" revision="165395bf01548d8a0135357ca4c222b9c0c0acaa" upstream="refs/heads/V2.3-stable"/> |
| <project name="chromiumos/third_party/ntirpc" path="src/third_party/ntirpc" revision="a9fc54d636fc3e5b5f0918769a2e5343c5f0d823" upstream="refs/heads/V1.3.3-cros"/> |
| <project name="chromiumos/third_party/portage_tool" path="src/third_party/portage_tool" revision="b36e7a36efba27e48554ff2603471b0f61728a19" upstream="refs/heads/chromeos-2.3.49"/> |
| <project groups="minilayout,firmware,buildtools" name="chromiumos/third_party/pyelftools" path="chromite/third_party/pyelftools" revision="0890b98431a9b2e637c18f719232d06a4e5c3cd8" upstream="refs/heads/master-0.22"/> |
| <project name="chromiumos/third_party/rootdev" path="src/third_party/rootdev" revision="9b7d26a6a54f5f9e02b93a5d5ebf266fd748e06c" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/seabios" path="src/third_party/seabios" revision="3004147dd3707e600772ec6c5d37beac7f4b8eb4" upstream="refs/heads/chromeos-2014.11.03"/> |
| <project name="chromiumos/third_party/sis-updater" path="src/third_party/sis-updater" revision="4066f05ebae55958e3d193f9177c310b1d480886" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/sound-open-firmware" path="src/third_party/sound-open-firmware" revision="5b43730e8620c60b4170231f7e9d91d2d2d89652" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/sysbios" path="src/third_party/sysbios" revision="33e1db34b8162de72a5e9bbbc44e6bce38978396" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/tlsdate" path="src/third_party/tlsdate" revision="4d15ba95a545740e44107f2a6744fe59dfcb65ab" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/toolchain-utils" path="src/third_party/toolchain-utils" revision="6befccfc2baa5042a9a2438b2012df2fa7f788b8" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/tpm-emulator" path="src/third_party/tpm-emulator" revision="5e23afec38885751ee658849beb5c7a610ba8e07" upstream="refs/heads/master"/> |
| <project groups="firmware" name="chromiumos/third_party/tpm2" path="src/third_party/tpm2" revision="46ff940bfe5066b1531065c158d70ee38ecdf4eb" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/trousers" path="src/third_party/trousers" revision="c6adcadf8c45c9a5b7f705b279c481e6d3d1d667" upstream="refs/heads/master-0.3.13"/> |
| <project name="chromiumos/third_party/u-boot" path="src/third_party/u-boot/files" revision="c526bbe09b550d40fba290237dd1caa5b5736277" upstream="refs/heads/chromeos-v2018.09"/> |
| <project name="chromiumos/third_party/virglrenderer" path="src/third_party/virglrenderer" revision="94172afa3f4f94281b1a19b747aa3f3ae7d7aa14" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/virtual-usb-printer" path="src/third_party/virtual-usb-printer" revision="3aa8acfc3fd2902cfb158beb1e0e85f7bf7bf88a" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/webrtc-apm" path="src/third_party/webrtc-apm" revision="23dc36459a1b9a88bae85d03613483ab6738be80" upstream="refs/heads/master"/> |
| <project name="chromiumos/third_party/whining" path="src/third_party/whining" revision="f17caea7f6bdbafaca8de35e83178de3999e4f45" upstream="refs/heads/master"/> |
| <project name="external/git.kernel.org/fs/xfs/xfstests-dev" path="src/third_party/xfstests" revision="f769a923f576df2d19faf731ee521ea9afe977ce" upstream="refs/heads/master"/> |
| <project groups="buildtools,chromeos-admin,firmware,labtools,minilayout" name="infra/luci/client-py" path="chromite/third_party/swarming.client" remote="chromium" revision="34b20305c7a69eb89e1abd5e2a94708db999f0a9"/> |
| <project name="linux-syscall-support" path="src/third_party/breakpad/src/third_party/lss" revision="a89bf7903f3169e6bc7b8efc10a73a7571de21cf"/> |
| <project name="platform/external/bsdiff" path="src/aosp/external/bsdiff" remote="aosp" revision="10118144d0b8a90496db9f97d55bf607db2c8c8b" upstream="refs/heads/master"/> |
| <project name="platform/external/libcxx" path="src/aosp/external/libcxx" remote="aosp" revision="81231c9ecd77a2f6492cf87807392434eb83134e" upstream="refs/heads/master"/> |
| <project name="platform/external/libcxxabi" path="src/aosp/external/libcxxabi" remote="aosp" revision="ebe828e0f9ec7cbaa7a8173703bf7a0457629a60" upstream="refs/heads/master"/> |
| <project name="platform/external/libunwind_llvm" path="src/aosp/external/libunwind_llvm" remote="aosp" revision="d88b1fc62511d02ee2021628af7c571528a09b8c" upstream="refs/heads/master"/> |
| <project name="platform/external/minijail" path="src/aosp/external/minijail" remote="aosp" revision="52f6adabb6f44761cc23a226cc396bd5c664641c" upstream="refs/heads/master"/> |
| <project name="platform/external/puffin" path="src/aosp/external/puffin" remote="aosp" revision="170cb8d77faed2c7a05e527e9e2923f2ae3587dd" upstream="refs/heads/master"/> |
| <project name="platform/system/keymaster" path="src/aosp/system/keymaster" remote="aosp" revision="04b02f651d8e215ddcdf72dd0dcccafacc2c92a2" upstream="refs/heads/master"/> |
| <project name="toolchain/binutils" path="src/aosp/toolchain/binutils" remote="aosp" revision="cce69c1b1bfc46de5e1cdd4923f87215c0edb884"/> |
| <project name="toolchain/gcc" path="src/aosp/toolchain/gcc" remote="aosp" revision="ac6128e0a17a52f011797f33ac3e7d6273a9368d"/> |
| <project name="weave/libweave" path="src/weave/libweave" revision="e296a5e3a2fb32cc5dce19114caf5be3e9ba079e" upstream="refs/heads/master"/> |
| <repo-hooks enabled-list="pre-upload" in-project="chromiumos/repohooks"/> |
| <pending_commit branch="chromeos-4.4" change_id="I410c1886ec482532fdea508f66ac6c85805f9dc2" commit="9eaa5e55770ccc4ca5e292c28fd6133511ba2ab2" commit_message="Revert "CHROMIUM: oom: Report info about the killer in OOM kills" This reverts commit 5f420c83308f9f97b81494a6df192f11a1082b73. BUG=chromium:957809 TEST=Built Change-Id: I410c1886ec482532fdea508f66ac6c85805f9dc2 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1627308 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> " fail_count="0" gerrit_number="1627308" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/08/1627308/5" remote="cros" total_fail_count="0"/><pending_commit branch="chromeos-4.4" change_id="I5f038717e8b0a8200a2c08655564c9d87270ad62" commit="6b6f2cdf6944c88f1355872fd2585b21450d6c64" commit_message="Revert "CHROMIUM: oom: Chill out and don't print refusals to die so often" This reverts commit 3f2d33d57bba55fe6d4cc0534c1e94f3f0181568. BUG=chromium:957809 TEST=Built Change-Id: I5f038717e8b0a8200a2c08655564c9d87270ad62 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628050 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> " fail_count="0" gerrit_number="1628050" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/50/1628050/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ib9e1d966aecdddd43f7b4c25596dc8dbe36a6470" commit="d99294dc2ac89907072fe5f5ac87eaaac2cad4ec" commit_message="Revert "CHROMIUM: oom: do not select new victim if current one is runnable" This reverts commit 205e01dc2b90aefedb0ebbd0a46bbb322fd5eafc. BUG=chromium:957809 TEST=Built Change-Id: Ib9e1d966aecdddd43f7b4c25596dc8dbe36a6470 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628051 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> " fail_count="0" gerrit_number="1628051" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/51/1628051/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Id33b678aa58d0cdcd536841974e3916abc30b4eb" commit="dece088a99c9a4e18ffd89fe4351c09caf0c93a7" commit_message="Revert "CHROMIUM: oom: show backtrace of threads refusing to die" This reverts commit 6422faf35f4b7a883eb689482a14a7a6a6f4ff7b. BUG=chromium:957809 TEST=Built Change-Id: Id33b678aa58d0cdcd536841974e3916abc30b4eb Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628052 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> " fail_count="0" gerrit_number="1628052" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/52/1628052/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Idcb4ef98b10aec8e130958a5edae6f6808617c62" commit="1a48eda001ec0a3c5b7dffebe2f7dc7db6379205" commit_message="Revert "CHROMIUM: DROP: mm/oom_kill: Avoid deadlock; allow multiple victims" This reverts commit ed758deb4a6ef27d56e95da9d1a73be0cbd09ac5. BUG=chromium:957809 TEST=Built Change-Id: Idcb4ef98b10aec8e130958a5edae6f6808617c62 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628053 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> " fail_count="0" gerrit_number="1628053" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/53/1628053/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ie006790d70c98b6da9307f1e2502c219a05f909c" commit="de6268ad07166d759210f79d967f759ff0085874" commit_message="Revert "CHROMIUM: DROP: mm/oom_kill: Double-check before killing a child in our place" This reverts commit d7cd7d859ad92dac0f9f4511a2bc1cf2208e8cbe. BUG=chromium:957809 TEST=Built Change-Id: Ie006790d70c98b6da9307f1e2502c219a05f909c Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628054 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> " fail_count="0" gerrit_number="1628054" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/54/1628054/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I1701c775bfaeade49583555341c1d8aea91a9ef9" commit="a9bbe0910c4a2b25d4964156348713073042b51a" commit_message="Revert "CHROMIUM: DROP: mm/oom_kill: Don't kill a subthread in our place if we still have mm" This reverts commit 222d652a0495a51be1d799772ec669e169ca9496. BUG=chromium:957809 TEST=Built Change-Id: I1701c775bfaeade49583555341c1d8aea91a9ef9 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628055 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> " fail_count="0" gerrit_number="1628055" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/55/1628055/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I6ba2af3874a17b20b34e2b30b8805cfb0ce9d9a7" commit="39c67471b70bbbfe097e86acfbdd8729ffd3e457" commit_message="UPSTREAM: sched: add schedule_timeout_idle() This will be needed in the patch "mm, oom: introduce oom reaper". Acked-by: Michal Hocko <mhocko@suse.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 69b27baf00fa9b7b14b3263c105390d1683425b2) BUG=chromium:957809 TEST=Built Change-Id: I6ba2af3874a17b20b34e2b30b8805cfb0ce9d9a7 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628056 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628056" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/56/1628056/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ie2de5c55d3252775acd9abfbf67a689fcad18b85" commit="b9a23340c0c4c198f2aa54d6b0ae692a3f6cd559" commit_message="UPSTREAM: mm, oom: introduce oom reaper This patch (of 5): This is based on the idea from Mel Gorman discussed during LSFMM 2015 and independently brought up by Oleg Nesterov. The OOM killer currently allows to kill only a single task in a good hope that the task will terminate in a reasonable time and frees up its memory. Such a task (oom victim) will get an access to memory reserves via mark_oom_victim to allow a forward progress should there be a need for additional memory during exit path. It has been shown (e.g. by Tetsuo Handa) that it is not that hard to construct workloads which break the core assumption mentioned above and the OOM victim might take unbounded amount of time to exit because it might be blocked in the uninterruptible state waiting for an event (e.g. lock) which is blocked by another task looping in the page allocator. This patch reduces the probability of such a lockup by introducing a specialized kernel thread (oom_reaper) which tries to reclaim additional memory by preemptively reaping the anonymous or swapped out memory owned by the oom victim under an assumption that such a memory won't be needed when its owner is killed and kicked from the userspace anyway. There is one notable exception to this, though, if the OOM victim was in the process of coredumping the result would be incomplete. This is considered a reasonable constrain because the overall system health is more important than debugability of a particular application. A kernel thread has been chosen because we need a reliable way of invocation so workqueue context is not appropriate because all the workers might be busy (e.g. allocating memory). Kswapd which sounds like another good fit is not appropriate as well because it might get blocked on locks during reclaim as well. oom_reaper has to take mmap_sem on the target task for reading so the solution is not 100% because the semaphore might be held or blocked for write but the probability is reduced considerably wrt. basically any lock blocking forward progress as described above. In order to prevent from blocking on the lock without any forward progress we are using only a trylock and retry 10 times with a short sleep in between. Users of mmap_sem which need it for write should be carefully reviewed to use _killable waiting as much as possible and reduce allocations requests done with the lock held to absolute minimum to reduce the risk even further. The API between oom killer and oom reaper is quite trivial. wake_oom_reaper updates mm_to_reap with cmpxchg to guarantee only NULL->mm transition and oom_reaper clear this atomically once it is done with the work. This means that only a single mm_struct can be reaped at the time. As the operation is potentially disruptive we are trying to limit it to the ncessary minimum and the reaper blocks any updates while it operates on an mm. mm_struct is pinned by mm_count to allow parallel exit_mmap and a race is detected by atomic_inc_not_zero(mm_users). Signed-off-by: Michal Hocko <mhocko@suse.com> Suggested-by: Oleg Nesterov <oleg@redhat.com> Suggested-by: Mel Gorman <mgorman@suse.de> Acked-by: Mel Gorman <mgorman@suse.de> Acked-by: David Rientjes <rientjes@google.com> Cc: Mel Gorman <mgorman@suse.de> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Hugh Dickins <hughd@google.com> Cc: Andrea Argangeli <andrea@kernel.org> Cc: Rik van Riel <riel@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit aac453635549699c13a84ea1456d5b0e574ef855) BUG=chromium:957809 TEST=Built Change-Id: Ie2de5c55d3252775acd9abfbf67a689fcad18b85 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628057 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628057" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/57/1628057/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ia7693fbde86b184045255b01bc5565778d0aca43" commit="84f515827858ea34c1ef52e89b6ccf9d07f33942" commit_message="UPSTREAM: oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space When oom_reaper manages to unmap all the eligible vmas there shouldn't be much of the freable memory held by the oom victim left anymore so it makes sense to clear the TIF_MEMDIE flag for the victim and allow the OOM killer to select another task. The lack of TIF_MEMDIE also means that the victim cannot access memory reserves anymore but that shouldn't be a problem because it would get the access again if it needs to allocate and hits the OOM killer again due to the fatal_signal_pending resp. PF_EXITING check. We can safely hide the task from the OOM killer because it is clearly not a good candidate anymore as everyhing reclaimable has been torn down already. This patch will allow to cap the time an OOM victim can keep TIF_MEMDIE and thus hold off further global OOM killer actions granted the oom reaper is able to take mmap_sem for the associated mm struct. This is not guaranteed now but further steps should make sure that mmap_sem for write should be blocked killable which will help to reduce such a lock contention. This is not done by this patch. Note that exit_oom_victim might be called on a remote task from __oom_reap_task now so we have to check and clear the flag atomically otherwise we might race and underflow oom_victims or wake up waiters too early. Signed-off-by: Michal Hocko <mhocko@suse.com> Suggested-by: Johannes Weiner <hannes@cmpxchg.org> Suggested-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Andrea Argangeli <andrea@kernel.org> Cc: David Rientjes <rientjes@google.com> Cc: Hugh Dickins <hughd@google.com> Cc: Mel Gorman <mgorman@suse.de> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Rik van Riel <riel@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 36324a990cf578b57828c04cd85ac62cd25cf5a4) BUG=chromium:957809 TEST=Built Change-Id: Ia7693fbde86b184045255b01bc5565778d0aca43 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628058 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628058" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/58/1628058/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I291598a5197b517e0015fa432824c3cd506eb5c6" commit="bb43a765d42bedca234d2bb2a1569be401a79e72" commit_message="UPSTREAM: mm, oom_reaper: report success/failure Inform about the successful/failed oom_reaper attempts and dump all the held locks to tell us more who is blocking the progress. [akpm@linux-foundation.org: fix CONFIG_MMU=n build] Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Andrea Argangeli <andrea@kernel.org> Cc: David Rientjes <rientjes@google.com> Cc: Hugh Dickins <hughd@google.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Mel Gorman <mgorman@suse.de> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Rik van Riel <riel@redhat.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit bc448e897b6d24aae32701763b8a1fe15d29fa26) BUG=chromium:957809 TEST=Built Change-Id: I291598a5197b517e0015fa432824c3cd506eb5c6 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628059 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628059" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/59/1628059/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ia9cd9584d3e69309a0828ea6dd4b26dd1e553b15" commit="451146e5f21bff978d6427736582f7f7b1dfb765" commit_message="UPSTREAM: mm, oom_reaper: implement OOM victims queuing wake_oom_reaper has allowed only 1 oom victim to be queued. The main reason for that was the simplicity as other solutions would require some way of queuing. The current approach is racy and that was deemed sufficient as the oom_reaper is considered a best effort approach to help with oom handling when the OOM victim cannot terminate in a reasonable time. The race could lead to missing an oom victim which can get stuck out_of_memory wake_oom_reaper cmpxchg // OK oom_reaper oom_reap_task __oom_reap_task oom_victim terminates atomic_inc_not_zero // fail out_of_memory wake_oom_reaper cmpxchg // fails task_to_reap = NULL This race requires 2 OOM invocations in a short time period which is not very likely but certainly not impossible. E.g. the original victim might have not released a lot of memory for some reason. The situation would improve considerably if wake_oom_reaper used a more robust queuing. This is what this patch implements. This means adding oom_reaper_list list_head into task_struct (eat a hole before embeded thread_struct for that purpose) and a oom_reaper_lock spinlock for queuing synchronization. wake_oom_reaper will then add the task on the queue and oom_reaper will dequeue it. Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Vladimir Davydov <vdavydov@virtuozzo.com> Cc: Andrea Argangeli <andrea@kernel.org> Cc: David Rientjes <rientjes@google.com> Cc: Hugh Dickins <hughd@google.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Mel Gorman <mgorman@suse.de> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Rik van Riel <riel@redhat.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 03049269de433cb5fe2859be9ae4469ceb1163ed) BUG=chromium:957809 TEST=Built Change-Id: Ia9cd9584d3e69309a0828ea6dd4b26dd1e553b15 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628060 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628060" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/60/1628060/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ic64320ef7b3cf4f0ea28224a9cd9988ed47f680b" commit="ec0fbe3e7d6c6e32fea56ed5182ea584be1c2749" commit_message="UPSTREAM: oom, oom_reaper: disable oom_reaper for oom_kill_allocating_task Tetsuo has reported that oom_kill_allocating_task=1 will cause oom_reaper_list corruption because oom_kill_process doesn't follow standard OOM exclusion (aka ignores TIF_MEMDIE) and allows to enqueue the same task multiple times - e.g. by sacrificing the same child multiple times. This patch fixes the issue by introducing a new MMF_OOM_KILLED mm flag which is set in oom_kill_process atomically and oom reaper is disabled if the flag was already set. Signed-off-by: Michal Hocko <mhocko@suse.com> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: David Rientjes <rientjes@google.com> Cc: Mel Gorman <mgorman@techsingularity.net> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Hugh Dickins <hughd@google.com> Cc: Rik van Riel <riel@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 855b018325737f7691f9b7d86339df40aa4e47c3) BUG=chromium:957809 TEST=Built Change-Id: Ic64320ef7b3cf4f0ea28224a9cd9988ed47f680b Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628061 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628061" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/61/1628061/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I39047a7af184df229c6cbcb50c14d42f6477f55a" commit="ea542a8f991ba985d520ceb2c964f92548d9eaba" commit_message="UPSTREAM: oom: make oom_reaper_list single linked Entries are only added/removed from oom_reaper_list at head so we can use a single linked list and hence save a word in task_struct. Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com> Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 29c696e1c6eceb5db6b21f0c89495fcfcd40c0eb) BUG=chromium:957809 TEST=Built Change-Id: I39047a7af184df229c6cbcb50c14d42f6477f55a Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628062 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628062" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/62/1628062/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I080aee8ac6fa29a6fee843255c84fe14ef62a955" commit="2d3ce20e7fb2816088345d6a40c7b85d55b741f0" commit_message="UPSTREAM: oom: make oom_reaper freezable After "oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space" oom_reaper will call exit_oom_victim on the target task after it is done. This might however race with the PM freezer: CPU0 CPU1 CPU2 freeze_processes try_to_freeze_tasks # Allocation request out_of_memory oom_killer_disable wake_oom_reaper(P1) __oom_reap_task exit_oom_victim(P1) wait_event(oom_victims==0) [...] do_exit(P1) perform IO/interfere with the freezer which breaks the oom_killer_disable semantic. We no longer have a guarantee that the oom victim won't interfere with the freezer because it might be anywhere on the way to do_exit while the freezer thinks the task has already terminated. It might trigger IO or touch devices which are frozen already. In order to close this race, make the oom_reaper thread freezable. This will work because a) already running oom_reaper will block freezer to enter the quiescent state b) wake_oom_reaper will not wake up the reaper after it has been frozen c) the only way to call exit_oom_victim after try_to_freeze_tasks is from the oom victim's context when we know the further interference shouldn't be possible Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: David Rientjes <rientjes@google.com> Cc: Mel Gorman <mgorman@techsingularity.net> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Hugh Dickins <hughd@google.com> Cc: Rik van Riel <riel@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit e26796066fdf929cbba22dabb801808f986acdb9) BUG=chromium:957809 TEST=Built Change-Id: I080aee8ac6fa29a6fee843255c84fe14ef62a955 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628063 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628063" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/63/1628063/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="If843ea42422a8e79d88d210d28ce26b266e68f1a" commit="48f067b694427056ceec05692cdf9cbfdd707d72" commit_message="UPSTREAM: oom, oom_reaper: protect oom_reaper_list using simpler way "oom, oom_reaper: disable oom_reaper for oom_kill_allocating_task" tried to protect oom_reaper_list using MMF_OOM_KILLED flag. But we can do it by simply checking tsk->oom_reaper_list != NULL. Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit bb29902a7515208846114b3b36a4281a9bbf766a) BUG=chromium:957809 TEST=Built Change-Id: If843ea42422a8e79d88d210d28ce26b266e68f1a Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628064 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628064" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/64/1628064/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I8a131a0ee356d7f4ad8d0de018dd04bd42e3ebdf" commit="32f4ba3a78e9fd46c2a7f8a02da4a06ed569a6e1" commit_message="UPSTREAM: oom, oom_reaper: do not enqueue task if it is on the oom_reaper_list head Commit bb29902a7515 ("oom, oom_reaper: protect oom_reaper_list using simpler way") has simplified the check for tasks already enqueued for the oom reaper by checking tsk->oom_reaper_list != NULL. This check is not sufficient because the tsk might be the head of the queue without any other tasks queued and then we would simply lockup looping on the same task. Fix the condition by checking for the head as well. Fixes: bb29902a7515 ("oom, oom_reaper: protect oom_reaper_list using simpler way") Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit af8e15cc85a253155fdcea707588bf6ddfc0be2e) BUG=chromium:957809 TEST=Built Change-Id: I8a131a0ee356d7f4ad8d0de018dd04bd42e3ebdf Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628065 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628065" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/65/1628065/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I40d46dc634d149c106cc7bd8e5acb2d17770e73a" commit="2d79967855a69e6838b09767e0c3b8d72c1c778d" commit_message="UPSTREAM: mm, oom_reaper: clear TIF_MEMDIE for all tasks queued for oom_reaper Right now the oom reaper will clear TIF_MEMDIE only for tasks which were successfully reaped. This is the safest option because we know that such an oom victim would only block forward progress of the oom killer without a good reason because it is highly unlikely it would release much more memory. Basically most of its memory has been already torn down. We can relax this assumption to catch more corner cases though. The first obvious one is when the oom victim clears its mm and gets stuck later on. oom_reaper would back of on find_lock_task_mm returning NULL. We can safely try to clear TIF_MEMDIE in this case because such a task would be ignored by the oom killer anyway. The flag would be cleared by that time already most of the time anyway. The less obvious one is when the oom reaper fails due to mmap_sem contention. Even if we clear TIF_MEMDIE for this task then it is not very likely that we would select another task too easily because we haven't reaped the last victim and so it would be still the #1 candidate. There is a rare race condition possible when the current victim terminates before the next select_bad_process but considering that oom_reap_task had retried several times before giving up then this sounds like a borderline thing. After this patch we should have a guarantee that the OOM killer will not be block for unbounded amount of time for most cases. Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Raushaniya Maksudova <rmaksudova@parallels.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: David Rientjes <rientjes@google.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 449d777d7ad6d7f9ac5ed8f618fa13e6ff36c32f) BUG=chromium:957809 TEST=Built Change-Id: I40d46dc634d149c106cc7bd8e5acb2d17770e73a Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628066 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628066" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/66/1628066/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I9dc45bab656481d0e44efd3e600ed6dc9a4927d3" commit="86a055fea5d6acbdaa45b90399763de2780cf42d" commit_message="UPSTREAM: mm, oom_reaper: hide oom reaped tasks from OOM killer more carefully Commit 36324a990cf5 ("oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space") not only clears TIF_MEMDIE for oom reaped task but also set OOM_SCORE_ADJ_MIN for the target task to hide it from the oom killer. This works in simple cases but it is not sufficient for (unlikely) cases where the mm is shared between independent processes (as they do not share signal struct). If the mm had only small amount of memory which could be reaped then another task sharing the mm could be selected and that wouldn't help to move out from the oom situation. Introduce MMF_OOM_REAPED mm flag which is checked in oom_badness (same as OOM_SCORE_ADJ_MIN) and task is skipped if the flag is set. Set the flag after __oom_reap_task is done with a task. This will force the select_bad_process() to ignore all already oom reaped tasks as well as no such task is sacrificed for its parent. Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit bb8a4b7fd1266ef888b3a80aa5f266062b224ef4) BUG=chromium:957809 TEST=Built Change-Id: I9dc45bab656481d0e44efd3e600ed6dc9a4927d3 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628067 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628067" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/67/1628067/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I27a77bfce4f6075caecb874f9b24d402b1a5c56e" commit="fea3977f2848fba116229a979daed6207acb9471" commit_message="UPSTREAM: mm,oom: do not loop !__GFP_FS allocation if the OOM killer is disabled After the OOM killer is disabled during suspend operation, any !__GFP_NOFAIL && __GFP_FS allocations are forced to fail. Thus, any !__GFP_NOFAIL && !__GFP_FS allocations should be forced to fail as well. Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 0a687aace3b8e215e08eed8a67014f5b8f133ab0) BUG=chromium:957809 TEST=Built Change-Id: I27a77bfce4f6075caecb874f9b24d402b1a5c56e Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628068 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628068" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/68/1628068/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ib39fdcacd3008d16ee9c19ed346f79f4b81e5947" commit="44ba92df7f5b40343941a7f0b07091964b888b9f" commit_message="UPSTREAM: mm, oom: move GFP_NOFS check to out_of_memory __alloc_pages_may_oom is the central place to decide when the out_of_memory should be invoked. This is a good approach for most checks there because they are page allocator specific and the allocation fails right after for all of them. The notable exception is GFP_NOFS context which is faking did_some_progress and keep the page allocator looping even though there couldn't have been any progress from the OOM killer. This patch doesn't change this behavior because we are not ready to allow those allocation requests to fail yet (and maybe we will face the reality that we will never manage to safely fail these request). Instead __GFP_FS check is moved down to out_of_memory and prevent from OOM victim selection there. There are two reasons for that - OOM notifiers might release some memory even from this context as none of the registered notifier seems to be FS related - this might help a dying thread to get an access to memory reserves and move on which will make the behavior more consistent with the case when the task gets killed from a different context. Keep a comment in __alloc_pages_may_oom to make sure we do not forget how GFP_NOFS is special and that we really want to do something about it. Note to the current oom_notifier users: The observable difference for you is that oom notifiers cannot depend on any fs locks because we could deadlock. Not that this would be allowed today because that would just lockup machine in most of the cases and ruling out the OOM killer along the way. Another difference is that callbacks might be invoked sooner now because GFP_NOFS is a weaker reclaim context and so there could be reclaimable memory which is just not reachable now. That would require GFP_NOFS only loads which are really rare and more importantly the observable result would be dropping of reconstructible object and potential performance drop which is not such a big deal when we are struggling to fulfill other important allocation requests. Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Raushaniya Maksudova <rmaksudova@parallels.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: David Rientjes <rientjes@google.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 3da88fb3bacfaa33ff9d13730d17110bb2d9604d) BUG=chromium:957809 TEST=Built Change-Id: Ib39fdcacd3008d16ee9c19ed346f79f4b81e5947 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628069 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628069" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/69/1628069/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I2611142a95fad353164b33f28deebb8046fe2227" commit="fb0f8350408d9d2b4908cda4532b24cd596aa0cc" commit_message="UPSTREAM: oom, oom_reaper: try to reap tasks which skip regular OOM killer path If either the current task is already killed or PF_EXITING or a selected task is PF_EXITING then the oom killer is suppressed and so is the oom reaper. This patch adds try_oom_reaper which checks the given task and queues it for the oom reaper if that is safe to be done meaning that the task doesn't share the mm with an alive process. This might help to release the memory pressure while the task tries to exit. [akpm@linux-foundation.org: fix nommu build] Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Raushaniya Maksudova <rmaksudova@parallels.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: David Rientjes <rientjes@google.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 3ef22dfff2390e75b379f9715388a852aa56e0d5) BUG=chromium:957809 TEST=Built Change-Id: I2611142a95fad353164b33f28deebb8046fe2227 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628070 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628070" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/70/1628070/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ibbd37b06be1a9bfc3d4f5019bd89ee8dc9798939" commit="0f45e40a3da28b5cd6276b235aa2615c97bb1cd8" commit_message="UPSTREAM: mm: oom: do not reap task if there are live threads in threadgroup If the current process is exiting, we don't invoke oom killer, instead we give it access to memory reserves and try to reap its mm in case nobody is going to use it. There's a mistake in the code performing this check - we just ignore any process of the same thread group no matter if it is exiting or not - see try_oom_reaper. Fix it. Link: http://lkml.kernel.org/r/1464087628-7318-1-git-send-email-vdavydov@virtuozzo.com Fixes: 3ef22dfff239 ("oom, oom_reaper: try to reap tasks which skip regular OOM killer path")Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit edd9f7230f591b7988533b1cafb07f3c03555f19) BUG=chromium:957809 TEST=Built Change-Id: Ibbd37b06be1a9bfc3d4f5019bd89ee8dc9798939 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628071 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628071" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/71/1628071/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ief3e2ed973c31f46b7d9de270817d68834691953" commit="62f23ea9e8838389d7a6054bcc30eda091abe719" commit_message="UPSTREAM: mm, oom_reaper: do not use siglock in try_oom_reaper() Oleg has noted that siglock usage in try_oom_reaper is both pointless and dangerous. signal_group_exit can be checked lockless. The problem is that sighand becomes NULL in __exit_signal so we can crash. Fixes: 3ef22dfff239 ("oom, oom_reaper: try to reap tasks which skip regular OOM killer path") Link: http://lkml.kernel.org/r/1464679423-30218-1-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Suggested-by: Oleg Nesterov <oleg@redhat.com> Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Cc: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit cbdcf7f78900625de35173961b9b95cde22bce45) BUG=chromium:957809 TEST=Built Change-Id: Ief3e2ed973c31f46b7d9de270817d68834691953 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628072 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628072" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/72/1628072/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ibd54e7472ec3748110d6d255058a328b63a2d445" commit="f682599dd0091f2b3bf7b5b1b3505bbe2607dd97" commit_message="UPSTREAM: mm, oom_reaper: do not mmput synchronously from the oom reaper context Tetsuo has properly noted that mmput slow path might get blocked waiting for another party (e.g. exit_aio waits for an IO). If that happens the oom_reaper would be put out of the way and will not be able to process next oom victim. We should strive for making this context as reliable and independent on other subsystems as much as possible. Introduce mmput_async which will perform the slow path from an async (WQ) context. This will delay the operation but that shouldn't be a problem because the oom_reaper has reclaimed the victim's address space for most cases as much as possible and the remaining context shouldn't bind too much memory anymore. The only exception is when mmap_sem trylock has failed which shouldn't happen too often. The issue is only theoretical but not impossible. Signed-off-by: Michal Hocko <mhocko@suse.com> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit ec8d7c14ea14922fe21945b458a75e39f11dd832) BUG=chromium:957809 TEST=Built Change-Id: Ibd54e7472ec3748110d6d255058a328b63a2d445 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628073 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628073" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/73/1628073/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Id1801a51edce85ff52d6b0589d4dc1af7824c26a" commit="6a581ff67199a05ac72c17f7721aa5d953648e65" commit_message="UPSTREAM: mm: oom_reaper: remove some bloat mmput_async is currently used only from the oom_reaper which is defined only for CONFIG_MMU. We can save work_struct in mm_struct for !CONFIG_MMU. [akpm@linux-foundation.org: fix typo, per Minchan] Link: http://lkml.kernel.org/r/20160520061658.GB19172@dhcp22.suse.cz Reported-by: Minchan Kim <minchan@kernel.org> Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Minchan Kim <minchan@kernel.org> Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 7ef949d77f95f0d129f0d404b336459a34a00101) BUG=chromium:957809 TEST=Built Change-Id: Id1801a51edce85ff52d6b0589d4dc1af7824c26a Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1627929 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1627929" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="4" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/29/1627929/4" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I2204f47240473e96b656c97a30538e16bcb60a41" commit="0160b15bca0c74401cfb6c58f35900649485fe3c" commit_message="UPSTREAM: oom_reaper: close race with exiting task Tetsuo has reported: Out of memory: Kill process 443 (oleg's-test) score 855 or sacrifice child Killed process 443 (oleg's-test) total-vm:493248kB, anon-rss:423880kB, file-rss:4kB, shmem-rss:0kB sh invoked oom-killer: gfp_mask=0x24201ca(GFP_HIGHUSER_MOVABLE|__GFP_COLD), order=0, oom_score_adj=0 sh cpuset=/ mems_allowed=0 CPU: 2 PID: 1 Comm: sh Not tainted 4.6.0-rc7+ #51 Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/31/2013 Call Trace: dump_stack+0x85/0xc8 dump_header+0x5b/0x394 oom_reaper: reaped process 443 (oleg's-test), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB In other words: __oom_reap_task exit_mm atomic_inc_not_zero tsk->mm = NULL mmput atomic_dec_and_test # > 0 exit_oom_victim # New victim will be # selected <OOM killer invoked> # no TIF_MEMDIE task so we can select a new one unmap_page_range # to release the memory The race exists even without the oom_reaper because anybody who pins the address space and gets preempted might race with exit_mm but oom_reaper made this race more probable. We can address the oom_reaper part by using oom_lock for __oom_reap_task because this would guarantee that a new oom victim will not be selected if the oom reaper might race with the exit path. This doesn't solve the original issue, though, because somebody else still might be pinning mm_users and so __mmput won't be called to release the memory but that is not really realiably solvable because the task will get away from the oom sight as soon as it is unhashed from the task_list and so we cannot guarantee a new victim won't be selected. [akpm@linux-foundation.org: fix use of unused `mm', Per Stephen] [akpm@linux-foundation.org: coding-style fixes] Fixes: aac453635549 ("mm, oom: introduce oom reaper") Link: http://lkml.kernel.org/r/1464271493-20008-1-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit e2fe14564d3316d1625ed20bf1083995f4960893) BUG=chromium:957809 TEST=Built Change-Id: I2204f47240473e96b656c97a30538e16bcb60a41 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628074 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628074" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/74/1628074/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I0836ca4978615bfb788a71c26583323fa1bebd0a" commit="9afd13fdcd263418d7f9e9c892c24ef5684da29a" commit_message="UPSTREAM: mm,oom_reaper: don't call mmput_async() without atomic_inc_not_zero() Commit e2fe14564d33 ("oom_reaper: close race with exiting task") reduced frequency of needlessly selecting next OOM victim, but was calling mmput_async() when atomic_inc_not_zero() failed. Link: http://lkml.kernel.org/r/1464423365-5555-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 491a1c65ae498dea0e39b24a46e528a78a8532ed) BUG=chromium:957809 TEST=Built Change-Id: I0836ca4978615bfb788a71c26583323fa1bebd0a Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628075 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628075" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/75/1628075/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I6ba7355cdb84718c561c29bfad2d23dec64cada7" commit="ee92c4119397f97189b891235c67848318eaf3eb" commit_message="UPSTREAM: oom_reaper: avoid pointless atomic_inc_not_zero usage. Since commit 36324a990cf5 ("oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space") changed to use find_lock_task_mm() for finding a mm_struct to reap, it is guaranteed that mm->mm_users > 0 because find_lock_task_mm() returns a task_struct with ->mm != NULL. Therefore, we can safely use atomic_inc(). Link: http://lkml.kernel.org/r/1465024759-8074-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 9df10fb7b80bc2f540956ba01b5e7ee1012001a5) BUG=chromium:957809 TEST=Built Change-Id: I6ba7355cdb84718c561c29bfad2d23dec64cada7 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628076 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628076" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/76/1628076/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I86e40350845ed91ae4d2973b327209f6f86149e9" commit="cb28257f1c370d95180fd5edad16359568aadea9" commit_message="UPSTREAM: mm, oom_reaper: make sure that mmput_async is called only when memory was reaped Tetsuo is worried that mmput_async might still lead to a premature new oom victim selection due to the following race: __oom_reap_task exit_mm find_lock_task_mm atomic_inc(mm->mm_users) # = 2 task_unlock task_lock task->mm = NULL up_read(&mm->mmap_sem) < somebody write locks mmap_sem > task_unlock mmput atomic_dec_and_test # = 1 exit_oom_victim down_read_trylock # failed - no reclaim mmput_async # Takes unpredictable amount of time < new OOM situation > the final __mmput will be executed in the delayed context which might happen far in the future. Such a race is highly unlikely because the write holder of mmap_sem would have to be an external task (all direct holders are already killed or exiting) and it usually have to pin mm_users in order to do anything reasonable. We can, however, make sure that the mmput_async is only called when we do not back off and reap some memory. That would reduce the impact of the delayed __mmput because the real content would be already freed. Pin mm_count to keep it alive after we drop task_lock and before we try to get mmap_sem. If the mmap_sem succeeds we can try to grab mm_users reference and then go on with unmapping the address space. It is not clear whether this race is possible at all but it is better to be more robust and do not pin mm_users unless we are sure we are actually doing some real work during __oom_reap_task. Link: http://lkml.kernel.org/r/1465306987-30297-1-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit e5e3f4c4f0e95ecbad2f8d2f4f6a29bb8a90226b) BUG=chromium:957809 TEST=Built Change-Id: I86e40350845ed91ae4d2973b327209f6f86149e9 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628078 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628078" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/78/1628078/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I91f6f58fc05bf795d4fe70d9a21d1f930bee123b" commit="3eb851ba19face172d76c18990a9bde14fddb231" commit_message="UPSTREAM: oom: consider multi-threaded tasks in task_will_free_mem task_will_free_mem is a misnomer for a more complex PF_EXITING test for early break out from the oom killer because it is believed that such a task would release its memory shortly and so we do not have to select an oom victim and perform a disruptive action. Currently we make sure that the given task is not participating in the core dumping because it might get blocked for a long time - see commit d003f371b270 ("oom: don't assume that a coredumping thread will exit soon"). The check can still do better though. We shouldn't consider the task unless the whole thread group is going down. This is rather unlikely but not impossible. A single exiting thread would surely leave all the address space behind. If we are really unlucky it might get stuck on the exit path and keep its TIF_MEMDIE and so block the oom killer. Link: http://lkml.kernel.org/r/1460452756-15491-1-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Oleg Nesterov <oleg@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 98748bd722005be9de2662bd4f7e41ad8148bdbd) BUG=chromium:957809 TEST=Built Change-Id: I91f6f58fc05bf795d4fe70d9a21d1f930bee123b Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628079 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628079" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/79/1628079/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I2fb472ba0d5595e1857eb2cd2b25ec6300996c84" commit="46f7c4842474bb7a453aa3a14b6486fc651ca253" commit_message="UPSTREAM: mm, oom: fortify task_will_free_mem() task_will_free_mem is rather weak. It doesn't really tell whether the task has chance to drop its mm. 98748bd72200 ("oom: consider multi-threaded tasks in task_will_free_mem") made a first step into making it more robust for multi-threaded applications so now we know that the whole process is going down and probably drop the mm. This patch builds on top for more complex scenarios where mm is shared between different processes - CLONE_VM without CLONE_SIGHAND, or in kernel use_mm(). Make sure that all processes sharing the mm are killed or exiting. This will allow us to replace try_oom_reaper by wake_oom_reaper because task_will_free_mem implies the task is reapable now. Therefore all paths which bypass the oom killer are now reapable and so they shouldn't lock up the oom killer. Link: http://lkml.kernel.org/r/1466426628-15074-8-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Oleg Nesterov <oleg@redhat.com> Cc: Vladimir Davydov <vdavydov@virtuozzo.com> Cc: David Rientjes <rientjes@google.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 1af8bb43269563e458ebcf0ece812e9a970864b3) BUG=chromium:957809 TEST=Built Change-Id: I2fb472ba0d5595e1857eb2cd2b25ec6300996c84 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628080 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628080" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/80/1628080/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I2cda86dcd2d1a126fabf128eb571401b74a0d5b3" commit="65aad066e82d12b07c943a88acd8f63eff721d0f" commit_message="UPSTREAM: mm, oom: task_will_free_mem should skip oom_reaped tasks The 0-day robot has encountered the following: Out of memory: Kill process 3914 (trinity-c0) score 167 or sacrifice child Killed process 3914 (trinity-c0) total-vm:55864kB, anon-rss:1512kB, file-rss:1088kB, shmem-rss:25616kB oom_reaper: reaped process 3914 (trinity-c0), now anon-rss:0kB, file-rss:0kB, shmem-rss:26488kB oom_reaper: reaped process 3914 (trinity-c0), now anon-rss:0kB, file-rss:0kB, shmem-rss:26900kB oom_reaper: reaped process 3914 (trinity-c0), now anon-rss:0kB, file-rss:0kB, shmem-rss:26900kB oom_reaper: reaped process 3914 (trinity-c0), now anon-rss:0kB, file-rss:0kB, shmem-rss:27296kB oom_reaper: reaped process 3914 (trinity-c0), now anon-rss:0kB, file-rss:0kB, shmem-rss:28148kB oom_reaper is trying to reap the same task again and again. This is possible only when the oom killer is bypassed because of task_will_free_mem because we skip over tasks with MMF_OOM_REAPED already set during select_bad_process. Teach task_will_free_mem to skip over MMF_OOM_REAPED tasks as well because they will be unlikely to free anything more. Analyzed by Tetsuo Handa. Link: http://lkml.kernel.org/r/1466426628-15074-9-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Oleg Nesterov <oleg@redhat.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Vladimir Davydov <vdavydov@virtuozzo.com> Cc: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 696453e66630ad45e644c4571307fa3ebec9a835) BUG=chromium:957809 TEST=Built Change-Id: I2cda86dcd2d1a126fabf128eb571401b74a0d5b3 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628081 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628081" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/81/1628081/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="If13647ed59f225398a5a3ff4422ab5669e5133f2" commit="a890a9e955632db9b6f13363986433ff29269a1e" commit_message="UPSTREAM: mm, oom_reaper: do not attempt to reap a task more than twice oom_reaper relies on the mmap_sem for read to do its job. Many places which might block readers have been converted to use down_write_killable and that has reduced chances of the contention a lot. Some paths where the mmap_sem is held for write can take other locks and they might either be not prepared to fail due to fatal signal pending or too impractical to be changed. This patch introduces MMF_OOM_NOT_REAPABLE flag which gets set after the first attempt to reap a task's mm fails. If the flag is present after the failure then we set MMF_OOM_REAPED to hide this mm from the oom killer completely so it can go and chose another victim. As a result a risk of OOM deadlock when the oom victim would be blocked indefinetly and so the oom killer cannot make any progress should be mitigated considerably while we still try really hard to perform all reclaim attempts and stay predictable in the behavior. Link: http://lkml.kernel.org/r/1466426628-15074-10-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Oleg Nesterov <oleg@redhat.com> Cc: Vladimir Davydov <vdavydov@virtuozzo.com> Cc: David Rientjes <rientjes@google.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 11a410d516e89320fe0817606eeab58f36c22968) BUG=chromium:957809 TEST=Built Change-Id: If13647ed59f225398a5a3ff4422ab5669e5133f2 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628082 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628082" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/82/1628082/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I72665e346c86b87a2bb9844980cac1f051f89773" commit="27417ddecf208e81f12f5b1c2b89fbfb895a0bd5" commit_message="UPSTREAM: mm, oom: tighten task_will_free_mem() locking "mm, oom: fortify task_will_free_mem" has dropped task_lock around task_will_free_mem in oom_kill_process bacause it assumed that a potential race when the selected task exits will not be a problem as the oom_reaper will call exit_oom_victim. Tetsuo was objecting that nommu doesn't have oom_reaper so the race would be still possible. The code would be racy and lockup prone theoretically in other aspects without the oom reaper anyway so I didn't considered this a big deal. But it seems that further changes I am planning in this area will benefit from stable task->mm in this path as well. So let's drop find_lock_task_mm from task_will_free_mem and call it from under task_lock as we did previously. Just pull the task->mm != NULL check inside the function. Link: http://lkml.kernel.org/r/1467201562-6709-1-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Vladimir Davydov <vdavydov@parallels.com> Cc: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 091f362c53c24ca9751727a699d63e50528c306b) BUG=chromium:957809 TEST=Built Change-Id: I72665e346c86b87a2bb9844980cac1f051f89773 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628083 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628083" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/83/1628083/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I58a00dc0764c6145a6662f6ac2519b8a2ced7b32" commit="9f2a398d1f1c0df8d1b6325853550e774fe012d1" commit_message="UPSTREAM: mm, oom: fix uninitialized ret in task_will_free_mem() mm/oom_kill.c: In function `task_will_free_mem': mm/oom_kill.c:767: warning: `ret' may be used uninitialized in this function If __task_will_free_mem() is never called inside the for_each_process() loop, ret will not be initialized. Fixes: 1af8bb43269563e4 ("mm, oom: fortify task_will_free_mem()") Link: http://lkml.kernel.org/r/1470255599-24841-1-git-send-email-geert@linux-m68k.org Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit f33e6f0671b3ba81acef4d7c078af86afcc855c4) BUG=chromium:957809 TEST=Built Change-Id: I58a00dc0764c6145a6662f6ac2519b8a2ced7b32 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628084 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628084" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/84/1628084/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I3b84288f3230ad0d05b3647b526da55c034369f5" commit="7da9cf7518fee81184572ed9a86a24392e406a70" commit_message="UPSTREAM: mm/oom_kill.c: fix task_will_free_mem() comment Attempt to demystify the task_will_free_mem() loop. Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 5870c2e1d78b043b69de3199469c056ca3b05102) BUG=chromium:957809 TEST=Built Change-Id: I3b84288f3230ad0d05b3647b526da55c034369f5 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628085 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628085" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/85/1628085/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I228cee39c945cf23e15227dc3f9794e09415cfc7" commit="538e3cb41eb4af8923987de03d8cc083bf8a1294" commit_message="UPSTREAM: mm,oom_reaper: reduce find_lock_task_mm() usage Patch series "fortify oom killer even more", v2. This patch (of 9): __oom_reap_task() can be simplified a bit if it receives a valid mm from oom_reap_task() which also uses that mm when __oom_reap_task() failed. We can drop one find_lock_task_mm() call and also make the __oom_reap_task() code flow easier to follow. Moreover, this will make later patch in the series easier to review. Pinning mm's mm_count for longer time is not really harmful because this will not pin much memory. This patch doesn't introduce any functional change. Link: http://lkml.kernel.org/r/1472119394-11342-2-git-send-email-mhocko@kernel.org Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Oleg Nesterov <oleg@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Vladimir Davydov <vdavydov@parallels.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 7ebffa45551fe7db86a2b32bf586f124ef484e6e) BUG=chromium:957809 TEST=Built Change-Id: I228cee39c945cf23e15227dc3f9794e09415cfc7 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628086 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628086" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/86/1628086/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I4baea289160509962716ac35bd1508101609236e" commit="e38bbbe64f7144167bc6e31b5163b2583b196293" commit_message="UPSTREAM: mm,oom_reaper: do not attempt to reap a task twice "mm, oom_reaper: do not attempt to reap a task twice" tried to give the OOM reaper one more chance to retry using MMF_OOM_NOT_REAPABLE flag. But the usefulness of the flag is rather limited and actually never shown in practice. If the flag is set, it means that the holder of mm->mmap_sem cannot call up_write() due to presumably being blocked at unkillable wait waiting for other thread's memory allocation. But since one of threads sharing that mm will queue that mm immediately via task_will_free_mem() shortcut (otherwise, oom_badness() will select the same mm again due to oom_score_adj value unchanged), retrying MMF_OOM_NOT_REAPABLE mm is unlikely helpful. Let's always set MMF_OOM_REAPED. Link: http://lkml.kernel.org/r/1472119394-11342-3-git-send-email-mhocko@kernel.org Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Oleg Nesterov <oleg@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Vladimir Davydov <vdavydov@parallels.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 8496afaba93ece80a83cbd096f0675a1020ddfc4) BUG=chromium:957809 TEST=Built Change-Id: I4baea289160509962716ac35bd1508101609236e Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628087 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628087" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/87/1628087/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I398db98e90f6082dfa1b913533b8300dc1089dc5" commit="06cd92ef51ddc97c5df01f1229e1b5b5006487f6" commit_message="UPSTREAM: mm: oom: add memcg to oom_control It's a part of oom context just like allocation order and nodemask, so let's move it to oom_control instead of passing it in the argument list. Link: http://lkml.kernel.org/r/40e03fd7aaf1f55c75d787128d6d17c5a71226c2.1464358556.git.vdavydov@virtuozzo.com Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com> Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 2a966b77ae3ede207e787e7538b87d1011c4364e) BUG=chromium:957809 TEST=Built Change-Id: I398db98e90f6082dfa1b913533b8300dc1089dc5 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628088 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628088" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/88/1628088/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I5f3de053149e04589db57456f1d8e08a1def5f9e" commit="6b6ed4b49d825a7b9d7422979601a13182c31e8c" commit_message="UPSTREAM: mm,oom: speed up select_bad_process() loop Since commit 3a5dda7a17cf ("oom: prevent unnecessary oom kills or kernel panics"), select_bad_process() is using for_each_process_thread(). Since oom_unkillable_task() scans all threads in the caller's thread group and oom_task_origin() scans signal_struct of the caller's thread group, we don't need to call oom_unkillable_task() and oom_task_origin() on each thread. Also, since !mm test will be done later at oom_badness(), we don't need to do !mm test on each thread. Therefore, we only need to do TIF_MEMDIE test on each thread. Although the original code was correct it was quite inefficient because each thread group was scanned num_threads times which can be a lot especially with processes with many threads. Even though the OOM is extremely cold path it is always good to be as effective as possible when we are inside rcu_read_lock() - aka unpreemptible context. If we track number of TIF_MEMDIE threads inside signal_struct, we don't need to do TIF_MEMDIE test on each thread. This will allow select_bad_process() to use for_each_process(). This patch adds a counter to signal_struct for tracking how many TIF_MEMDIE threads are in a given thread group, and check it at oom_scan_process_thread() so that select_bad_process() can use for_each_process() rather than for_each_process_thread(). [mhocko@suse.com: do not blow the signal_struct size] Link: http://lkml.kernel.org/r/20160520075035.GF19172@dhcp22.suse.cz Link: http://lkml.kernel.org/r/201605182230.IDC73435.MVSOHLFOQFOJtF@I-love.SAKURA.ne.jp Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Acked-by: Michal Hocko <mhocko@suse.com> Cc: David Rientjes <rientjes@google.com> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit f44666b04605d1c7fd94ab90b7ccf633e7eff228) BUG=chromium:957809 TEST=Built Change-Id: I5f3de053149e04589db57456f1d8e08a1def5f9e Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628089 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628089" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/89/1628089/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I090f144c078babed50c163a77aa81dac5573fb8e" commit="da6b3c2d62a5b8f9922a4efa9386767d98f25cf2" commit_message="UPSTREAM: mm, oom: hide mm which is shared with kthread or global init The only case where the oom_reaper is not triggered for the oom victim is when it shares the memory with a kernel thread (aka use_mm) or with the global init. After "mm, oom: skip vforked tasks from being selected" the victim cannot be a vforked task of the global init so we are left with clone(CLONE_VM) (without CLONE_SIGHAND). use_mm() users are quite rare as well. In order to help forward progress for the OOM killer, make sure that this really rare case will not get in the way - we do this by hiding the mm from the oom killer by setting MMF_OOM_REAPED flag for it. oom_scan_process_thread will ignore any TIF_MEMDIE task if it has MMF_OOM_REAPED flag set to catch these oom victims. After this patch we should guarantee forward progress for the OOM killer even when the selected victim is sharing memory with a kernel thread or global init as long as the victims mm is still alive. Link: http://lkml.kernel.org/r/1466426628-15074-11-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Oleg Nesterov <oleg@redhat.com> Cc: Vladimir Davydov <vdavydov@virtuozzo.com> Cc: David Rientjes <rientjes@google.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit a373966d1f64c04ba9d0159087f0fa1b5aac4c33) BUG=chromium:957809 TEST=Built Change-Id: I090f144c078babed50c163a77aa81dac5573fb8e Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628090 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628090" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/90/1628090/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I74fea35305cd9163c260cb8ab134e1f74a1515b3" commit="20d60dcd723bbeaaeb33ced6be83381037f9eb33" commit_message="UPSTREAM: mm, oom: skip vforked tasks from being selected vforked tasks are not really sitting on any memory. They are sharing the mm with parent until they exec into a new code. Until then it is just pinning the address space. OOM killer will kill the vforked task along with its parent but we still can end up selecting vforked task when the parent wouldn't be selected. E.g. init doing vfork to launch a task or vforked being a child of oom unkillable task with an updated oom_score_adj to be killable. Add a new helper to check whether a task is in the vfork sharing memory with its parent and use it in oom_badness to skip over these tasks. Link: http://lkml.kernel.org/r/1466426628-15074-6-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Oleg Nesterov <oleg@redhat.com> Cc: Vladimir Davydov <vdavydov@virtuozzo.com> Cc: David Rientjes <rientjes@google.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit b18dc5f291c07ddaf31562b9f27b3a122f1f9b7e) BUG=chromium:957809 TEST=Built Change-Id: I74fea35305cd9163c260cb8ab134e1f74a1515b3 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628091 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628091" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/91/1628091/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I2fb5d557fbf4209aedd0411632caa39dbe991abf" commit="158e71687f3ccf4b45fb7813b5f8ca912632a49b" commit_message="UPSTREAM: mm, oom: kill all tasks sharing the mm Currently oom_kill_process skips both the oom reaper and SIG_KILL if a process sharing the same mm is unkillable via OOM_ADJUST_MIN. After "mm, oom_adj: make sure processes sharing mm have same view of oom_score_adj" all such processes are sharing the same value so we shouldn't see such a task at all (oom_badness would rule them out). We can still encounter oom disabled vforked task which has to be killed as well if we want to have other tasks sharing the mm reapable because it can access the memory before doing exec. Killing such a task should be acceptable because it is highly unlikely it has done anything useful because it cannot modify any memory before it calls exec. An alternative would be to keep the task alive and skip the oom reaper and risk all the weird corner cases where the OOM killer cannot make forward progress because the oom victim hung somewhere on the way to exit. [rientjes@google.com - drop printk when OOM_SCORE_ADJ_MIN killed task the setting is inherently racy and we cannot do much about it without introducing locks in hot paths] Link: http://lkml.kernel.org/r/1466426628-15074-7-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Oleg Nesterov <oleg@redhat.com> Cc: Vladimir Davydov <vdavydov@virtuozzo.com> Cc: David Rientjes <rientjes@google.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 97fd49c2355ffdede6526afc0c72bc314d05f42a) BUG=chromium:957809 TEST=Built Change-Id: I2fb5d557fbf4209aedd0411632caa39dbe991abf Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628092 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628092" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/92/1628092/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Iab92472b80e869fce3d1fd8f1cff090a2a8025ac" commit="41eed2b1de1ae50b563f8e2cfd31f4a248629d11" commit_message="BACKPORT: oom: keep mm of the killed task available oom_reap_task has to call exit_oom_victim in order to make sure that the oom vicim will not block the oom killer for ever. This is, however, opening new problems (e.g oom_killer_disable exclusion - see commit 74070542099c ("oom, suspend: fix oom_reaper vs. oom_killer_disable race")). exit_oom_victim should be only called from the victim's context ideally. One way to achieve this would be to rely on per mm_struct flags. We already have MMF_OOM_REAPED to hide a task from the oom killer since "mm, oom: hide mm which is shared with kthread or global init". The problem is that the exit path: do_exit exit_mm tsk->mm = NULL; mmput __mmput exit_oom_victim doesn't guarantee that exit_oom_victim will get called in a bounded amount of time. At least exit_aio depends on IO which might get blocked due to lack of memory and who knows what else is lurking there. This patch takes a different approach. We remember tsk->mm into the signal_struct and bind it to the signal struct life time for all oom victims. __oom_reap_task_mm as well as oom_scan_process_thread do not have to rely on find_lock_task_mm anymore and they will have a reliable reference to the mm struct. As a result all the oom specific communication inside the OOM killer can be done via tsk->signal->oom_mm. Increasing the signal_struct for something as unlikely as the oom killer is far from ideal but this approach will make the code much more reasonable and long term we even might want to move task->mm into the signal_struct anyway. In the next step we might want to make the oom killer exclusion and access to memory reserves completely independent which would be also nice. Link: http://lkml.kernel.org/r/1472119394-11342-4-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Oleg Nesterov <oleg@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Vladimir Davydov <vdavydov@parallels.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 26db62f179d112d345031e14926a4cda9cd40d6e) BUG=chromium:957809 TEST=Built Change-Id: Iab92472b80e869fce3d1fd8f1cff090a2a8025ac Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628093 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> " fail_count="0" gerrit_number="1628093" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/93/1628093/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I72dd987b5ddf0e36fff4ca2368cb298d2c9cb7a0" commit="3462724659e81132f5b45e56d3bcacb0b7e0e5c7" commit_message="UPSTREAM: kernel, oom: fix potential pgd_lock deadlock from __mmdrop Lockdep complains that __mmdrop is not safe from the softirq context: ================================= [ INFO: inconsistent lock state ] 4.6.0-oomfortification2-00011-geeb3eadeab96-dirty #949 Tainted: G W --------------------------------- inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage. swapper/1/0 [HC0[0]:SC1[1]:HE1:SE0] takes: (pgd_lock){+.?...}, at: pgd_free+0x19/0x6b {SOFTIRQ-ON-W} state was registered at: __lock_acquire+0xa06/0x196e lock_acquire+0x139/0x1e1 _raw_spin_lock+0x32/0x41 __change_page_attr_set_clr+0x2a5/0xacd change_page_attr_set_clr+0x16f/0x32c set_memory_nx+0x37/0x3a free_init_pages+0x9e/0xc7 alternative_instructions+0xa2/0xb3 check_bugs+0xe/0x2d start_kernel+0x3ce/0x3ea x86_64_start_reservations+0x2a/0x2c x86_64_start_kernel+0x17a/0x18d irq event stamp: 105916 hardirqs last enabled at (105916): free_hot_cold_page+0x37e/0x390 hardirqs last disabled at (105915): free_hot_cold_page+0x2c1/0x390 softirqs last enabled at (105878): _local_bh_enable+0x42/0x44 softirqs last disabled at (105879): irq_exit+0x6f/0xd1 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(pgd_lock); <Interrupt> lock(pgd_lock); *** DEADLOCK *** 1 lock held by swapper/1/0: #0: (rcu_callback){......}, at: rcu_process_callbacks+0x390/0x800 stack backtrace: CPU: 1 PID: 0 Comm: swapper/1 Tainted: G W 4.6.0-oomfortification2-00011-geeb3eadeab96-dirty #949 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Debian-1.8.2-1 04/01/2014 Call Trace: <IRQ> print_usage_bug.part.25+0x259/0x268 mark_lock+0x381/0x567 __lock_acquire+0x993/0x196e lock_acquire+0x139/0x1e1 _raw_spin_lock+0x32/0x41 pgd_free+0x19/0x6b __mmdrop+0x25/0xb9 __put_task_struct+0x103/0x11e delayed_put_task_struct+0x157/0x15e rcu_process_callbacks+0x660/0x800 __do_softirq+0x1ec/0x4d5 irq_exit+0x6f/0xd1 smp_apic_timer_interrupt+0x42/0x4d apic_timer_interrupt+0x8e/0xa0 <EOI> arch_cpu_idle+0xf/0x11 default_idle_call+0x32/0x34 cpu_startup_entry+0x20c/0x399 start_secondary+0xfe/0x101 More over commit a79e53d85683 ("x86/mm: Fix pgd_lock deadlock") was explicit about pgd_lock not to be called from the irq context. This means that __mmdrop called from free_signal_struct has to be postponed to a user context. We already have a similar mechanism for mmput_async so we can use it here as well. This is safe because mm_count is pinned by mm_users. This fixes bug introduced by "oom: keep mm of the killed task available" Link: http://lkml.kernel.org/r/1472119394-11342-5-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Oleg Nesterov <oleg@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Vladimir Davydov <vdavydov@parallels.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 7283094ec3db318e87ec9e31cf75f136ac2a4dd3) BUG=chromium:957809 TEST=Built Change-Id: I72dd987b5ddf0e36fff4ca2368cb298d2c9cb7a0 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628094 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628094" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/94/1628094/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I6e171550e7b836dae95bd1e0e572d2975a887103" commit="5c7c1af45a998602904b62c6f5983a33a70a40a6" commit_message="BACKPORT: mm, oom: get rid of signal_struct::oom_victims After "oom: keep mm of the killed task available" we can safely detect an oom victim by checking task->signal->oom_mm so we do not need the signal_struct counter anymore so let's get rid of it. This alone wouldn't be sufficient for nommu archs because exit_oom_victim doesn't hide the process from the oom killer anymore. We can, however, mark the mm with a MMF flag in __mmput. We can reuse MMF_OOM_REAPED and rename it to a more generic MMF_OOM_SKIP. Link: http://lkml.kernel.org/r/1472119394-11342-6-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Oleg Nesterov <oleg@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Vladimir Davydov <vdavydov@parallels.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 862e3073b3eed13f17bd6be6ca6052db15c0b728) BUG=chromium:957809 TEST=Built Change-Id: I6e171550e7b836dae95bd1e0e572d2975a887103 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628095 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> " fail_count="0" gerrit_number="1628095" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/95/1628095/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I84467ca5a841e0fdae6f4e1f224a25d800ba026e" commit="2a8e785c348d00b79dde129cb1fa18092c2551a0" commit_message="UPSTREAM: mm: make sure that kthreads will not refault oom reaped memory There are only few use_mm() users in the kernel right now. Most of them write to the target memory but vhost driver relies on copy_from_user/get_user from a kernel thread context. This makes it impossible to reap the memory of an oom victim which shares the mm with the vhost kernel thread because it could see a zero page unexpectedly and theoretically make an incorrect decision visible outside of the killed task context. To quote Michael S. Tsirkin: : Getting an error from __get_user and friends is handled gracefully. : Getting zero instead of a real value will cause userspace : memory corruption. The vhost kernel thread is bound to an open fd of the vhost device which is not tight to the mm owner life cycle in general. The device fd can be inherited or passed over to another process which means that we really have to be careful about unexpected memory corruption because unlike for normal oom victims the result will be visible outside of the oom victim context. Make sure that no kthread context (users of use_mm) can ever see corrupted data because of the oom reaper and hook into the page fault path by checking MMF_UNSTABLE mm flag. __oom_reap_task_mm will set the flag before it starts unmapping the address space while the flag is checked after the page fault has been handled. If the flag is set then SIGBUS is triggered so any g-u-p user will get a error code. Regular tasks do not need this protection because all which share the mm are killed when the mm is reaped and so the corruption will not outlive them. This patch shouldn't have any visible effect at this moment because the OOM killer doesn't invoke oom reaper for tasks with mm shared with kthreads yet. Link: http://lkml.kernel.org/r/1472119394-11342-9-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: "Michael S. Tsirkin" <mst@redhat.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Oleg Nesterov <oleg@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Vladimir Davydov <vdavydov@parallels.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 3f70dc38cec2ad6e5355f80c4c7a15a3f7e97a19) BUG=chromium:957809 TEST=Built Change-Id: I84467ca5a841e0fdae6f4e1f224a25d800ba026e Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628096 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628096" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/96/1628096/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Icdab0d3925d1f2927d0456f6266052570acef819" commit="c711486fd33c7d7e09feed94bed311f75b4c69e5" commit_message="UPSTREAM: oom, oom_reaper: allow to reap mm shared by the kthreads oom reaper was skipped for an mm which is shared with the kernel thread (aka use_mm()). The primary concern was that such a kthread might want to read from the userspace memory and see zero page as a result of the oom reaper action. This is no longer a problem after "mm: make sure that kthreads will not refault oom reaped memory" because any attempt to fault in when the MMF_UNSTABLE is set will result in SIGBUS and so the target user should see an error. This means that we can finally allow oom reaper also to tasks which share their mm with kthreads. Link: http://lkml.kernel.org/r/1472119394-11342-10-git-send-email-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Oleg Nesterov <oleg@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Vladimir Davydov <vdavydov@parallels.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 1b51e65eab64fac72cab009691e8ca9915624876) BUG=chromium:957809 TEST=Built Change-Id: Icdab0d3925d1f2927d0456f6266052570acef819 Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628097 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628097" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/97/1628097/5" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="I31e6d174aebe045f3478d2232d01f5907fed776d" commit="e997798dfc8d85b0694421c4ffef5b628eba7842" commit_message="UPSTREAM: mm: drop zap_details::ignore_dirty The only user of ignore_dirty is oom-reaper. But it doesn't really use it. ignore_dirty only has effect on file pages mapped with dirty pte. But oom-repear skips shared VMAs, so there's no way we can dirty file pte in them. Link: http://lkml.kernel.org/r/20170118122429.43661-1-kirill.shutemov@linux.intel.com Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Rik van Riel <riel@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit da162e9368990ed747075e2ab427da0759fc4a59) BUG=chromium:957809 TEST=Built Change-Id: I31e6d174aebe045f3478d2232d01f5907fed776d Signed-off-by: Yu Zhao <yuzhao@google.com> Reviewed-on: https://chromium-review.googlesource.com/1628098 Tested-by: Yu Zhao <yuzhao@chromium.org> Commit-Ready: Yu Zhao <yuzhao@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu Zhao <yuzhao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="0" gerrit_number="1628098" owner_email="yuzhao@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/98/1628098/5" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Ia93ed189e7561ca18c63b5ded81826bc9b1cff12" commit="c85bfb65057900959c59012c4d9c0f686337ef22" commit_message="update_engine: Add newer DBus method and signal for GetStatus The current GetStatus function is pretty non-extendable and there has been use cases where we wanted to add arguments to it but it was quite hard to do specially changes in Chrome. This CL adds a new DBus Method GetStatusAdvanced and Signal UpdateStatusAdvanced which use a protobuf for communicating dbus messages. This allows us to extend the protobuf without much effort in the future. BUG=chromium:977320 TEST=unittests, precq Cq-Depend: chromium:1672684, chrome-internal:1424559 Change-Id: Ia93ed189e7561ca18c63b5ded81826bc9b1cff12 Reviewed-on: https://chromium-review.googlesource.com/1669974 Tested-by: Amin Hassani <ahassani@chromium.org> Commit-Ready: Amin Hassani <ahassani@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> " fail_count="1" gerrit_number="1669974" owner_email="ahassani@chromium.org" pass_count="0" patch_number="15" project="aosp/platform/system/update_engine" project_url="https://chromium-review.googlesource.com/aosp/platform/system/update_engine" ref="refs/changes/74/1669974/15" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I6e34ee76ede0c7b0b8cd1bba603a5836743d67fc" commit="e411611ae5fe267ffa3691cc2ce7f9f95197907a" commit_message="update_engine: Use DBus protobuf capabilities in dlcservice API methods DBus have the capability to pass protobuf message directly in the method without the need for serializing it manually. This CL uses those types of arguments which is almost used everywhere in the platform2 code base. BUG=chromium:978672 TEST=precq Cq-Depend: chromium:1672684 Change-Id: I6e34ee76ede0c7b0b8cd1bba603a5836743d67fc Reviewed-on: https://chromium-review.googlesource.com/1672021 Tested-by: Amin Hassani <ahassani@chromium.org> Commit-Ready: Amin Hassani <ahassani@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> " fail_count="1" gerrit_number="1672021" owner_email="ahassani@chromium.org" pass_count="0" patch_number="11" project="aosp/platform/system/update_engine" project_url="https://chromium-review.googlesource.com/aosp/platform/system/update_engine" ref="refs/changes/21/1672021/11" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I699b00bb84ec7f4ac384ae490aca91c7f5069f23" commit="2197aa9291d11a301f14967c9fe8fabe2d2845b7" commit_message="dlcservice: Use DBus protobuf capabilities for update_engine DBus methods DBus have the capability to pass protobuf message directly in the methods and signals without the need for serializing it manually. This CL uses those types of arguments which is almost used everywhere in the platform2 code base. This allows users of the API to not care about serializing/deserializing the protobuf and their implementation will be much cleaner. BUG=chromium:978672 TEST=unittest, precq Cq-Depend: chromium:1672021 Change-Id: I699b00bb84ec7f4ac384ae490aca91c7f5069f23 Reviewed-on: https://chromium-review.googlesource.com/1672684 Tested-by: Amin Hassani <ahassani@chromium.org> Commit-Ready: Amin Hassani <ahassani@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> " fail_count="2" gerrit_number="1672684" owner_email="ahassani@chromium.org" pass_count="0" patch_number="4" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/84/1672684/4" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I10ee0cf432a0b5e363dcc4a5c34d294ebcdafd02" commit="b13b94937899e0e611ad8a641903b4fc382fc82b" commit_message="shill: cellular: drop 'universal' in cellular capability Given that those legacy cellular capability classes have been removed, it's no longer necessary to keep 'universal' in the naming of the remaining cellular capability classes, which are renamed in this CL as follows: CellularCapabilityUniversal -> CellularCapability3gpp CellularCapabilityUniversalCdma -> CellularCapabilityCdma This CL is generated with the following commands: sed -i \ -e 's/CapabilityUniversalCdma/CapabilityCdma/g' \ -e 's/CAPABILITY_UNIVERSAL_CDMA/CAPABILITY_CDMA/g' \ -e 's/capability_universal_cdma/capability_cdma/g' \ -e 's/CapabilityUniversal/Capability3gpp/g' \ -e 's/CAPABILITY_UNIVERSAL/CAPABILITY_3GPP/g' \ -e 's/capability_universal/capability_3gpp/g' \ -e 's/kTypeUniversalCdma/kTypeCdma/gI' \ -e 's/kTypeUniversal/kType3gpp/gI' \ $(git ls-files '*.h' '*.cc') BUILD.gn git mv cellular/cellular_capability_{universal,3gpp}.h git mv cellular/cellular_capability_{universal,3gpp}.cc git mv cellular/cellular_capability_{universal,3gpp}_test.cc git mv cellular/cellular_capability_{universal_,}cdma.h git mv cellular/cellular_capability_{universal_,}cdma.cc git mv cellular/cellular_capability_{universal_,}cdma_test.cc git cl format BUG=None TEST=Run unit tests. Change-Id: I10ee0cf432a0b5e363dcc4a5c34d294ebcdafd02 Reviewed-on: https://chromium-review.googlesource.com/1682851 Tested-by: Ben Chan <benchan@google.com> Commit-Ready: Ben Chan <benchan@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Ben Chan <benchan@google.com> " fail_count="5" gerrit_number="1682851" owner_email="benchan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/51/1682851/3" remote="cros" total_fail_count="7"/><pending_commit branch="master" change_id="I2a7d2c7ece53ff64b3b6d6c1fc18a694dc231000" commit="352b9949fd5243aebb30de3e558164084ab9cfbc" commit_message="shill: cellular: remove unused CellularCapability3gpp::ModemModes BUG=None TEST=Run unit tests. Change-Id: I2a7d2c7ece53ff64b3b6d6c1fc18a694dc231000 Reviewed-on: https://chromium-review.googlesource.com/1682271 Tested-by: Ben Chan <benchan@chromium.org> Commit-Ready: Ben Chan <benchan@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> " fail_count="5" gerrit_number="1682271" owner_email="benchan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/71/1682271/3" remote="cros" total_fail_count="7"/><pending_commit branch="master" change_id="Id9681f8405b84928d09cce32c646a7bc873439f6" commit="f6e8ba6074c46550a9d6f4828c92290a1614d632" commit_message="shill: cellular: make CellularCapabilityCdma::OnModemCdmaPropertiesChanged non-virtual There is no needed to override CellularCapabilityCdma::OnModemCdmaPropertiesChanged, so this CL makes it non-virtual. BUG=None TEST=Run unit tests. Change-Id: Id9681f8405b84928d09cce32c646a7bc873439f6 Reviewed-on: https://chromium-review.googlesource.com/1682272 Tested-by: Ben Chan <benchan@chromium.org> Commit-Ready: Ben Chan <benchan@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> " fail_count="5" gerrit_number="1682272" owner_email="benchan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/72/1682272/3" remote="cros" total_fail_count="7"/><pending_commit branch="master" change_id="I009eafc774a54e2b4324877c972ae9ff22ecb6eb" commit="fc00f1521fc808a38b8bfda1e40248f7f5917eb4" commit_message="shill: cellular: move private static methods to unnamed namespace CellularCapability3gpp::IsRegisteredState(), CellularCapabilityCdma::GetActivationStateString() CellularCapabilityCdma::GetActivationErrorString() are private implementation details. There is no need to expose them via the class interface. BUG=None TEST=Run unit tests. Change-Id: I009eafc774a54e2b4324877c972ae9ff22ecb6eb Reviewed-on: https://chromium-review.googlesource.com/1682273 Tested-by: Ben Chan <benchan@chromium.org> Commit-Ready: Ben Chan <benchan@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> " fail_count="5" gerrit_number="1682273" owner_email="benchan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/73/1682273/3" remote="cros" total_fail_count="7"/><pending_commit branch="master" change_id="I0fcfd8ba6a2ae59a419af963eb7b54245f697d77" commit="b2146d3a443b190a53300dc26c492e0f9b52aecb" commit_message="minigbm: fix subsampling issue For YUV, we're not consistent. For the "y" component, we assume the offset is just y * plane_stride, letting the API user take care of the subsampling. For the "x" component, we subsample the "x" the user passes in (see drv_stride_from_format(..)). Let's be consistent and not subsample. This likely makes neglible difference since the users of the API map the entire plane. BUG=b:132939420 TEST=none Change-Id: I0fcfd8ba6a2ae59a419af963eb7b54245f697d77 Reviewed-on: https://chromium-review.googlesource.com/1681382 Tested-by: Gurchetan Singh <gurchetansingh@chromium.org> Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> Reviewed-by: Lepton Wu <lepton@chromium.org> " fail_count="2" gerrit_number="1681382" owner_email="gurchetansingh@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform/minigbm" project_url="https://chromium-review.googlesource.com/chromiumos/platform/minigbm" ref="refs/changes/82/1681382/2" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I6efc5faa55dfc2841ca17d04db9f16eaeac39d7e" commit="3159b30e008e6fdf704f7d8fcb3780f92d274079" commit_message="minigbm: update virgl_hw.h Taken from ToT virglrenderer (commit e27247), which contains the upstream version of this file. BUG=b:132939420 TEST=compile Change-Id: I6efc5faa55dfc2841ca17d04db9f16eaeac39d7e Reviewed-on: https://chromium-review.googlesource.com/1645878 Tested-by: Gurchetan Singh <gurchetansingh@chromium.org> Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> Reviewed-by: Lepton Wu <lepton@chromium.org> " fail_count="2" gerrit_number="1645878" owner_email="gurchetansingh@chromium.org" pass_count="0" patch_number="7" project="chromiumos/platform/minigbm" project_url="https://chromium-review.googlesource.com/chromiumos/platform/minigbm" ref="refs/changes/78/1645878/7" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I3ac10f5c986bc5dae5b34cd70654676d4ad289ea" commit="6d68ccf4a729a93ea2e937875849d4b0367fdfaf" commit_message="minigbm: modify resolve format hooks a bit Plumb the driver backend to the resolve format hook. BUG=b:132939420 TEST=compile Change-Id: I3ac10f5c986bc5dae5b34cd70654676d4ad289ea Reviewed-on: https://chromium-review.googlesource.com/1645879 Tested-by: Gurchetan Singh <gurchetansingh@chromium.org> Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> Reviewed-by: Lepton Wu <lepton@chromium.org> " fail_count="2" gerrit_number="1645879" owner_email="gurchetansingh@chromium.org" pass_count="0" patch_number="7" project="chromiumos/platform/minigbm" project_url="https://chromium-review.googlesource.com/chromiumos/platform/minigbm" ref="refs/changes/79/1645879/7" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I486f7be23f8431aa8bbaea89dca7c1304536e9ac" commit="25b8dee00cfd0de65283c5b2962e68c1c8b9251c" commit_message="minigbm: virtio-gpu: use NV12 as flexible media format All of our future drivers (including MTK_MT8183) seem to prefer NV12 as their flexible media format, so advertise that. In the unlikely event that changes, we can set either use the capabilities or resource create versioning (a planned feature). This has the benefit of keeping Android flexible formats in Android userspace. BUG=b:132939420 TEST=compile Change-Id: I486f7be23f8431aa8bbaea89dca7c1304536e9ac Reviewed-on: https://chromium-review.googlesource.com/1644464 Tested-by: Gurchetan Singh <gurchetansingh@chromium.org> Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> Reviewed-by: Lepton Wu <lepton@chromium.org> " fail_count="2" gerrit_number="1644464" owner_email="gurchetansingh@chromium.org" pass_count="0" patch_number="9" project="chromiumos/platform/minigbm" project_url="https://chromium-review.googlesource.com/chromiumos/platform/minigbm" ref="refs/changes/64/1644464/9" remote="cros" total_fail_count="2"/><pending_commit branch="chromeos-4.14" change_id="I945003ae3269803a8f4dfd98694ac52ca82526e4" commit="c873ea48ce115c416cb02c9ad77c3b55f65fc3ee" commit_message="UPSTREAM: BACKPORT: drm/udl: introduce a macro to convert dev to udl. This just makes it easier to later embed drm into udl. Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190405031715.5959-3-airlied@gmail.com BUG=b:135472125 TEST=Plug and unplug MIMO repeatedly on guado-kernelnext. The diff vs upstream is due to the fact that in chromeos-4.14 the udl_gem_mmap() function doesn't have a local 'struct udl_device' pointer so it didn't need to be converted. Change-Id: I945003ae3269803a8f4dfd98694ac52ca82526e4 (cherry picked from commit fd96e0dba19c53c2d66f2a398716bb74df8ca85e) Signed-off-by: Ross Zwisler <zwisler@google.com> Reviewed-on: https://chromium-review.googlesource.com/1682867 Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Jon Flatley <jflat@chromium.org> Reviewed-by: Dominik Behr <dbehr@chromium.org> " fail_count="2" gerrit_number="1682867" owner_email="zwisler@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/67/1682867/1" remote="cros" total_fail_count="2"/><pending_commit branch="chromeos-4.14" change_id="Icb084277062e85a7f810f08e872e0ad45dee216f" commit="7415f752b63c1b47fdda12297429f07fc23e9858" commit_message="UPSTREAM: drm/udl: Replace drm_dev_unref with drm_dev_put This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20180926120212.25359-1-tzimmermann@suse.de BUG=b:135472125 TEST=Plug and unplug MIMO repeatedly on guado-kernelnext. Change-Id: Icb084277062e85a7f810f08e872e0ad45dee216f (cherry picked from commit ac3b35f11a06964f5fe7f6ea9a190a28a7994704) Signed-off-by: Ross Zwisler <zwisler@google.com> Reviewed-on: https://chromium-review.googlesource.com/1682868 Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Dominik Behr <dbehr@chromium.org> " fail_count="1" gerrit_number="1682868" owner_email="zwisler@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/68/1682868/1" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.14" change_id="If335f9a42c1aff0d5914eb334851c349ea6f9463" commit="2c37a1e89ce9988c1be225f784d7454db5e9d6d8" commit_message="UPSTREAM: drm/udl: move to embedding drm device inside udl device. This should help with some of the lifetime issues, and move us away from load/unload. Acked-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190405031715.5959-4-airlied@gmail.com BUG=b:135472125 TEST=Plug and unplug MIMO repeatedly on guado-kernelnext. Change-Id: If335f9a42c1aff0d5914eb334851c349ea6f9463 (cherry picked from commit 6ecac85eadb9d4065b9038fa3d3c66d49038e14b) Signed-off-by: Ross Zwisler <zwisler@google.com> Reviewed-on: https://chromium-review.googlesource.com/1682869 Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Dominik Behr <dbehr@chromium.org> " fail_count="1" gerrit_number="1682869" owner_email="zwisler@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/69/1682869/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I98f55edbdc56ad8f8b4d09b9e7cbc13245750c89" commit="5d89e15e81ee5710881de6496323c377309384a3" commit_message="vm_tools: concierge: implement CreateDiskImage for Plugin VM This adds the ability to create a new Plugin VM image and attach given ISO as a source media to it to allow installing OS. BUG=b:135054054 TEST=Try creating a new Plugin VM image. Change-Id: I98f55edbdc56ad8f8b4d09b9e7cbc13245750c89 Reviewed-on: https://chromium-review.googlesource.com/1663394 Tested-by: Dmitry Torokhov <dtor@chromium.org> Commit-Ready: Dmitry Torokhov <dtor@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> " fail_count="2" gerrit_number="1663394" owner_email="dtor@chromium.org" pass_count="0" patch_number="7" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/94/1663394/7" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Ifd69e0d435112b50f0e4f0ac9f6b7e1edba4c0f9" commit="8316b325ec0cd51d08f3aaae97587800f740dd4d" commit_message="vm_tools: concierge: move VmPlugin* API into pvm::dispatcher namespace Now that we have pvm::helper namespace, let's move dispatcher interface to pvm::dispatcher under vm_tools::concierge. BUG=b:135054054 TEST=Try creating a new Plugin VM image. Change-Id: Ifd69e0d435112b50f0e4f0ac9f6b7e1edba4c0f9 Reviewed-on: https://chromium-review.googlesource.com/1672716 Tested-by: Dmitry Torokhov <dtor@chromium.org> Commit-Ready: Dmitry Torokhov <dtor@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> " fail_count="2" gerrit_number="1672716" owner_email="dtor@chromium.org" pass_count="0" patch_number="6" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/16/1672716/6" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Iad8a912925532a63d86b049bedec0e9a6258025c" commit="bdb2914ffde54020c3c75c1c0935f075d4d2f305" commit_message="vm_tools: crostini_client: implement "create" command This allows creating new Plugin VM instances and attaching an installation media to them: vmc create -p VmName install.iso -- more args BUG=b:135054054 TEST=Try creating a new Plugin VM image. Change-Id: Iad8a912925532a63d86b049bedec0e9a6258025c Reviewed-on: https://chromium-review.googlesource.com/1680854 Tested-by: Dmitry Torokhov <dtor@chromium.org> Commit-Ready: Dmitry Torokhov <dtor@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org> " fail_count="2" gerrit_number="1680854" owner_email="dtor@chromium.org" pass_count="0" patch_number="4" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/54/1680854/4" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Ic333adfe3b56670cd7253c2007ff094156199c0f" commit="23ed2da08f2b9409ba97570915986e00ec46889d" commit_message="cros-camera-hal-usb: Add cros-camera-libcamera_realtek dependency BUG=b:123889668 TEST=emerge-${BOARD} cros-camera-hal-usb with new use flag Change-Id: Ic333adfe3b56670cd7253c2007ff094156199c0f Reviewed-on: https://chromium-review.googlesource.com/1657873 Tested-by: Heng-ruey Hsu <henryhsu@google.com> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Shik Chen <shik@chromium.org> " fail_count="7" gerrit_number="1657873" owner_email="henryhsu@chromium.org" pass_count="0" patch_number="5" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/73/1657873/5" remote="cros" total_fail_count="7"/><pending_commit branch="master" change_id="I22c1a0de5c9e31ec2868665fdabbfcd0c3755122" commit="f70881aaa30822485d0fa32cc1f9fa0ad2114530" commit_message="vm_protos: add new package to break out protos and headers from vm_tools BUG=b:128413415 TEST=FEATURES=test build-packages --board=sarien FEATURES=test build-packages --board=tatl Cq-Depend: chromium:1515945 Change-Id: I22c1a0de5c9e31ec2868665fdabbfcd0c3755122 Reviewed-on: https://chromium-review.googlesource.com/1516752 Tested-by: Trent Begin <tbegin@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> " fail_count="5" gerrit_number="1516752" owner_email="tbegin@chromium.org" pass_count="0" patch_number="15" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/52/1516752/15" remote="cros" total_fail_count="9"/><pending_commit branch="master" change_id="I554e194d064e4df76f7f95ca3356a5f9b7bb6374" commit="078a4b14a049727928d246cb9ae853e478c2228f" commit_message="vm_tools: make vm_tools protos a seperate build project This change makes vm_protos a seperate ebuild so that it can be used by multiple projects. They are now installed and used through pkg-config. BUG=b:128413415 TEST=FEATURES=test build-packages --board=sarien FEATURES=test build-packages --board=tatl Ran cicerone_container_listener_fuzzer test Cq-Depend: chromium:1516752 Change-Id: I554e194d064e4df76f7f95ca3356a5f9b7bb6374 Reviewed-on: https://chromium-review.googlesource.com/1515945 Tested-by: Trent Begin <tbegin@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> " fail_count="5" gerrit_number="1515945" owner_email="tbegin@chromium.org" pass_count="0" patch_number="16" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/45/1515945/16" remote="cros" total_fail_count="9"/><pending_commit branch="master" change_id="Ia2846026e91097a310e10efda8dac4cdf2227aca" commit="208c6478ef27e5809f5f39dbf0f16855e67e0e48" commit_message="Update .ebuild for migrating cros-camera-tool to gn. BUG=chromium:767517 TEST=emerge-amd64-generic cros-camera-tool Cq-Depend: chromium:1672661 Change-Id: Ia2846026e91097a310e10efda8dac4cdf2227aca Reviewed-on: https://chromium-review.googlesource.com/1673709 Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> " fail_count="1" gerrit_number="1673709" owner_email="yamaguchi@chromium.org" pass_count="0" patch_number="3" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/09/1673709/3" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I3ddaebe0d7fd635972a0152bcffd653cfa958539" commit="12971687b64e423de9dd078552ef46fd40d20eda" commit_message="camera: migrate cros-camera-tool to gn. BUG=chromium:767517 TEST=emerge-amd64-generic cros-camera-tool Cq-Depend: chromium:1673709 Change-Id: I3ddaebe0d7fd635972a0152bcffd653cfa958539 Reviewed-on: https://chromium-review.googlesource.com/1672661 Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> " fail_count="1" gerrit_number="1672661" owner_email="yamaguchi@chromium.org" pass_count="0" patch_number="4" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/61/1672661/4" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Ie99447ca8e581a9ecccb3d279cffe1b6498b48e1" commit="b11f99cbfcc14950f43a62437e7d9a2aa46c787b" commit_message="Update .build for migrating arc-camera-profile to gn. BUG=chromium:767517 TEST=emerge-amd64-generic cros-camera-tool Cq-Depend: chromium:1672662 Change-Id: Ie99447ca8e581a9ecccb3d279cffe1b6498b48e1 Reviewed-on: https://chromium-review.googlesource.com/1673710 Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> " fail_count="2" gerrit_number="1673710" owner_email="yamaguchi@chromium.org" pass_count="0" patch_number="2" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/10/1673710/2" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Ib099874ec44d6a0a25db0a22bbc0cb9094705d5e" commit="376ec3dc4d23c94e276875f0e6ac47aa1bc1de7d" commit_message="camera: migrate arc-camera-profile to gn. BUG=chromium:767517 TEST=emerge-amd64-generic arc-camera-profile Cq-Depend: chromium:1673710 Change-Id: Ib099874ec44d6a0a25db0a22bbc0cb9094705d5e Reviewed-on: https://chromium-review.googlesource.com/1672662 Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> " fail_count="2" gerrit_number="1672662" owner_email="yamaguchi@chromium.org" pass_count="0" patch_number="5" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/62/1672662/5" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Ibf515d00cc35f265a28fc96b9beb1c92e5339353" commit="ee9182f534a98adffbb6786f2be733d210dce1a0" commit_message="shill: ip_address: Use default copy constructor & assignment op BUG=None TEST=All unit tests are passing. Change-Id: Ibf515d00cc35f265a28fc96b9beb1c92e5339353 Reviewed-on: https://chromium-review.googlesource.com/1681038 Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> " fail_count="1" gerrit_number="1681038" owner_email="akhouderchah@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/38/1681038/2" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Iad549d452b335515909630117fb41394f3746d7f" commit="8cc6ae9396c9e0fe1455204f315cd50be5383d34" commit_message="shill: byte_string: Rm unnecessary copy/move ctrs and assignment/move ops BUG=None TEST=All unit tests are passing. Change-Id: Iad549d452b335515909630117fb41394f3746d7f Reviewed-on: https://chromium-review.googlesource.com/1681039 Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> " fail_count="1" gerrit_number="1681039" owner_email="akhouderchah@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/39/1681039/2" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.14" change_id="I2217d546cfba93f3b0796bac1584a11505aa2bfe" commit="1274a0f6be7421d64fcbd492c17798890ccbbc04" commit_message="Revert "CHROMIUM: config: Enable UFS provisioning for Qualcomm" This reverts commit 23b4a524fe10686c3481011b6779da68a2c9b5af. Conflicts occurred because of the big normalization savedefconfig normalization. The fixup is to accept neither choice, they should both be deleted after the revert. Conflicts: chromeos/config/arm64/chromiumos-arm64.flavour.config chromeos/config/arm64/chromiumos-qualcomm.flavour.config BUG=b:111557905 TEST=None Signed-off-by: Evan Green <evgreen@chromium.org> Change-Id: I2217d546cfba93f3b0796bac1584a11505aa2bfe Reviewed-on: https://chromium-review.googlesource.com/1680683 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> " fail_count="3" gerrit_number="1680683" owner_email="evgreen@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/83/1680683/1" remote="cros" total_fail_count="3"/><pending_commit branch="chromeos-4.14" change_id="Icd67ebc35c888acf699a4451a8db7a98ff8a48bc" commit="459f5ff8df1a249adbcb0be36de6553760df3e96" commit_message="Revert "FIXUP: FROMLIST: scsi: ufs: Add configfs support for UFS provisioning" This reverts commit 79858f63c35a75def7110462bdde4b40f150f46b. Revert "FROMLIST: scsi: ufs: Add configfs support for UFS provisioning" This reverts commit 7c634e7bcbf7e36db5957cdeadc8c2682230d6ae. This change reverts the above two commits and then squashes them together to avoid bisection issues. BUG=b:111557905 TEST=None Change-Id: Icd67ebc35c888acf699a4451a8db7a98ff8a48bc Signed-off-by: Evan Green <evgreen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1680684 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> " fail_count="3" gerrit_number="1680684" owner_email="evgreen@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/84/1680684/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Ib8383debb3a3c2c88de734b6b22a44dfea500ffa" commit="2fd29bf91e7725faa33322948bafc227fe12116f" commit_message="CRAS: Fix header for repo check Add "OS", remove (c) BUG=chromium:950858 TEST=Run repo check Change-Id: Ib8383debb3a3c2c88de734b6b22a44dfea500ffa Reviewed-on: https://chromium-review.googlesource.com/1669666 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1669666" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/66/1669666/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I822fc4a42913b55c78ea91155855f41e19a69014" commit="c9e213d7c954bc6d97cd24ee2a8ce772388e8d2a" commit_message="CRAS: Format cras_bt Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I822fc4a42913b55c78ea91155855f41e19a69014 Reviewed-on: https://chromium-review.googlesource.com/1670747 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1670747" owner_email="enshuo@google.com" pass_count="0" patch_number="2" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/47/1670747/2" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I72ee43d44e8b8c7dadf1aefb888cc3fbcb790534" commit="ad56574985535ff54cb7d9305381071b181d1e05" commit_message="CRAS: Remove (c) for cras_main_message BUG=chromium:950858 TEST=Repo hook Change-Id: I72ee43d44e8b8c7dadf1aefb888cc3fbcb790534 Reviewed-on: https://chromium-review.googlesource.com/1669339 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1669339" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/39/1669339/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I3509480830f75f6e2e168c69dc4b4824c27dbca9" commit="4154141116ce79748d5dd0c15ebc43b9fd18cf57" commit_message="CRAS: Format cras_main_message Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I3509480830f75f6e2e168c69dc4b4824c27dbca9 Reviewed-on: https://chromium-review.googlesource.com/1669340 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1669340" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/40/1669340/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I7b557b8501d9dbe3edc19a9b35d16b38f392286f" commit="287929d69cd8f3e4f30162b9c97955c49847cce7" commit_message="Update .ebuild for migrating libcamera_v4l2_device. BUG=chromium:767517 TEST=emerge-amd64-generic media-libs/cros-camera-libcamera_v4l2_device Cq-Depend: chromium:1673949 Change-Id: I7b557b8501d9dbe3edc19a9b35d16b38f392286f Reviewed-on: https://chromium-review.googlesource.com/1673716 Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Ready: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> " fail_count="3" gerrit_number="1673716" owner_email="yamaguchi@chromium.org" pass_count="0" patch_number="2" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/16/1673716/2" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="Ie4c6527f5644ddaaf9e09db97cf7b07b4e744d9f" commit="28bf8efdb0a42a1ddf268e9bf4107e840f2eda39" commit_message="camera: Migrate libcamera_v4l2_device to GN. BUG=chromium:767517 TEST=emerge-amd64-generic emerge-amd64-generic media-libs/cros-camera-libcamera_v4l2_device Cq-Depend: chromium:1673716 Change-Id: Ie4c6527f5644ddaaf9e09db97cf7b07b4e744d9f Reviewed-on: https://chromium-review.googlesource.com/1673949 Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Ready: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> " fail_count="3" gerrit_number="1673949" owner_email="yamaguchi@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/49/1673949/3" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I74f7fce3aaa3cfae10da2d826be92f674c407980" commit="d7372a5f59331fadaaa91f93095842900137debb" commit_message="biod: Change CrosFpFirmware to allow mocking We allow a CrosFpFirmware to remain in the default kUninitialized state if no file path is given in the constructor. This mimics the base::File behavior. This is needed because the mock class needs to be able to inject fake versions for a CrosFpFirmware, without presenting an actual firmware file. The issue with the current implementation is that it attempts to decode the firmware file in the single constructor. The functionality of a superclass constructor cannot be overridden (even with a virtual function). BUG=b:117182903 TEST=FEATURES=test emerge-nocturne biod TEST=FEATURES=test emerge-nami biod Change-Id: I74f7fce3aaa3cfae10da2d826be92f674c407980 Reviewed-on: https://chromium-review.googlesource.com/1636173 Tested-by: Craig Hesling <hesling@chromium.org> Commit-Ready: Craig Hesling <hesling@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org> " fail_count="2" gerrit_number="1636173" owner_email="hesling@chromium.org" pass_count="0" patch_number="12" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/73/1636173/12" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Id7a5fa8f23573e7f970cb6de0b15ba26e6eab59a" commit="bad03c2d50602864153f0391e8829ed43d372edd" commit_message="biod: Add unit tests for cros_fp_updater.cc BUG=b:117182903 TEST=FEATURES=test emerge-nocturne biod TEST=FEATURES=test emerge-nami biod TEST=code coverage LLVM_PROFILE_FILE="/tmp/default.profraw" USE=coverage FEATURES="test noclean" emerge-nocturne biod cd /build/nocturne/tmp/ llvm-profdata merge -o default.profdata default.profraw llvm-cov show -instr-profile=default.profdata -format=html -output-dir=. -object=/build/nocturne/tmp/portage/chromeos-base/biod-9999/work/build/out/Default/biod_test_runner Change-Id: Id7a5fa8f23573e7f970cb6de0b15ba26e6eab59a Reviewed-on: https://chromium-review.googlesource.com/1636174 Tested-by: Craig Hesling <hesling@chromium.org> Commit-Ready: Craig Hesling <hesling@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org> " fail_count="3" gerrit_number="1636174" owner_email="hesling@chromium.org" pass_count="0" patch_number="20" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/74/1636174/20" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I8a6b5ef855d53f68c8c197277a302e4db4ce1a9a" commit="7b508a3d1699c5d9c3335181201d52255cfaae77" commit_message="Port platform_ToolchainOptions to Tast Whitelists are from both autotest-private and public. Changes in the Tast version: - filepath.Walk is used instead of multiple find commands. - /debug/elf is used instead of the readelf command. - info from /debug/elf is used instead of the file command. Things which were not added to the Tast test: - Autotest allowed setting the rootdir to an alternate root. The test is faster, so it's not any better to run on a smaller set of files. - Autotest allowed passing in a hardfp option. This was not enabled by default and has not been running in the lab. That check has been skipped. - the Autotest has a check that has been commented out since 2014. It was not ported but is still tracked in crbug.com/417912. - the Autotest has a fixme bug (that was closed years ago) for an issue on i?86 architectures. Since alex/mario/zgb are deprecated, that differentiation is not ported. BUG=chromium:963332 TEST=compared found static/dynamic files from both the Autotest and Tast. Compared all non-whitelisted files for each check. Compared lists of found files for different properties (e.g. program headers, dyntags). Ran on nautilus, blaze, panther, kip, eve, pit, peppy. Cq-Depend: chromium:1652468 Change-Id: I8a6b5ef855d53f68c8c197277a302e4db4ce1a9a Reviewed-on: https://chromium-review.googlesource.com/1638849 Tested-by: Katherine Threlkeld <kathrelkeld@chromium.org> Commit-Ready: Katherine Threlkeld <kathrelkeld@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> " fail_count="9" gerrit_number="1638849" owner_email="kathrelkeld@chromium.org" pass_count="0" patch_number="8" project="chromiumos/platform/tast-tests" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast-tests" ref="refs/changes/49/1638849/8" remote="cros" total_fail_count="9"/><pending_commit branch="master" change_id="Ia037643ad781942a17fe289d35ed447d8aa8935c" commit="034daedbc6a5263e07a2c6ce6e76fcbdaf9a2bf4" commit_message="tast: Add no_asan dependency Needed to skip images built with Address Sanitizer for the port of platform_ToolchainOptions, which skips them at runtime in the Autotest version. This dependency is functionally the same as "aslr", but defining it separately will prevent future failures due to ASLR related changes. TEST=applied to a new test and ran it BUG=chromium:963332 Cq-Depend: chromium:1638849 Change-Id: Ia037643ad781942a17fe289d35ed447d8aa8935c Reviewed-on: https://chromium-review.googlesource.com/1652468 Tested-by: Katherine Threlkeld <kathrelkeld@chromium.org> Commit-Ready: Katherine Threlkeld <kathrelkeld@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> " fail_count="9" gerrit_number="1652468" owner_email="kathrelkeld@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform/tast" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast" ref="refs/changes/68/1652468/3" remote="cros" total_fail_count="9"/><pending_commit branch="master" change_id="Ifedd3ca4e53d8c72910341d52477960e7b410d98" commit="a713b84f7470aaf11adef8d040d60c89354a9437" commit_message="CHROMIUM: Intel BT 7265: Fix LE ping and Overlapping channel map issue This is firmware patch for Intel Bluetooth 7265 (StP D1) StP D1 FW Patch Version: 0x3E(62) This patch contains the following fixes on previous 0x3D(61): - Exception Improvements(AddIRQsafe for the delay to write to mail boxandmake sure in case of IRQ switch delaymustbeaccounted) - Porting of LE ping fixes fromThP/JfP - Optimized patches to accommodate LE ping patches BUG=b:130226649, b:130232056 TEST=the last bytes output by the command "hcitool cmd 3f 05" change: - ......... 50 19 14 0F 3D + ......... 50 19 14 0F 3E TEST=Basic BR/EDR and LE profile level sanity tests are passed Change-Id: Ifedd3ca4e53d8c72910341d52477960e7b410d98 Signed-off-by: Amit K Bag <amit.k.bag@intel.com> Reviewed-on: https://chromium-review.googlesource.com/1640760 Tested-by: Yoni Shavit <yshavit@chromium.org> Commit-Ready: Yoni Shavit <yshavit@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yoni Shavit <yshavit@chromium.org> Reviewed-by: Chethan Tumkur Narayan <chethan.tumkur.narayan@intel.corp-partner.google.com> " fail_count="0" gerrit_number="1640760" owner_email="amit.k.bag@intel.com" pass_count="0" patch_number="4" project="chromiumos/third_party/linux-firmware" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/linux-firmware" ref="refs/changes/60/1640760/4" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I4bda68acc559c56fcc99a8c93845e77cc9614670" commit="71cbef7948b0cb988525ccb6e66f6b85188ab5b2" commit_message="tast: Add test for Japanese input on virtual keyboard. We would like to have sanity checks for all supported languages on Chrome OS. We'll start with Japanese, which has two different input methods. The test just loops through the two input methods and checks whether the right suggestions show up when tapping certain keys. We'll be adding additional languages in the future. BUG=chromium:879073 TEST=veyron_minnie Change-Id: I4bda68acc559c56fcc99a8c93845e77cc9614670 Reviewed-on: https://chromium-review.googlesource.com/1645192 Tested-by: Darren Shen <shend@chromium.org> Commit-Ready: Darren Shen <shend@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> " fail_count="0" gerrit_number="1645192" owner_email="shend@chromium.org" pass_count="0" patch_number="5" project="chromiumos/platform/tast-tests" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast-tests" ref="refs/changes/92/1645192/5" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I72153a3bdae1b7f804c886b834603931ca9f2832" commit="f9e53880e60f7ddec72480a79cbecc9a093e840e" commit_message="tast-tests: vm: Factor CrostiniStartEverything into a precondition Historically we dropped all the tests in CrostiniStartEverything as a way of avoiding the expensive setup cost. Tast now has a feature for that (preconditions) so this change makes CrostiniStartEverything use that. We model the implementation on arc/pre.go. There are several outstanding items, notably breaking up the test into its subtests. BUG=chromium:965398 TEST=tast -verbose run $DUT "vm.CrostiniStartEverything" Change-Id: I72153a3bdae1b7f804c886b834603931ca9f2832 Reviewed-on: https://chromium-review.googlesource.com/1677824 Tested-by: Nic Hollingum <hollingum@google.com> Commit-Ready: Nic Hollingum <hollingum@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Po-Hsien Wang <pwang@chromium.org> " fail_count="0" gerrit_number="1677824" owner_email="hollingum@google.com" pass_count="0" patch_number="6" project="chromiumos/platform/tast-tests" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast-tests" ref="refs/changes/24/1677824/6" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Ia1d0468911530778fd29a7a8e2572f94e2e28882" commit="b1fde51a83a6a608f60a263765a2cfa6bc18a0d5" commit_message="ml: Add TFLite version table to docs This is important as we are now starting to tackle version skew issues. BUG=none TEST=looked at preview Change-Id: Ia1d0468911530778fd29a7a8e2572f94e2e28882 Reviewed-on: https://chromium-review.googlesource.com/1684616 Tested-by: Andrew Moylan <amoylan@chromium.org> Commit-Ready: Andrew Moylan <amoylan@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> " fail_count="0" gerrit_number="1684616" owner_email="amoylan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/16/1684616/3" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I10b53d23bcf6bb3fcc90a6b2a198fa41950ab453" commit="11bb72b043579f62e08b4d21e03f4f77626daea6" commit_message="vm_tools: Factor out termina_vm USB support code and use it in arc_vm This moves the USB support code in termina to vm_util and invokes it from termina and arc_vm. Note that USB support in arcvm currently depends on enabling xhci in the Android guest kernel (crrev.com/c/1680155) and enabling sandboxing (crrev.com/c/1662753). BUG=b:123374026 TEST=Invoke AttachUsbDevice() and verify that lsusb lists the attached device within Android TEST=crosvm usb list shows attached device Change-Id: I10b53d23bcf6bb3fcc90a6b2a198fa41950ab453 Reviewed-on: https://chromium-review.googlesource.com/1680382 Tested-by: Philippe Liard <pliard@google.com> Commit-Ready: Philippe Liard <pliard@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> " fail_count="2" gerrit_number="1680382" owner_email="pliard@google.com" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/82/1680382/3" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I451989a5d26da06ef650ffdb689f88108dba800b" commit="c2caaeaa8a8b02b3a12860b98dc465d20330a990" commit_message="autotest: runner - collect_last_summary - Remove summary file if exists To avoid commad execution error while removing summary file, added a check for file presence. Error: [stderr] rm: missing operand 22:07:28 INFO | autoserv| [stderr] Try 'rm --help' for more information. 22:07:28 INFO | autoserv| Non-critical failure: Failed to delete the latest directory summary: 22:07:28 INFO | autoserv| Traceback (most recent call last): BUG=None TEST=Ran on DUT locally Change-Id: I451989a5d26da06ef650ffdb689f88108dba800b Reviewed-on: https://chromium-review.googlesource.com/1685453 Tested-by: Kasaiah Bogineni <kasaiah.bogineni@intel.com> Commit-Ready: Kasaiah Bogineni <kasaiah.bogineni@intel.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> " fail_count="1" gerrit_number="1685453" owner_email="kasaiah.bogineni@intel.com" pass_count="0" patch_number="2" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/53/1685453/2" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I7b9ea7da2cf0bea21bf0acb3b22035f2fbb7a103" commit="74f9dd8cfd82d981b00c4aa600f75264e2925045" commit_message="bluetooth : change label to bt_peer Change label for testing using tester host to bt_peer instead of bt_hid since these test do not use RN-42 BUG=None TEST=Tested locally Change-Id: I7b9ea7da2cf0bea21bf0acb3b22035f2fbb7a103 Reviewed-on: https://chromium-review.googlesource.com/1677404 Tested-by: Shijin Abraham <shijinabraham@google.com> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yun-Hao Chung <howardchung@google.com> " fail_count="1" gerrit_number="1677404" owner_email="shijinabraham@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/04/1677404/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Ia72192aec0f0123a8bd1f4740f706af60bd3cf60" commit="4b890399e21df590deb9fb9972354d79abe91e20" commit_message="atrusctl: Add OWNERS BUG=b:132724115 TEST=None Change-Id: Ia72192aec0f0123a8bd1f4740f706af60bd3cf60 Reviewed-on: https://chromium-review.googlesource.com/1680803 Tested-by: Kyle Williams <kdgwill@chromium.org> Tested-by: Matthew Ziegelbaum <ziegs@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Kyle Williams <kdgwill@chromium.org> Reviewed-by: Matthew Ziegelbaum <ziegs@chromium.org> " fail_count="1" gerrit_number="1680803" owner_email="kdgwill@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/atrusctl" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/atrusctl" ref="refs/changes/03/1680803/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I4d7ed943d5e7dfd7c3ca33c47cd05c4c50e2208c" commit="524b6376cfba432fa757da82c1d1e665b6518c3c" commit_message="aver-updater:Update OWNERS file BUG=b:132724115 TEST=None Change-Id: I4d7ed943d5e7dfd7c3ca33c47cd05c4c50e2208c Reviewed-on: https://chromium-review.googlesource.com/1681059 Tested-by: Kyle Williams <kdgwill@chromium.org> Tested-by: Matthew Ziegelbaum <ziegs@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Kyle Williams <kdgwill@chromium.org> Reviewed-by: Matthew Ziegelbaum <ziegs@chromium.org> " fail_count="1" gerrit_number="1681059" owner_email="kdgwill@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/aver-updater" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/aver-updater" ref="refs/changes/59/1681059/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I6b864dd2a41320c044df9100a6a882e1ab56b47a" commit="215fda0ceee22f8bb944a675f8de7ca1b72447b2" commit_message="logitech-updater:Update OWNERS file BUG=b:132724115 TEST=None Change-Id: I6b864dd2a41320c044df9100a6a882e1ab56b47a Reviewed-on: https://chromium-review.googlesource.com/1681060 Tested-by: Kyle Williams <kdgwill@chromium.org> Tested-by: Matthew Ziegelbaum <ziegs@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Kyle Williams <kdgwill@chromium.org> Reviewed-by: Matthew Ziegelbaum <ziegs@chromium.org> " fail_count="1" gerrit_number="1681060" owner_email="kdgwill@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/logitech-updater" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/logitech-updater" ref="refs/changes/60/1681060/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I348372e0c02eaa1dc75dea6223028f98fb6bbd3a" commit="c27ca28f7f4305b8e88a9419c25eda805ab45966" commit_message="mimo-updater:Update OWNERS file BUG=b:132724115 TEST=None Change-Id: I348372e0c02eaa1dc75dea6223028f98fb6bbd3a Reviewed-on: https://chromium-review.googlesource.com/1681061 Tested-by: Kyle Williams <kdgwill@chromium.org> Tested-by: Matthew Ziegelbaum <ziegs@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Kyle Williams <kdgwill@chromium.org> Reviewed-by: Matthew Ziegelbaum <ziegs@chromium.org> " fail_count="1" gerrit_number="1681061" owner_email="kdgwill@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/mimo-updater" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/mimo-updater" ref="refs/changes/61/1681061/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Ifda2489da1dda80e29d1d6c9c40c7a33a90b9499" commit="a4c8ae1eb1f9ca0f5c266dc19be6ce25377ed676" commit_message="sis-updater:Update OWNERS file BUG=b:132724115 TEST=None Change-Id: Ifda2489da1dda80e29d1d6c9c40c7a33a90b9499 Reviewed-on: https://chromium-review.googlesource.com/1681062 Tested-by: Kyle Williams <kdgwill@chromium.org> Tested-by: Matthew Ziegelbaum <ziegs@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Kyle Williams <kdgwill@chromium.org> Reviewed-by: Matthew Ziegelbaum <ziegs@chromium.org> " fail_count="1" gerrit_number="1681062" owner_email="kdgwill@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/sis-updater" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/sis-updater" ref="refs/changes/62/1681062/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I414252ad68e9075d389b045a722d2ceef318ba9c" commit="7e605ca1c36d4afe993368254b875b214d151563" commit_message="bluetooth : Add test for PairableTimeout Add test for PairableTimeout in bluetooth_AdapterSASanity. Refactor common code out of the test for DiscoverableTimeout BUG=b:136125778 TEST=Tested locally Change-Id: I414252ad68e9075d389b045a722d2ceef318ba9c Reviewed-on: https://chromium-review.googlesource.com/1682590 Tested-by: Shijin Abraham <shijinabraham@google.com> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yun-Hao Chung <howardchung@google.com> " fail_count="1" gerrit_number="1682590" owner_email="shijinabraham@google.com" pass_count="0" patch_number="6" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/90/1682590/6" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ic45176e612e6c75bded5e73e4ef6485d462559d9" commit="ca6e246e043489a6449a4fa3d0ddca1a80647256" commit_message="UPSTREAM: ASoC: Intel: Skylake: Fix to delete DSP pipe after stopping pipe DSP pipe needs to stopped before deleting the pipe. Currently check is for pipe state > STARTED, which is incorrect. So changed to include pipe state STARTED to stop the pipe if it started. Signed-off-by: Jeeja KP <jeeja.kp@intel.com> Acked-by: Vinod Koul <vinod.koul@intel.com> Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 6914968b8203aef72edf936319c4d46c6d46401b) BUG=b:128869071 TEST= Switch between Headset and Speaker from UI when video is running on Youtube and Appr.tc is active Change-Id: Ic45176e612e6c75bded5e73e4ef6485d462559d9 Signed-off-by: Vani Ganji <vani.ganji@intel.corp-partner.google.com> Signed-off-by: Curtis Malainey <cujomalainey@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1681459 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> Reviewed-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> " fail_count="2" gerrit_number="1681459" owner_email="vani.ganji@intel.corp-partner.google.com" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/59/1681459/2" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="If907669328fcebcc4d29894ac14626c82637fa46" commit="57d69005e7fa042e91bd743b494ca2e7c69a47eb" commit_message="g2f_tools: Add dependency on metrics for UMA Required since crrev.com/c/1628507 BUG=chromium:976463 TEST=build Change-Id: If907669328fcebcc4d29894ac14626c82637fa46 Reviewed-on: https://chromium-review.googlesource.com/1679814 Tested-by: Louis Collard <louiscollard@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> Reviewed-by: Wei-Cheng Xiao <garryxiao@chromium.org> " fail_count="5" gerrit_number="1679814" owner_email="louiscollard@chromium.org" pass_count="0" patch_number="2" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/14/1679814/2" remote="cros" total_fail_count="5"/><pending_commit branch="chromeos-3.18" change_id="I73d11264c048b33c167ae9acf89823632e4f070e" commit="a6aaf6f889519756d32184f51fbe9328ca8bc533" commit_message="UPSTREAM: audit: use supplied gfp_mask from audit_buffer in kauditd_send_multicast_skb Eric Paris explains: Since kauditd_send_multicast_skb() gets called in audit_log_end(), which can come from any context (aka even a sleeping context) GFP_KERNEL can't be used. Since the audit_buffer knows what context it should use, pass that down and use that. See: https://lkml.org/lkml/2014/12/16/542 BUG: sleeping function called from invalid context at mm/slab.c:2849 in_atomic(): 1, irqs_disabled(): 0, pid: 885, name: sulogin 2 locks held by sulogin/885: #0: (&sig->cred_guard_mutex){+.+.+.}, at: [<ffffffff91152e30>] prepare_bprm_creds+0x28/0x8b #1: (tty_files_lock){+.+.+.}, at: [<ffffffff9123e787>] selinux_bprm_committing_creds+0x55/0x22b CPU: 1 PID: 885 Comm: sulogin Not tainted 3.18.0-next-20141216 #30 Hardware name: Dell Inc. Latitude E6530/07Y85M, BIOS A15 06/20/2014 ffff880223744f10 ffff88022410f9b8 ffffffff916ba529 0000000000000375 ffff880223744f10 ffff88022410f9e8 ffffffff91063185 0000000000000006 0000000000000000 0000000000000000 0000000000000000 ffff88022410fa38 Call Trace: [<ffffffff916ba529>] dump_stack+0x50/0xa8 [<ffffffff91063185>] ___might_sleep+0x1b6/0x1be [<ffffffff910632a6>] __might_sleep+0x119/0x128 [<ffffffff91140720>] cache_alloc_debugcheck_before.isra.45+0x1d/0x1f [<ffffffff91141d81>] kmem_cache_alloc+0x43/0x1c9 [<ffffffff914e148d>] __alloc_skb+0x42/0x1a3 [<ffffffff914e2b62>] skb_copy+0x3e/0xa3 [<ffffffff910c263e>] audit_log_end+0x83/0x100 [<ffffffff9123b8d3>] ? avc_audit_pre_callback+0x103/0x103 [<ffffffff91252a73>] common_lsm_audit+0x441/0x450 [<ffffffff9123c163>] slow_avc_audit+0x63/0x67 [<ffffffff9123c42c>] avc_has_perm+0xca/0xe3 [<ffffffff9123dc2d>] inode_has_perm+0x5a/0x65 [<ffffffff9123e7ca>] selinux_bprm_committing_creds+0x98/0x22b [<ffffffff91239e64>] security_bprm_committing_creds+0xe/0x10 [<ffffffff911515e6>] install_exec_creds+0xe/0x79 [<ffffffff911974cf>] load_elf_binary+0xe36/0x10d7 [<ffffffff9115198e>] search_binary_handler+0x81/0x18c [<ffffffff91153376>] do_execveat_common.isra.31+0x4e3/0x7b7 [<ffffffff91153669>] do_execve+0x1f/0x21 [<ffffffff91153967>] SyS_execve+0x25/0x29 [<ffffffff916c61a9>] stub_execve+0x69/0xa0 Cc: stable@vger.kernel.org #v3.16-rc1 Reported-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu> Signed-off-by: Richard Guy Briggs <rgb@redhat.com> Tested-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu> Signed-off-by: Paul Moore <pmoore@redhat.com> (cherry picked from commit 54dc77d974a50147d6639dac6f59cb2c29207161) BUG=chromium:979179 TEST=cheets_AntutuTest Change-Id: I73d11264c048b33c167ae9acf89823632e4f070e Signed-off-by: Chinglin Yu <chinglinyu@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1681744 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> " fail_count="2" gerrit_number="1681744" owner_email="chinglinyu@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/44/1681744/2" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Ieb5fa0c99ddb308f500dde95a23a1aa5b0bd3a77" commit="ee8b66f0dd5d46bfe20268b644abfee774ca8ca7" commit_message="autotest: Add tests for running blktests Add tests to run blktests on a loopback over a file, a loopback over a block device, a block device, and a test that runs blktests on all three. When running on a real block device, exclude test block/013. It is expected to fail when run on a block device partition instead of a full block device. BUG=chromium:938096 TEST=Ran the four blktestsSuite tests on a fizz with kernel v4.19. Change-Id: Ieb5fa0c99ddb308f500dde95a23a1aa5b0bd3a77 Reviewed-on: https://chromium-review.googlesource.com/1592646 Tested-by: Alexis Savery <asavery@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@chromium.org> " fail_count="3" gerrit_number="1592646" owner_email="asavery@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/46/1592646/3" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I2828af5a25d43f907909e370caf4b6c18586aabf" commit="5e64631e39957c8c4bdfefe2299dab79867331c6" commit_message="autotest-tests: Add blktests to test image. BUG=chromium:938096 TEST=Check blktests is installed on the test image. Tested on eve and fizz. Change-Id: I2828af5a25d43f907909e370caf4b6c18586aabf Reviewed-on: https://chromium-review.googlesource.com/1593674 Tested-by: Alexis Savery <asavery@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@chromium.org> " fail_count="3" gerrit_number="1593674" owner_email="asavery@chromium.org" pass_count="0" patch_number="3" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/74/1593674/3" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I0358152a80062a94c3e46642b80d05a6b780252a" commit="02958d04035184898ae1b7a5fd8d0ed5b7b2fb58" commit_message="dev-rust/protoc-rust: relax tempfile version This will allow us to replace tempfile with a cros_workon ebuild (which will no longer have a 3.* version number). BUG=chromium:974059 TEST=emerge-nami dev-rust/protoc-rust Change-Id: I0358152a80062a94c3e46642b80d05a6b780252a Signed-off-by: Daniel Verkamp <dverkamp@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1658666 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> " fail_count="3" gerrit_number="1658666" owner_email="dverkamp@chromium.org" pass_count="0" patch_number="1" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/66/1658666/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I8f3b0252b0228540305ba31b48e9314586f23af4" commit="06092830ad0199384537937905f22a72cf31b748" commit_message="chromeos-config: handle case of model name equals to wl_sig_id. Normally, in whitelabel project the key-id will not equal to model name because key-id is based on LOEM's name. But in case of leveraging existed model to the new one with only marketing name change, whitelabel_tag is used. As a result, we have the chance of key-id equal to model name. The solution here is to filter this situation and not mark this firmware info of config to have_image=False. BUG=b:127342204 TEST=`pack_firmware.py` and verify the result of Octopus. Change-Id: I8f3b0252b0228540305ba31b48e9314586f23af4 Reviewed-on: https://chromium-review.googlesource.com/1675635 Tested-by: Marco Chen <marcochen@chromium.org> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> " fail_count="1" gerrit_number="1675635" owner_email="marcochen@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/35/1675635/3" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I54aedf11b45a41d08f029680ab0499ad91fe9ad8" commit="f1fa88397711740d9e9fdb194735570c6dc4638b" commit_message="CRAS: Format cras_server Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I54aedf11b45a41d08f029680ab0499ad91fe9ad8 Reviewed-on: https://chromium-review.googlesource.com/1670833 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="2" gerrit_number="1670833" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/33/1670833/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I0116311ae8abffa1fe14c3f9a8eba69122bad4b3" commit="0de9843496340c68f89d1513ba98a3b223bcbb23" commit_message="CRAS: Format dev_io Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I0116311ae8abffa1fe14c3f9a8eba69122bad4b3 Reviewed-on: https://chromium-review.googlesource.com/1669336 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="1" gerrit_number="1669336" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/36/1669336/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Id255734da2d0bdeb48bf597fd6d63fbe6f8c3fbe" commit="61f0242700e29628870ab6127092684c69d3756b" commit_message="CRAS: Format cras_tm Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: Id255734da2d0bdeb48bf597fd6d63fbe6f8c3fbe Reviewed-on: https://chromium-review.googlesource.com/1669342 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1669342" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/42/1669342/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I33ee15d5d1b7245fc17dbb2a84cf7da513d4a3b5" commit="8b6f1ec462aa332ed5bbbb62a10632510599a666" commit_message="CRAS: Format cras_gpio_jack Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I33ee15d5d1b7245fc17dbb2a84cf7da513d4a3b5 Reviewed-on: https://chromium-review.googlesource.com/1669345 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1669345" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/45/1669345/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I019c1faebf4eb618f58942bbd9b2cee84a207305" commit="95073f17f1c128b5bf127810b813d08dd288ea0f" commit_message="CRAS: Format a2dp Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adh Change-Id: I019c1faebf4eb618f58942bbd9b2cee84a207305 Reviewed-on: https://chromium-review.googlesource.com/1640877 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="4" gerrit_number="1640877" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/77/1640877/1" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="Iecb1310a08d9e36fb8a6344e4ee982977373d858" commit="f9405653b0fbad4adf732910d506bd4d00f82ea7" commit_message="CRAS: Format cras_telephony Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: Iecb1310a08d9e36fb8a6344e4ee982977373d858 Reviewed-on: https://chromium-review.googlesource.com/1669344 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="1" gerrit_number="1669344" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/44/1669344/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Id214a7cf38db74f457ffbf427bf6abbc555c5b29" commit="b06efc77f1a7d68e9d6b88d261e5e9bbebd844d0" commit_message="CRAS: Format cras_system_state Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: Id214a7cf38db74f457ffbf427bf6abbc555c5b29 Reviewed-on: https://chromium-review.googlesource.com/1669346 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="2" gerrit_number="1669346" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/46/1669346/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Iffc701690a341433ff3db8138de99c714460d28f" commit="4e2bbf8263f42fde3677ab4813327a168d74e06a" commit_message="CRAS: Format cras_alsa_mixer Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: Iffc701690a341433ff3db8138de99c714460d28f Reviewed-on: https://chromium-review.googlesource.com/1670836 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1670836" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/36/1670836/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I9786152917710512a4336c70c74a6cdef1d8b09e" commit="397f44fe26e4f7889730725d2a06a3af90ac8a6e" commit_message="CRAS: Format cras_alsa_card Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I9786152917710512a4336c70c74a6cdef1d8b09e Reviewed-on: https://chromium-review.googlesource.com/1670838 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1670838" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/38/1670838/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I2d59732a22b3b9276ffe29fb47742fe504b63fd4" commit="f62dea277634c6e452451bf1effc2e3702ef9f59" commit_message="CRAS: Format float_buffer Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I2d59732a22b3b9276ffe29fb47742fe504b63fd4 Reviewed-on: https://chromium-review.googlesource.com/1669341 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1669341" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/41/1669341/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I6a25ca2c85a3875e8d6f0b9be124e3b16c9e74a4" commit="9032c53b934c67631511d5550e717a458bc75675" commit_message="CRAS: Format test_iodev Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I6a25ca2c85a3875e8d6f0b9be124e3b16c9e74a4 Reviewed-on: https://chromium-review.googlesource.com/1670830 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1670830" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/30/1670830/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I9f31e0079136d06b8574d82fd9da7602907d69fa" commit="4df71c4ade72c0f94003f8fe5e82b91ffb4d7797" commit_message="CRAS: Format cras_utf8 Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I9f31e0079136d06b8574d82fd9da7602907d69fa Reviewed-on: https://chromium-review.googlesource.com/1670829 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1670829" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/29/1670829/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I41d4ccd03042098966aad6a778fbfa5202155225" commit="db0cd25ba1847a9e0ba98f203679c579a12b2dc0" commit_message="CRAS: Format cras_alsa_helper Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] Add () for the 3 of CH_TO_CRAS(ch) and CH_TO_ALSA, otherwise, clang-format will regard ((ch) - 3) as type casting and format it to (ch)-3. BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I41d4ccd03042098966aad6a778fbfa5202155225 Reviewed-on: https://chromium-review.googlesource.com/1670837 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="2" gerrit_number="1670837" owner_email="enshuo@google.com" pass_count="0" patch_number="2" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/37/1670837/2" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Ia752feda44482949044fb662fc873505e2cc991f" commit="a16c1fa103eed7d0958ea8a6c6b0692f471b4c9c" commit_message="CRAS: Format cras_loopback_iodev Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: Ia752feda44482949044fb662fc873505e2cc991f Reviewed-on: https://chromium-review.googlesource.com/1669413 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1669413" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/13/1669413/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="If4e36df9c6d390dff78214c7ac78fea7b9f59975" commit="ba592c84a397de937ed89a2a244cba157f01b85b" commit_message="CRAS: Format cras_udev Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: If4e36df9c6d390dff78214c7ac78fea7b9f59975 Reviewed-on: https://chromium-review.googlesource.com/1670827 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1670827" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/27/1670827/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Ia86f2816736b2097b7acc2d5cbe55470a6eca1cd" commit="052cc2d431fda819c26a94869759f3e3dcecf19d" commit_message="CRAS: Format cras_alsa_io Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: Ia86f2816736b2097b7acc2d5cbe55470a6eca1cd Reviewed-on: https://chromium-review.googlesource.com/1669415 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1669415" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/15/1669415/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I3a9a6062fef3d84533029d64a133a6cfc5520482" commit="39003cdf37bbf0494a1da94dc0a51727bb8057a5" commit_message="CRAS: Format cras_observer Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: I3a9a6062fef3d84533029d64a133a6cfc5520482 Reviewed-on: https://chromium-review.googlesource.com/1670831 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="3" gerrit_number="1670831" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/31/1670831/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="If9c6174516cdcdcccf323466b31ed92aa853f31c" commit="81c9c1c5bb01b20c8272b85818ece4c659e9dc0b" commit_message="CRAS: Format cras_alsa_ucm Reformat codes with the .clang-format we just introduced. To format whole files provided in-place: clang-format -i -style=file [<file> ...] BUG=chromium:950858 TEST=Add directory to check_format_error and run FEATURES="test" USE=asan emerge-${BOARD} -v media-sound/adhd Change-Id: If9c6174516cdcdcccf323466b31ed92aa853f31c Reviewed-on: https://chromium-review.googlesource.com/1670835 Tested-by: En-Shuo Hsu <enshuo@google.com> Commit-Ready: En-Shuo Hsu <enshuo@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> " fail_count="1" gerrit_number="1670835" owner_email="enshuo@google.com" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/35/1670835/1" remote="cros" total_fail_count="1"/><pending_commit branch="chromeos-4.4" change_id="Ie28f9c6ca0258e1ee78dea435118a091c8de11d7" commit="fddf06f53498bea023fdfd737a3c465f522ca537" commit_message="FROMLIST: ASoC: Intel: boards: add dmic format constraint platform dmic recording fixup 16bits Signed-off-by: Mac Chiang <mac.chiang@intel.com> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> (am from https://patchwork.kernel.org/patch/11001117/) (also found at https://lkml.kernel.org/r/1560836926-27055-1-git-send-email-mac.chiang@intel.com) BUG=b:128955894 TEST=verified by #alsa_conformance_test -C hw:0,3 --dev_info_only available formats: S16_LE Change-Id: Ie28f9c6ca0258e1ee78dea435118a091c8de11d7 Signed-off-by: Mac Chiang <mac.chiang@intel.com> Reviewed-on: https://chromium-review.googlesource.com/1617381 Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Commit-Ready: Jeremy Lin <jeremy.p.lin@intel.corp-partner.google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> " fail_count="3" gerrit_number="1617381" owner_email="mac.chiang@intel.com" pass_count="0" patch_number="3" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/81/1617381/3" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I45694e56cf01b5297d327a502621d08923e6d7d4" commit="0d2f4dabbe026688c91e410f1946b923a281241a" commit_message="init: use commit for only ext4 stateful partitions "commit=" is a fs-specific mount option that is only used in ext4, ocfs and btrfs. Till now, we only use a ext4 stateful partition, so keep the commit option guarded under ext4 check. BUG=none TEST=boot with an f2fs stateful partition. Change-Id: I45694e56cf01b5297d327a502621d08923e6d7d4 Reviewed-on: https://chromium-review.googlesource.com/1685977 Tested-by: Sarthak Kukreti <sarthakkukreti@chromium.org> Commit-Ready: Sarthak Kukreti <sarthakkukreti@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> " fail_count="0" gerrit_number="1685977" owner_email="sarthakkukreti@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/77/1685977/1" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I64f69377ec22cb1939d4856ea05ab55c3d1c7891" commit="a2c9bfde574ade9afff890a5648d2ca45aa577eb" commit_message="drallion: Add disk_layout.json Add a copy of sarien's disk_layout.json to drallion so that build_image works when the private overlay is added. BUG=b:136032010 TEST=./build_packages --board drallion && \ ./build_image --board drallion With private overlays Change-Id: I64f69377ec22cb1939d4856ea05ab55c3d1c7891 Reviewed-on: https://chromium-review.googlesource.com/1686336 Tested-by: Mathew King <mathewk@chromium.org> Commit-Ready: Mathew King <mathewk@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Mathew King <mathewk@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> " fail_count="0" gerrit_number="1686336" owner_email="mathewk@chromium.org" pass_count="0" patch_number="2" project="chromiumos/overlays/board-overlays" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/board-overlays" ref="refs/changes/36/1686336/2" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I5d805899f738ab3c545f1f35542b72667f32a7f4" commit="9562dacaf6c2d938671e2c50da32ab1e28a7bc6d" commit_message="add --no-confirmation flag to atest host rename I manually tested this change on one DUT prior to submitting it. BUG=chromium:976324 TEST=None Change-Id: I5d805899f738ab3c545f1f35542b72667f32a7f4 Reviewed-on: https://chromium-review.googlesource.com/1685878 Tested-by: Gregory Nisbet <gregorynisbet@google.com> Commit-Ready: Gregory Nisbet <gregorynisbet@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Gregory Nisbet <gregorynisbet@google.com> " fail_count="0" gerrit_number="1685878" owner_email="gregorynisbet@google.com" pass_count="0" patch_number="2" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/78/1685878/2" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I06a3e8539d913354f8eab091583021d896532b2b" commit="b686b4e30fdbdf825262102106186e917c37d7eb" commit_message="CRAS: cras_iodev - Return how many frames have been read We should return frames in cras_iodev_put_input_buffer function so that capture_to_streams can use it correctly. In the current version, total_read is always zero. Therefore, the loop in capture_to_streams does not work. It causes the audio thread will wake up immediately next time to read frames again from devices. With this change, the autio thread can read all frames it needs in the one wake up period. It can reduce lots of unnecessary operations. BUG=None TEST=Audio thread read samples correctly on panther. Change-Id: I06a3e8539d913354f8eab091583021d896532b2b Reviewed-on: https://chromium-review.googlesource.com/1683552 Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Commit-Ready: Yu-Hsuan Hsu <yuhsuan@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org> " fail_count="1" gerrit_number="1683552" owner_email="yuhsuan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/52/1683552/3" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="If7214d892375a73d0a8a2b90a699182773d35e7a" commit="bb79abf1494a0889d268cad7ac9d990590b17811" commit_message="permission_broker: drop USE=containers support We've deleted the code from the source, so drop the ebuild side. BUG=chromium:976916 TEST=cq passes Cq-Depend: chromium:1672408 Change-Id: If7214d892375a73d0a8a2b90a699182773d35e7a Reviewed-on: https://chromium-review.googlesource.com/1672230 Tested-by: Mike Frysinger <vapier@chromium.org> Commit-Ready: Mike Frysinger <vapier@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> " fail_count="3" gerrit_number="1672230" owner_email="vapier@chromium.org" pass_count="0" patch_number="2" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/30/1672230/2" remote="cros" total_fail_count="6"/><pending_commit branch="master" change_id="Iaed964182a089dcbf974196c5cdb083a2c554537" commit="a396def3c1f1a4c639ab9bc386ba9d41077714dc" commit_message="tast: Make build fail if cgo is enabled. This change adds cgo.go which is built only when cgo is enabled and gives a compilation error, which should prevent Tast binaries to be built with cgo enabled. cgo.go is placed in the testing package because it is linked in every Tast binary. BUG=chromium:976196 TEST=fast_build.sh -T TEST=fast_build.sh TEST=fast_build.sh && ~/go/bin/tast run -build=true DUT example.pass TEST=sudo emerge --nodeps chromeos-base/tast-cmd TEST=emerge-betty --nodeps chromeos-base/tast-local-tests-cros TEST=fast_build.sh # without CGO_ENABLED=0 build fails Cq-Depend: chromium:1663976 Cq-Depend: chromium:1664194 Change-Id: Iaed964182a089dcbf974196c5cdb083a2c554537 Reviewed-on: https://chromium-review.googlesource.com/1683693 Tested-by: Shuhei Takahashi <nya@chromium.org> Commit-Ready: Shuhei Takahashi <nya@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> " fail_count="6" gerrit_number="1683693" owner_email="nya@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform/tast" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast" ref="refs/changes/93/1683693/2" remote="cros" total_fail_count="6"/><pending_commit branch="master" change_id="Ib777eb8f490d8649b1d58b0ebc5ac3365a8f63c5" commit="6123afb416d04241937e47bcfa6525747877b51c" commit_message="app-emulation/lxd: Patch ContainerTarWriter into lxd overlay BUG=chromium:972835 Change-Id: Ib777eb8f490d8649b1d58b0ebc5ac3365a8f63c5 Reviewed-on: https://chromium-review.googlesource.com/1679797 Tested-by: Julian Watson <juwa@google.com> Commit-Ready: Julian Watson <juwa@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> " fail_count="3" gerrit_number="1679797" owner_email="juwa@google.com" pass_count="0" patch_number="4" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/97/1679797/4" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I28b58b7aa0b6c336439b5165fda8954ab52402e8" commit="70b525f0f6d37274d71484e29e47fdfeb65ee3f7" commit_message="vm_tools: plumb through ExportLxdContainerStatus Streaming parameters BUG=chromium:972835 Cq-Depend: chromium:1679821,chromium:1679822 Change-Id: I28b58b7aa0b6c336439b5165fda8954ab52402e8 Reviewed-on: https://chromium-review.googlesource.com/1679823 Tested-by: Julian Watson <juwa@google.com> Commit-Ready: Julian Watson <juwa@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> " fail_count="3" gerrit_number="1679823" owner_email="juwa@google.com" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/23/1679823/3" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="I4e748bda6b7b24fc304e20635428429c39075445" commit="607069e9083488ddfc50c189276e052a5da7a2fd" commit_message="dev-rust: Add serde_json and its dependencies This crate will be used by a first-party program and potentially by many programs as it is for general serializing/deserializing operations. BUG=b:135765932 TEST=emerge-gale dev-rust/serde_json Change-Id: I4e748bda6b7b24fc304e20635428429c39075445 Reviewed-on: https://chromium-review.googlesource.com/1672065 Tested-by: Jacob Lin <jacoblin@google.com> Commit-Ready: Jacob Lin <jacoblin@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Chinyue Chen <chinyue@chromium.org> Reviewed-by: Jacob Lin <jacoblin@google.com> " fail_count="2" gerrit_number="1672065" owner_email="jacoblin@google.com" pass_count="0" patch_number="7" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/65/1672065/7" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I6fc26eefae387766b926749742ccd928baa8af0a" commit="28d37f6aeacee3a99edef68da14929ac6a7cc465" commit_message="cryptohome: fix comment format in |tpm_new_impl.h| BUG=None TEST=emerge-chell cryptohome Change-Id: I6fc26eefae387766b926749742ccd928baa8af0a Reviewed-on: https://chromium-review.googlesource.com/1684614 Tested-by: Leo Lai <cylai@google.com> Commit-Ready: Leo Lai <cylai@google.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Wei-Cheng Xiao <garryxiao@chromium.org> " fail_count="1" gerrit_number="1684614" owner_email="cylai@google.com" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/14/1684614/1" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I00483f9bf32bee66c9168d9430b2479bf86796a0" commit="b9dcc4ffb7cb2d35ec98239a93a679f911d18873" commit_message="frecon: fix detecting keyboards BUG=none TEST=connect keyboard that uses Logitech Unifying Receiver Change-Id: I00483f9bf32bee66c9168d9430b2479bf86796a0 Signed-off-by: Dominik Behr <dbehr@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1316420 Tested-by: Stéphane Marchesin <marcheu@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> " fail_count="0" gerrit_number="1316420" owner_email="dbehr@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform/frecon" project_url="https://chromium-review.googlesource.com/chromiumos/platform/frecon" ref="refs/changes/20/1316420/2" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I1265e34f8f6e1557209416cbc71ca05b1d0247ba" commit="179f4bc95967be1e45b38ec2f3d03be85501e3a0" commit_message="tast: Add crossystem software dependency Adding crossystem software dependency as VMs don't have support for all crossystem sub-commands and platform.Crossystem test is failing due to it. crbug/974615 and crbug/954901 bugs raised BUG=chromium:974615 TEST=None Change-Id: I1265e34f8f6e1557209416cbc71ca05b1d0247ba Reviewed-on: https://chromium-review.googlesource.com/1661324 Tested-by: Kasaiah Bogineni <kasaiah.bogineni@intel.com> Commit-Ready: Kasaiah Bogineni <kasaiah.bogineni@intel.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> " fail_count="1" gerrit_number="1661324" owner_email="kasaiah.bogineni@intel.com" pass_count="0" patch_number="7" project="chromiumos/platform/tast" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast" ref="refs/changes/24/1661324/7" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="I1184c06d98cfde94637e4957a94672d142b2cef7" commit="521d67c1630deeaab4ce13ee216ee2d3a9b7923d" commit_message="faft: Open various files using 'with' statements. In several places, the framework opens a file, but doesn't explicitly close it when done. With that usage, the file objects may be closed a while after they're dereferenced. The 'with' statement closes the file immediately upon exit. BUG=None TEST=Run firmware_RollbackFirmware and firmware_RollbackKernel Change-Id: I1184c06d98cfde94637e4957a94672d142b2cef7 Reviewed-on: https://chromium-review.googlesource.com/1656514 Tested-by: Dana Goyette <dgoyette@chromium.org> Commit-Ready: Dana Goyette <dgoyette@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Greg Edelston <gredelston@google.com> Reviewed-by: Dana Goyette <dgoyette@chromium.org> " fail_count="3" gerrit_number="1656514" owner_email="dgoyette@chromium.org" pass_count="0" patch_number="8" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/14/1656514/8" remote="cros" total_fail_count="9"/><pending_commit branch="master" change_id="Ic9d7e76b281d31314a597b04896479d15fd09aee" commit="99d48db529caf5a8f26863e3e40916c4e48488de" commit_message="tast-tests: Add build properties expectation for kefka-kernelnext. BUG=b:136435600 TEST=arc.BuildProperties Change-Id: Ic9d7e76b281d31314a597b04896479d15fd09aee Reviewed-on: https://chromium-review.googlesource.com/1683798 Tested-by: Sam McNally <sammc@chromium.org> Commit-Ready: Sergei Datsenko <dats@chromium.org> Commit-Ready: Sam McNally <sammc@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Alex Levin <levinale@chromium.org> Reviewed-by: Sergei Datsenko <dats@chromium.org> " fail_count="0" gerrit_number="1683798" owner_email="sammc@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform/tast-tests" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast-tests" ref="refs/changes/98/1683798/1" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I152d2c703aaf671d70f684ac0e2a1409f78acb27" commit="fc4fb432e0c0ae5959128ac74ee239cf50cee9bc" commit_message="servo: add cr50 reset control Some boards have the cr50 reset signal connected to pin 46 of the servo header. Alias pch_disable to cr50_reset_odl. BUG=b:133261091 BRANCH=none TEST=dut-control cr50_reset_odl:on cr50_reset_odl:off gets cr50 to do a power-on reset. Change-Id: I152d2c703aaf671d70f684ac0e2a1409f78acb27 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1679994 Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> " fail_count="3" gerrit_number="1679994" owner_email="mruthven@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/hdctools" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/hdctools" ref="refs/changes/94/1679994/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I1b36c1ffe4592af9dea1678d8cf70a9d2a43a302" commit="2ccbf37494096be233dbf561faf60682c9d2fe91" commit_message="crash: Add "crash_loop_mode" to crash_reporter Implements the crash_reporter side of login-crash-loop handling. If this crash happened soon enough that it will be considered a crash loop by session manager, do not write files to disk but instead collect them in memory and send them via DBus to debugd for immediate upload. BUG=chromium:857317 TEST=Forced login-crash-loop mode, confirmed that chrome crashes were immediately uploaded and had all their files present. Also confirmed normal mode still works correctly. Tested both eve and kevin. Change-Id: I1b36c1ffe4592af9dea1678d8cf70a9d2a43a302 Reviewed-on: https://chromium-review.googlesource.com/1661455 Tested-by: Ian Barkley-Yeung <iby@chromium.org> Commit-Ready: Ian Barkley-Yeung <iby@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> " fail_count="0" gerrit_number="1661455" owner_email="iby@chromium.org" pass_count="0" patch_number="6" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/55/1661455/6" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I8a24ac7af24d8acba5175de0392b8bd22e279f70" commit="1d838af3694ad905783ead2f899dc4a90f2586d4" commit_message="mesa: explicitly use shared libgcc. For clang toolchain, we are changing the default for unwinder library from shared library to static library. Since mesa is explicitly requesting the libgcc library, let's explicitly request the share library version to keep the old behavior. There is no functional change here. It just allows us to change the default. Also note that, for Chrome OS, libgcc is mostly not used. It has been replaced by llvm/compiler-rt. The only remaining part in use from libgcc is libgcc_eh (for unwinding). BUG=chromium:972454 TEST=None. No functional change. Change-Id: I8a24ac7af24d8acba5175de0392b8bd22e279f70 Reviewed-on: https://chromium-review.googlesource.com/1679105 Tested-by: Luis Lozano <llozano@chromium.org> Commit-Ready: Ilja H. Friedel <ihf@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Chad Versace <chadversary@chromium.org> " fail_count="8" gerrit_number="1679105" owner_email="llozano@chromium.org" pass_count="0" patch_number="4" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/05/1679105/4" remote="cros" total_fail_count="8"/><pending_commit branch="master" change_id="Ibea88b78466a788e8c255b4727c6baaef5c40a8b" commit="af59fab68832a7a12514e51a329b706457faa129" commit_message="string: Compare strings without assigned number of characters Currently Helios board is mistaken as Heli board. BUG=b:136568791 TEST=manually test on a helios board, mosys can identify the platform id correctly Change-Id: Ibea88b78466a788e8c255b4727c6baaef5c40a8b Signed-off-by: Philip Chen <philipchen@google.com> Reviewed-on: https://chromium-review.googlesource.com/1684260 Tested-by: Philip Chen <philipchen@chromium.org> Commit-Ready: Philip Chen <philipchen@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Aaron Durbin <adurbin@google.com> " fail_count="0" gerrit_number="1684260" owner_email="philipchen@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform/mosys" project_url="https://chromium-review.googlesource.com/chromiumos/platform/mosys" ref="refs/changes/60/1684260/1" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I6f0cd6e283f2e36db37f311b37a41901db403645" commit="02f567439338944a9c4024f9f46c30249c614288" commit_message="faft: Rename cr50_stress_experimental suite. The suite doesn't actually contain stress tests; this change makes the name consistent with faft_cr50_prepvt and faft_cr50_pvt. BUG=None TEST=Run suite:faft_cr50_experimental Change-Id: I6f0cd6e283f2e36db37f311b37a41901db403645 Reviewed-on: https://chromium-review.googlesource.com/1677406 Tested-by: Dana Goyette <dgoyette@chromium.org> Commit-Ready: Dana Goyette <dgoyette@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Mary Ruthven <mruthven@chromium.org> " fail_count="0" gerrit_number="1677406" owner_email="dgoyette@chromium.org" pass_count="0" patch_number="2" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/06/1677406/2" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I16af281b433680ab8b3c77bc37463bc32f91908a" commit="a2e01c5c026fb2045aef9ce2c6fdac15758ba653" commit_message="hatch: Make provisioned/unprovisioned devices share the same config The devices w/o SKU ID provisioned should still have the basic configs (e.g. power) to work properly. At this moment, provisioned/unprovisioned devices can share the same base_config in the public model.yaml. BUG=b:136217692 TEST=emerge-hatch chromeos-config-bsp-hatch \ chromeos-config-bsp-hatch-private chromeos-config-bsp Change-Id: I16af281b433680ab8b3c77bc37463bc32f91908a Reviewed-on: https://chromium-review.googlesource.com/1684230 Tested-by: Philip Chen <philipchen@chromium.org> Commit-Ready: Philip Chen <philipchen@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> " fail_count="0" gerrit_number="1684230" owner_email="philipchen@chromium.org" pass_count="0" patch_number="2" project="chromiumos/overlays/board-overlays" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/board-overlays" ref="refs/changes/30/1684230/2" remote="cros" total_fail_count="0"/><pending_commit branch="chromeos-4.14" change_id="I2e3ceb3dd6824fb4dd4aab2bc250eaba24c707f5" commit="e2235d0a70cdeeb60febaef317f84489787df957" commit_message="FIXUP: ANDROID: net: ipv6: autoconf routes into per-device tables The current code triggers syzbot reports. kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: 0000 [#1] PREEMPT SMP KASAN PTI Modules linked in: CPU: 1 PID: 78 Comm: kworker/u4:1 Not tainted 4.14.81-gdc93096 #1 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: netns cleanup_net task: ffff8801d9a248c0 task.stack: ffff8801d7f78000 RIP: 0010:addrconf_rt_table+0x32/0xa7 net/ipv6/addrconf.c:2293 RSP: 0018:ffff8801d7f7f6f0 EFLAGS: 00010206 RAX: dffffc0000000000 RBX: 00000000000000fe RCX: 1ffff1003b344a48 RDX: 000000000000004d RSI: 1ffff1003afefec9 RDI: 0000000000000268 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: ffffed003afefe71 R11: ffffed003afefe70 R12: 0000000000000000 R13: ffff8801d5f04400 R14: 0000000000000000 R15: ffff8801d2278000 FS: 0000000000000000(0000) GS:ffff8801db500000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000004a20fd CR3: 0000000004c22003 CR4: 00000000001606e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: addrconf_get_prefix_route+0x31/0x21d net/ipv6/addrconf.c:2347 __ipv6_ifa_notify+0x52c/0x5e2 net/ipv6/addrconf.c:5599 addrconf_ifdown+0x93a/0xbb6 net/ipv6/addrconf.c:3723 addrconf_notify+0x1378/0x13c1 net/ipv6/addrconf.c:3558 notifier_call_chain+0xf5/0x15c kernel/notifier.c:93 call_netdevice_notifiers+0x7b/0x9e net/core/dev.c:1688 rollback_registered_many+0x518/0x79e net/core/dev.c:7226 unregister_netdevice_many+0x47/0x17c net/core/dev.c:8275 default_device_exit_batch+0x30c/0x35b net/core/dev.c:8734 ops_exit_list+0x80/0x123 net/core/net_namespace.c:145 cleanup_net+0x300/0x4d8 net/core/net_namespace.c:483 process_one_work+0x7d2/0xcfe kernel/workqueue.c:2114 worker_thread+0x5e4/0x73c kernel/workqueue.c:2248 kthread+0x2ff/0x313 kernel/kthread.c:232 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:402 RIP: addrconf_rt_table+0x32/0xa7 net/ipv6/addrconf.c:2293 RSP: ffff8801d7f7f6f0 ---[ end trace af14b2237c8d750c ]--- The problem is not seen anymore in chromeos-4.19 after aligning the code with its latest version in Android. Do the same in chromeos.4.14. Functional changes: - In addrconf_rt_table(), check if idev(=in6_dev_get(dev)) is NULL - Remove DEVCONF_ACCEPT_RA_RT_TABLE BUG=b:119966745 TEST=syzbot Change-Id: I2e3ceb3dd6824fb4dd4aab2bc250eaba24c707f5 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1682453 Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Hugo Benichi <hugobenichi@google.com> " fail_count="4" gerrit_number="1682453" owner_email="groeck@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/53/1682453/3" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="Ibffbd26f5690a2ea22d4e64fe70d64ec83715810" commit="61d1fb9b45444b1060758d5909cfc673913ec58e" commit_message="adhd: add veyron_jerry-kernelnext to CROS_BOARDS Follow work done for minnie-kernelnext in CL:1641219 BUG=chromium:941638 TEST=cras and ucm configs are installed for veyron_jerry-kernelnext with CL:1682833 Change-Id: Ibffbd26f5690a2ea22d4e64fe70d64ec83715810 Reviewed-on: https://chromium-review.googlesource.com/1682834 Tested-by: Ryan Case <ryandcase@chromium.org> Commit-Ready: Ryan Case <ryandcase@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="2" gerrit_number="1682834" owner_email="ryandcase@chromium.org" pass_count="0" patch_number="1" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/34/1682834/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I856553bd2cedd6e35845739b037e8dc1a487c2d0" commit="336be0cd1d669b993e16b53a45d3fa1f93b51dfc" commit_message="cras-config: Add configs for veyron_jerry-kernelnext Follow fixes for minnie in CL:1639629 Using the same configs as jerry so created symlinks to jerry folder. BUG=chromium:941638 TEST=emerge-veyron_jerry-kernelnext adhd && verify configs installed Change-Id: I856553bd2cedd6e35845739b037e8dc1a487c2d0 Reviewed-on: https://chromium-review.googlesource.com/1682833 Tested-by: Ryan Case <ryandcase@chromium.org> Commit-Ready: Ryan Case <ryandcase@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="2" gerrit_number="1682833" owner_email="ryandcase@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/adhd" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/adhd" ref="refs/changes/33/1682833/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I2a9813a9cfe1205304aaf531b4d539aab82ff6c7" commit="bd4a16ce6a4131c4b274e9a05f71c4960f8a01ca" commit_message="veyron-jerry: Add appid for veyron_jerry-kernelnext Follow samus-kernelnext example and add a unique appid for kernelnext builds. BUG=chromium:941638 TEST=./build_image --board=veyron_jerry-kernelnext Change-Id: I2a9813a9cfe1205304aaf531b4d539aab82ff6c7 Reviewed-on: https://chromium-review.googlesource.com/1682196 Tested-by: Ryan Case <ryandcase@chromium.org> Commit-Ready: Ryan Case <ryandcase@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> " fail_count="2" gerrit_number="1682196" owner_email="ryandcase@chromium.org" pass_count="0" patch_number="1" project="chromiumos/overlays/board-overlays" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/board-overlays" ref="refs/changes/96/1682196/1" remote="cros" total_fail_count="2"/><lkgm version="12316.0.0-rc1"/></manifest> |
