blob: 8dfa9ef6f69bca571c91c77e833233de3219fe0c [file] [log] [blame]
<?xml version="1.0" encoding="utf-8"?><manifest revision="27013616305bc744fccf5fb5b53c879200e9b3d0">
<notice>Your sources have been sync'd successfully.</notice>
<remote fetch="https://android.googlesource.com" name="aosp" review="https://android-review.googlesource.com"/>
<remote alias="cros" fetch="https://chromium.googlesource.com/" name="chromium"/>
<remote fetch="https://chromium.googlesource.com" name="cros" review="https://chromium-review.googlesource.com"/>
<default remote="cros" revision="refs/heads/master" sync-j="8"/>
<project name="aosp/platform/external/libchrome" path="src/aosp/external/libchrome" revision="78e77b7f04d2d1be4868a9696c30e38be73b37cc" upstream="refs/heads/master"/>
<project name="aosp/platform/external/modp_b64" path="src/third_party/modp_b64" revision="afc3e28a3de4a627e3afaf73b4c55ed85c992470" upstream="refs/heads/master"/>
<project name="aosp/platform/system/core/libsync" path="src/aosp/system/libsync" revision="f4f4387b6bf2387efbcfd1453af4892e8982faf6" upstream="refs/heads/master"/>
<project groups="devserver" name="aosp/platform/system/update_engine" path="src/aosp/system/update_engine" revision="2f8594e369b7eb14809a210c9f8450b158cb9f06" upstream="refs/heads/master"/>
<project name="apps/libapps" path="src/third_party/libapps" revision="505af55573cc1fda803792f347d808423d812126" upstream="refs/heads/master">
<annotation name="branch-mode" value="pin"/>
</project>
<project name="chromium/deps/libmtp" path="src/chromium/src/third_party/libmtp" remote="chromium" revision="4f4fad584e9c2735af5131f15b697376a3327de5" upstream="refs/heads/master"/>
<project groups="minilayout,buildtools,labtools" name="chromium/llvm-project/cfe/tools/clang-format" path="src/chromium/src/buildtools/clang_format/script" remote="chromium" revision="8b4035c040d06609bfd9a0fe37da9497060cea4e" upstream="refs/heads/master"/>
<project groups="minilayout,buildtools,labtools" name="chromium/src/buildtools" path="src/chromium/src/buildtools" remote="chromium" revision="cf454b247c611167388742c7a31ef138a6031172" upstream="refs/heads/master"/>
<project name="chromium/src/third_party/Python-Markdown" path="src/chromium/src/third_party/Python-Markdown" remote="chromium" revision="36657c103ce5964733bbbb29377085e9cc1a9472" upstream="refs/heads/master"/>
<project name="chromium/src/tools/md_browser" path="src/chromium/src/tools/md_browser" remote="chromium" revision="0bfd826f8566a99923e64a782908faca72bc457c" upstream="refs/heads/master"/>
<project groups="minilayout,firmware,buildtools,labtools" name="chromium/tools/depot_tools" remote="chromium" revision="3841eaa164c2f34c8ea969d462a3151b10151780"/>
<project groups="minilayout,firmware,buildtools,chromeos-admin,labtools,sysmon,devserver" name="chromiumos/chromite" path="chromite" revision="16fc2da9908a23f9f559466dfbed4c80f5f99e52" upstream="refs/heads/master">
<copyfile dest="AUTHORS" src="AUTHORS"/>
<copyfile dest="LICENSE" src="LICENSE"/>
</project>
<project name="chromiumos/containers/cros-container-guest-tools" path="src/platform/container-guest-tools" revision="3d3ab7dad64091a64fcd50d4b75a2573c4ecf5cc" upstream="refs/heads/master"/>
<project name="chromiumos/docs" path="docs" revision="7b9fc026ce6fcec77984bae3effca939c775a6d2" upstream="refs/heads/master"/>
<project name="chromiumos/graphyte" path="src/platform/graphyte" revision="10d607271aef6033e704ce55cabfef486fdd3211" upstream="refs/heads/master"/>
<project groups="chromeos-admin" name="chromiumos/infra/ci_results_archiver" path="infra/ci_results_archiver" revision="e26eb065275789dcc18c1f7c18c345d52c732bea" upstream="refs/heads/master"/>
<project name="chromiumos/infra/cl_exonerator" path="infra/cl_exonerator" revision="e3886f47d7832b18854c073838d836cf7a8b334b" upstream="refs/heads/master"/>
<project name="chromiumos/infra/cl_status_viewer" path="infra/cl_status_viewer" revision="c83dac930c70348b312188615cf0f080d4903f86" upstream="refs/heads/master"/>
<project name="chromiumos/infra/distfiles_updater" path="infra/distfiles_updater" revision="2d1aa33972b2028d19a288baaacee9b2cd8644f7" upstream="refs/heads/master"/>
<project name="chromiumos/infra/dummies/general-sandbox" path="infra/dummies/general-sandbox" revision="c78d5b6556c7c4da269a4dc64ff40af4703bcf06" upstream="refs/heads/master"/>
<project name="chromiumos/infra/dummies/merge-sandbox" path="infra/dummies/merge-sandbox" revision="651c1f3b89c112222f5dae2f79091421543dd4ee" upstream="refs/heads/master"/>
<project groups="chromeos-admin" name="chromiumos/infra/go" path="infra/go" revision="b9f472a89047895090895f15b45ca23aa5715f3c" upstream="refs/heads/master">
<annotation name="branch-mode" value="tot"/>
</project>
<project name="chromiumos/infra/logstock" path="infra/logstock" revision="2c820dcfff228f1b9f9cef99173ea4c1cfe215d4" upstream="refs/heads/master"/>
<project name="chromiumos/infra/lucifer" path="infra/lucifer" revision="5f943c8f7bf2951dcfa32a319e0b0083415d0390" upstream="refs/heads/master"/>
<project name="chromiumos/infra/proto" path="chromite/infra/proto" revision="a8926c84bda0347007ce78e505576a7a9168c9c6" upstream="refs/heads/master">
<annotation name="branch-mode" value="tot"/>
</project>
<project groups="chromeos-admin" name="chromiumos/infra/recipes" path="infra/recipes" revision="9db772bd931c1aa0ab3674a798f52c8cb997040b" upstream="refs/heads/master">
<annotation name="branch-mode" value="tot"/>
</project>
<project groups="chromeos-admin,labtools" name="chromiumos/infra/skylab_inventory" path="infra/skylab_inventory" revision="8a42cac951ad336e232420bc34fa32c02f30db62" upstream="refs/heads/master"/>
<project name="chromiumos/infra/suite_scheduler" path="infra/suite_scheduler" revision="172024eb109b96443f173578a6e4ebc965ddd818" upstream="refs/heads/master"/>
<project name="chromiumos/infra/test_analyzer" path="infra/test_analyzer" revision="2b64804e94031c148e5ddf43320229fd81a372db" upstream="refs/heads/master"/>
<project groups="minilayout,firmware,buildtools,chromeos-admin,labtools,sysmon,devserver" name="chromiumos/infra_virtualenv" path="infra_virtualenv" revision="a070aaec477f1a6d192d70b0b2491d1184424aba" upstream="refs/heads/master"/>
<project name="chromiumos/manifest" path="manifest" revision="6ccaf77cc32a5dc784eb678e05e6b76b6ee20850" upstream="refs/heads/master"/>
<project groups="minilayout,firmware" name="chromiumos/overlays/board-overlays" path="src/overlays" revision="320234fd9e7acac8ca7b40c27abb70f5a10125b8" upstream="refs/heads/master"/>
<project groups="minilayout,firmware,labtools" name="chromiumos/overlays/chromiumos-overlay" path="src/third_party/chromiumos-overlay" revision="d8e458973350073653e7dcdf2e313eb4e012d5df" sync-c="true" upstream="refs/heads/master"/>
<project groups="minilayout,firmware,labtools" name="chromiumos/overlays/eclass-overlay" path="src/third_party/eclass-overlay" revision="9e15f6b049b2fd7db389f0b0e597de920cf692bc" upstream="refs/heads/master"/>
<project groups="minilayout,firmware,labtools" name="chromiumos/overlays/portage-stable" path="src/third_party/portage-stable" revision="d50a90ca2ea7b0d624e6996d3de971a97f77a0e3" upstream="refs/heads/master"/>
<project name="chromiumos/platform/assets" path="src/platform/assets" revision="e7ebdd172ce76d34147a0d3fe32843f577f98942" upstream="refs/heads/master"/>
<project name="chromiumos/platform/audiotest" path="src/platform/audiotest" revision="fe6f079ddafe2b4233cc95b8b4c681349d3e7bba" upstream="refs/heads/master"/>
<project name="chromiumos/platform/battery_updater" path="src/platform/battery_updater" revision="6ff439321073109d6343280da70a4aae6cc51f65" upstream="refs/heads/master"/>
<project name="chromiumos/platform/bisect-kit" path="src/platform/bisect-kit" revision="85a244f03a3e440dbbf3556e30ba3dc358177f80" upstream="refs/heads/master"/>
<project name="chromiumos/platform/bmpblk" path="src/platform/bmpblk" revision="537df96d8ce3c41676e019cae3b60363d0659312" upstream="refs/heads/master"/>
<project name="chromiumos/platform/bootcache" path="src/platform/bootcache" revision="6ed1eea32f34b2ef5f0d88ba45eb728186c7458a" upstream="refs/heads/master"/>
<project name="chromiumos/platform/btsocket" path="src/platform/btsocket" revision="300354e5d74418c8e03737ca9029c64d9297a28d" upstream="refs/heads/master"/>
<project name="chromiumos/platform/cfm-device-monitor" path="src/platform/cfm-device-monitor" revision="fbc6381a8b9ab3bc372a3a9ab174e9fb1ec876c9" upstream="refs/heads/master"/>
<project name="chromiumos/platform/chameleon" path="src/platform/chameleon" revision="8d940f9a68d0800576f427a61077e08f390146b7" upstream="refs/heads/master"/>
<project name="chromiumos/platform/chromiumos-assets" path="src/platform/chromiumos-assets" revision="a5acfbd3dd6cab1b133d84080b22e7b8e6d0e199" upstream="refs/heads/master"/>
<project name="chromiumos/platform/cobble" path="src/platform/cobble" revision="bae5ccdc16ed42fac1e6596cfb199d06e4c92d3e" upstream="refs/heads/master"/>
<project groups="minilayout,firmware,buildtools" name="chromiumos/platform/crostestutils" path="src/platform/crostestutils" revision="e3b0ea7999f1b58d053270bc98f4c3816dd55105" upstream="refs/heads/master"/>
<project groups="minilayout,firmware,buildtools,labtools" name="chromiumos/platform/crosutils" path="src/scripts" revision="ca7cd94abd16aa45419206849667b4dabd86b977" upstream="refs/heads/master"/>
<project name="chromiumos/platform/crosvm" path="src/platform/crosvm" revision="71a6f0a790eb3f9a6fccbaf08aa915396a9d6749" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/platform/depthcharge" path="src/platform/depthcharge" revision="acf1e674583e5191fb10fc21c9f18da926d4956d" upstream="refs/heads/master"/>
<project groups="minilayout,firmware,buildtools,devserver" name="chromiumos/platform/dev-util" path="src/platform/dev" revision="f28894ebd65ac148e8b97532c76a861c84987cb9" upstream="refs/heads/master"/>
<project name="chromiumos/platform/dm-verity" path="src/platform/verity" revision="393cd4d510256b0bb2bdd0acd9656105cfd28771" upstream="refs/heads/master"/>
<project name="chromiumos/platform/drm-tests" path="src/platform/drm-tests" revision="f14d024be892abda3b7a309e173b26c0fe630d67" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/platform/ec" path="src/platform/ec" revision="881d05951d94345c7c5bdea909cf5d393bd66a57" upstream="refs/heads/master"/>
<project name="chromiumos/platform/experimental" path="src/platform/experimental" revision="2927fce20adf74b0c9a32a61e3edff894221f283" upstream="refs/heads/master"/>
<project name="chromiumos/platform/factory" path="src/platform/factory" revision="feb73c2e542c9481ae47fe2c7c1a75832d1e9e93" upstream="refs/heads/master"/>
<project name="chromiumos/platform/factory_installer" path="src/platform/factory_installer" revision="fee00dc55fbaef9a8982dc8e6d556984e95d02ce" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/platform/firmware" path="src/platform/firmware" revision="4c68bbe46bcc1f91b744a5cf5b11ac3e90232be2" upstream="refs/heads/master"/>
<project name="chromiumos/platform/frecon" path="src/platform/frecon" revision="aa279299deec851ef4cc29eb99f38426afc92d12" upstream="refs/heads/master"/>
<project name="chromiumos/platform/gestures" path="src/platform/gestures" revision="f1622a22be553e019f0ef97d4a6c154d1274446d" upstream="refs/heads/master"/>
<project name="chromiumos/platform/glbench" path="src/platform/glbench" revision="414ba8197d43e497a0351a51e1aac8df607a2ff1" upstream="refs/heads/master"/>
<project name="chromiumos/platform/go-seccomp" path="src/platform/go-seccomp" revision="9f7e7fb007ebfb3070e878526876a039b6add840" upstream="refs/heads/master"/>
<project name="chromiumos/platform/google-breakpad" path="src/third_party/breakpad" revision="01dfa81f1b4becb157ed9ccc9277f6eac1de67e3" upstream="refs/heads/master"/>
<project name="chromiumos/platform/initramfs" path="src/platform/initramfs" revision="0eb1b0c34da7b03c9c39954fce196d4ba4afd073" upstream="refs/heads/master"/>
<project name="chromiumos/platform/inputcontrol" path="src/platform/inputcontrol" revision="4c0c21a9a02024f5c9913c1c7d0f74f100e861d1" upstream="refs/heads/master"/>
<project name="chromiumos/platform/jabra_vold" path="src/platform/jabra_vold" revision="233d517d2904912b207d273794b0ec5343e48010" upstream="refs/heads/master"/>
<project name="chromiumos/platform/libevdev" path="src/platform/libevdev" revision="231ea3605643c8bac1f997a80442c230d69cbe44" upstream="refs/heads/master"/>
<project name="chromiumos/platform/microbenchmarks" path="src/platform/microbenchmarks" revision="c7ece0f317b6ef8343f01fc2b07a47cee81c9ba3" upstream="refs/heads/master"/>
<project name="chromiumos/platform/minigbm" path="src/platform/minigbm" revision="86e72a439a0da42108ff66e4aa6ad9578cf85fbd" upstream="refs/heads/master"/>
<project name="chromiumos/platform/moblab" path="src/platform/moblab" revision="1b660e5568d644bf0f5c448cb360831306f68054" upstream="refs/heads/master"/>
<project name="chromiumos/platform/mosys" path="src/platform/mosys" revision="2a1e42b06605cd7341dcd451b2205976275edce4" upstream="refs/heads/master"/>
<project name="chromiumos/platform/mttools" path="src/platform/mttools" revision="5d51be06ab30e90c9e1272a86462e718de916695" upstream="refs/heads/master"/>
<project name="chromiumos/platform/newblue" path="src/platform/newblue" revision="938dc3077a07c1b877a2f2e91c452356bbfa5438" upstream="refs/heads/master"/>
<project name="chromiumos/platform/tast" path="src/platform/tast" revision="e96973b86aed3668339f33407f2eb6d39413b5a0" upstream="refs/heads/master"/>
<project name="chromiumos/platform/tast-tests" path="src/platform/tast-tests" revision="d2229f5f9eb5b97e154d778128c7f513c13f9074" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/platform/touch_firmware_test" path="src/platform/touch_firmware_test" revision="8b455f6fe6b82cf679de9a9b7379147c33025998" upstream="refs/heads/master"/>
<project name="chromiumos/platform/touch_updater" path="src/platform/touch_updater" revision="a26736c4cbfc995fffcaab9e53de8c230954f321" upstream="refs/heads/master"/>
<project name="chromiumos/platform/touchbot" path="src/platform/touchbot" revision="9546ffbb37d5fef191ad1607eeb0b76a6f3a9872" upstream="refs/heads/master"/>
<project name="chromiumos/platform/touchpad-tests" path="src/platform/touchpad-tests" revision="33c9165824594caf35bb39d2a73f67f3eaac62ce" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/platform/tpm" path="src/third_party/tpm" revision="8afebd60c77201ab9eac6e049e4576ed26c6d600" upstream="refs/heads/master"/>
<project name="chromiumos/platform/tpm_lite" path="src/platform/tpm_lite" revision="dd6ae9f3a223c0a8a89a2e4c10600f7700354a53" upstream="refs/heads/master"/>
<project name="chromiumos/platform/tremplin" path="src/platform/tremplin" revision="15a97c380f613d1b9b1b70f35cf334ccc7610cd2" upstream="refs/heads/master"/>
<project name="chromiumos/platform/uboot-env" path="src/platform/uboot-env" revision="5ad506f38e25df5361f1ec7892e9b4f201590a64" upstream="refs/heads/master"/>
<project groups="firmware,buildtools" name="chromiumos/platform/vboot_reference" path="src/platform/vboot_reference" revision="14c01ac6c6e80b37e38c8b34d07e8501084ba2a8" upstream="refs/heads/master"/>
<project name="chromiumos/platform/vkbench" path="src/platform/vkbench" revision="00777b2669009fbdff36d8982da86629d6ea0b23" upstream="refs/heads/master"/>
<project name="chromiumos/platform/vpd" path="src/platform/vpd" revision="fabe3f4cc2204755d26ff611a1631fd51c8b0fa6" upstream="refs/heads/master"/>
<project name="chromiumos/platform/webplot" path="src/platform/webplot" revision="bbd5ea22ef9f8e109e363b26958d9a2fc8921f0f" upstream="refs/heads/master"/>
<project name="chromiumos/platform/xorg-conf" path="src/platform/xorg-conf" revision="570365d36c3235ee4f9e96219cd8e96cd6d5332c" upstream="refs/heads/master"/>
<project name="chromiumos/platform2" path="src/platform2" revision="998d244109b17808a769fa83796ebf0eab6f583a" upstream="refs/heads/master"/>
<project groups="minilayout,firmware,buildtools,labtools" name="chromiumos/repohooks" path="src/repohooks" revision="aa7dc943f9ac356eb700331884ece7f0d4c6421c" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/adhd" path="src/third_party/adhd" revision="dac1d658c1e3c0d8b95dcc9816746698b3d7fd81" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/arm-trusted-firmware" path="src/third_party/arm-trusted-firmware" revision="6129e9a643274e658a0e6f5428ad976676c7bb7a" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/atheros" path="src/third_party/atheros" revision="97c9ec1e9d4b66a3b8dacf6d9e13540eda4938bd" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/atrusctl" path="src/third_party/atrusctl" revision="8a6c0ff0755e4ba9e0d3c024a431494006563b4e" upstream="refs/heads/master"/>
<project groups="buildtools,labtools,devserver" name="chromiumos/third_party/autotest" path="src/third_party/autotest/files" revision="43269162d33250181fe3a9084acc777bdb01e244" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/aver-updater" path="src/third_party/aver-updater" revision="ca398c4893b944f6d6ba9b3f0bc34e59079bd82f" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/bluez" path="src/third_party/bluez" revision="af462979f7f87ae40fc1ce4f3f8d8560566b00b7" upstream="refs/heads/chromeos-5.44"/>
<project groups="firmware" name="chromiumos/third_party/bootstub" path="src/third_party/bootstub" revision="e69fbecd355bf860f4bf165fb83abb354e513fa8" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/broadcom" path="src/third_party/broadcom" revision="bee0942a568971cc491c2da2d82e527f93e3e304" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/cbootimage" path="src/third_party/cbootimage" revision="b7d5b2d6a6dd05874d86ee900ff441d261f9034c" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/coreboot" path="src/third_party/coreboot" revision="daf23dbe0d1863d5b91fb9b8a100c2209b9cfa85" upstream="refs/heads/chromeos-2016.05"/>
<project groups="firmware" name="chromiumos/third_party/coreboot/blobs" path="src/third_party/coreboot/3rdparty/blobs" revision="643912c02aaad0cc5347310676ab585db75a4ddf" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/coreboot/intel-microcode" path="src/third_party/coreboot/3rdparty/intel-microcode" revision="ee319ae7bc59e88b60142f40a9ec1b46656de4db" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/cros-adapta" path="src/third_party/cros-adapta" revision="eb6d8c1832b9181926df107faf41a80887fd982c" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/cryptoc" path="src/third_party/cryptoc" revision="e05bfa91102dd5137b4027b4f3405e041ffe2c32" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/cups" path="src/third_party/cups" revision="a98d244469a38b442c57cc61aaffe5220873dc18" upstream="refs/heads/cups-2-2-8"/>
<project name="chromiumos/third_party/daisydog" path="src/third_party/daisydog" revision="5f4302621d8e011edbd83858b0c3183e29f842b5" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/edk2" revision="e0d276cc82ff8a5b58672235fd90cb4731937208" upstream="refs/heads/chromeos-2017.08"/>
<project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/cml/edk2/branch1" revision="264551f027e80cd73a4554b431043ff29c6685a8" upstream="refs/heads/chromeos-cml-branch1"/>
<project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/cnl/edk2" revision="1d24ff60d457f2e8c0457577f3fe8163164dcd99" upstream="refs/heads/chromeos-cnl"/>
<project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/glk/edk2" revision="b157545b7eac7a0538b1437521f2d3cc2dfdd759" upstream="refs/heads/chromeos-glk"/>
<project groups="firmware" name="chromiumos/third_party/edk2" path="src/third_party/fsp/icl/edk2" revision="a5d08a5efcfbddf9b668c945213d806b353ef887" upstream="refs/heads/chromeos-icl"/>
<project groups="firmware" name="chromiumos/third_party/em100" path="src/third_party/em100" revision="845504afde5b44c44c6e8b51f137dfa6f017ca5b" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/fastrpc" path="src/third_party/fastrpc" revision="c2d1cdc0fb781ee673077c5d4b243eb239c73bb5" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/flashmap" path="src/third_party/flashmap" revision="2f7b2e16f588dde75a0c9c28175f16b8cb9e11dc" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/flashrom" path="src/third_party/flashrom" revision="c6f484a4208f7406153ffd30e2c1ce159cccbe8e" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/fwupd" path="src/third_party/fwupd" revision="62d946925a06791cdc54a98fc415081f478528d5" upstream="refs/heads/fwupd-1.2.5"/>
<project groups="labtools" name="chromiumos/third_party/hdctools" path="src/third_party/hdctools" revision="37c700c66b152cce3c7d23dbc35376a09667a316" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/hostap" path="src/third_party/wpa_supplicant" revision="8fbe25ac02942ba3b6c39b615cb2325f7a0c1e19" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/hostap" path="src/third_party/wpa_supplicant-2.6" revision="1ee0cb9e68742513a9bfa30e00a7355966eed0d7" upstream="refs/heads/wpa_supplicant-2.6"/>
<project name="chromiumos/third_party/hostap" path="src/third_party/wpa_supplicant-2.8" revision="68459cc3d71b3ccaded2577cec611f0e78a9a73f" upstream="refs/heads/wpa_supplicant-2.8"/>
<project name="chromiumos/third_party/huddly-updater" path="src/third_party/huddly-updater" revision="db3ba96c05e307b5b3de22a8329c74e9c562b1ef" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.8" revision="68a6baeff369aa1b42f8d46defb4609fc7d6efc6" upstream="refs/heads/chromeos-3.8"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.10" revision="563ef7eb484107d3b6b34283b48d772004add0bb" upstream="refs/heads/chromeos-3.10"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.14" revision="8bfac500e8aeb147834ebd7498563e9de5e4089a" upstream="refs/heads/chromeos-3.14"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v3.18" revision="e7120866029029a0078b3c2fc9f88d95da03825e" upstream="refs/heads/chromeos-3.18"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.4" revision="3da25be341083224e445596694cc32a630b4ca1b" upstream="refs/heads/chromeos-4.4"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.14" revision="23976b7456feedccb77218d529b5d70b264c50b1" upstream="refs/heads/chromeos-4.14"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.14-mistral" revision="62cc4a5d677543740a039978a8af351cfd3b22c7" upstream="refs/heads/chromeos-4.14-mistral"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.14-gw" revision="d5313e11c6123732134f82846e8e088df748bd9b" upstream="refs/heads/chromeos-4.14-gw"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.19" revision="fc43b936545b9de2bd3fcd165b57fcd77a2582f7" upstream="refs/heads/chromeos-4.19"/>
<project name="chromiumos/third_party/kernel" path="src/third_party/kernel/v4.19-lakitu" revision="2d26b9df3f90536fc6a275fcad13edfb5871ad65" upstream="refs/heads/chromeos-4.19-lakitu"/>
<project name="chromiumos/third_party/khronos" path="src/third_party/khronos" revision="b3d20636223e605ec5bcea0071baf2687381f73a" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/kvmtool" path="src/third_party/kvmtool" revision="1b159b990afd33c0c2e3b47ebda6dd5cc793dd92" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/libcamera" path="src/third_party/libcamera" revision="f0b2582c4961ce9e5b637a2a326aa59ebc905e52" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/libdrm" path="src/third_party/libdrm" revision="728dfa9dbeeb013e5a26c24f4372a16eace99c5e" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/libiio" path="src/third_party/libiio" revision="bca23460e8951af087404cae168fc53e4379744f" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/libmbim" path="src/third_party/libmbim" revision="863b8d54c623c293866d5e963e8f3f96bfb4f81b" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/libqmi" path="src/third_party/libqmi" revision="bee44736cd853ee2c712d2d159c460a2f5055c90" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/libqrtr" path="src/third_party/libqrtr" revision="e5cc28a8bec257bc82e1936b075aab7b8c468c29" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/libscrypt" path="src/third_party/libscrypt" revision="e9fe99ea600bc3f2745eaf7c04f38330b04dc80e" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/libsigrok" path="src/third_party/libsigrok" revision="199fe31115c76231746f5953271795d58679561c" upstream="refs/heads/chromeos"/>
<project name="chromiumos/third_party/libsigrok-cli" path="src/third_party/sigrok-cli" revision="c9edfa218e5a5972531b6f4a3ece8d33a44ae1b5" upstream="refs/heads/chromeos"/>
<project name="chromiumos/third_party/libsigrokdecode" path="src/third_party/libsigrokdecode" revision="3279c2825684c7009775b731d0a9e37815778282" upstream="refs/heads/chromeos"/>
<project name="chromiumos/third_party/libv4lplugins" path="src/third_party/libv4lplugins" revision="79286ece8624ab016575a5ad8965a61b334ab169" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/linux-firmware" path="src/third_party/linux-firmware" revision="61bb4a6c55a0d2e19b1721132b97b4459ad3ca3f" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/logitech-updater" path="src/third_party/logitech-updater" revision="60f028a6b444146c90cf11c3e81e9b02ec17f9b4" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/ltp" path="src/third_party/ltp" revision="08733aa7d62b171c667d3eb7e299aa7345053fa9" upstream="refs/heads/chromeos-20150119"/>
<project name="chromiumos/third_party/marvell" path="src/third_party/marvell" revision="82b4358bb82a8be3eb2ee1723736229acb6e6c03" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/mesa" path="src/third_party/mesa" revision="fafd20f67dec9f5891838435ecde1dedb77ab742" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/mesa" path="src/third_party/mesa-debian" revision="bb8c9e16c5ffe4c66fa0af2a3cacd3c010674a16" upstream="refs/heads/debian"/>
<project name="chromiumos/third_party/mesa" path="src/third_party/mesa-freedreno" revision="bd02151f908f1707cbd3712f0a5978a3b13fdf1b" upstream="refs/heads/chromeos-freedreno"/>
<project name="chromiumos/third_party/mesa" path="src/third_party/mesa-img" revision="129178893b2260df22db96327c5ca9c2ce7db046" upstream="refs/heads/mesa-img"/>
<project name="chromiumos/third_party/mimo-updater" path="src/third_party/mimo-updater" revision="ee7ebf23c4515f88ad97f750b0fd53409292c078" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/mmc-utils" path="src/third_party/mmc-utils" revision="329c5cade4d639803c0c356da250f8314617956c" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/modemmanager-next" path="src/third_party/modemmanager-next" revision="a7ba6da86b0196b9da5212363bfd982d9eea4b28" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/nfs-ganesha" path="src/third_party/nfs-ganesha" revision="165395bf01548d8a0135357ca4c222b9c0c0acaa" upstream="refs/heads/V2.3-stable"/>
<project name="chromiumos/third_party/ntirpc" path="src/third_party/ntirpc" revision="a9fc54d636fc3e5b5f0918769a2e5343c5f0d823" upstream="refs/heads/V1.3.3-cros"/>
<project name="chromiumos/third_party/portage_tool" path="src/third_party/portage_tool" revision="4d5d3e06311bf0fd54b4deaff9cc326b3bb75697" upstream="refs/heads/chromeos-2.3.49"/>
<project groups="minilayout,firmware,buildtools" name="chromiumos/third_party/pyelftools" path="chromite/third_party/pyelftools" revision="0890b98431a9b2e637c18f719232d06a4e5c3cd8" upstream="refs/heads/master-0.22"/>
<project name="chromiumos/third_party/rootdev" path="src/third_party/rootdev" revision="9b7d26a6a54f5f9e02b93a5d5ebf266fd748e06c" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/seabios" path="src/third_party/seabios" revision="3004147dd3707e600772ec6c5d37beac7f4b8eb4" upstream="refs/heads/chromeos-2014.11.03"/>
<project name="chromiumos/third_party/shellcheck" path="src/third_party/shellcheck" revision="e9a0e8b8a2c051b3cf722b88b08c245f70ac6949" upstream="refs/heads/chromeos-0.7"/>
<project name="chromiumos/third_party/sis-updater" path="src/third_party/sis-updater" revision="00891af50692fd9d5aca4153243271e7fbc8822f" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/sound-open-firmware" path="src/third_party/sound-open-firmware" revision="5b43730e8620c60b4170231f7e9d91d2d2d89652" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/sysbios" path="src/third_party/sysbios" revision="33e1db34b8162de72a5e9bbbc44e6bce38978396" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/tlsdate" path="src/third_party/tlsdate" revision="4b584f8041db5f3e8c26e954f3a2447ef8279728" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/toolchain-utils" path="src/third_party/toolchain-utils" revision="61413b95947a29deff13de9b744c1eb97032a2d3" upstream="refs/heads/master"/>
<project groups="firmware" name="chromiumos/third_party/tpm2" path="src/third_party/tpm2" revision="a9bc45bb7fafc65ea8a787894434d409f533b1f1" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/trousers" path="src/third_party/trousers" revision="c6adcadf8c45c9a5b7f705b279c481e6d3d1d667" upstream="refs/heads/master-0.3.13"/>
<project name="chromiumos/third_party/u-boot" path="src/third_party/u-boot/files" revision="e22ab0b2ab75f6f613976c6690f497dd791bc6d9" upstream="refs/heads/chromeos-v2018.09"/>
<project name="chromiumos/third_party/virglrenderer" path="src/third_party/virglrenderer" revision="4e0a17405aa1f19c3bc63b3ec55703c28eae293f" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/virtual-usb-printer" path="src/third_party/virtual-usb-printer" revision="3005fddc52d5e2db563f7f0ff7a77be0a693eb44" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/webrtc-apm" path="src/third_party/webrtc-apm" revision="23dc36459a1b9a88bae85d03613483ab6738be80" upstream="refs/heads/master"/>
<project name="chromiumos/third_party/whining" path="src/third_party/whining" revision="f17caea7f6bdbafaca8de35e83178de3999e4f45" upstream="refs/heads/master"/>
<project name="external/git.kernel.org/fs/xfs/xfstests-dev" path="src/third_party/xfstests" revision="0fd43f3f4bd7b6800e876fafdd26a3d9dd82ff47" upstream="refs/heads/master"/>
<project groups="buildtools,chromeos-admin,firmware,labtools,minilayout" name="infra/luci/client-py" path="chromite/third_party/swarming.client" remote="chromium" revision="34b20305c7a69eb89e1abd5e2a94708db999f0a9"/>
<project name="linux-syscall-support" path="src/third_party/breakpad/src/third_party/lss" revision="8048ece6c16c91acfe0d36d1d3cc0890ab6e945c"/>
<project name="platform/external/bsdiff" path="src/aosp/external/bsdiff" remote="aosp" revision="3153f95a452fd9d7771b8f0395d4355839c4be0c" upstream="refs/heads/master"/>
<project name="platform/external/libcxx" path="src/aosp/external/libcxx" remote="aosp" revision="32e8014cfb73ddcc4f25d9780aae7fed90ab05d7" upstream="refs/heads/master"/>
<project name="platform/external/libcxxabi" path="src/aosp/external/libcxxabi" remote="aosp" revision="8920c61b6bfd666e1c45c1f2b8a2ebc3400db648" upstream="refs/heads/master"/>
<project name="platform/external/libunwind_llvm" path="src/aosp/external/libunwind_llvm" remote="aosp" revision="9e1eb2ff225347aec5f9f8fc4ee19df0c03e8576" upstream="refs/heads/master"/>
<project name="platform/external/minijail" path="src/aosp/external/minijail" remote="aosp" revision="056955ceed2aac3f53a345c079a312088028a7cc" upstream="refs/heads/master"/>
<project name="platform/external/puffin" path="src/aosp/external/puffin" remote="aosp" revision="bc7745523aef2d7f620ca16aa6ab11a8e38dc60e" upstream="refs/heads/master"/>
<project name="platform/system/keymaster" path="src/aosp/system/keymaster" remote="aosp" revision="49dfc58d6c4c66f5d0b0d06f0161da4e602a1293" upstream="refs/heads/pie-release"/>
<project name="toolchain/binutils" path="src/aosp/toolchain/binutils" remote="aosp" revision="cce69c1b1bfc46de5e1cdd4923f87215c0edb884"/>
<project name="toolchain/gcc" path="src/aosp/toolchain/gcc" remote="aosp" revision="ac6128e0a17a52f011797f33ac3e7d6273a9368d"/>
<project name="weave/libweave" path="src/weave/libweave" revision="87e56c8b19ceabf3e8e9c75a208b410bd1d3d478" upstream="refs/heads/master"/>
<repo-hooks enabled-list="pre-upload" in-project="chromiumos/repohooks"/>
<pending_commit branch="master" change_id="I9c99dbecdea272835284747cc58d2fac06609441" commit="9db91e400f7e62c358153717b9825d13cc8bae56" commit_message="policy_NotificationsAllowedForUrls: Add missing 'raise' This test is creating an exception without raising it, which means that it will be immediately discarded without effect and the test continues running, potentially &quot;passing&quot; when it should have failed. This patch adds the missing 'raise' statement to fix the issue. BUG=chromium:1005893 TEST=None Change-Id: I9c99dbecdea272835284747cc58d2fac06609441 Signed-off-by: Julius Werner &lt;jwerner@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1814941 Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Katherine Threlkeld &lt;kathrelkeld@chromium.org&gt; " fail_count="5" gerrit_number="1814941" owner_email="jwerner@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/41/1814941/3" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I4c9a947ec82d54542698caae414a80c7b9c66449" commit="2a136e93122668deb4a4f6df134c4fe679a07b52" commit_message="platform_Pkcs11LoadPerf: Add missing 'raise' This test is creating an exception without raising it, which means that it will be immediately discarded without effect and the test continues running, potentially &quot;passing&quot; when it should have failed. This patch adds the missing 'raise' statement to fix the issue. BUG=chromium:1005893 TEST=None Change-Id: I4c9a947ec82d54542698caae414a80c7b9c66449 Signed-off-by: Julius Werner &lt;jwerner@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1814942 Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Rohit Makasana &lt;rohitbm@chromium.org&gt; " fail_count="5" gerrit_number="1814942" owner_email="jwerner@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/42/1814942/3" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I5f3358ec9652fa8823e6f820abfc3fab87791041" commit="cb1058761da633251f622f1b40233eeeb8f14d60" commit_message="bluetooth_RegressionServer: Add missing 'raise' This test is creating an exception without raising it, which means that it will be immediately discarded without effect and the test continues running, potentially &quot;passing&quot; when it should have failed. This patch adds the missing 'raise' statement to fix the issue. BUG=chromium:1005893 TEST=None Change-Id: I5f3358ec9652fa8823e6f820abfc3fab87791041 Signed-off-by: Julius Werner &lt;jwerner@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1814948 Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Katherine Threlkeld &lt;kathrelkeld@chromium.org&gt; " fail_count="5" gerrit_number="1814948" owner_email="jwerner@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/48/1814948/3" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I4aa301a4d90ced909597cd3e54e1bae7b43cd969" commit="f5df793b509fdb02e45654e887fe410558b23303" commit_message="Delete hardware_TPMFirmwareServer This was the server half of a test that was already removed 5 years ago (CL:201806). Nobody involved in it is still on the team. BUG=chromium:1005893 TEST=None Change-Id: I4aa301a4d90ced909597cd3e54e1bae7b43cd969 Signed-off-by: Julius Werner &lt;jwerner@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1814949 Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Joel Kitching &lt;kitching@chromium.org&gt; " fail_count="5" gerrit_number="1814949" owner_email="jwerner@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/49/1814949/3" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I97767ce50683ae3217ffcd1cfae07211fb9fa704" commit="26dd31a343e8f81d1f9b16e012239c91cf0026c2" commit_message="cros.power_status: Add missing 'raise' This test is creating an exception without raising it, which means that it will be immediately discarded without effect and the test continues running, potentially &quot;passing&quot; when it should have failed. This patch adds the missing 'raise' statement to fix the issue. BUG=chromium:1005893 TEST=None Change-Id: I97767ce50683ae3217ffcd1cfae07211fb9fa704 Signed-off-by: Julius Werner &lt;jwerner@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1816303 Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Todd Broch &lt;tbroch@chromium.org&gt; " fail_count="6" gerrit_number="1816303" owner_email="jwerner@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/03/1816303/1" remote="cros" total_fail_count="6"/><pending_commit branch="master" change_id="Ic4c19e2024577ae377f7cf3e1903097c90f3198d" commit="16fc8ea40cf3224af899076fb016b44c8625fd23" commit_message="cros.ec: Add missing 'raise' This test is creating an exception without raising it, which means that it will be immediately discarded without effect and the test continues running, potentially &quot;passing&quot; when it should have failed. This patch adds the missing 'raise' statement to fix the issue. BUG=chromium:1005893 TEST=None Change-Id: Ic4c19e2024577ae377f7cf3e1903097c90f3198d Signed-off-by: Julius Werner &lt;jwerner@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1816304 Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Todd Broch &lt;tbroch@chromium.org&gt; " fail_count="6" gerrit_number="1816304" owner_email="jwerner@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/04/1816304/1" remote="cros" total_fail_count="6"/><pending_commit branch="master" change_id="I7af0a4c02b910b8e5c334aa34d68fd44e114986a" commit="bd55c6c0de29f72fae559f2fc9c1a8cc3cd3844d" commit_message="faft: Add Tpm.GetTpmVersion RPC For some FAFT tests it is necessary to distinguish whether the DUT uses a TPM 1.2 or 2.0 (cr50). This patch adds an RPC to the existing Tpm service to query this information. BUG=chromium:1005893 TEST=With next patch. Change-Id: I7af0a4c02b910b8e5c334aa34d68fd44e114986a Signed-off-by: Julius Werner &lt;jwerner@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1817130 Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Andrey Pronin &lt;apronin@chromium.org&gt; Reviewed-by: Greg Edelston &lt;gredelston@google.com&gt; " fail_count="3" gerrit_number="1817130" owner_email="jwerner@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/30/1817130/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I829b87d0538b13f8753f103428b3b3ad6645ece2" commit="febe470b9a1f5ab3c7d0ce769a6bb990b2b5fbd2" commit_message="firmware_TPMExtend: Fix test and add TPM 2.0 support firmware_TPMExtend is supposed to test whether vboot correctly extends the TPM PCRs on boot. Unfortunately, while the PCR test itself works fine (for TPM 1.2), the test has a bug that causes it to &quot;pass&quot; even when it found errors in the PCRs. This patch fixes this issue. This test was written before the introduction of TPM 2.0, and since it never failed we never realized that we needed to update it for that. Now that it is again working correctly, it would fail on all TPM 2.0 devices, so this patch also adds the code to support those. BUG=chromium:1005893 TEST=Ran on Kevin and Scarlet. Change-Id: I829b87d0538b13f8753f103428b3b3ad6645ece2 Signed-off-by: Julius Werner &lt;jwerner@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1817131 Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Andrey Pronin &lt;apronin@chromium.org&gt; Reviewed-by: Wai-Hong Tam &lt;waihong@google.com&gt; " fail_count="3" gerrit_number="1817131" owner_email="jwerner@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/31/1817131/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I0bf0ab764d33f022db662f3c9d66b7a97758c178" commit="a53c86f3817c9e7471d95e0a8d8863537a29321d" commit_message="UPSTREAM: qcom: add firmware files for Adreno A3xx Symlinks have been added because existing driver in mainline kernel is already merged and expects the files there. For future version of the firmware (or newer hardware) we will fixup the search path, but the symlinks are needed to work with released kernels. Signed-off-by: Nicolas Dechesne &lt;nicolas.dechesne@linaro.org&gt; (cherry picked from commit 9a0a0548a7bb02d052318ed8f5333005773878f2) BUG=b:118771034 TEST=Check that Adreno firmwares are deployed to cheza Change-Id: I0bf0ab764d33f022db662f3c9d66b7a97758c178 Signed-off-by: Kristian H. Kristensen &lt;hoegsberg@google.com&gt; Reviewed-on: https://chromium-review.googlesource.com/1822632 Tested-by: Kristian H. Kristensen &lt;hoegsberg@chromium.org&gt; Commit-Ready: Douglas Anderson &lt;dianders@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Douglas Anderson &lt;dianders@chromium.org&gt; " fail_count="2" gerrit_number="1822632" owner_email="hoegsberg@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/linux-firmware" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/linux-firmware" ref="refs/changes/32/1822632/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Iffa344b59aea29f319ae5cf94a1ad67dfecd35a1" commit="fe84aa9e4f32cca1dea9c7d9b826fe9970440432" commit_message="UPSTREAM: qcom: add firmware files for Adreno a530 Signed-off-by: Nicolas Dechesne &lt;nicolas.dechesne@linaro.org&gt; (cherry picked from commit f36a8e2199da8ec7315a5e766766dc93b22320cc) BUG=b:118771034 TEST=Check that Adreno firmwares are deployed to cheza Change-Id: Iffa344b59aea29f319ae5cf94a1ad67dfecd35a1 Signed-off-by: Kristian H. Kristensen &lt;hoegsberg@google.com&gt; Reviewed-on: https://chromium-review.googlesource.com/1822633 Tested-by: Kristian H. Kristensen &lt;hoegsberg@chromium.org&gt; Commit-Ready: Douglas Anderson &lt;dianders@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Douglas Anderson &lt;dianders@chromium.org&gt; " fail_count="2" gerrit_number="1822633" owner_email="hoegsberg@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/linux-firmware" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/linux-firmware" ref="refs/changes/33/1822633/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I7be1219c42cc448a0ba45184857e33e1a7f0a5df" commit="9e75ba98133ce0e129b629869982806eabc342ea" commit_message="UPSTREAM: qcom: add firmware files for Adreno a630 Signed-off-by: Nicolas Dechesne &lt;nicolas.dechesne@linaro.org&gt; (cherry picked from commit 88ea23e7eed04e78111013df9b81dd851037e4da) BUG=b:118771034 TEST=Check that Adreno firmwares are deployed to cheza Change-Id: I7be1219c42cc448a0ba45184857e33e1a7f0a5df Signed-off-by: Kristian H. Kristensen &lt;hoegsberg@google.com&gt; Reviewed-on: https://chromium-review.googlesource.com/1822634 Tested-by: Kristian H. Kristensen &lt;hoegsberg@chromium.org&gt; Commit-Ready: Douglas Anderson &lt;dianders@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Douglas Anderson &lt;dianders@chromium.org&gt; " fail_count="2" gerrit_number="1822634" owner_email="hoegsberg@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/linux-firmware" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/linux-firmware" ref="refs/changes/34/1822634/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I0ea730ac3f827a8e63b42f6bb2a3f58eee373310" commit="b16e0eedcbff4a180d10570c8f556348ead231ac" commit_message="linux-firmware: Add Adreno 630 firmware BUG=b:118771034 TEST=Check that Adreno firmwares are deployed to cheza Cq-Depend: chromium:1822634 Change-Id: I0ea730ac3f827a8e63b42f6bb2a3f58eee373310 Reviewed-on: https://chromium-review.googlesource.com/1823254 Tested-by: Kristian H. Kristensen &lt;hoegsberg@chromium.org&gt; Commit-Ready: Douglas Anderson &lt;dianders@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Douglas Anderson &lt;dianders@chromium.org&gt; " fail_count="0" gerrit_number="1823254" owner_email="hoegsberg@chromium.org" pass_count="0" patch_number="7" project="chromiumos/overlays/chromiumos-overlay" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay" ref="refs/changes/54/1823254/7" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="Ia3afdeae50ea24f068b55af4f5b04559b823656b" commit="37381bbc9b564686388908074ffd3574c2a31caf" commit_message="baseboard-cheza: Get firmware from linux-firmware BUG=b:118771034 TEST=Check that Adreno firmwares are deployed to cheza Change-Id: Ia3afdeae50ea24f068b55af4f5b04559b823656b Cq-Depend: chrome-internal:1874421, chromium:1823254 Reviewed-on: https://chromium-review.googlesource.com/1825264 Tested-by: Kristian H. Kristensen &lt;hoegsberg@chromium.org&gt; Commit-Ready: Douglas Anderson &lt;dianders@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Douglas Anderson &lt;dianders@chromium.org&gt; " fail_count="0" gerrit_number="1825264" owner_email="hoegsberg@chromium.org" pass_count="0" patch_number="2" project="chromiumos/overlays/board-overlays" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/board-overlays" ref="refs/changes/64/1825264/2" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I1c823e72c8317b969c48aa31ee7d13bd2e57bc84" commit="9ece8cbad175f3cdb7c06cfa3b95a70df0846f7a" commit_message="crosh: Hide module messages when executing a single command only. This makes it possible for rust-crosh to call into crosh.sh for printing command help without the module loading messages spamming the output. BUG=chromium:979224 TEST=crosh -- help top Change-Id: I1c823e72c8317b969c48aa31ee7d13bd2e57bc84 Reviewed-on: https://chromium-review.googlesource.com/1814887 Tested-by: Allen Webb &lt;allenwebb@google.com&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="1" gerrit_number="1814887" owner_email="allenwebb@google.com" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/87/1814887/3" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="I29a0d8beab6ae2b864e33312b64aa9b372b63301" commit="75a804055efecdc511f0df8dfefede85cdc7e862" commit_message="crosh: Add dispatcher, legacy, and util modules. The dispatcher module provides support for * registering command handlers (as well as subcommand handlers) * parsing command switches/flags * completing partially entered commands The legacy module registers existing crosh commands that are forwarded to the original implementation. The util module provides reusable helpers. BUG=chromium:979224 TEST=FEATURES=test emerge-${BOARD} crosh Cq-Depend: chromium:1816954 Change-Id: I29a0d8beab6ae2b864e33312b64aa9b372b63301 Reviewed-on: https://chromium-review.googlesource.com/1793292 Tested-by: Allen Webb &lt;allenwebb@google.com&gt; Commit-Ready: Allen Webb &lt;allenwebb@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="0" gerrit_number="1793292" owner_email="allenwebb@google.com" pass_count="0" patch_number="21" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/92/1793292/21" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="If80a30fe158f855b25f529e662dc8c33ff31791c" commit="8e5a3b70c640159af1ad83a2beb2c365508084f0" commit_message="crosh: Add basic command history functionality. This adds soft up and down arrow support for cycling through command history. The history does not yet persist. BUG=chromium:979224 TEST=FEATURES=test emerge-${BOARD} crosh Change-Id: If80a30fe158f855b25f529e662dc8c33ff31791c Reviewed-on: https://chromium-review.googlesource.com/1804229 Tested-by: Allen Webb &lt;allenwebb@google.com&gt; Commit-Ready: Allen Webb &lt;allenwebb@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Zach Reizner &lt;zachr@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="0" gerrit_number="1804229" owner_email="allenwebb@google.com" pass_count="0" patch_number="14" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/29/1804229/14" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="Ib2c92e995149e0e3fa90c50a2ce717312b7e2441" commit="37f22e4a47f7c0d583a2012168f22d7a6158e0b3" commit_message="crosh: Add rust implementation of set_time. This serves as an example implemenation of a crosh command that previously depended on dbus-send. BUG=chromium:979224 TEST=sudo -u chronos crosh -- set_time today Change-Id: Ib2c92e995149e0e3fa90c50a2ce717312b7e2441 Reviewed-on: https://chromium-review.googlesource.com/1797266 Tested-by: Allen Webb &lt;allenwebb@google.com&gt; Commit-Ready: Allen Webb &lt;allenwebb@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="0" gerrit_number="1797266" owner_email="allenwebb@google.com" pass_count="0" patch_number="21" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/66/1797266/21" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I027106babb80511e68a1ff63c7736c5778fd89e7" commit="134e4fd11364356bbb2a9c5aa2fa9a804b8a7178" commit_message="crosh: Add rust implementation of shell. Implement the first dev-mode-only command in rust. 'shell' was chosen because it is particularly sensitive to how forking and stdin are handled so it is nice for testing. BUG=chromium:979224 TEST=sudo -u chronos crosh -- shell Change-Id: I027106babb80511e68a1ff63c7736c5778fd89e7 Reviewed-on: https://chromium-review.googlesource.com/1799395 Tested-by: Allen Webb &lt;allenwebb@google.com&gt; Commit-Ready: Allen Webb &lt;allenwebb@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="0" gerrit_number="1799395" owner_email="allenwebb@google.com" pass_count="0" patch_number="21" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/95/1799395/21" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I02540f8cfd23c6fe9ac89652006f0989acff08ea" commit="e4d97ea821a20252cab048e8c9c8a1efa8018dd8" commit_message="crosh: Add rust implementation of vmc. BUG=chromium:979224 TEST=sudo -u chronos crosh -- vmc Change-Id: I02540f8cfd23c6fe9ac89652006f0989acff08ea Reviewed-on: https://chromium-review.googlesource.com/1802667 Tested-by: Allen Webb &lt;allenwebb@google.com&gt; Commit-Ready: Allen Webb &lt;allenwebb@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="0" gerrit_number="1802667" owner_email="allenwebb@google.com" pass_count="0" patch_number="15" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/67/1802667/15" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I74f839681328b3434c907f09f8da5f8e0e32286f" commit="7d4e9a985b90e13dff0b96859aa87214b0e452d0" commit_message="Revert &quot;arc: network: migrate to generalized MOCK_METHOD() macro&quot; This reverts commit 90af0bc2af03de44559fbd7ab030ea358b1bb8d5. Reason for revert: This cl causes CQ very flaky crbug/1001290 Original change's description: &gt; arc: network: migrate to generalized MOCK_METHOD() macro &gt; &gt; This CL replaces the uses of MOCK_METHOD*() and MOCK_CONST_METHOD*() &gt; macros in unit tests with the generalized MOCK_METHOD() macro, which is &gt; now the recommended way to define mocked methods with gmock. In &gt; particular, MOCK_METHOD() supports annotating a mocked method with &gt; specifiers such as 'override'. &gt; &gt; BUG=None &gt; TEST=Run unit tests. &gt; &gt; Change-Id: I747d7e0f3a20eb28a35281f399e5969645e1f726 &gt; Reviewed-on: https://chromium-review.googlesource.com/1817340 &gt; Tested-by: Ben Chan &lt;benchan@google.com&gt; &gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; &gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; &gt; Reviewed-by: Eric Caruso &lt;ejcaruso@chromium.org&gt; BUG=chromium:1001290 Exempt-From-Owner-Approval: Speculative fix for networking unstability in ARC tests Change-Id: I74f839681328b3434c907f09f8da5f8e0e32286f Reviewed-on: https://chromium-review.googlesource.com/1824405 Tested-by: Shuhei Takahashi &lt;nya@chromium.org&gt; Commit-Ready: Long Cheng &lt;lgcheng@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Yuichiro Hanada &lt;yhanada@chromium.org&gt; " fail_count="3" gerrit_number="1824405" owner_email="yhanada@chromium.org" pass_count="0" patch_number="4" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/05/1824405/4" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I5749a93d76c56e3ac9ac35e56242407cc7d7c1ff" commit="927e7b8f9bd839e8e8864b767989992aef01d037" commit_message="Revert &quot;arc: networkd: Remove ip helper.&quot; This reverts commit 965578087f75a5eff8479985654c4c945f335e0f. Reason for revert: This cl causes CQ very flaky crbug/1001290 Original change's description: &gt; arc: networkd: Remove ip helper. &gt; &gt; This patch completes the refactoring and deletes the helper process code. &gt; It also removes most of the proto definition that supported it but some &gt; remains for future clean up. &gt; &gt; BUG=b:136695230 &gt; BUG=b:133194105 &gt; TEST=manual betty, nocturne &gt; &gt; Change-Id: I09d26a1b5be867cceb2d833ce7256e6ae985525e &gt; Reviewed-on: https://chromium-review.googlesource.com/1727636 &gt; Tested-by: Garrick Evans &lt;garrick@chromium.org&gt; &gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; &gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; &gt; Reviewed-by: Hugo Benichi &lt;hugobenichi@google.com&gt; BUG=b:136695230, b:133194105 BUG=chromium:1001290 Exempt-From-Owner-Approval: Speculative fix for networking unstability in ARC tests Change-Id: I5749a93d76c56e3ac9ac35e56242407cc7d7c1ff Reviewed-on: https://chromium-review.googlesource.com/1822958 Tested-by: Shuhei Takahashi &lt;nya@chromium.org&gt; Commit-Ready: Long Cheng &lt;lgcheng@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Abhishek Bhardwaj &lt;abhishekbh@chromium.org&gt; Reviewed-by: Sean Abraham &lt;seanabraham@chromium.org&gt; " fail_count="3" gerrit_number="1822958" owner_email="lgcheng@google.com" pass_count="0" patch_number="4" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/58/1822958/4" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I5a41ad9c16289ad12b1169e0169c6e8f089cc3f2" commit="3162e854b78eb0d481951317811e6772df93e3ac" commit_message="Revert &quot;arc: networkd: Move IPv6 configuration into ArcService&quot; This reverts commit 6467aba174eb3b0b5eaee2a1f7e824ffa0c2d4d0. Reason for revert: This cl causes CQ very flaky crbug/1001290 Original change's description: &gt; arc: networkd: Move IPv6 configuration into ArcService &gt; &gt; This patch refactors the IPv6 codes from ArcIpConfig into ArcSerivice. &gt; Relevant logic is also moved into Datapath. &gt; ArcIpConfig is also removed as it's no longer used. &gt; &gt; TODO: Obselete unit tests were removed but new ones must be added to &gt; cover the refactored functionality. &gt; &gt; BUG=b:136688327 &gt; BUG=b:133194105 &gt; BUG=b:136695230 &gt; TEST=units, manual, suite:bvt-arc &gt; &gt; Change-Id: Ibbcef998968dbb25802aa5027a7f266f280a6543 &gt; Reviewed-on: https://chromium-review.googlesource.com/1727635 &gt; Tested-by: Garrick Evans &lt;garrick@chromium.org&gt; &gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; &gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; &gt; Reviewed-by: Hugo Benichi &lt;hugobenichi@google.com&gt; BUG=b:136688327, b:133194105, b:136695230 BUG=chromium:1001290 Exempt-From-Owner-Approval: Speculative fix for networking unstability in ARC tests Cq-Depend: chromium:1822958 Change-Id: I5a41ad9c16289ad12b1169e0169c6e8f089cc3f2 Reviewed-on: https://chromium-review.googlesource.com/1822506 Tested-by: Shuhei Takahashi &lt;nya@chromium.org&gt; Commit-Ready: Long Cheng &lt;lgcheng@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Abhishek Bhardwaj &lt;abhishekbh@chromium.org&gt; Reviewed-by: Sean Abraham &lt;seanabraham@chromium.org&gt; " fail_count="4" gerrit_number="1822506" owner_email="lgcheng@google.com" pass_count="0" patch_number="10" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/06/1822506/10" remote="cros" total_fail_count="6"/><pending_commit branch="master" change_id="Ibe3d65098c5271dfc7badfe6b7f986d48d3cb141" commit="0a3ec22303d13f06495c774da6f201667a2ea315" commit_message="Revert &quot;arc: networkd: Move setup and teardown logic into ArcService.&quot; This reverts commit ac982ead352d6c5933e6e13ed01ad375a3a671e6. Reason for revert: This cl causes CQ very flaky crbug/1001290 Cq-Depend: chromium:1822506 Original change's description: &gt; arc: networkd: Move setup and teardown logic into ArcService. &gt; &gt; This patch refactors the setup/teardown, init/uninit and enable/disable code &gt; from ArcIpConfig into ArcService. Earlier attempts to break each logical unit &gt; into multicle CLs caused too many problems given the timing and interconencted &gt; nature of these pieces, due largely to the fact that the functionality was &gt; beig split across processes. &gt; &gt; Another key change in this patch is the gating of enable/disable on both sides &gt; of the veth pair being up. This is achieved by DeviceManager listening to rt &gt; netlink messages on the host and ArcService doing the same in the container's &gt; net namespace. Doing so, guarantees that once IPv6 route detection and address &gt; assignment runs, it can set up the datapath and configuration immediately. &gt; One caveat here is that the device keeps state that is currently specific to &gt; the ARC guest alone. This will have to be expanded, if necessary, to accomodate &gt; others. &gt; &gt; More functionality is moved into Datapath from ArcIpConfig. &gt; In order to add DeviceManager unit testing, a base class was added for mocking. &gt; ArcIpConfig unit test removed since it is no longer relevant. &gt; TODO: Add relevant tests to ArcSeviceTest &gt; &gt; BUG=b:133194105 &gt; BUG=b:136688327 &gt; BUG=b:136695230 &gt; TEST=units, manual andsuite:bvt-arc on nocturne &gt; &gt; Change-Id: Ibc3bd7134baa0eb8e7d1215e0709b50ac6e6fc31 &gt; Reviewed-on: https://chromium-review.googlesource.com/1727633 &gt; Tested-by: Garrick Evans &lt;garrick@chromium.org&gt; &gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; &gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; &gt; Reviewed-by: Hugo Benichi &lt;hugobenichi@google.com&gt; BUG=b:133194105, b:136688327, b:136695230 BUG=chromium:1001290 Exempt-From-Owner-Approval: Speculative fix for networking unstability in ARC tests Change-Id: Ibe3d65098c5271dfc7badfe6b7f986d48d3cb141 Reviewed-on: https://chromium-review.googlesource.com/1822508 Tested-by: Shuhei Takahashi &lt;nya@chromium.org&gt; Commit-Ready: Long Cheng &lt;lgcheng@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Abhishek Bhardwaj &lt;abhishekbh@chromium.org&gt; Reviewed-by: Sean Abraham &lt;seanabraham@chromium.org&gt; " fail_count="4" gerrit_number="1822508" owner_email="lgcheng@google.com" pass_count="0" patch_number="7" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/08/1822508/7" remote="cros" total_fail_count="6"/><pending_commit branch="master" change_id="Ie8cc3771db480b7be529dc90cacf12ed2e37f351" commit="7d89b4059c7bef123dc158d45fdf95e69209bfc1" commit_message="Revert &quot;arc: networkd: DeviceManager listens to all shill events always.&quot; This reverts commit a2a0e930e12f7f94715a9a94ab5c644cb89e9494. Reason for revert: This cl causes CQ very flaky crbug/1001290 Cq-Depend: chromium:1822508 Original change's description: &gt; arc: networkd: DeviceManager listens to all shill events always. &gt; &gt; Previously, arc-networkd would register/unregister shill handlers &gt; when ARC++ booted up or shut down, respectively. But in a multi-guest &gt; world, it needs to be aware of the host devices independent of guest &gt; lifecyles. And more specifically, for ARCVM it needs to be aware at &gt; VM boot time. &gt; &gt; BUG=b:133193765 &gt; TEST=units, TODO &gt; &gt; Change-Id: I79268587b8fa85eba74ccfb438dd35266e4f0336 &gt; Reviewed-on: https://chromium-review.googlesource.com/1707790 &gt; Tested-by: Garrick Evans &lt;garrick@chromium.org&gt; &gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; &gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; &gt; Reviewed-by: Hugo Benichi &lt;hugobenichi@google.com&gt; BUG=b:133193765 BUG=chromium:1001290 Exempt-From-Owner-Approval: Speculative fix for networking unstability in ARC tests Change-Id: Ie8cc3771db480b7be529dc90cacf12ed2e37f351 Reviewed-on: https://chromium-review.googlesource.com/1822510 Tested-by: Shuhei Takahashi &lt;nya@chromium.org&gt; Commit-Ready: Long Cheng &lt;lgcheng@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Abhishek Bhardwaj &lt;abhishekbh@chromium.org&gt; Reviewed-by: Sean Abraham &lt;seanabraham@chromium.org&gt; " fail_count="4" gerrit_number="1822510" owner_email="lgcheng@google.com" pass_count="0" patch_number="6" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/10/1822510/6" remote="cros" total_fail_count="6"/><pending_commit branch="master" change_id="I3f407d866fea7eac656adcff48d9b0bd33b04cbe" commit="bea7240cc32a29dbcfc7514732911b9e743b0afc" commit_message="Revert &quot;arc: networkd: Begin refactoring to remove ip helper process.&quot; This reverts commit 5b55c5c1cb8082a3101f92b4d21c4db68372cc58. Reason for revert: This cl causes CQ very flaky crbug/1001290 Original change's description: &gt; arc: networkd: Begin refactoring to remove ip helper process. &gt; &gt; This patch is the first in a series to migrate all datapath &gt; configuration into the main process. It introduces the guest &gt; service construct and adds a placeh-holder implementation &gt; for the existing ARC++ code, and wires in the lifecycle events, &gt; &gt; BUG=b:133193765 &gt; BUG=b:133194026 &gt; BUG=b:136695230 &gt; TEST=units &gt; &gt; Change-Id: If17f32cf66b4228aabdd2fc12a49c9ffd9e9a28b &gt; Reviewed-on: https://chromium-review.googlesource.com/1707789 &gt; Tested-by: Garrick Evans &lt;garrick@chromium.org&gt; &gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; &gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; &gt; Reviewed-by: Hugo Benichi &lt;hugobenichi@google.com&gt; BUG=b:133193765, b:133194026, b:136695230 BUG=chromium:1001290 Exempt-From-Owner-Approval: Speculative fix for networking unstability in ARC tests Change-Id: I3f407d866fea7eac656adcff48d9b0bd33b04cbe Reviewed-on: https://chromium-review.googlesource.com/1822511 Tested-by: Cheng-Yi Chiang &lt;cychiang@chromium.org&gt; Commit-Ready: Long Cheng &lt;lgcheng@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Abhishek Bhardwaj &lt;abhishekbh@chromium.org&gt; Reviewed-by: Sean Abraham &lt;seanabraham@chromium.org&gt; " fail_count="3" gerrit_number="1822511" owner_email="lgcheng@google.com" pass_count="0" patch_number="7" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/11/1822511/7" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I08381180012248a75afa51918c7f4c0b6ef4ddfa" commit="cd4413dd704859af2c3b43cfa3da2d7f82095462" commit_message="baseboard-trogdor: Get firmware from linux-firmware BUG=b:141640845 TEST=Check that Adreno firmwares are deployed to trogdor Change-Id: I08381180012248a75afa51918c7f4c0b6ef4ddfa Cq-Depend: chromium:1823254 Reviewed-on: https://chromium-review.googlesource.com/1825265 Tested-by: Kristian H. Kristensen &lt;hoegsberg@chromium.org&gt; Commit-Ready: Kristian H. Kristensen &lt;hoegsberg@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Douglas Anderson &lt;dianders@chromium.org&gt; " fail_count="0" gerrit_number="1825265" owner_email="hoegsberg@chromium.org" pass_count="0" patch_number="1" project="chromiumos/overlays/board-overlays" project_url="https://chromium-review.googlesource.com/chromiumos/overlays/board-overlays" ref="refs/changes/65/1825265/1" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I259e63563348b6d4a5a66d34fe21480799d5d6fc" commit="c73d063cfeb39498684528d02f371879477f3c0e" commit_message="cryptohome: Add CRYPTOHOME_ERROR_TPM_UPDATE_REQUIRED to UserDataAuth CRYPTOHOME_ERROR_TPM_UPDATE_REQUIRED is added in cryptohome:: but not user_data_auth:: BUG=none TEST=FEATURES=test USE=cryptohome_userdataauth_interface emerge-$BOARD cryptohome Change-Id: I259e63563348b6d4a5a66d34fe21480799d5d6fc Reviewed-on: https://chromium-review.googlesource.com/1792684 Tested-by: John L Chen &lt;zuan@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Andrey Pronin &lt;apronin@chromium.org&gt; " fail_count="6" gerrit_number="1792684" owner_email="zuan@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/84/1792684/2" remote="cros" total_fail_count="13"/><pending_commit branch="master" change_id="I46c1902af568a0d644fc76d6c3750fbfe3114dc6" commit="4d3c2b7b5c482e596a1253ee32cceafea66fe0a3" commit_message="cryptohome: Add GetStatusString to UserDataAuth and proxy Add GetStatusString() to UserDataAuth interface and cryptohome-proxy. BUG=b:123564547 TEST=dbus-send &amp;&amp; FEATURES=test USE=cryptohome_userdataauth_interface emerge-eve cryptohome Change-Id: I46c1902af568a0d644fc76d6c3750fbfe3114dc6 Reviewed-on: https://chromium-review.googlesource.com/1708811 Tested-by: John L Chen &lt;zuan@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Leo Lai &lt;cylai@google.com&gt; " fail_count="6" gerrit_number="1708811" owner_email="zuan@chromium.org" pass_count="0" patch_number="8" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/11/1708811/8" remote="cros" total_fail_count="10"/><pending_commit branch="master" change_id="I68a35c61c4c6345483151ac97e26a8b6acfd6c5a" commit="3ad3a99a29a1c94b06d2044c991b49a2306ec5e5" commit_message="cryptohome: Add GetTpmStatus to cryptohome-proxy Add GetTpmStatus() to cryptohome-proxy and add its associated unit tests. BUG=b:128271460 TEST=dbus-send &amp;&amp; FEATURES=test USE=cryptohome_new_interface emerge-eve cryptohome Change-Id: I68a35c61c4c6345483151ac97e26a8b6acfd6c5a Reviewed-on: https://chromium-review.googlesource.com/1708812 Tested-by: John L Chen &lt;zuan@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Wei-Cheng Xiao &lt;garryxiao@chromium.org&gt; " fail_count="6" gerrit_number="1708812" owner_email="zuan@chromium.org" pass_count="0" patch_number="9" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/12/1708812/9" remote="cros" total_fail_count="11"/><pending_commit branch="master" change_id="Ie454260a66f979e7ac447b6e3c4a06a5c8fb53cc" commit="60d701e61d3ed751a8b35bf1a33b449bff24b471" commit_message="cryptohome: Add TpmGetVersionStructured() to cryptohome-proxy Add TpmGetVersionStructured() to cryptohome-proxy and add its associated unit tests. BUG=b:128271460 TEST=dbus-send &amp;&amp; FEATURES=test USE=cryptohome_new_interface emerge-eve cryptohome Change-Id: Ie454260a66f979e7ac447b6e3c4a06a5c8fb53cc Reviewed-on: https://chromium-review.googlesource.com/1708813 Tested-by: John L Chen &lt;zuan@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Leo Lai &lt;cylai@google.com&gt; " fail_count="6" gerrit_number="1708813" owner_email="zuan@chromium.org" pass_count="0" patch_number="9" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/13/1708813/9" remote="cros" total_fail_count="11"/><pending_commit branch="master" change_id="I5ada1e852ef245d970ad631fd15626e5b0583685" commit="4d91870cdb394c172053912e7d008abf33f6d4a1" commit_message="smbfs: Implement SMB read directory BUG=chromium:939235 TEST=Build/deploy to chell, mount an unauthenticated share, and browse the share using 'cd' and 'ls -l'. Cq-Depend: chromium:1781985 Change-Id: I5ada1e852ef245d970ad631fd15626e5b0583685 Reviewed-on: https://chromium-review.googlesource.com/1786528 Tested-by: Anand Mistry &lt;amistry@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Austin Tankiang &lt;austinct@chromium.org&gt; Reviewed-by: François Degros &lt;fdegros@chromium.org&gt; " fail_count="3" gerrit_number="1786528" owner_email="amistry@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/28/1786528/3" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Iff96a4662e05928aa5151033812c7e6429958024" commit="2a9cbd9cf6daf63e2b325658fb6544fa0455d827" commit_message="smbfs: Implement file read/write. This allows for files to be created and opened for writing, but does not support truncation (i.e. O_TRUNC and truncate()). BUG=chromium:939235 TEST=Build/deploy to chell, mount an unauthenticated share, 'sha256sum &lt;file&gt; &gt; foo.sha' and verify sum written matches expected value, 'sha256sum &lt;file&gt; &gt;&gt; foo.sha' and verify sum is appended to file. Cq-Depend: chromium:1786528 Change-Id: Iff96a4662e05928aa5151033812c7e6429958024 Reviewed-on: https://chromium-review.googlesource.com/1786529 Tested-by: Anand Mistry &lt;amistry@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Austin Tankiang &lt;austinct@chromium.org&gt; Reviewed-by: François Degros &lt;fdegros@chromium.org&gt; " fail_count="3" gerrit_number="1786529" owner_email="amistry@chromium.org" pass_count="0" patch_number="7" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/29/1786529/7" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Ic3799e4c2a3f346dc4907d5c6ce032cff39e4a87" commit="26339be77a481032d8dbd62de6e2f4997b633896" commit_message="smbfs: Implement setattr for changing file size This allows file sizes to be changed using open(O_TRUNC) and truncate(). BUG=chromium:939235 TEST=Build/deploy to chell, mount an unauthenticated share, 'truncate -s 1000 &lt;file&gt;' and verify size of file is changed Cq-Depend: chromium:1786529 Change-Id: Ic3799e4c2a3f346dc4907d5c6ce032cff39e4a87 Reviewed-on: https://chromium-review.googlesource.com/1787767 Tested-by: Anand Mistry &lt;amistry@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Austin Tankiang &lt;austinct@chromium.org&gt; Reviewed-by: François Degros &lt;fdegros@chromium.org&gt; " fail_count="3" gerrit_number="1787767" owner_email="amistry@chromium.org" pass_count="0" patch_number="5" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/67/1787767/5" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I687a07b67866a3bf35062b82a4e51d2dbf26a2a0" commit="1c19eb7b8b653587c14e31e6e24ae234d582dba5" commit_message="smbfs: Improve request logging of flags and mode bits open() flags are decoded into a string of or'd flags as defined in the open man(2) page. Similarly, the |to_set| flags to SetAttr() are also decoded into the FUSE_SET_ATTR_* flags. mode bits are usually specified in octal. BUG=chromium:939235 TEST=Build/deploy to chell, mount an unauthenticated share with --log-level=-1, create/open files and see flags decoded in logs Cq-Depend: chromium:1774505 Change-Id: I687a07b67866a3bf35062b82a4e51d2dbf26a2a0 Reviewed-on: https://chromium-review.googlesource.com/1787768 Tested-by: Anand Mistry &lt;amistry@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Austin Tankiang &lt;austinct@chromium.org&gt; Reviewed-by: François Degros &lt;fdegros@chromium.org&gt; " fail_count="3" gerrit_number="1787768" owner_email="amistry@chromium.org" pass_count="0" patch_number="6" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/68/1787768/6" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I7fac853f4883ba0d9cea886fbfbcba82f40cc681" commit="b369c189fb0978d5f9eb82ee8435ab6443d4dfd9" commit_message="cryptohome: include &lt;utility&gt; for std::make_pair This CL addresses the following cpplint warning: user_oldest_activity_timestamp_cache.cc:47: Add #include &lt;utility&gt; for make_pair [build/include_what_you_use] [4] BUG=None TEST=Re-run cpplint on the updated file. TEST=Run unit tests. Change-Id: I7fac853f4883ba0d9cea886fbfbcba82f40cc681 Reviewed-on: https://chromium-review.googlesource.com/1817217 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Andrey Pronin &lt;apronin@chromium.org&gt; " fail_count="2" gerrit_number="1817217" owner_email="benchan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/17/1817217/3" remote="cros" total_fail_count="8"/><pending_commit branch="master" change_id="I1468ff3439ce28fb7448b55c4cd83fe8a3ffe598" commit="fdfe9b78c18a1ef28e01e69dc0063f110f75d60a" commit_message="cryptohome: remove empty test fixtures and tear down method BUG=None TEST=Run unit tests. Change-Id: I1468ff3439ce28fb7448b55c4cd83fe8a3ffe598 Reviewed-on: https://chromium-review.googlesource.com/1817218 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Andrey Pronin &lt;apronin@chromium.org&gt; " fail_count="2" gerrit_number="1817218" owner_email="benchan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/18/1817218/3" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I7de443c491bf112b3a671e485f282c4ddfd1654c" commit="b8994848fda591e8dc9b2a002e27bdcf1e130346" commit_message="cryptohome: clean up mocked methods This CL cleans up mocked methods as follows: - Remove methods in mocks that don't actually mock any method in their base class. - Fix mismatches in mocked methods so that they correctly mock their corresponding method in base class. - Make methods to be mocked a virtual method. BUG=None TEST=Run unit tests. Change-Id: I7de443c491bf112b3a671e485f282c4ddfd1654c Reviewed-on: https://chromium-review.googlesource.com/1817219 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Andrey Pronin &lt;apronin@chromium.org&gt; " fail_count="2" gerrit_number="1817219" owner_email="benchan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/19/1817219/3" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I71fc10bf310d8be65cf05b1be43c6ed12ae10a1f" commit="7f94db93289ed0b319fb7532c2653837df215a8c" commit_message="cryptohome: migrate to generalized MOCK_METHOD() macro This CL replaces the uses of MOCK_METHOD*() and MOCK_CONST_METHOD*() macros in unit tests with the generalized MOCK_METHOD() macro, which is now the recommended way to define mocked methods with gmock. In particular, MOCK_METHOD() supports annotating a mocked method with specifiers such as 'override'. One minor change is that argument names are omitted in the argument list provided to MOCK_METHOD() in order to prevent clang-format from formatting code like `Foo* foo` into `Foo * foo`. BUG=None TEST=Run unit tests. Change-Id: I71fc10bf310d8be65cf05b1be43c6ed12ae10a1f Reviewed-on: https://chromium-review.googlesource.com/1817220 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Andrey Pronin &lt;apronin@chromium.org&gt; " fail_count="2" gerrit_number="1817220" owner_email="benchan@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/20/1817220/3" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I1982af049844f295f7a96734056a23e48d9b5b2e" commit="15705246fca853626133060d7811b0b25df5d7e2" commit_message="chromeos-config: add fallback to mosys for non-unibuild platforms This reverts commit 68b7afd82c94c12a65c658dc5415d03fd200b21a. BUG=chromium:991653,b:140909519 TEST=sudo FEATURES=test emerge chromeos-config-tools Signed-off-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt; Change-Id: I1982af049844f295f7a96734056a23e48d9b5b2e Reviewed-on: https://chromium-review.googlesource.com/1809879 Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Abe Levkoy &lt;alevkoy@chromium.org&gt; Reviewed-by: Simon Glass &lt;sjg@chromium.org&gt; " fail_count="1" gerrit_number="1809879" owner_email="jrosenth@chromium.org" pass_count="0" patch_number="8" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/79/1809879/8" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Ice39d47a2198cde26da55589980767f01b90daa3" commit="0bb1f29491ea1edd437f67e0f68feee4d554077c" commit_message="chromeos-config: make matching logic match any default SKU Previously, the matching logic would allow selection of any sku-id when a negative SKU was given. Change to default SKU id. BUG=none TEST=sudo FEATURES=test emerge chromeos-config-tools Change-Id: Ice39d47a2198cde26da55589980767f01b90daa3 Signed-off-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1817339 Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Abe Levkoy &lt;alevkoy@chromium.org&gt; Reviewed-by: Simon Glass &lt;sjg@chromium.org&gt; " fail_count="1" gerrit_number="1817339" owner_email="jrosenth@chromium.org" pass_count="0" patch_number="8" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/39/1817339/8" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="Ic0f4d12b75ea1e4a2f0fbeaeba2139eab6fd2cf5" commit="bed4a930182d6056f8294c0fc78a5b12de5ecf63" commit_message="chromeos-config: change ASSERT to EXPECT in tests where appropriate EXPECT will allow the test to keep running, with the failure noted, if the assertion fails. It's better style to use EXPECT where we can. BUG=none TEST=sudo FEATURES=test emerge chromeos-config-tools Change-Id: Ic0f4d12b75ea1e4a2f0fbeaeba2139eab6fd2cf5 Signed-off-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1819843 Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Abe Levkoy &lt;alevkoy@chromium.org&gt; Reviewed-by: Simon Glass &lt;sjg@chromium.org&gt; " fail_count="0" gerrit_number="1819843" owner_email="jrosenth@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/43/1819843/1" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="Ieb220b47130a0faaecee201672540b98abeadbc9" commit="c51413c9a3114adc92ab26f6beeeeb02aa19e0e8" commit_message="permission_broker: use nullptr instead of NULL BUG=None TEST=Run unit tests. Change-Id: Ieb220b47130a0faaecee201672540b98abeadbc9 Reviewed-on: https://chromium-review.googlesource.com/1817402 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Jorge Lucangeli Obes &lt;jorgelo@chromium.org&gt; " fail_count="5" gerrit_number="1817402" owner_email="benchan@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/02/1817402/1" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="Idbb8e49b98470ffda0f7d082c5f9a322f52b9f14" commit="ff4a0fb65972bbcc599ebd8ffaae880bcc7454dc" commit_message="permission_broker: migrate to generalized MOCK_METHOD() macro This CL replaces the uses of MOCK_METHOD*() and MOCK_CONST_METHOD*() macros in unit tests with the generalized MOCK_METHOD() macro, which is now the recommended way to define mocked methods with gmock. In particular, MOCK_METHOD() supports annotating a mocked method with specifiers such as 'override'. BUG=None TEST=Run unit tests. Change-Id: Idbb8e49b98470ffda0f7d082c5f9a322f52b9f14 Reviewed-on: https://chromium-review.googlesource.com/1817403 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Jorge Lucangeli Obes &lt;jorgelo@chromium.org&gt; " fail_count="5" gerrit_number="1817403" owner_email="benchan@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/03/1817403/1" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="If3d050b6306b271796847b29c2537a203d5e7ca1" commit="6e332889550d5734ecf916665e77acced176fb22" commit_message="permission_broker: replace empty body {con,de}structors with `= default` An explicitly defaulted constructor/destructor is preferred over a user-defined empty body constructor/destructor as the former could potentially enable more opportunities in optimization. BUG=None TEST=Run unit test. Change-Id: If3d050b6306b271796847b29c2537a203d5e7ca1 Reviewed-on: https://chromium-review.googlesource.com/1817404 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Jorge Lucangeli Obes &lt;jorgelo@chromium.org&gt; " fail_count="5" gerrit_number="1817404" owner_email="benchan@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/04/1817404/1" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I242805188bb56b8102c2caab71880713630797af" commit="97fb7623e348ae3d16b1f2822962197ced16db86" commit_message="crash: collect logs for suspend failures This adds a generic failure collector (with tests) that is first utilized for suspend failures. The collector assumes no crash files exist, and that just logs need to be collected. BUG=chromium:1000519 TEST=new crash-reporter unittests and checking that .log and .meta files show up in /var/spool/crash for suspend failures Change-Id: I242805188bb56b8102c2caab71880713630797af Reviewed-on: https://chromium-review.googlesource.com/1797279 Tested-by: Derek Basehore &lt;dbasehore@chromium.org&gt; Commit-Ready: Derek Basehore &lt;dbasehore@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Miriam Zimmerman &lt;mutexlox@chromium.org&gt; " fail_count="0" gerrit_number="1797279" owner_email="dbasehore@chromium.org" pass_count="0" patch_number="4" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/79/1797279/4" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I265086f50293858df9ed483d92ba969027f5f60d" commit="a55055bcfbe6bba8922246a974de1e6b4b4aa225" commit_message="tast-tests: add platform.SuspendFailure This adds a test to verify that logs are collected when suspend fails. BUG=chromium:1000519 TEST=check that `tast run &lt;DUT IP&gt; platform.SuspendFailure` passes Cq-Depend: chromium:1797279 Change-Id: I265086f50293858df9ed483d92ba969027f5f60d Reviewed-on: https://chromium-review.googlesource.com/1817251 Tested-by: Derek Basehore &lt;dbasehore@chromium.org&gt; Commit-Ready: Derek Basehore &lt;dbasehore@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Eric Caruso &lt;ejcaruso@chromium.org&gt; Reviewed-by: Miriam Zimmerman &lt;mutexlox@chromium.org&gt; " fail_count="0" gerrit_number="1817251" owner_email="dbasehore@chromium.org" pass_count="0" patch_number="6" project="chromiumos/platform/tast-tests" project_url="https://chromium-review.googlesource.com/chromiumos/platform/tast-tests" ref="refs/changes/51/1817251/6" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I6dbc9f95b0232c61201d9e7c6dfa83deb2eb73ba" commit="149738b4f163502f423d4ee066785a7ed4f3be16" commit_message="shill: metrics: Move kMetrics{Daily,Monthly}* constants to unnamed namespace BUG=None TEST=All unit tests are passing. Change-Id: I6dbc9f95b0232c61201d9e7c6dfa83deb2eb73ba Reviewed-on: https://chromium-review.googlesource.com/1809406 Tested-by: Alex Khouderchah &lt;akhouderchah@chromium.org&gt; Commit-Ready: Alex Khouderchah &lt;akhouderchah@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Eric Caruso &lt;ejcaruso@chromium.org&gt; " fail_count="0" gerrit_number="1809406" owner_email="akhouderchah@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/06/1809406/1" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I9626cb5bc669569a52415c36d1f9cfd147e78a81" commit="f5aebe69199af826e9230b60b9751d5513b84338" commit_message="shill: metrics: Use base::TimeDelta directly for daily/monthly time values BUG=None TEST=All unit tests are passing. Change-Id: I9626cb5bc669569a52415c36d1f9cfd147e78a81 Reviewed-on: https://chromium-review.googlesource.com/1807257 Tested-by: Alex Khouderchah &lt;akhouderchah@chromium.org&gt; Commit-Ready: Alex Khouderchah &lt;akhouderchah@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Eric Caruso &lt;ejcaruso@chromium.org&gt; " fail_count="0" gerrit_number="1807257" owner_email="akhouderchah@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/57/1807257/3" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I9080519143a16da4c078621cbf1742a887da4820" commit="9f9824a62f9fe81aa92cac3cc04e73e70d66b783" commit_message="shill: net: make NetlinkSocket::Init() a virtual method This CL makes NetlinkSocket::Init() a virtual method, so that it can be properly mocked. BUG=None TEST=Run unit tests. Change-Id: I9080519143a16da4c078621cbf1742a887da4820 Reviewed-on: https://chromium-review.googlesource.com/1825646 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Alex Khouderchah &lt;akhouderchah@chromium.org&gt; " fail_count="0" gerrit_number="1825646" owner_email="benchan@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/46/1825646/1" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I05a93f9ccf840aabcfe88a1a1df7519f53d8e3e1" commit="12bd52dac06a70f8bb7b48459851f05cb55725f8" commit_message="shill: net: migrate to generalized MOCK_METHOD() macro This CL replaces the uses of MOCK_METHOD*() and MOCK_CONST_METHOD*() macros in unit tests with the generalized MOCK_METHOD() macro, which is now the recommended way to define mocked methods with gmock. In particular, MOCK_METHOD() supports annotating a mocked method with specifiers such as 'override'. One minor change is that argument names are omitted in the argument list provided to MOCK_METHOD() in order to prevent clang-format from formatting code like `Foo* foo` into `Foo * foo`. BUG=None TEST=Run unit tests. Change-Id: I05a93f9ccf840aabcfe88a1a1df7519f53d8e3e1 Reviewed-on: https://chromium-review.googlesource.com/1825647 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Alex Khouderchah &lt;akhouderchah@chromium.org&gt; " fail_count="0" gerrit_number="1825647" owner_email="benchan@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/47/1825647/1" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I2f2aab7f3a6efed1528258d83d825bcd30379886" commit="ca8ae034a90fd4f8edafe5b8be557b0a9b1bc0af" commit_message="metrics: remove unnecessary mock method declarations in TimerReporterMock BUG=None TEST=Run unit tests. Change-Id: I2f2aab7f3a6efed1528258d83d825bcd30379886 Reviewed-on: https://chromium-review.googlesource.com/1823823 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="2" gerrit_number="1823823" owner_email="benchan@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/23/1823823/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I58d05cb3806a59cab72e0ec927e98da9e2df2c22" commit="10cdaaeceedb47ed4f38c0e37bebc6c4aece8f97" commit_message="metrics: migrate to generalized MOCK_METHOD() macro This CL replaces the uses of MOCK_METHOD*() and MOCK_CONST_METHOD*() macros in unit tests with the generalized MOCK_METHOD() macro, which is now the recommended way to define mocked methods with gmock. In particular, MOCK_METHOD() supports annotating a mocked method with specifiers such as 'override'. One minor change is that argument names are omitted in the argument list provided to MOCK_METHOD() in order to prevent clang-format from formatting code like `Foo* foo` into `Foo * foo`. BUG=None TEST=Run unit tests. Change-Id: I58d05cb3806a59cab72e0ec927e98da9e2df2c22 Reviewed-on: https://chromium-review.googlesource.com/1823824 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="2" gerrit_number="1823824" owner_email="benchan@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/24/1823824/2" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Ib578982aa2e3426d2adbd9187c337220fabfb19e" commit="73046a8129597d2bd43067492855edf19dcf96d2" commit_message="graphics_util: More properly identify internal vs external displays The graphics_util functions were assuming that CRTC[0] was always the internal display. This is not a valid assumption and is causing failures on veyron devices on kernel 4.19. Let's correlate the other info from modetest to figure out the proper internal display. BUG=chromium:1004949 TEST=test_that ${DUT} display_Resolution.mirrored --args &quot;chameleon_host=${CHAM}&quot; Change-Id: Ib578982aa2e3426d2adbd9187c337220fabfb19e Signed-off-by: Douglas Anderson &lt;dianders@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1817470 Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Wai-Hong Tam &lt;waihong@google.com&gt; Reviewed-by: Ilja H. Friedel &lt;ihf@chromium.org&gt; " fail_count="5" gerrit_number="1817470" owner_email="dianders@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/70/1817470/3" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I7c35538308630ce7ff0a9e1f3553044b83fe4357" commit="5e3c3f0b0750cf6544aaf5129aa7262f50fc4477" commit_message="autotest: Remove video autotests that were replaced or deprecated Remove video autotests which * we replaced with Tast version, and * we decided not to monitor It's safe to remove them because these tests were already excluded from packaging by CL:1717071, CL:1717072, CL:1772802 and CL:1813997. Removed Autotest tests | Corresponding Tast tests -------------------------------------------------------------------------- video_ChromeHWDecodeUsed | video.PlayDecodeAccelUsed* video_ChromeRTCHWDecodeUsed | webrtc.DecodeAccelUsed* video_ChromeRTCHWEncodeUsed | webrtc.EncodeAccelUsed* video_ChromeVidResChangeHWDecode | video.DecodeAccel*ResolutionSwitch video_GlitchDetection | N/A (Deprecated) video_HangoutHardwarePerf | video.DecodeEncodeAccelPerf video_JDAPerf | camera.DecodeAccelJPEGPerf video_JEAPerf | camera.EncodeAccelJPEGPerf video_JpegDecodeAccelerator | camera.DecodeAccelJPEG video_JpegEncodeAccelerator | camera.EncodeAccelJPEG video_MediaRecorderHWEncodeUsed | webrtc.MediaRecorderEncodeAccelUsed video_MediaRecorderPerf | webrtc.MediaRecorderPerfH264 video_MultiplePlayback | N/A (Deprecated) video_PlaybackPerf | video.PlaybackPerf(H264|VP8|VP9)* video_VDAPerf | video.DecodeAccelPerf(H264|VP8|VP9)* video_VDASanity | video.DecodeAccelSanity* video_VDAStress (server test) | N/A (Deprecated) video_VEAPerf | video.EncodeAccelPerf(H264|VP8)* video_VideoCapability | video.Capability video_VideoCorruption | N/A (Deprecated) video_VideoDecodeAccelerator | video.DecodeAccel(H264|VP8|VP9)* video_VideoDecodeMemoryUsage | N/A (Deprecated) video_VideoEncodeAccelerator | video.EncodeAccel(H264|VP8|VP9)* video_VideoReload | N/A (Deprecated) video_VideoSanity | video.Play(H264|VP8|VP9) video_VideoSeek | video.Seek* video_VimeoVideo | N/A (Deprecated) video_VimeoVideoWPR | N/A (Deprecated) video_WebRtcCamera | camera.GetUserMedia video_WebRtcMediaRecorder | webrtc.MediaRecorder video_WebRtcPeerConnectionWithCamera | webrtc.PeerConn* video_WebRtcPerf | webrtc.DecodePerf video_WebRtcSanity | N/A (Deprecated) video_YouTubeHTML5 | N/A (Deprecated) video_YouTubeMseEme | N/A (Deprecated) video_YouTubePage | N/A (Deprecated) We still keep following video autotests: * video_AVAnalysis (owned by vsuley@) * video_WebRtcMainFeedSwitching (owned by Meet team) * video_WebRtcResolutionSwitching (owned by Meet team) * power server tests (should be ported/deprecated in crbug.com/1006104) - power_Hangout - video_PowerConsumption Also, we leave source code of the following tests which are used by power tests: * video_HangoutHardwarePerf * video_PlaybackPerf * video_WebRtcPerf These tests will stop as we remove control files. BUG=chromium:885910, chromium:899586, chromium:953553 TEST=Pre-CQ passed Change-Id: I7c35538308630ce7ff0a9e1f3553044b83fe4357 Signed-off-by: Keiichi Watanabe &lt;keiichiw@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1773022 Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: David Staessens &lt;dstaessens@chromium.org&gt; " fail_count="2" gerrit_number="1773022" owner_email="keiichiw@chromium.org" pass_count="0" patch_number="8" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/22/1773022/8" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I4d4f9bd25159e8d3d0b14a84f7f566593e1438ac" commit="f5a01bb1e8a414497763619fa2981aa0d243ab4b" commit_message="crosperf: mark a run as failed if samples collected is 0 There is situation that in cwp mode, test runs correctly but not samples are collected. For this case, we want to mark the run as failure so that we could have correct speedup calculation and user can notice it. BUG=chromium:927554 TEST=Passed unit tests Change-Id: I4d4f9bd25159e8d3d0b14a84f7f566593e1438ac Reviewed-on: https://chromium-review.googlesource.com/1594288 Tested-by: Zhizhou Yang &lt;zhizhouy@google.com&gt; Commit-Ready: Zhizhou Yang &lt;zhizhouy@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Manoj Gupta &lt;manojgupta@chromium.org&gt; " fail_count="0" gerrit_number="1594288" owner_email="zhizhouy@google.com" pass_count="0" patch_number="2" project="chromiumos/third_party/toolchain-utils" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/toolchain-utils" ref="refs/changes/88/1594288/2" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I454f021dda5d25237c6c26319762025a928408e2" commit="3f076f57764c0e866dd1efb940be0c07d5ebe12b" commit_message="chromeos-config: update .gitignore Add these files which are generated by tests right now: product_name product_sku test.json test_arm.json (the last two are covered by test*.json) Remove test*.dtb, as the dtb implementation of cros_config is long gone. BUG=none TEST=ran tests, generated files are now ignored Change-Id: I454f021dda5d25237c6c26319762025a928408e2 Signed-off-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1819769 Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: C Shapiro &lt;shapiroc@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; Reviewed-by: Simon Glass &lt;sjg@chromium.org&gt; " fail_count="5" gerrit_number="1819769" owner_email="jrosenth@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/69/1819769/2" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I23912975cfc1726069b92942dea4de1fbd3ec714" commit="7ae8baaf86269f9d0fcbb4117a9841fc6be87dc4" commit_message="bluetooth: Forward SetLongTermKeys to both BlueZ and NewBlue Currently btdispatch isn't configured what to do with SetLongTermKeys so that it rejects and returns error. We need to forward this to BlueZ and NewBlue. BUG=chromium:1004847 TEST=Check dbus-monitor, simulate adapter initialiation with rmmod btusb and modprobe btusb and check that SetLongTermKeys no longer produces error in the D-Bus log. Change-Id: I23912975cfc1726069b92942dea4de1fbd3ec714 Reviewed-on: https://chromium-review.googlesource.com/1809405 Tested-by: Sonny Sasaka &lt;sonnysasaka@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Ryan Hansberry &lt;hansberry@chromium.org&gt; Reviewed-by: Alain Michaud &lt;alainmichaud@google.com&gt; Reviewed-by: Yu Liu &lt;yudiliu@chromium.org&gt; " fail_count="4" gerrit_number="1809405" owner_email="sonnysasaka@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/05/1809405/1" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="Iabd307fa611b8f82d3a414928856bc5addce8103" commit="d55e1c620be0a0c41307b55e739d84bbaaf481bd" commit_message="shill: l2tp: Properly handle l2tpipsec_vpn exit codes L2TPIPSecDriver::TranslateExitStatusToFailure previously assumed that the status passed to it was a wstatus value from wait() or waitpid(). As that is not the case, all exit codes were being mapped to Service::kFailureInternal. This change fixes this assumption. BUG=chromium:1007383 TEST=-All unit tests are passing. -Manual testing with L2TP connections and disconnections. -Using an invalid VPN server hostname indicates a DNS lookup failure rather than internal error. Change-Id: Iabd307fa611b8f82d3a414928856bc5addce8103 Reviewed-on: https://chromium-review.googlesource.com/1825440 Tested-by: Alex Khouderchah &lt;akhouderchah@chromium.org&gt; Commit-Ready: Alex Khouderchah &lt;akhouderchah@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Eric Caruso &lt;ejcaruso@chromium.org&gt; " fail_count="0" gerrit_number="1825440" owner_email="akhouderchah@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/40/1825440/3" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="Ib017005b848320b0cab1c8620547eb8805208982" commit="5394b9dc22a39ba7d8b55d1a0fadfbcf2fcf61fd" commit_message="touch_updater: Fix early return in rebind_driver() if required arg is missing. This fixes a mistake in CL:1772378 . This early return is effectively an assertion against buggy touch updater wrappers, so for any working touch updater, this bug fix is a no-op. Note the lack of logging for this return path is deliberate. If this return path is encountered, it is by definition a bug in the touch updater wrapper which called this function. It's not worth polluting the common library with logging lines for that. (Early return path log lines are worthwhile for conditions which could be triggered by device or driver behavior.) BUG=b:132830741 TEST=Tested both normal update and firmware corruption recovery with etphidiap updater. No behavior or logging output changes, as expected, and both update attempts succeeded. Logging output showed that rebind_driver() was used and succeeded in both attempts. Also verified no-update case, which does not invoke this code. Change-Id: Ib017005b848320b0cab1c8620547eb8805208982 Signed-off-by: Matthew Blecker &lt;matthewb@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1825860 Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Sean O'Brien &lt;seobrien@chromium.org&gt; " fail_count="0" gerrit_number="1825860" owner_email="matthewb@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform/touch_updater" project_url="https://chromium-review.googlesource.com/chromiumos/platform/touch_updater" ref="refs/changes/60/1825860/1" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I87aad984f8d73ce46f11ad5436dd5923a4b85e13" commit="f6c7208884b62050c410cecde47ebe14f6258b82" commit_message="bluetooth: emit the name, discovering and uuids properties from Newblue BUG=chromium:1001712 TEST=Manually test with bluetoothctl and verified that no behavior changes observed in the terminal with this CL alone. The following changes observed when testing together with 1808359: 1. bluetoothctl --service org.chromium.Bluetooth 2. power off, it shows the following in the terminal Changing power off succeeded [CHG] Controller 4C:80:93:FD:CD:EC Powered: no [CHG] Controller 4C:80:93:FD:CD:EC Discovering: no [CHG] Controller 4C:80:93:FD:CD:EC Name: BlueZ 5.44 [DEL] Device AC:37:43:7A:D1:E0 PC120A 🐾 [CHG] Controller 4C:80:93:FD:CD:EC Class: 0x000000 3. power on, it shows the following in the terminal [CHG] Controller 4C:80:93:FD:CD:EC Class: 0x480104 Changing power on succeeded [CHG] Controller 4C:80:93:FD:CD:EC Powered: yes [CHG] Controller 4C:80:93:FD:CD:EC Name: BlueZ 5.44 Newblue 1.0 [CHG] Controller 4C:80:93:FD:CD:EC Discovering: yes [NEW] Device AC:37:43:7A:D1:E0 PC120A 🐾 4. show, it shows the following in the terminal Controller 4C:80:93:FD:CD:EC Name: BlueZ 5.44 Newblue 1.0 Alias: Chromebook_D958 Class: 0x480104 Powered: yes Discoverable: no Pairable: yes UUID: Headset AG (00001112-0000-1000-8000-00805f9b34fb) UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb) UUID: A/V Remote Control (0000110e-0000-1000-8000-00805f9b34fb) UUID: Generic Access Profile (00001800-0000-1000-8000-00805f9b34fb) UUID: PnP Information (00001200-0000-1000-8000-00805f9b34fb) UUID: A/V Remote Control Target (0000110c-0000-1000-8000-00805f9b34fb) UUID: Audio Source (0000110a-0000-1000-8000-00805f9b34fb) UUID: Handsfree Audio Gateway (0000111f-0000-1000-8000-00805f9b34fb) Modalias: bluetooth:v00E0p245Ad0400 Discovering: yes 5. remove AC:37:43:7A:D1:E0 6. show, it shows the following in the terminal, note that the Discovering is set to no now because no pairing device exists so it stopped doing any background discovering. Controller 4C:80:93:FD:CD:EC Name: BlueZ 5.44 Newblue 1.0 Alias: Chromebook_D958 Class: 0x480104 Powered: yes Discoverable: no Pairable: yes UUID: Headset AG (00001112-0000-1000-8000-00805f9b34fb) UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb) UUID: A/V Remote Control (0000110e-0000-1000-8000-00805f9b34fb) UUID: Generic Access Profile (00001800-0000-1000-8000-00805f9b34fb) UUID: PnP Information (00001200-0000-1000-8000-00805f9b34fb) UUID: A/V Remote Control Target (0000110c-0000-1000-8000-00805f9b34fb) UUID: Audio Source (0000110a-0000-1000-8000-00805f9b34fb) UUID: Handsfree Audio Gateway (0000111f-0000-1000-8000-00805f9b34fb) Modalias: bluetooth:v00E0p245Ad0400 Discovering: no 7. bluetoothctl --service org.chromium.Newblue [NEW] Controller AA:BB:CC:DD:EE:FF &lt;unknown&gt; [default] [bluetooth]# show Controller AA:BB:CC:DD:EE:FF Name: Newblue Powered: yes UUID: Generic Access Profile (00001800-0000-1000-8000-00805f9b34fb) UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb) Change-Id: I87aad984f8d73ce46f11ad5436dd5923a4b85e13 Reviewed-on: https://chromium-review.googlesource.com/1799465 Tested-by: Yu Liu &lt;yudiliu@chromium.org&gt; Commit-Ready: Yu Liu &lt;yudiliu@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Michael Sun &lt;michaelfsun@google.com&gt; Reviewed-by: Miao-chen Chou &lt;mcchou@chromium.org&gt; " fail_count="0" gerrit_number="1799465" owner_email="yudiliu@chromium.org" pass_count="0" patch_number="5" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/65/1799465/5" remote="cros" total_fail_count="0"/><pending_commit branch="chromeos-5.44" change_id="I1d8be51f51bfceb11941741d85b0bd02a9f211d1" commit="2df63a5fbd4ccc11a72dc0366fae4741a1c3b58e" commit_message="CHROMIUM: Combine known bad LTKs with LTKs from SetLongTermKeys In CL:1653712 SetLongTermKeys was temporarily disabled to use local LTKs instead. Now it is re-enabled with a change in behavior that it combines the given LTKs with the local LTKs. BUG=chromium:973164 TEST=Manual test with modified Chrome that sends dummy LTKs Change-Id: I1d8be51f51bfceb11941741d85b0bd02a9f211d1 Reviewed-on: https://chromium-review.googlesource.com/1735885 Tested-by: Sonny Sasaka &lt;sonnysasaka@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Miao-chen Chou &lt;mcchou@chromium.org&gt; " fail_count="18" gerrit_number="1735885" owner_email="sonnysasaka@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/bluez" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/bluez" ref="refs/changes/85/1735885/3" remote="cros" total_fail_count="18"/><pending_commit branch="master" change_id="Ifed8ccfe5f0b720b00b8cc537c9722e8e3e16305" commit="1a127b6222aae8b87f894564edae03819127a5f1" commit_message="vm_tools: proto: cicerone: Add ApplyAnsiblePlaybookProgress rpc Adds RPC endpoint for reporting Ansible playbook application progress back to Cicerone and add interface in Cicerone that allows reporting Ansible playbook application progress from default Crostini container. BUG=chromium:998518 TEST=emerge-tatl vm_protos; emerge-tatl vm_guest_tools; emerge-${BOARD} vm_protos; emerge-${BOARD} vm_host_tools Change-Id: Ifed8ccfe5f0b720b00b8cc537c9722e8e3e16305 Reviewed-on: https://chromium-review.googlesource.com/1813897 Tested-by: Olya Kalitova &lt;okalitova@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Stephen Barber &lt;smbarber@chromium.org&gt; " fail_count="4" gerrit_number="1813897" owner_email="okalitova@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/97/1813897/3" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="I29cac695057f1cec1c8b68301e219920dfb5dd45" commit="6342c7f8a9cf74de519743e325be1062232bb5aa" commit_message="pytests: hwid: add argument 'include_brand_code' Set this argument to false to remove RLZ brand code. BUG=b:139654327 TEST=make test Change-Id: I29cac695057f1cec1c8b68301e219920dfb5dd45 Reviewed-on: https://chromium-review.googlesource.com/1757659 Tested-by: Wei-Han Chen &lt;stimim@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Yong Hong &lt;yhong@chromium.org&gt; " fail_count="6" gerrit_number="1757659" owner_email="stimim@chromium.org" pass_count="0" patch_number="4" project="chromiumos/platform/factory" project_url="https://chromium-review.googlesource.com/chromiumos/platform/factory" ref="refs/changes/59/1757659/4" remote="cros" total_fail_count="6"/><pending_commit branch="master" change_id="Iaab0590553b11ab5370b1bbd02205187b07bbc4b" commit="d2d51bf588201bbebe90447945781972cc2e2a92" commit_message="faft: Raise exceptions for broken shellballs. This was suggested by a comment on CL:1739598. Previously, an empty manifest file would result in a ValueError, and an empty manifest dictionary would result in assuming default paths. Now it gives specific error messages for several problems: * Empty shellball (zero bytes) * Empty manifest string (zero characters or all whitespace) * Empty manifest dict BUG=None TEST=Run firmware_Update*Version tests and firmware_FAFTRPC.updater Change-Id: Iaab0590553b11ab5370b1bbd02205187b07bbc4b Reviewed-on: https://chromium-review.googlesource.com/1762285 Tested-by: Dana Goyette &lt;dgoyette@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Hung-Te Lin &lt;hungte@chromium.org&gt; " fail_count="16" gerrit_number="1762285" owner_email="dgoyette@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/85/1762285/3" remote="cros" total_fail_count="16"/><pending_commit branch="master" change_id="Idcbc791e024ac6d0a18331204fae13055d0fad03" commit="4ce14234a247b478e0dac0f326b397e686bc0993" commit_message="runtime_probe,debugd: limit callers for EvaluateProbeFunction In order to prevent privilege escalation once users get permission of binary execution, this commit restricts calls to the debugd function EvaluateProbeFunction from users except root and runtime_probe. BUG=b:138183179 TEST=Manual test in go/cros-probe-testing Change-Id: Idcbc791e024ac6d0a18331204fae13055d0fad03 Reviewed-on: https://chromium-review.googlesource.com/1806694 Tested-by: Clark Chung &lt;ckclark@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Jorge Lucangeli Obes &lt;jorgelo@chromium.org&gt; " fail_count="2" gerrit_number="1806694" owner_email="ckclark@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/94/1806694/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Idfe38c709b646e4d5b0a6585b97e1a4416b8f4dd" commit="f9ad7fa1fbfb7e650b9b84fcc95cd8eff96c4407" commit_message="system_api: Build Go protos for VM Plugin Dispatcher For use in future tast tests, add go protos for the VM Plugin Dispatcher. BUG=chromium:1006664 TEST=build system_api Change-Id: Idfe38c709b646e4d5b0a6585b97e1a4416b8f4dd Reviewed-on: https://chromium-review.googlesource.com/1819137 Tested-by: Timothy Loh &lt;timloh@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="3" gerrit_number="1819137" owner_email="timloh@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/37/1819137/1" remote="cros" total_fail_count="3"/><pending_commit branch="chromeos-4.4" change_id="I643e8204cc495b125cc043cba01cbfd95e916017" commit="2703e3ab4412914de93c99240fd39a75809d3616" commit_message="BACKPORT: i915/guc: Add Kabylake GuC Loading This patch added the loading of the GuC for Kabylake. It loads a 9.14 firmware. v2: Fix commit message v3: Fix major/minor var names to match -nightly. (Rodrigo) Cc: Christophe Prigent &lt;christophe.prigent@intel.com&gt; Signed-off-by: Peter Antoine &lt;peter.antoine@intel.com&gt; Signed-off-by: Michel Thierry &lt;michel.thierry@intel.com&gt; Reviewed-by: Rodrigo Vivi &lt;rodrigo.vivi@intel.com&gt; Signed-off-by: Rodrigo Vivi &lt;rodrigo.vivi@intel.com&gt; Reviewed-by: Michel Thierry &lt;michel.thierry@intel.com&gt; (v3) Signed-off-by: Tvrtko Ursulin &lt;tvrtko.ursulin@intel.com&gt; Link: http://patchwork.freedesktop.org/patch/msgid/1467304672-2106-1-git-send-email-rodrigo.vivi@intel.com (cherry picked from commit ff64cc16e25dbfdf36c7e1489b0ad2a90e8c48d1) Fixed compilation issues: use dev_priv in IS_KABYLAKE() call BUG=chromium:965320 TEST=run drm-test/plane_test -f NV12 Change-Id: I643e8204cc495b125cc043cba01cbfd95e916017 Signed-off-by: Eugene Nemkov &lt;eugene.nemkov@intel.com&gt; Reviewed-on: https://chromium-review.googlesource.com/1703427 Tested-by: Santosh Kumar Avati &lt;santosh.kumar.avati@intel.com&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Stéphane Marchesin &lt;marcheu@chromium.org&gt; " fail_count="2" gerrit_number="1703427" owner_email="eugene.nemkov@intel.com" pass_count="0" patch_number="2" project="chromiumos/third_party/kernel" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/kernel" ref="refs/changes/27/1703427/2" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I691876c29b0000171a4a5a434abcd597c411e6e8" commit="0b24e6cb08eceb292ad75846d5f29357aab43f12" commit_message="cros-disks: Migrate from raw libudev usage to brillo::Udev* Also migrate a few trivial tests to using a MockUdevDevice. BUG=chromium:985186 TEST=Run unit tests TEST=Build/deploy to chell and run platform_CrosDisks* autotests Change-Id: I691876c29b0000171a4a5a434abcd597c411e6e8 Reviewed-on: https://chromium-review.googlesource.com/1797609 Tested-by: Anand Mistry &lt;amistry@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Ben Chan &lt;benchan@google.com&gt; " fail_count="4" gerrit_number="1797609" owner_email="amistry@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/09/1797609/3" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="Icdf6e2386fd1dd4a55285c1f9c1dd38de39a02f6" commit="bc2c8470903812942b3938897d50d8b0abaa279a" commit_message="gatt: add support of MTU query on a GATT connection BUG=b:134425062 TEST=built Change-Id: Icdf6e2386fd1dd4a55285c1f9c1dd38de39a02f6 Reviewed-on: https://chromium-review.googlesource.com/1804514 Tested-by: Miao-chen Chou &lt;mcchou@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Yu Liu &lt;yudiliu@chromium.org&gt; " fail_count="2" gerrit_number="1804514" owner_email="mcchou@chromium.org" pass_count="0" patch_number="4" project="chromiumos/platform/newblue" project_url="https://chromium-review.googlesource.com/chromiumos/platform/newblue" ref="refs/changes/14/1804514/4" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I6334ff225104b43bdd32d18205c4aa2f71efc1ef" commit="206ea22a1fa15f8ab47c5794d2e3f2069914f7f1" commit_message="timberslide: Refactor code in preparation for adding tests No code changes; just moving code. BUG=chromium:1003564 TEST=emerge-hatch timberslide Change-Id: I6334ff225104b43bdd32d18205c4aa2f71efc1ef Reviewed-on: https://chromium-review.googlesource.com/1809402 Tested-by: Tom Hughes &lt;tomhughes@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Eric Caruso &lt;ejcaruso@chromium.org&gt; Reviewed-by: Tim Wawrzynczak &lt;twawrzynczak@chromium.org&gt; " fail_count="5" gerrit_number="1809402" owner_email="tomhughes@chromium.org" pass_count="0" patch_number="3" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/02/1809402/3" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I00a6553860470642475331e05857e17901747bc4" commit="ba12bf55b3fcf8bff46f0c9f025d12602b33dc9a" commit_message="factory: Use assertEqual() assertEquals() is deprecated in python3. BUG=chromium:999876 TEST=make test TEST=umpire test Change-Id: I00a6553860470642475331e05857e17901747bc4 Reviewed-on: https://chromium-review.googlesource.com/1816632 Tested-by: Yilin Yang &lt;kerker@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Wei-Han Chen &lt;stimim@chromium.org&gt; " fail_count="2" gerrit_number="1816632" owner_email="kerker@chromium.org" pass_count="0" patch_number="4" project="chromiumos/platform/factory" project_url="https://chromium-review.googlesource.com/chromiumos/platform/factory" ref="refs/changes/32/1816632/4" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I2972447b38ee7f93a88d02f62433cde894154b4b" commit="68a6738a754fb48f75258fc4db54c4a96edb543d" commit_message="vm_tools: concierge: fix usb-list parsing The ParseUsbControlRequest function parses the output of the `crosvm usb list` command into the list used by `vmc usb-list`. There was a bug in the ParseUsbControlRequest implementation that caused it to repeat the information for the first device rather than returning the correct information for each device when multiple devices were attached. BUG=chromium:1007000 TEST=`vmc usb-list termina` with multiple devices attached Change-Id: I2972447b38ee7f93a88d02f62433cde894154b4b Signed-off-by: Daniel Verkamp &lt;dverkamp@chromium.org&gt; Reviewed-on: https://chromium-review.googlesource.com/1819964 Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Stephen Barber &lt;smbarber@chromium.org&gt; " fail_count="3" gerrit_number="1819964" owner_email="dverkamp@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/64/1819964/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Icbe14cc96e20b3ae92d32fd64c2732d625deb7a9" commit="a82c8487d3bbc144fccf622813817c6eb3fdbc10" commit_message="shill: service: Fix UserInitiated{Connect,Disconnect} semantics Prior to this change, there was an issue in which a UserInitiatedConnect that fails quickly would result in unnecessarily setting |is_in_user_connect_|. For example, if a client tried to connect to a Service that was not connectable(), the failure would not be recorded by ReportUserInitiatedConnectionResult and the next connection (which would likely be an AutoConnect triggered by SetConnectableFull) would be considered a user initiated connection. A similar, but latent, issue is fixed for UserInitiatedDisconnect. Since Cellular is the only technology that uses SetFailureSilent to drive a Service state back to kStateIdle during a disconnect, but also happens to have an asynchronous disconnect in which SetFailureSilent is called *after* UserInitiatedDisconnect has completed, this issue is currently not hit by any flows. BUG=None TEST=-All unit tests are passing. -Manual testing with connections and disconnections through the Chrome UI. -Manual testing involving LOGs in UserInitiatedConnect and `connect-service` calls (as the Chrome UI doesn't let us do things like connect to a connected Service). Change-Id: Icbe14cc96e20b3ae92d32fd64c2732d625deb7a9 Reviewed-on: https://chromium-review.googlesource.com/1762627 Tested-by: Alex Khouderchah &lt;akhouderchah@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Eric Caruso &lt;ejcaruso@chromium.org&gt; Reviewed-by: Brian Norris &lt;briannorris@chromium.org&gt; " fail_count="2" gerrit_number="1762627" owner_email="akhouderchah@chromium.org" pass_count="0" patch_number="6" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/27/1762627/6" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Ia400dc08ca416585d720b129db5daabc83053201" commit="3c20837b11e3831087d9a82bc67a3a00b41db379" commit_message="vm_tools: cicerone: implement UpdateListeningPorts for chunnel The cicerone service will be responsible for determining tunneling policy. It will receive a global view of all listening ports in all running containers, and will then inform chunneld of which ports need to be listened to. StartSshForwarding is renamed to SetUpSshConfig and still sets up the private key and known_hosts files, but no longer starts SSH. cicerone will stop managing the config altogether once tast is updated to use the SSH keys D-Bus API directly. BUG=chromium:848063 TEST=crostini.* Change-Id: Ia400dc08ca416585d720b129db5daabc83053201 Reviewed-on: https://chromium-review.googlesource.com/1717819 Tested-by: Stephen Barber &lt;smbarber@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Chirantan Ekbote &lt;chirantan@chromium.org&gt; Reviewed-by: Nicholas Verne &lt;nverne@chromium.org&gt; " fail_count="2" gerrit_number="1717819" owner_email="smbarber@chromium.org" pass_count="0" patch_number="18" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/19/1717819/18" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I177ac7a85842e13378b92337415e46edca51ca66" commit="142c4e755ecfe62f440e32da7698598b67e7f5ce" commit_message="biod: Create FakeCrosFpDevice for unit-testing CrosFpBiometricsManager Create a FakeCrosFpDevice class to facilitate unit tests for CrosFpBiometricsManager class. Also create CrosFpBiometricsManagerPeer class so that we can unit-test private methods. BUG=chromium:927095 TEST=FEATURES=test emerge-nocturne biod TEST=Tested enrollment, matching, deleting and multifinger on nocturne DUT Change-Id: I177ac7a85842e13378b92337415e46edca51ca66 Reviewed-on: https://chromium-review.googlesource.com/1740519 Tested-by: Yicheng Li &lt;yichengli@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Tom Hughes &lt;tomhughes@chromium.org&gt; " fail_count="3" gerrit_number="1740519" owner_email="yichengli@chromium.org" pass_count="0" patch_number="7" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/19/1740519/7" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I4246a5aa0fa9892eee76e28e76535a7fc186f14c" commit="5f62bb6d5c5c17b5a2ef71fca1132b0866ce953c" commit_message="[Autotest] More policy testing backend - policy group object Adding the policy_group object. Part 2 of 3 or 4 Cls. TEST=test_policy_group unittest BUG=None CQ-DEPEND=CL:1733697 Change-Id: I4246a5aa0fa9892eee76e28e76535a7fc186f14c Reviewed-on: https://chromium-review.googlesource.com/1745415 Tested-by: Derek Beckett &lt;dbeckett@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Ruben Zakarian &lt;rzakarian@chromium.org&gt; " fail_count="2" gerrit_number="1745415" owner_email="dbeckett@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/15/1745415/5" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I850281b9b92ae31aa87518a4bedff9368a07f6bf" commit="493ff8bd7d0967618702eef1e9f898efbcc0c3cc" commit_message="setup: Publish cros_docker image version 20190916140050. A new release of cros_docker image on 20190916140050, built from source using hash 72994a8327fbdd368e1d3003611127e8e2dd5788. Published as factory-server-20190916140050-72994a-docker-1.10.3.txz. Major changes: 0828e5b48 setup: cros_docker: create loop device when run umpire container 96bc687e8 dome: Add compress/download progress table in UI 726dfc618 dome: Add frontend for downloading test logs c02196750 dome: Add backend for downloading test logs 63bb3c78b switch python shebangs to python2 8b0856481 Instalog: Add TestlogRule to the flow policy b8640e64b Goofy: Add a new output_file to instalog plugin on Goofy 172fe9678 factory: cros_payload: set default TMPDIR to the +exec directory in install stub e4fa8348a dome: Update whitelist of downloadable resources ff0b10116 Instalog: Add an exclude_history feature to output file plugin a73ca9113 dome: download files in bundle from UI 53070baf9 cros_payload: Add install_optional function b972485ad Instalog: Fix the buffer_priority_file plugin on creating tmpfiles BUG=chromium:679609 TEST=None Change-Id: I850281b9b92ae31aa87518a4bedff9368a07f6bf Signed-off-by: Yilin Yang &lt;kerker@google.com&gt; Reviewed-on: https://chromium-review.googlesource.com/1804705 Tested-by: Corner Li &lt;cornerli@google.com&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Wei-Han Chen &lt;stimim@chromium.org&gt; " fail_count="6" gerrit_number="1804705" owner_email="kerker@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform/factory" project_url="https://chromium-review.googlesource.com/chromiumos/platform/factory" ref="refs/changes/05/1804705/1" remote="cros" total_fail_count="6"/><pending_commit branch="master" change_id="Ib9da5e13d2843e32d82758e824335443a5fd6eff" commit="5ebea7014063229db9f6d3e4f6c03e6c341f73ef" commit_message="camera: Avoids connecting to CameraHalDispatcher when it is already bound This CL avoid connecting to CameraHalDispatcher when it is already bound to fix a race condition that sometimes when we register HAL server twice, it will reset the previous one and cause crash on Chrome VCD. BUG=b:140920101, b:140843799 TEST=tast run [DUT] camera.CaptureUnittests Change-Id: Ib9da5e13d2843e32d82758e824335443a5fd6eff Reviewed-on: https://chromium-review.googlesource.com/1813617 Tested-by: Wei Lee &lt;wtlee@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Ricky Liang &lt;jcliang@chromium.org&gt; " fail_count="4" gerrit_number="1813617" owner_email="wtlee@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/17/1813617/2" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="I78bd2d33fb52aece25d5ceb3d2e4e1cb3ef9874f" commit="302a0de5ef9bb838e53d829107e041104efb6215" commit_message="init: Remove agoode from OWNERS file I was added as part of the initiative to add OWNERS coverage, but do not work on this code anymore. BUG=b:132095048 TEST=None Change-Id: I78bd2d33fb52aece25d5ceb3d2e4e1cb3ef9874f Reviewed-on: https://chromium-review.googlesource.com/1814983 Tested-by: Adam Goode &lt;agoode@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt; " fail_count="2" gerrit_number="1814983" owner_email="agoode@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/83/1814983/2" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I65eb69b82245030257bbc3aa47ea780a73520931" commit="a77e31eb94d845db635b37ee39190fa96efe5ddc" commit_message="easy-unlock: Add hansberry to OWNERS TEST=None BUG=None Change-Id: I65eb69b82245030257bbc3aa47ea780a73520931 Reviewed-on: https://chromium-review.googlesource.com/1817338 Tested-by: Toni Baržić &lt;tbarzic@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Ryan Hansberry &lt;hansberry@chromium.org&gt; Reviewed-by: Toni Baržić &lt;tbarzic@chromium.org&gt; " fail_count="3" gerrit_number="1817338" owner_email="tbarzic@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/38/1817338/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Ifa677adc778f73e4108f6e35e5f0ae66eca205e6" commit="e3590c8efe58f6d595f2a647dde08f5819e12216" commit_message="autotest: Ignore the unknown vendor event error for now. This happens on guado-kernelnext since the Intel WP2 chip sends us this unknown event. BUG=b:141178173 TEST=Test passed with the fix Change-Id: Ifa677adc778f73e4108f6e35e5f0ae66eca205e6 Reviewed-on: https://chromium-review.googlesource.com/1817343 Tested-by: Yu Liu &lt;yudiliu@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Yoni Shavit &lt;yshavit@chromium.org&gt; " fail_count="2" gerrit_number="1817343" owner_email="yudiliu@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/43/1817343/3" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="Ife3685ce00a545fcaf81d3bd9198491c1d7a4382" commit="1872f40f5710763df54b56e81a14498045f625dc" commit_message="vm_tools: crostini_client: allow gpu on stable channel TEST=enable crostini gpu flag on stable channel BUG=chromium:1007042 Change-Id: Ife3685ce00a545fcaf81d3bd9198491c1d7a4382 Reviewed-on: https://chromium-review.googlesource.com/1820052 Tested-by: Zach Reizner &lt;zachr@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Dylan Reid &lt;dgreid@chromium.org&gt; Reviewed-by: Daniel Verkamp &lt;dverkamp@chromium.org&gt; Reviewed-by: Stephen Barber &lt;smbarber@chromium.org&gt; Reviewed-by: David Riley &lt;davidriley@chromium.org&gt; " fail_count="3" gerrit_number="1820052" owner_email="zachr@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/52/1820052/2" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Ifc0e60454546bdcbc5a870a1757e3bb52ed15700" commit="6bae5374e289cb5dfe84968db01e1869a4e6d835" commit_message="cheets_GTS: Cache the media asset of GtsYouTubeTestCases. Reusing the existing code for cheets_CTS_{N,P}. The URI of the asset and the target path is now parameterized. BUG=b:128874657 TEST=cheets_GTS.7.0_r2.GtsYouTubeTestCases (cached download is used) TEST=cheets_GTS.7.0_r2.GtsContentTestCases (no error) TEST=cheets_CTS_P.9.0_r9.arm.CtsUsbTests (no error) TEST=cheets_CTS_P.9.0_r9.arm.CtsMediaBitstreamsTestCases (download cached) TEST=cheets_CTS_N.7.1_r28.arm.CtsUsbTests (no error) Change-Id: Ifc0e60454546bdcbc5a870a1757e3bb52ed15700 Reviewed-on: https://chromium-review.googlesource.com/1824618 Tested-by: Kazuhiro Inaba &lt;kinaba@chromium.org&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Yoshiki Iguchi &lt;yoshiki@chromium.org&gt; " fail_count="1" gerrit_number="1824618" owner_email="kinaba@chromium.org" pass_count="0" patch_number="3" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/18/1824618/3" remote="cros" total_fail_count="1"/><pending_commit branch="master" change_id="I6975b798b3812723e2846984da212969d6f330e7" commit="5d886051e772221e3960fee503ccbd68bd0af48a" commit_message="Revert &quot;cros-disks: update setuid whitelist&quot; This reverts commit 034a6259cd6b7a253c1c79bc7b315b69f8c0325c. Reason for revert: Reverting while I write some shell script to make an exception for allowing the chronos-&gt;root transition while in dev mode. See crbug.com/1006979 Original change's description: &gt; cros-disks: update setuid whitelist &gt; &gt; Previously, this whitelist was in an insecure state, since a compromised &gt; cros-disks could switch to one of the whitelisted child UIDs and then &gt; switch to any other UID on the system (including root). Eliminate this &gt; security hole by enforcing that none of cros-disks' child UIDs are able to &gt; switch to other users on the system. NOTE: These uid whitelists are &gt; per-user whitelists, so if no policy is applied to a given user, then no &gt; whitelist policy in the system will prevent that user from accessing &gt; other UIDs. For more info, see the docs: &gt; &gt; https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/chromeos-4.14/Documentation/admin-guide/LSM/SafeSetID.rst &gt; &gt; BUG=chromium:845640 &gt; TEST=manual tests with SafeSetID LSM &gt; &gt; Change-Id: I6e752eea51b962951a19e8bf6d71779b609d534a &gt; Reviewed-on: https://chromium-review.googlesource.com/1564628 &gt; Tested-by: Micah Morton &lt;mortonm@chromium.org&gt; &gt; Commit-Ready: Micah Morton &lt;mortonm@chromium.org&gt; &gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; &gt; Reviewed-by: Anand Mistry &lt;amistry@chromium.org&gt; Bug: chromium:845640, chromium:1006979 Change-Id: I6975b798b3812723e2846984da212969d6f330e7 Reviewed-on: https://chromium-review.googlesource.com/1816420 Tested-by: Micah Morton &lt;mortonm@chromium.org&gt; Commit-Ready: Philip Chen &lt;philipchen@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Anand Mistry &lt;amistry@chromium.org&gt; Reviewed-by: Micah Morton &lt;mortonm@chromium.org&gt; " fail_count="3" gerrit_number="1816420" owner_email="mortonm@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/20/1816420/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I52553881178c73ccfb6dd5d6e1416d62a5e85eb0" commit="55d9be8548c429380840253f91cf6a6836ca2f48" commit_message="faft: Remove a few more Android-related calls. This CL is part of the Ryu/Android deprecation. One usage of is_android was accidentally left in, causing an error in the RestoreModifiedFwids RPC. When I checked for any other uses of is_android or wait_for_device, I found and removed two more RPCs: System.WaitForClient System.WaitForClientOffline BUG=b:138222680 TEST=Run firmware_FAFTRPC.system TEST=Run firmware_FWupdate, interrupt it after flash, then run it again. Change-Id: I52553881178c73ccfb6dd5d6e1416d62a5e85eb0 Reviewed-on: https://chromium-review.googlesource.com/1816810 Tested-by: Dana Goyette &lt;dgoyette@chromium.org&gt; Commit-Ready: Dana Goyette &lt;dgoyette@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Greg Edelston &lt;gredelston@google.com&gt; " fail_count="3" gerrit_number="1816810" owner_email="dgoyette@chromium.org" pass_count="0" patch_number="1" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/10/1816810/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="Ia525486842e23fb02739038182667b23f0209f93" commit="c514a3aba84066be437f377cce8dc0f864f5e77d" commit_message="faft: Capture logs from servo log-dir. With CL:1481750, the servod logging now uses a directory for each instance, based on port number. This change allows autotest to capture logs from the new location. This CL also includes a change to split the logs into three stages: one for setup, one for test body, and one for cleanup. It also includes changes to account for the upcoming parallel logging from CL:1793030. Once the test machines are all running that CL, we can remove the no-level case. BUG=chromium:932820 TEST=Run suite:faft_lv1, check results for files matching servod.* Change-Id: Ia525486842e23fb02739038182667b23f0209f93 Reviewed-on: https://chromium-review.googlesource.com/1808442 Tested-by: Dana Goyette &lt;dgoyette@chromium.org&gt; Commit-Ready: Dana Goyette &lt;dgoyette@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Ruben Rodriguez Buchillon &lt;coconutruben@chromium.org&gt; " fail_count="5" gerrit_number="1808442" owner_email="dgoyette@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/42/1808442/5" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I26331c7472bc4ffd96fb44506182e6eb3b1aba8c" commit="30adde94f12dbcbeacb4ca847edd8eac9395d720" commit_message="Chameleon generate_labels returns wrong type The generate_labels method should return type list instead of list of list. BUG=chromium:1005829 TEST=test it locally Change-Id: I26331c7472bc4ffd96fb44506182e6eb3b1aba8c Reviewed-on: https://chromium-review.googlesource.com/1815999 Tested-by: Kalin Stoyanov &lt;kalin@chromium.org&gt; Commit-Ready: Yun-Hao Chung &lt;howardchung@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Wai-Hong Tam &lt;waihong@google.com&gt; Reviewed-by: Kalin Stoyanov &lt;kalin@chromium.org&gt; " fail_count="5" gerrit_number="1815999" owner_email="howardchung@google.com" pass_count="0" patch_number="2" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/99/1815999/2" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I4a5ba8ff059b8deee373fac29d64aa12934eee3c" commit="678683a249475dda269e488dd7c4ac569a17b68b" commit_message="metrics: Update OWNERS Tim is off to Ads -- Bye, Tim! Jeff requested we use jkardatzke@google.com as OWNER instead of jkardatzke@chromium.org. BUG=None TEST=None Change-Id: I4a5ba8ff059b8deee373fac29d64aa12934eee3c Reviewed-on: https://chromium-review.googlesource.com/1823821 Tested-by: Ian Barkley-Yeung &lt;iby@chromium.org&gt; Commit-Ready: Ian Barkley-Yeung &lt;iby@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Miriam Zimmerman &lt;mutexlox@chromium.org&gt; Reviewed-by: Jeffrey Kardatzke &lt;jkardatzke@google.com&gt; " fail_count="2" gerrit_number="1823821" owner_email="iby@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/21/1823821/1" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I1af2e6291e6adbd2ea09b8f0bfaaa6221cdc2547" commit="77fda6cdf24b9f93b33c8cd893364312472cdcc3" commit_message="power: Notify powersupply observers on battery percentage change. Currently when we receive power_supply subsystem udev events we update the observers only if : 1. external_power status change (one of USB, AC, DISCONNECTED). 2. battery_state changed (one of FULL, CHARGING, DISCHARGING, NOT_PRESENT) 3. If connected sources are equal. This code seems to be added with the idea that udev events are sent only when state changes but not when battery percentage changes. On receving udev events we also reset one short poll timer that polls the battery percentage every 30 secs. This means if we receive a udev event due to battery percentage change at a frequency faster than 30 secs, we end up not notifying the clients about the change in the battery percentage. This means ash tray will show same percentage unless there is a power source change. This one line change fixes the same bug. BUG=b:141472256 TEST=unit test &amp; build pass Change-Id: I1af2e6291e6adbd2ea09b8f0bfaaa6221cdc2547 Reviewed-on: https://chromium-review.googlesource.com/1820117 Tested-by: Ravi Chandra Sadineni &lt;ravisadineni@chromium.org&gt; Commit-Ready: Ravi Chandra Sadineni &lt;ravisadineni@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Todd Broch &lt;tbroch@chromium.org&gt; Reviewed-by: Puthikorn Voravootivat &lt;puthik@chromium.org&gt; " fail_count="2" gerrit_number="1820117" owner_email="ravisadineni@chromium.org" pass_count="0" patch_number="2" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/17/1820117/2" remote="cros" total_fail_count="2"/><pending_commit branch="master" change_id="I3396cd7d3f68f9aa61559a280aa97ed0e40da2e6" commit="66620fec823947a164e03c8674482b295f944d49" commit_message="bluetooth: Refactor Discovered Device Callback Mechanism Currently, upon device discovered. The device information including EIR are send to Device Interface for parsing. This change seperate the parsing from device interface into Scan Manager instead. BUG=b:141194444 TEST=unit test and manual test Change-Id: I3396cd7d3f68f9aa61559a280aa97ed0e40da2e6 Reviewed-on: https://chromium-review.googlesource.com/1809921 Tested-by: Michael Sun &lt;michaelfsun@google.com&gt; Commit-Ready: Michael Sun &lt;michaelfsun@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Miao-chen Chou &lt;mcchou@chromium.org&gt; " fail_count="5" gerrit_number="1809921" owner_email="michaelfsun@google.com" pass_count="0" patch_number="12" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/21/1809921/12" remote="cros" total_fail_count="8"/><pending_commit branch="master" change_id="Idcc875376c6c04cc0c9aa6db46f752f13946558f" commit="f4c827ed24369c9e58308d01fbf43a66cc3a4b92" commit_message="hammerd: migrate to generalized MOCK_METHOD() macro This CL replaces the uses of MOCK_METHOD*() and MOCK_CONST_METHOD*() macros in unit tests with the generalized MOCK_METHOD() macro, which is now the recommended way to define mocked methods with gmock. In particular, MOCK_METHOD() supports annotating a mocked method with specifiers such as 'override'. One minor change is that argument names are omitted in the argument list provided to MOCK_METHOD() in order to prevent clang-format from formatting code like `Foo* foo` into `Foo * foo`. BUG=None TEST=Run unit tests. Change-Id: Idcc875376c6c04cc0c9aa6db46f752f13946558f Reviewed-on: https://chromium-review.googlesource.com/1817430 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Joel Kitching &lt;kitching@chromium.org&gt; " fail_count="5" gerrit_number="1817430" owner_email="benchan@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/30/1817430/1" remote="cros" total_fail_count="5"/><pending_commit branch="master" change_id="I140c8af3a281c048f0f11f385bff1beefb4868c2" commit="8c45229054ac51741a8fe9c40d52d2725497053c" commit_message="oobe_config: migrate to generalized MOCK_METHOD() macro This CL replaces the uses of MOCK_METHOD*() and MOCK_CONST_METHOD*() macros in unit tests with the generalized MOCK_METHOD() macro, which is now the recommended way to define mocked methods with gmock. In particular, MOCK_METHOD() supports annotating a mocked method with specifiers such as 'override'. BUG=None TEST=Run unit tests. Change-Id: I140c8af3a281c048f0f11f385bff1beefb4868c2 Reviewed-on: https://chromium-review.googlesource.com/1817337 Tested-by: Ben Chan &lt;benchan@chromium.org&gt; Commit-Ready: Ben Chan &lt;benchan@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Zentaro Kavanagh &lt;zentaro@chromium.org&gt; " fail_count="3" gerrit_number="1817337" owner_email="benchan@chromium.org" pass_count="0" patch_number="1" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/37/1817337/1" remote="cros" total_fail_count="3"/><pending_commit branch="master" change_id="I4b9bbd5d86c0865a1ed3853251fe8aba47da6c35" commit="733855dc6fb1c3c79150466932441808512d402c" commit_message="diagnostics: implement PowerdEventService PowerdEventService obrerves events from PowerdAdapter, parses proto messages and notifes it's observers about power events. BUG=b:124360089 TEST=unittests Change-Id: I4b9bbd5d86c0865a1ed3853251fe8aba47da6c35 Reviewed-on: https://chromium-review.googlesource.com/1793162 Tested-by: Oleh Lamzin &lt;lamzin@google.com&gt; Commit-Ready: Oleh Lamzin &lt;lamzin@google.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Polina Bondarenko &lt;pbond@chromium.org&gt; Reviewed-by: Oleh Lamzin &lt;lamzin@google.com&gt; " fail_count="0" gerrit_number="1793162" owner_email="lamzin@google.com" pass_count="0" patch_number="6" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/62/1793162/6" remote="cros" total_fail_count="0"/><pending_commit branch="master" change_id="I17c57506bef4f8126dd227292ca1c6a24e1494c8" commit="787d375097228f960f8899271ce0aba58e597eb1" commit_message="diagnostics: Implement SendWilcoDtcMessageToUi mojo/gRPC methods BUG=b:129908963 TEST=unit_tests Change-Id: I17c57506bef4f8126dd227292ca1c6a24e1494c8 Reviewed-on: https://chromium-review.googlesource.com/1774499 Tested-by: Oleh Lamzin &lt;lamzin@google.com&gt; Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Oleh Lamzin &lt;lamzin@google.com&gt; " fail_count="4" gerrit_number="1774499" owner_email="puttaraju_r@dell.corp-partner.google.com" pass_count="0" patch_number="7" project="chromiumos/platform2" project_url="https://chromium-review.googlesource.com/chromiumos/platform2" ref="refs/changes/99/1774499/7" remote="cros" total_fail_count="4"/><pending_commit branch="master" change_id="I591bd76d2e1355a3a93f63141f92c8e43c99f787" commit="d61f5df9c149457cbcff85b02dd68db9f91cf076" commit_message="[moblab] Remove firmware version check for the verifier. The lab check is per model, so Wukong fizz is at a higher version than Wukong fizz-moblab. Drop the firmware check for moblab_host, the check will be done manually. TEST=None BUG=chromium:1006425 Change-Id: I591bd76d2e1355a3a93f63141f92c8e43c99f787 Reviewed-on: https://chromium-review.googlesource.com/1819607 Tested-by: Keith Haddow &lt;haddowk@chromium.org&gt; Commit-Ready: Keith Haddow &lt;haddowk@chromium.org&gt; Legacy-Commit-Queue: Commit Bot &lt;commit-bot@chromium.org&gt; Reviewed-by: Xixuan Wu &lt;xixuan@chromium.org&gt; " fail_count="3" gerrit_number="1819607" owner_email="haddowk@chromium.org" pass_count="0" patch_number="5" project="chromiumos/third_party/autotest" project_url="https://chromium-review.googlesource.com/chromiumos/third_party/autotest" ref="refs/changes/07/1819607/5" remote="cros" total_fail_count="4"/><lkgm version="12541.0.0-rc2"/></manifest>