|author||Yang Liang <firstname.lastname@example.org>||Wed Sep 19 16:48:09 2018|
|committer||ChromeOS Commit Bot <email@example.com>||Fri Sep 28 01:37:27 2018|
intel: ipu3: Fix 1080p still capture distorted issue The configuration from the app is as below: one 3264x2448 YUV output stream, one 1080p BLOB output stream, one 1080p IMPL output stream. The IMPL output stream runs in video pipe. The YUV output stream and BLOB output stream all run in still pipe. Because the YUV steam is the bigger, the still pipe will out 3264x2448. And the BLOB's source buffer is the 3264x2448, but the width:height ratio is not the same as the out resolution 1080p. The crop function is not implemented, so the issue happens. Crop the 3264x2448 to 3264x1836, then let it to be the source buffer of the JPEG encoder. The JPEG encoder will do the downscaling and JPEG encoding to 1080p. BUG=b:116070581 TEST=Build and deploy package to platform and camera works Change-Id: I4df4dc9b11a5b674c15fcb0ae34553f4a0fb7741 Signed-off-by: Yang Liang <firstname.lastname@example.org> Reviewed-on: https://chromium-review.googlesource.com/1234714 Commit-Ready: Wei Meng <email@example.com> Tested-by: Wei Meng <firstname.lastname@example.org> Reviewed-by: Ricky Liang <email@example.com> Reviewed-by: Hung-yu Wu <firstname.lastname@example.org> Reviewed-by: Liang L Yang <email@example.com> (cherry picked from commit 04e2262bd767af4ba813cd039a4fe56e06bc6790) Reviewed-on: https://chromium-review.googlesource.com/1248402 Tested-by: Ricky Liang <firstname.lastname@example.org> Commit-Queue: Ricky Liang <email@example.com>
The repository hosts the core Chrome OS platform camera components, including:
The camera service provider on Chrome OS is a standalone process that can be divided into two part:
Currently we have two major camera clients on Chrome OS: Chrome browser and Android container. All the clients connect to the camera HAL adapter through the Camera Module Mojo IPC interface and the Camera Device Mojo IPC interface to access camera functions. The Mojo IPC interface is very similar to the Android camera HAL v3 APIs.
Usually the platform-specific camera HAL is accompanied with a proprietary camera 3A (auto focus, auto exposure, and auto white-balance) library that provides the algorithms to control the camera subsystem for capturing high quality images. We isolate the camera 3A library in a separated sandboxed process for security consideration. The camera HAL accesses the camera 3A library through the Camera Algorithm Mojo IPC interface.
The camera HAL needs to generate JPEG images when processing still shot requests. On Chrome OS the JPEG codec service, if supported on the platform, is provided by the GPU process in Chrome browser. We provide libraries to handle JPEG encoding and decoding: On platform that supports hardware-accelerated JPEG encoder/decoder, the JPEG libraries connect to the Chrome GPU process through Mojo IPC channels to encode/decode JPEG images; othewise the JPEG encoding/decoding is done through software.
The Chrome OS camera HAL are essentially the following shared libraries, plus and dependencies required by them:
camera_hal.sothat provides the camera HAL interface. This is very similar to a regular Android camera HAL. (Required)
libcam_algo.sothat provides the camera algorithm interface for the isolated camera 3A library. (Required if the camera HAL requires 3A library to work).
We provide the following packages that are required to build the camera HAL:
A package that installs all the necessary Android headers files required by the camera HAL.
Provides functions to access the isolated camera 3A library if the camera HAL requires it to work.
A replacement for Android gralloc. The library provides APIs to import and map buffer handles received in capture requests.
A port of the Android
A port of the Android
Provides functions to access camera V4L2 devices.
A port of the Android
In addition to the required packages, we also have some useful packages that can handle some general functions for the camera HAL:
Provides utility functions to fill in the EXIF headers of a JPEG image.
Provides utility functions to encode JPEG image.
Provides utility functions to get the local timezone.
To add a new camera HAL for a new platform, one needs to upload the source code of the camera HAL to the camera HAL directory.
After the camera HAL source code is uploaded, one needs to add corresponding packages to build and install the camera HAL and the required libraries. On Chrome OS, packages are managed by ebuild files. The following ebuild files are required for a new camera HAL:
A ebuild file for the newly added camera HAL. The ebuild file is used to build the camera HAL and install the
libcam_algo.so shared libraries into the board sysroot. To integrate the camera HAL into the OS image, a
virtual/cros-camera-hal ebuild that includes the newly added camera HAL as
RDEPEND is required in the baseboard or board overlay.
For board-specific camera HAL config files, we have the
virtual/cros-camera-hal-configs ebuild. One can add a new ebuild to install the board-specific camera HAL config files, and list the new ebuild as
RDEPEND of the virtual ebuild.