)]}' { "commit": "abf9abf3073363ee5e1fa239aa0280ba8edd5c52", "tree": "3cc1efe40df7e0e068238461b662dd3dbcf7d09a", "parents": [ "c64e43ebdf03b938b3ab9a7db100e1b8b72e833b" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Sep 26 19:12:15 2013" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Mon Nov 04 20:44:56 2013" }, "message": "tweak syslog error message style\n\nThe current error message format uses angle brackets like so:\n2013-09-26T11:54:23.931018-07:00 localhost bootcache[3789]: bootcache /mnt/host/source/src/platform/bootcache/bootcache.c:eopen\u003c154\u003e open /sys/devices/virtual/block/dm-0/dm/valid: No such file or directory\u003c2\u003e\n\nFor kernel hackers, those angle brackets look wrong. It implies that\nsome log message was incorrectly split across lines. In reality, the\ncode is trying to just show some numbers.\n\nEven then, it\u0027s a little weird. The format is:\n\tprogname src_file:func\u003clineno\u003e error message...\nBut it\u0027s much more common (imo) to use the format:\n\tprogname src_file:lineno:func error message...\n\nSo tweak the format slightly to avoid these angle brackets. Now we have:\n2013-09-26T12:22:25.853974-07:00 localhost bootcache[3753]: bootcache /mnt/host/source/src/platform/bootcache/bootcache.c:154:eopen open /sys/devices/virtual/block/dm-0/dm/valid: No such file or directory (errno\u003d2)\n\nBUG\u003dNone\nTEST\u003dbooted a system and reviewed /var/log/messages\n\nChange-Id: Iab08241ef2f8804981e662124044424b0279ff04\nReviewed-on: https://chromium-review.googlesource.com/170772\nReviewed-by: Don Garrett \u003cdgarrett@chromium.org\u003e\nReviewed-by: Luigi Semenzato \u003csemenzato@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "c93eec87b253d56b07297db3ab5f13822f07d526", "old_mode": 33188, "old_path": "bootcache.c", "new_id": "5c6967e0e8827bf0624dc9e3ebf55e67d9c2f83f", "new_mode": 33188, "new_path": "bootcache.c" } ] }