commit c5151fe341f7e6cc8e001f3b59d36940badce0e1
author Tomasz Michalec <tmichalec@google.com> Thu Jul 03 15:44:03 2025
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Aug 07 09:06:53 2025
tree 426ea0e35c50f1fb67e9cc020365307921f5f0da
parent 17760ac4f6ef6943f9808860c2d4e55341c2f7e1

fastboot: Do not print variable when getting it failed

Do not print variable in "fastboot getvar all" command, when it wasn't
possible to obtain it's value.

BRANCH=main
BUG=None
TEST=FEATURES=test USE="avb test" FW_NAME=kano emerge-brya depthcharge

Change-Id: Ieec25de871b2d3cd112e9814ea5249f3f8a1db1f
Signed-off-by: Tomasz Michalec <tmichalec@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/6702484
Reviewed-by: Julius Werner <jwerner@chromium.org>

src/fastboot/vars.c

diff --git a/src/fastboot/vars.c b/src/fastboot/vars.c
index b0694d8..72b5ca4 100644
--- a/src/fastboot/vars.c
+++ b/src/fastboot/vars.c
@@ -66,9 +66,8 @@
 			} while (state == STATE_OK || state == STATE_TRY_NEXT);
 		} else {
 			size_t len = FASTBOOT_MSG_MAX;
-			fastboot_getvar(fb, var->var, NULL, 0, var_buf, &len);
-			fastboot_info(fb, "%s:%.*s", var->name, (int)len,
-				      var_buf);
+			if (fastboot_getvar(fb, var->var, NULL, 0, var_buf, &len) == STATE_OK)
+				fastboot_info(fb, "%s:%.*s", var->name, (int)len, var_buf);
 		}
 	}
 	fastboot_succeed(fb);