)]}' { "commit": "a39d889e49c745633b50301d3733e80e8a141618", "tree": "47cb48eebd816339a602ae274e0540f2a09b650f", "parents": [ "6ae8fc5c6e9b8cfc268b2b18447114b770229c3b" ], "author": { "name": "Adrian Ratiu", "email": "adrian.ratiu@collabora.corp-partner.google.com", "time": "Fri May 20 09:28:55 2022" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun May 22 16:57:06 2022" }, "message": "platform_graphics: fix gonum-plot API breakage\n\nNewer versions of gonum-plot have removed the error return\nvalue from their plot.New(). There is very little context\nwhy they did it, but changes have been done in the entire\ncodebase to drop it, for eg see upstream commit:\n\ncommit e331c55ac6e2923dc189213cd771cbdcbe350383\nAuthor: Sebastien Binet \u003cbinet@cern.ch\u003e\nDate: Sat Feb 6 16:19:59 2021 +0100\n\n all: introduce no-err New plot function\n\nSo we also drop the err return value.\n\nBUG\u003db:232947069\nTEST\u003dLocal builds in GOPATH/modules mode on x64, arm.\n\nCq-Depend: chromium:3652421\nChange-Id: I50f3eb669f5981e90a6b17a2e5e33b4dfbd988ce\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/graphics/+/3647715\nAuto-Submit: Adrian Ratiu \u003cadrian.ratiu@collabora.corp-partner.google.com\u003e\nTested-by: Adrian Ratiu \u003cadrian.ratiu@collabora.corp-partner.google.com\u003e\nCommit-Queue: Adrian Ratiu \u003cadrian.ratiu@collabora.corp-partner.google.com\u003e\nTested-by: Manoj Gupta \u003cmanojgupta@chromium.org\u003e\nReviewed-by: Po-Hsien Wang \u003cpwang@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "a093ac505ba4f33f02f08410e7b630045258f8d2", "old_mode": 33188, "old_path": "src/trace_profiling/cmd/analyze/analyze/graph.go", "new_id": "9a2f349ee30f8e7d515bc68135be66032507c7db", "new_mode": 33188, "new_path": "src/trace_profiling/cmd/analyze/analyze/graph.go" } ] }