99-inputcontrol: Drop irrelevant NAME handling
Udev complains about the use of NAME as follows:
...
udevd[1643]: event4: /lib/udev/rules.d/99-inputcontrol.rules:4 Only
network interfaces can be renamed, ignoring NAME="input/%k".
...
It's very much unclear what the intention here was.
* if it was to create a device node ... that's not how to do it (one
could use SYMLINK, for example, to create name aliases); and
/dev/input/eventX nodes are created by the kernel+devtmpfs
automatically
* if it was to *match* on a particular naming pattern, that doesn't
work either -- this is an assignment (NAME=foo) not a match
(NAME==foo). If we want to match on something about "input", we can
do that instead by 'SUBSYSTEM=="input"'
Altogether, we really just want to drop the use of NAME, because it's
doing nothing but create log noise. Add SUBSYSTEM, because that seems to
make sense here, rather than touching *every* possible device name
"event*".
NB: this seems a bit redundant with other rules (e.g.,
50-udev-default.rules already sets GROUP="input"), but I haven't proved
out that it's 100% redundant (especially the MODE), so I leave that
aspect alone.
And tweak license header to satisfy the linter.
BUG=none
TEST=`find /sys /dev -group input -exec ls -l {} \;` yields same
group/mode
TEST=udev logs are less noisy
Change-Id: I6c58275b2f3aad70a5faa9fed023e167e2cb5e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/inputcontrol/+/5440615
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>
Auto-Submit: Brian Norris <briannorris@chromium.org>
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
1 file changed
