| commit | 4c5c3411158b3850cd4eeca860b5a0a9ecb71c2b | [log] [tgz] |
|---|---|---|
| author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Tue May 28 10:14:07 2024 |
| committer | chromeos-ci-prod <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> | Tue May 28 11:19:44 2024 |
| tree | d7f348988ced7c17814532ebf9f3fe2dec410a50 | |
| parent | 55bcd368ef14474ae2f60369061b4986b9899e94 [diff] |
Revert "Rewrite previously excluded raw_ptr fields" This reverts commit 8a98a9bad2a2f3fc9a7a8e34092e95b6d4705b2a. Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8746706113493454977 Sample failed build: https://ci.chromium.org/b/8746706113493454977 If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5497157&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8746706113493454977&type=BUG Original change's description: > Rewrite previously excluded raw_ptr fields > > This rewrites pointers to byte buffers that were accidentally skipped by > the rewriter. In addition to skipping string literals, the rewriter was > wrongly skipping byte buffers. > > DanglingUntriaged-notes: Annotating pre-existing dangling pointers. > Bug: 331840473 > Change-Id: I1845d17a5edffeeb94150e17afb2166b889f4c9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497157 > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Commit-Queue: Ali Hijazi <ahijazi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1306660} > Bug: 331840473 Change-Id: Ibea32e36178bd8161e69855ab9194d2f65fba677 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5573454 Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1306670} CrOS-Libchrome-Original-Commit: 1c7549731b0de0e41f52b32c7a60ee50c39cf763
diff --git a/base/trace_event/trace_event_impl.h b/base/trace_event/trace_event_impl.h index f8ef00a..8a2bdce 100644 --- a/base/trace_event/trace_event_impl.h +++ b/base/trace_event/trace_event_impl.h
@@ -17,7 +17,6 @@ #include "base/base_export.h" #include "base/functional/callback.h" -#include "base/memory/raw_ptr.h" #include "base/process/process_handle.h" #include "base/strings/string_util.h" #include "base/threading/platform_thread.h" @@ -160,7 +159,7 @@ // The equivalence is checked with a static_assert() in trace_event_impl.cc. const char* scope_ = nullptr; unsigned long long id_ = 0u; - raw_ptr<const unsigned char> category_group_enabled_ = nullptr; + const unsigned char* category_group_enabled_ = nullptr; const char* name_ = nullptr; StringStorage parameter_copy_storage_; TraceArguments args_;