| commit | caff2b0d8ef107f69e84db9345f0456934ca2335 | [log] [tgz] |
|---|---|---|
| author | Christoph Schlosser <cschlosser@chromium.org> | Wed Aug 30 12:56:45 2023 |
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 31 13:52:29 2023 |
| tree | f8c85f10d2bc3d165a879a953ecd23c5b7ec594a | |
| parent | 0e151167bea3ae3ae4edef3a7985c00429c0ba19 [diff] |
libchrome: Add presubmit check for Chromium UMA collection code UMA collection macros or functions from Chromium don't work on CrOS and send the metrics silently into the void. Since such collecting code is used in //base changing to #ifdefs that fail to compile on CrOS isn't feasible. The hook can be overriden by the developer through --no-verify and this is fine as it should be a warning but not stopping the author if they don't need the metrics on CrOS. BUG=b:298176110 TEST=repo upload of code that collects UMA using Chromium code Change-Id: I5f2ec7503fb50315ab0e6eada4897252a36dba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/libchrome/+/4822575 Tested-by: Christoph Schlosser <cschlosser@chromium.org> Reviewed-by: Grace Cham <hscham@chromium.org> Commit-Queue: Christoph Schlosser <cschlosser@chromium.org> Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
This directory includes the source from Chrome's libbase for use in Chrome OS.
See libchrome.md for more info.