| commit | d2495c7c05bba6cf22dd1a975b7491628d2815e9 | [log] [tgz] |
|---|---|---|
| author | Paul Stewart <pstew@chromium.org> | Fri Apr 18 15:52:00 2014 |
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Tue Apr 22 16:33:45 2014 |
| tree | 08e5053b34cb6ca56f10279a481a8978cab0d6de | |
| parent | 00506193ee713399fcbae7f939be37a17f62c02b [diff] |
shill: DHCPConfig: Reorder callback and lease expiration timer The lease expiration timer should be started before calling the "UpdateProperties" method, since the latter may end up stopping the DHCPConfig instance. Otherwise, we may inadevertently start an expiration timer with no running DHCP process. The concept of having an expiration timer is attractive, so that even with a static IP configuration (the plausible reason that the config would be stopped) it might be attractive to periodically restart the lease acquisition process. However it probably makes sense to use a different timer for this purpose. Originally-Reviewed-on: https://chromium-review.googlesource.com/195560 (cherry picked from commit 97f0196ebad2ca07a79e45a1455c24f427816b58) BUG=chromium:364735 TEST=Unit tests, repro of bug steps Change-Id: Ib72cac18f017746f720ef0788efaf36f2f38d2c8 Reviewed-on: https://chromium-review.googlesource.com/196208 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>