commit 7654b7e35f11d88d999bc99c14e90857bd1372b6
author Evan Benn <evanbenn@chromium.org> Thu Sep 23 04:57:09 2021
committer Commit Bot <commit-bot@chromium.org> Mon Sep 27 12:09:39 2021
tree e3e521591b02dedb464067283468c7a277dbb1d5
parent cc5724bfd9b631489e72c736ccf29411339af241

hps: Use the dbus protobuf API

BUG=b:200630593
TEST=tast run zork hps.\*

Cq-Depend: chromium:3149794
Change-Id: Ie7e37c9159adfcad4a416ddde170dc78ce8d09c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/3177051
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Tested-by: Stuart Langley <slangley@chromium.org>

src/chromiumos/tast/local/bundles/cros/hps/dbus.go

diff --git a/src/chromiumos/tast/local/bundles/cros/hps/dbus.go b/src/chromiumos/tast/local/bundles/cros/hps/dbus.go
index 8130862..d2a7163 100644
--- a/src/chromiumos/tast/local/bundles/cros/hps/dbus.go
+++ b/src/chromiumos/tast/local/bundles/cros/hps/dbus.go
@@ -9,6 +9,7 @@
 
 	"github.com/godbus/dbus"
 
+	pb "chromiumos/system_api/hps_proto"
 	"chromiumos/tast/local/dbusutil"
 	"chromiumos/tast/local/upstart"
 	"chromiumos/tast/testing"
@@ -32,6 +33,7 @@
 		dbusName      = "org.chromium.Hps"
 		dbusPath      = "/org/chromium/Hps"
 		dbusInterface = "org.chromium.Hps"
+		dbusMethod    = "EnableHpsSense"
 
 		job = "hpsd"
 	)
@@ -45,10 +47,15 @@
 		s.Fatalf("Failed to connect to %s: %v", dbusName, err)
 	}
 
-	s.Log("Running EnableFeature(0) on hpsd")
-	if err := obj.CallWithContext(ctx, dbusInterface+".EnableFeature", 0, byte(0)).Store(); err != nil {
-		s.Error("EnableFeature(0) failed: ", err)
+	s.Log("Running EnableHpsSense(BasicFilter) on hpsd")
+	config := &pb.FeatureConfig{
+		FilterConfig: &pb.FeatureConfig_BasicFilterConfig_{
+			BasicFilterConfig: &pb.FeatureConfig_BasicFilterConfig{},
+		},
+	}
+	if err := dbusutil.CallProtoMethod(ctx, obj, dbusInterface+"."+dbusMethod, config, nil); err != nil {
+		s.Error("EnableHpsSense(BasicFilter) failed: ", err)
 	} else {
-		s.Log("EnableFeature(0) success")
+		s.Log("EnableHpsSense(BasicFilter) success")
 	}
 }