| commit | 3ea2efd38bfc021dcaf451b99f429de08c8c2ab2 | [log] [tgz] |
|---|---|---|
| author | Daniel Erat <derat@chromium.org> | Fri Mar 08 03:07:01 2019 |
| committer | chrome-bot <chrome-bot@chromium.org> | Sat Mar 09 05:21:11 2019 |
| tree | 1f37dbce783f3feb0b8cf3485757982403ccce76 | |
| parent | 2f152589f8498bf51fb020efd139eba61eb8bd63 [diff] |
tast-tests: Make chrome.Chrome use WebSocket for browser.
Update chrome.Chrome to use a WebSocket connection to
communicate with the browser instead of using the Chrome
DevTools Protocol's HTTP endpoints. There was formerly a
weird mix where chrome.Conn used WebSocket connections to
manipulate pages (including closing them), but chrome.Chrome
used HTTP to create and enumerate targets.
I'm not too optimistic that this will fix the "websocket:
bad handshake" errors that seem occasionally happen when
creating a new target after closing another target, since it
now seems like the issue is that the target isn't even being
created. But this at least makes the code more consistent
and increases what we can try in the future (e.g. watching
for targets being created or destroyed).
I'm also removing Chrome.reconnect, which doesn't appear to
help at all, and fixing some OOBE connection leaks that I
just noticed.
BUG=chromium:925703
TEST=ran tests using chrome.LoggedIn precondition in a loop
for hours
Change-Id: I31a64f6d7a5baa8293ac0d903933de6a017ea174
Reviewed-on: https://chromium-review.googlesource.com/1510713
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
This repository contains integration tests that are run by Tast.
src/chromiumos/tast/Shared code, the main tast executable, the local_test_runner and remote_test_runner executables responsible for running bundles, and documentation are located in the tast repository.
