Google Git
Sign in
chromium / chromiumos / platform / tast-tests / refs/heads/stabilize-14388.61.B
commitc69914d1b102cc191e9b8069ee0d320e638bd4c5[log] [tgz]
authorGeorg Neis <neis@chromium.org>Thu Jan 20 14:25:03 2022
committerCommit Bot <commit-bot@chromium.org>Wed Jan 26 16:02:36 2022
tree016044f8ce7cb23bf98f8135774001dfddc63697
parentd18dc646c58b283b385341d37701106a098dac3b [diff]
Lacros: Fix user tmp directory handling in fixture

A recent CL (00b4cef1cafa01d0ea714d3ecc55c971a1aad0b1) changed the
Lacros fixture code such that the fixture's userTmpDir value is no
longer constant but changes on each Reset(). However,
s.FixtValue().UserTmpDir() failed to account for these updates and
always returned the initial directory. Fix this via a pointer
indirection in fixtValueImpl.

BUG=chromium:1289202
TEST=tast run $DUT policy.ShowHomeButton.lacros policy.Disable3DAPIs.lacros

Change-Id: Iaee534ca41f19ef274a5d8024fc011635cc9323f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/3402206
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Georg Neis <neis@chromium.org>
Reviewed-by: Gabor Zsolt Magda <gabormagda@google.com>
Commit-Queue: Georg Neis <neis@chromium.org>
(cherry picked from commit e3dbec57a89f1246c6d1323ace837cf5b088bc22)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/3414804
Reviewed-by: Hyung Tae Kim <hyungtaekim@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
1 file changed
tree: 016044f8ce7cb23bf98f8135774001dfddc63697
  1. android/
  2. helpers/
  3. src/
  4. tools/
  5. vars/
  6. local_tests ⇨ src/chromiumos/tast/local/bundles/cros
  7. remote_tests ⇨ src/chromiumos/tast/remote/bundles/cros
  8. .gitignore
  9. LICENSE
  10. OWNERS
  11. PRESUBMIT.cfg
  12. PRESUBMIT.py
  13. README.md
  14. unblocked_terms.txt
README.md

Tast (tests)

This repository contains integration tests that are run by Tast.

Directory structure

  • helpers/ - Source code for binaries executed by tests.
    • local/ - Helpers for local tests that are compiled and installed to /usr/local/libexec/tast/helpers/local/cros by the tast-local-helpers-cros package.
  • src/chromiumos/tast/
    • local/ - Code related to local (i.e. on-device or “client”) tests.
      • bundles/ - Local test bundles.
        • cros/ - The “cros” local test bundle, containing standard Chrome OS tests. Tests are packaged by category.
      • ... - Packages used only by local tests.
    • remote/ - Code related to remote (i.e. off-device or “server”) tests.
      • bundles/ - Remote test bundles.
        • cros/ - The “cros” remote test bundle, containing standard Chrome OS tests. Tests are packaged by category.
      • ... - Packages used only by remote tests.

Shared code, the main tast executable, the local_test_runner and remote_test_runner executables responsible for running bundles, and documentation are located in the tast repository.

GoDoc