tast: fix go 1.26 vet breakages Go >= 1.26.0 is stricter when formatting types and will not automatically default to %v anymore when %q fails, so we need to use %v explicitly to print complex types like maps. Example error: go.chromium.org/tast/core/cmd/tast * Vetting "go.chromium.org/tast/core/cmd/remote_test_runner/..." * Vetting "go.chromium.org/tast/core/cmd/tast/..." src/go.chromium.org/tast/core/cmd/tast/internal/run/config/config_test.go:416:35: (*testing.common).Errorf format %q has arg got of wrong type map[go.chromium.org/tast/core/internal/debugger.DebugTarget]int BUG=b:489125153 TEST=Local builds with Go 1.26.0; CQ. Change-Id: Iec5e03cfa8cfacf88ab204932c8483090451216e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast/+/7627922 Reviewed-by: George Burgess <gbiv@chromium.org> Reviewed-by: See Wai Fu <seewaifu@google.com> Tested-by: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com> Auto-Submit: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com> Commit-Queue: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
diff --git a/src/go.chromium.org/tast/core/cmd/tast-lint/internal/git/git_test.go b/src/go.chromium.org/tast/core/cmd/tast-lint/internal/git/git_test.go index 165e05b..485044e 100644 --- a/src/go.chromium.org/tast/core/cmd/tast-lint/internal/git/git_test.go +++ b/src/go.chromium.org/tast/core/cmd/tast-lint/internal/git/git_test.go
@@ -156,7 +156,7 @@ {git.Added, symlinkName}, {git.Modified, testName}, }; !reflect.DeepEqual(fns, exp) { - t.Errorf("ChangedFiles() = %q; want %q", fns, exp) + t.Errorf("ChangedFiles() = %v; want %v", fns, exp) } }
diff --git a/src/go.chromium.org/tast/core/cmd/tast/internal/run/config/config_test.go b/src/go.chromium.org/tast/core/cmd/tast/internal/run/config/config_test.go index 9ba89b7..9cf98b5 100644 --- a/src/go.chromium.org/tast/core/cmd/tast/internal/run/config/config_test.go +++ b/src/go.chromium.org/tast/core/cmd/tast/internal/run/config/config_test.go
@@ -413,7 +413,7 @@ t.Fatalf(`Unexpected error in %s: %s`, tc.name, err.Error()) } if got := cfg.DebuggerPorts; !reflect.DeepEqual(got, tc.want) { - t.Errorf("cfg.DebuggerPorts = %q; want %q", got, tc.want) + t.Errorf("cfg.DebuggerPorts = %v; want %v", got, tc.want) } } }
diff --git a/src/go.chromium.org/tast/core/internal/devserver/pseudo_test.go b/src/go.chromium.org/tast/core/internal/devserver/pseudo_test.go index 246fa14..01427c4 100644 --- a/src/go.chromium.org/tast/core/internal/devserver/pseudo_test.go +++ b/src/go.chromium.org/tast/core/internal/devserver/pseudo_test.go
@@ -87,6 +87,6 @@ t.Error("Get failed: ", err) } if resp.StatusCode != 404 { - t.Errorf("Get returned %q; want %q", resp.Status, 404) + t.Errorf("Get returned %v; want %v", resp.Status, 404) } }