// Copyright 2018 The ChromiumOS Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package check

import (
	"fmt"
	"go/ast"
	"go/token"
	"path/filepath"
)

// InterFileRefs checks that entry files do not have inter-file references.
// f should be one obtained from cachedParser; that is, its references within
// the package should have been resolved, but imports should not have been
// resolved.
func InterFileRefs(fs *token.FileSet, f *ast.File) []*Issue {
	const docURL = "https://chromium.googlesource.com/chromiumos/platform/tast/+/HEAD/docs/writing_tests.md#scoping-and-shared-code"

	filename := fs.Position(f.Package).Filename
	if !isEntryFile(filename) {
		return nil
	}

	var issues []*Issue
	v := funcVisitor(func(node ast.Node) {
		// Look into resolved references only. Since we do not resolve imports,
		// all resolved references are declared in the same package.
		id, ok := node.(*ast.Ident)
		if !ok || id == nil || id.Obj == nil || id.Obj.Decl == nil {
			return
		}

		decl := id.Obj.Decl.(ast.Node)
		declFn := fs.Position(decl.Pos()).Filename
		if declFn != filename {
			issues = append(issues, &Issue{
				Pos:  fs.Position(node.Pos()),
				Msg:  fmt.Sprintf("Tast forbids inter-file references in entry files; move %s %s in %s to a shared package", id.Obj.Kind, id.Name, filepath.Base(declFn)),
				Link: docURL,
			})
		}
	})
	ast.Walk(v, f)

	return issues
}