tremplin: Fix linter errors
As part of b:218608945 `golint` will be replaced with `staticcheck` as
the default Go linter for ChromeOS. As a preliminary step we need to
ensure `staticcheck` passes with current Go packages.
This fixes the following errors[1] for test/provision (`cros-provision`):
* S1005 (unnecessary use of the blank identifier)
* S1025 (unnecessary use of fmt.Sprintf)
* SA4006 (assigned but unused variable)
* SA4017 (return value of function discarded)
* ST1005 (incorrectly formatted error strings)
* U1000 (unused const)
[1] Please refer to https://staticcheck.dev/docs/checks/ for details
about each check.
BUG=b:218608945
TEST=staticcheck -checks "inherit,-SA1019" \
"chromiumos/tremplin/..."
Change-Id: I5f45df1d5f1230c85184f0a066bb7ac5a84a0f6d
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tremplin/+/5873243
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
12 files changed
