)]}' { "commit": "527ba810eff4006cf69579f6b96cb4350cb1e189", "tree": "b6dbfc7e51af7478d8a333dbe32d3f7cc4574d8b", "parents": [ "8fa13ad6f727d44fdc0ae1d2bde5f54b32dab9b9" ], "author": { "name": "Simon Glass", "email": "sjg@chromium.org", "time": "Thu Jul 25 14:48:47 2013" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Fri Aug 30 16:47:03 2013" }, "message": "Implementation of Region API\n\nAt present reading data from storage in Vboot is a little fragmented. For\nthe firmware image, we expect the boot loader to handle this. For the disk\nwe have a block-level API. For the GBB (which also sits in the firmware\nimage) we expect the entire thing to be read before Vboot is called.\n\nAdd the concept of a region, and an API to read from a region. At present,\nand most pressing, is reading from a GBB region. In the future this could\nbe extended to other parts of the firmware or even the disk.\n\nMove all access to the GBB into this API so that the boot loader can provide\neither a GBB region in one large contiguous chunk, or a function to deal with\nread requests from vboot.\n\nThe call to VbExRegionRead() is behind a flag since not all boot loaders\nsupport it yet.\n\nThe main change for boot loaders which don\u0027t support this new API is that\nvboot will do more behind the scenes. For example, it will allocate memory\nfor chunks of data that it reads from the GBB, rather than just accessing it\ndirectly. This approach is considerably simpler than trying to pass char **\neverywhere and have vboot decide whether something needs to be allocated or\nnot.\n\nThe tests are updated, mainly to include setting up a GBB structure\naccessible from VbCommonParams, which is now required by the firmware and\nkernel functions. In normal operation this is set up at the start of\nVbLoadFIrmware() and VbSelectAndLoadKernel() but for tests which call\nchildren of these functions directly, the GBB structure must be set up\nmanually by the test.\n\nBUG\u003dchrome-os-partner:21115\nBRANCH\u003dnone\nTEST\u003dmanual\nFEATURES\u003dtest sudo -E emerge vboot_reference\n\nChange-Id: If2b8bbe467fdbd643239d8d9b5d7aa98df4d286f\nSigned-off-by: Simon Glass \u003csjg@chromium.org\u003e\nSigned-off-by: David Hendricks \u003cdhendrix@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/63336\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/167361\n", "tree_diff": [ { "type": "modify", "old_id": "403b4d62b8dd5e9427e09c6be4dea2966a1ac041", "old_mode": 33188, "old_path": "Makefile", "new_id": "b810a5f591d67331e3aeb8caaa5e65075a087905", "new_mode": 33188, "new_path": "Makefile" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "b94d0cdb6be6a5576b1beb99145e9f34c634210a", "new_mode": 33188, "new_path": "firmware/include/gbb_access.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "78e1dba0b06adbb08e634ac9952c13734c6223df", "new_mode": 33188, "new_path": "firmware/include/region.h" }, { "type": "modify", "old_id": "10adc37776d2940d462f186cf64bd4bf4ecba92b", "old_mode": 33188, "old_path": "firmware/include/vboot_api.h", "new_id": "214da753a6965695d19e9453e48b127de79f20df", "new_mode": 33188, "new_path": "firmware/include/vboot_api.h" }, { "type": "modify", "old_id": "dd6e1a8427118d5691ebc13efa1cf7f0ea77f6bb", "old_mode": 33188, "old_path": "firmware/lib/include/load_kernel_fw.h", "new_id": "a710ee5df1b993141cc4863a090de69555917a6f", "new_mode": 33188, "new_path": "firmware/lib/include/load_kernel_fw.h" }, { "type": "modify", "old_id": "17ce48b8358c75f987b78e499ea34f7f8599efe2", "old_mode": 33188, "old_path": "firmware/lib/include/vboot_display.h", "new_id": "c35f669747f1d8414f60c27e48f7104431efadb0", "new_mode": 33188, "new_path": "firmware/lib/include/vboot_display.h" }, { "type": "modify", "old_id": "1243cb84814e66888b7c5b57d260f962e62c0a1a", "old_mode": 33188, "old_path": "firmware/lib/include/vboot_kernel.h", "new_id": "48e12536e0a57a1eb52004865dabd85fc4ba0c20", "new_mode": 33188, "new_path": "firmware/lib/include/vboot_kernel.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "e2c6488a1fac7e2d91dc38190f77e5230d4ba241", "new_mode": 33188, "new_path": "firmware/lib/region-fw.c" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "bec0450df0ecd4f6fd7eb77de7424d6ff40b1c70", "new_mode": 33188, "new_path": "firmware/lib/region-init.c" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "84d474daa187a307e3155837310c3c0022121786", "new_mode": 33188, "new_path": "firmware/lib/region-kernel.c" }, { "type": "modify", "old_id": "e0c93a377db0e6d962dbd0ce5cd3974a2de818fa", "old_mode": 33188, "old_path": "firmware/lib/vboot_api_firmware.c", "new_id": "cfe4251cf9178264dd5c030cad9bfa7fbcbffb00", "new_mode": 33188, "new_path": "firmware/lib/vboot_api_firmware.c" }, { "type": "modify", "old_id": "c55e708c3ee2643a686c9ff62ad3e5b026e23b5c", "old_mode": 33188, "old_path": "firmware/lib/vboot_api_init.c", "new_id": "ebafe2a760dd9b189a8b737e3d8752ae1e77d1d1", "new_mode": 33188, "new_path": "firmware/lib/vboot_api_init.c" }, { "type": "modify", "old_id": "7ad45929120ef231ddb4eb15a38fe7acb4a70726", "old_mode": 33188, "old_path": "firmware/lib/vboot_api_kernel.c", "new_id": "4f0b3f20fc55ca202a73bc88113ed6809de4bba3", "new_mode": 33188, "new_path": "firmware/lib/vboot_api_kernel.c" }, { "type": "modify", "old_id": "5414f3258db73b96799df45a7383fe60469fb194", "old_mode": 33188, "old_path": "firmware/lib/vboot_audio.c", "new_id": "e24a039b4b67ab9db114f4d03b8526f38edd6bc5", "new_mode": 33188, "new_path": "firmware/lib/vboot_audio.c" }, { "type": "modify", "old_id": "f79dfe13b83e036e3bc8608db25b9ff43917b7ba", "old_mode": 33188, "old_path": "firmware/lib/vboot_display.c", "new_id": "910c60a03f7626628da7b3024a35e3e169f8668c", "new_mode": 33188, "new_path": "firmware/lib/vboot_display.c" }, { "type": "modify", "old_id": "c5000cb7f5785efdb3e9693fe76c25c2f3dd174a", "old_mode": 33188, "old_path": "firmware/lib/vboot_firmware.c", "new_id": "e6a31fa9095d9e7fd1607c01d7ff7ebc241806d2", "new_mode": 33188, "new_path": "firmware/lib/vboot_firmware.c" }, { "type": "modify", "old_id": "aa1e41e3f37c7127809b37424d91d55613a3466e", "old_mode": 33188, "old_path": "firmware/lib/vboot_kernel.c", "new_id": "72cd2cc1fdf94d4875ef929f004bec58529c3951", "new_mode": 33188, "new_path": "firmware/lib/vboot_kernel.c" }, { "type": "modify", "old_id": "bdf1483afc91ebd7095f00c30ff0047cf75f4fca", "old_mode": 33188, "old_path": "firmware/linktest/main.c", "new_id": "2ff8e9d7ede8a268c690639d520a275e3590acac", "new_mode": 33188, "new_path": "firmware/linktest/main.c" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "07142035ee11631a22c8aee5d98cb02c7469931f", "new_mode": 33188, "new_path": "firmware/stub/vboot_api_stub_region.c" }, { "type": "modify", "old_id": "b10bba67f7d0aa5f183925d1deab66f48926a87a", "old_mode": 33188, "old_path": "tests/vboot_api_devmode_tests.c", "new_id": "61f0de14ca23773791a01d7fd575f94dd5068f99", "new_mode": 33188, "new_path": "tests/vboot_api_devmode_tests.c" }, { "type": "modify", "old_id": "9e7c441d8a0c9597d1c21e5413cf9f924500a24f", "old_mode": 33188, "old_path": "tests/vboot_api_firmware_tests.c", "new_id": "4a97b930b7dc410c6bab9b8ebb2943b6c9f18e65", "new_mode": 33188, "new_path": "tests/vboot_api_firmware_tests.c" }, { "type": "modify", "old_id": "6451bd81bccbeb55ccfee1f060243ff13a0a0d28", "old_mode": 33188, "old_path": "tests/vboot_api_init_tests.c", "new_id": "9aa34b413f50b76130048007edfdc8f0d4cdbf39", "new_mode": 33188, "new_path": "tests/vboot_api_init_tests.c" }, { "type": "modify", "old_id": "c1572c2fefc27f473410daac5836a0f58774c438", "old_mode": 33188, "old_path": "tests/vboot_api_kernel2_tests.c", "new_id": "323f5f664c6a76f6e28b518d50d745eccb7622c3", "new_mode": 33188, "new_path": "tests/vboot_api_kernel2_tests.c" }, { "type": "modify", "old_id": "e2155f56e5ef68ab242f361d3813d16441782d62", "old_mode": 33188, "old_path": "tests/vboot_api_kernel4_tests.c", "new_id": "82b150163bacff10a6928629e77a7d53ebbec0e0", "new_mode": 33188, "new_path": "tests/vboot_api_kernel4_tests.c" }, { "type": "modify", "old_id": "87dc6cfa6f8011b8aa2547dde20fb7aec5de7bc9", "old_mode": 33188, "old_path": "tests/vboot_api_kernel_tests.c", "new_id": "8cfc1cb40f9aae892bbd978a7159c90ed96a114d", "new_mode": 33188, "new_path": "tests/vboot_api_kernel_tests.c" }, { "type": "modify", "old_id": "23667b1eb6aa9515f6961f05dda2ad28ca823560", "old_mode": 33188, "old_path": "tests/vboot_audio_tests.c", "new_id": "d674931dab9166c4cb6e3a0c7357851437b0c39f", "new_mode": 33188, "new_path": "tests/vboot_audio_tests.c" }, { "type": "modify", "old_id": "8e4a3a27981276582f938cad6806d3339e4861eb", "old_mode": 33188, "old_path": "tests/vboot_display_tests.c", "new_id": "8086d3194f1881c241b992f5a25100abd7f74cdf", "new_mode": 33188, "new_path": "tests/vboot_display_tests.c" }, { "type": "modify", "old_id": "f6b96fec246f059991f77146e6337beb501181a8", "old_mode": 33188, "old_path": "tests/vboot_firmware_tests.c", "new_id": "724e7f8b04f15a2c9205a76dfd02375c3788d9f7", "new_mode": 33188, "new_path": "tests/vboot_firmware_tests.c" }, { "type": "modify", "old_id": "6992e94a939776257d0281be59d4600b4218f5d5", "old_mode": 33188, "old_path": "tests/vboot_kernel_tests.c", "new_id": "8dde9cb61ba29f5edcfc57b7f208f4be06fb398f", "new_mode": 33188, "new_path": "tests/vboot_kernel_tests.c" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "1293136e9d2bf3b02ad7c39371928a3625ec1bf5", "new_mode": 33188, "new_path": "tests/vboot_region_tests.c" }, { "type": "modify", "old_id": "307b8ee2e8c1350794d1067c8d2af74503e116b9", "old_mode": 33188, "old_path": "utility/load_kernel_test.c", "new_id": "8e6c5191f1639359f00f825c15f2198202bece2a", "new_mode": 33188, "new_path": "utility/load_kernel_test.c" } ] }