)]}' { "log": [ { "commit": "292ad28cbbc7819cb844130bc2863822d836c623", "tree": "d3e87a93eec3f51d964545be608f619fe6075562", "parents": [ "9b3c34468c8b0300672ac7928e8c20765a89be8b" ], "author": { "name": "Doug Anderson", "email": "dianders@chromium.org", "time": "Tue Nov 22 00:23:48 2011" }, "committer": { "name": "Gerrit", "email": "chrome-bot@google.com", "time": "Tue Nov 22 01:15:38 2011" }, "message": "wm: Avoid log spew in window manager logs.\n\nOn developer builds (where NDEBUG is not defined), the window\nmanager logs are growing uncontrollably. After a few days (Nov 17\nthough Nov 21), I\u0027ve got almost a gigabyte of logs:\n\n # du -sh /var/log/window_manager/\n 923M /var/log/window_manager/\n\nThis machine has really just been sitting at the login prompt.\nAfter the initial bit of debug info, logs are filled with:\n\n [1121/131449:21180773:INFO:opengles_visitor.cc(227)] Performing partial screen update: 405, 570, 23, 22.\n [1121/131449:21181179:INFO:opengles_visitor.cc(267)] Visit container: stage\n [1121/131449:21258991:INFO:opengles_visitor.cc(227)] Performing partial screen update: 405, 570, 23, 22.\n [1121/131449:21259441:INFO:opengles_visitor.cc(267)] Visit container: stage\n [1121/131449:21336403:INFO:opengles_visitor.cc(227)] Performing partial screen update: 405, 570, 23, 22.\n [1121/131449:21336905:INFO:opengles_visitor.cc(267)] Visit container: stage\n\nThese messages aren\u0027t providing enough useful information to the\naverage user to justify such log spew. Deleting them so that we can\nstill keep other INFO-level logs around but don\u0027t get these ones.\n\nNOTE that filling up /var/log so badly had the effect of\nmaking all autotests take forever, so this should really help the\naverage developer.\n\nBUG\u003dNone\nTEST\u003dEmerged and saw that log spew was gone.\n\nChange-Id: I60d727bb8f37456a232d75aed8eabc5c59fdf0e0\nReviewed-on: https://gerrit.chromium.org/gerrit/12011\nTested-by: Doug Anderson \u003cdianders@chromium.org\u003e\nReviewed-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\nCommit-Ready: Doug Anderson \u003cdianders@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "9b3c34468c8b0300672ac7928e8c20765a89be8b", "tree": "5b66b65a91b517052f1252a80631ca6216800ec9", "parents": [ "0217f2b36ddaae8640427a5283fa113070b381f9" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Oct 06 19:11:51 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Oct 10 19:59:25 2011" }, "message": "wm: Defer GL texture refreshes when compositing.\n\nWait to update textures from GLX pixmaps until we\u0027re drawing\nthe frame. This avoids the case where a backlog of damage\nevents builds up when texture updating is slow (e.g.\nsoftware rendering).\n\nBUG\u003dchromium-os:20971\nTEST\u003dadded one; also manually tested that update latency still seems okay when compositing on alex\n\nChange-Id: I502fbd639788d4d076a7f09d608625e67ac4ad6b\nReviewed-on: http://gerrit.chromium.org/gerrit/8872\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\n" }, { "commit": "0217f2b36ddaae8640427a5283fa113070b381f9", "tree": "bfe540b88e37b8fc2125f153de3ce299b819a1f0", "parents": [ "3280e0adb0312239e34ec22015bb01cdc165d912" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Sep 29 16:25:15 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Oct 03 23:25:54 2011" }, "message": "wm: Increase duration of screen locker fade-in to 450 ms.\n\nThe 50-millisecond fade that was there looked overly abrupt\nnow that the screen locker window is white instead of dark\nblue.\n\nBUG\u003dchromium-os:20948\nTEST\u003dmanual\n\nChange-Id: I4b5d7ac25b99e1a80e13b2d45255ad8539c1ed4e\nReviewed-on: http://gerrit.chromium.org/gerrit/8580\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "3280e0adb0312239e34ec22015bb01cdc165d912", "tree": "08e24e5c39b028c27646bcb2fdb3c0486a8f92fb", "parents": [ "2f6752957e4e2262503510e883d1ebe17a5bc31e" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Sep 30 01:02:01 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Sep 30 16:24:32 2011" }, "message": "wm: Draw shadows under 24-bit transient windows.\n\nNow that Chrome is using rectangular windows for its\ndialogs, the window manager should draw shadows under them\nagain.\n\nBUG\u003dchromium-os:20997\nTEST\u003dadded; also manually tested that the task manager and file browser windows get shadows after updating chrome to use 24-bit windows instead of 32-bit ones for them\n\nChange-Id: Iaf14f9795e29d9fd623c3ea1dadde522ce4b7197\nReviewed-on: http://gerrit.chromium.org/gerrit/8538\nCommit-Ready: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "2f6752957e4e2262503510e883d1ebe17a5bc31e", "tree": "42d72a426adde3ac659e811e9e37a50dff0fb08f", "parents": [ "6c7c95b41805fb8f8c38f3b555f937ba2bc2576e" ], "author": { "name": "Ivan Korotkov", "email": "ivankr@chromium.org", "time": "Mon Sep 12 14:03:37 2011" }, "committer": { "name": "Ivan Korotkov", "email": "ivankr@chromium.org", "time": "Tue Sep 13 16:20:19 2011" }, "message": "Focus is returned from modal dialogs to parent window in WebUI after user is logged in.\n\nBUG\u003dNone\nTEST\u003dLoginControllerTest.FocusTransientParentWebUILoggedIn\n\nChange-Id: I6bf1a6ab999a1a174b5a8f33e860cc548f747de0\nReviewed-on: http://gerrit.chromium.org/gerrit/7537\nReviewed-by: Ivan Korotkov \u003civankr@chromium.org\u003e\nTested-by: Ivan Korotkov \u003civankr@chromium.org\u003e\n" }, { "commit": "6c7c95b41805fb8f8c38f3b555f937ba2bc2576e", "tree": "88c5ab30d752ff3e6d74e88625ba5491fe095a56", "parents": [ "f19b9401ca471509488ea8894a410f7be696d61e" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Sep 06 22:25:48 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Sep 07 03:28:18 2011" }, "message": "wm: Fix compilation on gcc-4.6.0.\n\nBUG\u003dchromium-os:20071\nTEST\u003dbuilt it\n\nChange-Id: Idcadb48c1ebe55073cddcde78d710591f1123709\nReviewed-on: http://gerrit.chromium.org/gerrit/7296\nReviewed-by: asharif \u003casharif@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "f19b9401ca471509488ea8894a410f7be696d61e", "tree": "e29dd9484006899cbf0b738f8b8aea9a4bc26982", "parents": [ "e662964dde4d19d1f2c6b6a24e8b4bf46bbf73e9" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Aug 31 23:12:45 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Sep 01 20:02:14 2011" }, "message": "wm: Avoid focusing windows in response to scrolling.\n\nThis makes us only install grabs for buttons 1-3 (instead of\nfor all buttons) on unfocused windows, and also makes the\nlayout manager ignore scrollwheel events on the windows at\nthe edges of the screen in overlapping-windows mode.\n\nBUG\u003dchromium-os:19770\nTEST\u003dadded tests; also manually tested by checking that a focused panel keeps the focus when i scroll in browser window and vice versa\n\nChange-Id: I2ea7b844d6e9c458ec8d5ab28e6eae69410d865c\nReviewed-on: http://gerrit.chromium.org/gerrit/7045\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "e662964dde4d19d1f2c6b6a24e8b4bf46bbf73e9", "tree": "6c7eb6bb66bba968a5f438c6116efa2c975b4eac", "parents": [ "9f7ba3a569146c034818c7f14c4fd41583fb5469" ], "author": { "name": "Satoru Takabayashi", "email": "satorux@chromium.org", "time": "Wed Aug 17 20:34:20 2011" }, "committer": { "name": "Satoru Takabayashi", "email": "satorux@chromium.org", "time": "Wed Aug 17 20:50:56 2011" }, "message": "wm: Stop linking libchromeos.\n\nWe no longer need to link libchromeos to use D-Bus service constants.\nIncluding dbus/service_constants.h, provided by system_api, just suffices.\n\nBUG\u003dchromium-os:19054\nTEST\u003demerge-x86-alex chromeos-wm\n\nChange-Id: I7799e0381a0bebd0e27c4834b8ba4c2f48b5f299\nReviewed-on: http://gerrit.chromium.org/gerrit/6177\nTested-by: Satoru Takabayashi \u003csatorux@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "9f7ba3a569146c034818c7f14c4fd41583fb5469", "tree": "88d487ccb19d00fae6cee4f4725900087db59cfd", "parents": [ "55605f9cce30d6cc7191d41edc81df459b1dc02f" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Aug 15 15:47:35 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Aug 15 21:13:05 2011" }, "message": "wm: Display a message onscreen at startup for debug builds.\n\nBUG\u003dchromium-os:19060\nTEST\u003dmanual\n\nChange-Id: Ie85c6ca4864e1ba0b1a7eb39ee93ca25fb0b37d8\nReviewed-on: http://gerrit.chromium.org/gerrit/5995\nReviewed-by: Dave Moore \u003cdavemoore@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "55605f9cce30d6cc7191d41edc81df459b1dc02f", "tree": "99015d769bf976cfb9976e3a690d2f71c93e6dcf", "parents": [ "f897b0cf3098ab71f40a29befeea5751ada05d8d" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Aug 08 16:15:09 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Aug 09 21:36:46 2011" }, "message": "wm: Avoid leak if a duplicate login window is mapped.\n\nThis is just a guess at a possible cause for a failed assert\nthat I\u0027ve noticed on the crash server. If a second WebUI,\nbackground, or wizard/guest window gets mapped,\nLoginController should unregister its interest in the\nearlier window.\n\nBUG\u003dchromium-os:18809\nTEST\u003dadded a test for the duplicate-wizard-window case\n\nChange-Id: I46ec5b1c3277dcc2f87e6a3b0a4e30d1bc448335\nReviewed-on: http://gerrit.chromium.org/gerrit/5495\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "f897b0cf3098ab71f40a29befeea5751ada05d8d", "tree": "c0851063b431efe5ae5e8240e228bdf37937ad40", "parents": [ "70124f0a39db84331df222ba93d575d14e722d31" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Aug 05 01:32:49 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Aug 08 21:47:54 2011" }, "message": "wm: Add squish animation on no-op F5 with a single window.\n\nThis adds visual feedback when the F5 (\"[ ]]]\") key is\npressed when there\u0027s only a single browser window open (so\nwe can\u0027t perform the usual action of switching to\noverlapping-windows mode).\n\nBUG\u003dchromium-os:18700\nTEST\u003dmanual; also added a test for a compositor change\n\nChange-Id: I009c2c529822a4a700edf2504582917af6fd9ba3\nReviewed-on: http://gerrit.chromium.org/gerrit/5486\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "70124f0a39db84331df222ba93d575d14e722d31", "tree": "7e5ff4d0c5059ff3ae845f81f2fb38305fe1bb61", "parents": [ "c5c577c1cda44ebbe07ee1c329bccc2f21acf72d" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Aug 04 23:39:45 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Aug 04 23:54:53 2011" }, "message": "wm: Don\u0027t automatically overlap browser windows.\n\nThis makes us stay in maximized-window mode when a second\nbrowser window is mapped. Overlapping mode can still be\ntoggled when multiple windows are open by hitting the F5\n(\"[ ]]]\") key or by clicking the maximize/restore icon in\nthe upper-right corner.\n\nBUG\u003dchromium-os:18699\nTEST\u003dmanual, also added a test for the flag\n\nChange-Id: Id79be66dd5ba650b5bc032cc93136a1e943d2aa0\nReviewed-on: http://gerrit.chromium.org/gerrit/5355\nReviewed-by: Dave Moore \u003cdavemoore@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "c5c577c1cda44ebbe07ee1c329bccc2f21acf72d", "tree": "e472d28702a78145b3bd4a50ae9629e587e39849", "parents": [ "731228847bc3546abb9a2b4221c796625c8e0bfe" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jul 28 00:28:13 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Aug 04 22:24:32 2011" }, "message": "wm: Display borders when hovering over resize handles.\n\nThis makes us display a translucent black box when the\npointer is over a border that can dragged to resize a\nbrowser window.\n\nIdeally, we\u0027d do something similar for panels as well, and\nwe\u0027d fade to a nicer-looking, heavier shadow instead of just\ndrawing a translucent box. This doesn\u0027t look too terrible\nto me, though, and gives us a way to see how this feels.\n\nBUG\u003dchromium-os:18092\nTEST\u003dmanual; also added tests\n\nChange-Id: I3b10a2c849aa741a2f5db2b8c67cc7dac6039169\nReviewed-on: http://gerrit.chromium.org/gerrit/5236\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "731228847bc3546abb9a2b4221c796625c8e0bfe", "tree": "4b2c098f7f4794bbb1c3d457e8ae6f3d025cce0a", "parents": [ "2b6e4fb7eab2db4fdbdcf1b48cc5ba27dc9741db" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Aug 03 17:49:13 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Aug 03 20:55:17 2011" }, "message": "wm: Fix some timerfd leaks.\n\nThere were a few places where I wasn\u0027t removing one-shot\ntimeouts after they fired. This corrects that, adds a\nDCHECK() to EventLoop\u0027s d\u0027tor to make these easier to catch,\nand makes mostly-cosmetic cleanups to some other\ntimeout-related code.\n\nBUG\u003dchromium-os:18556\nTEST\u003dverified that updated tests pass; also ran this code, locked and unlocked the screen several times, and checked that what I think is the expected number of timer FDs are open (two: one for the compositor and one for the watchdog) -- with the old code, there are more open and the number grows whenever I lock and unlock the screen\n\nChange-Id: I307921bdf35a5c787881fb27911f1989427bbb65\nReviewed-on: http://gerrit.chromium.org/gerrit/5222\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "2b6e4fb7eab2db4fdbdcf1b48cc5ba27dc9741db", "tree": "6e6b95824d0a17ae424c9a4c63c34fc6e041abbf", "parents": [ "48726641d16d6c5c236585b8b5221b6fec0b6252" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jul 28 16:37:06 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Aug 01 23:35:49 2011" }, "message": "wm: Snap to maximized when interactively resizing browser.\n\nThis makes the interactive resize triggered by dragging a\nbrowser window\u0027s border snap to maximized mode if the user\ndrags 50 pixels or more beyond the maximum width permitted\nfor unmaximized windows.\n\nBUG\u003dchromium-os:17160\nTEST\u003dmanual; also added a simple test\n\nChange-Id: I0514bfecfc6ec913f00fe56111e14c6d1ea826bb\nReviewed-on: http://gerrit.chromium.org/gerrit/4965\nTested-by: David Reveman \u003creveman@chromium.org\u003e\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "48726641d16d6c5c236585b8b5221b6fec0b6252", "tree": "6dd8c4cc0c9a20558c9092c3a14ab5f4526b10b0", "parents": [ "a6531b90974718192287c292e64a73b5bcd60629" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jul 25 17:52:51 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jul 26 00:00:49 2011" }, "message": "wm: Switch to last window on Alt-9.\n\nAlt-1 through Alt-8 were implemented, but Alt-9 wasn\u0027t doing\nanything.\n\nBUG\u003dchromium-os:18129\nTEST\u003dmanual; also wrote a test for these hotkeys\n\nChange-Id: I5ac31147e26213fdd83696156a7a862c13b5097b\nReviewed-on: http://gerrit.chromium.org/gerrit/4679\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "a6531b90974718192287c292e64a73b5bcd60629", "tree": "f3a8d11629c6835f119d8721700cb7b410c65a14", "parents": [ "448828e7987d9b5d98f95ba62425908648ddc54c" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jul 22 02:38:16 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jul 22 17:25:08 2011" }, "message": "wm: Focus newest-mapped modal window.\n\nUpdate the window manager so that when a browser has\nmultiple modal transient windows, the most-recently-mapped\none gets the focus and is raised above its siblings.\n\nBUG\u003dchromium-os:17642\nTEST\u003dadded; manual testing suggests that there may be another issue in chrome\n\nChange-Id: I1cbe1dff6c590a25aa0c134be5748e44ff7d98dd\nReviewed-on: http://gerrit.chromium.org/gerrit/4551\nReviewed-by: James Cook \u003cjamescook@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "448828e7987d9b5d98f95ba62425908648ddc54c", "tree": "58a36383e3f9c7fc60e6655db109f478b7657318", "parents": [ "a2bc12e3761d2c1d41b69c2a334af60262e7bd4c" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Jul 13 17:18:19 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Sun Jul 17 18:08:51 2011" }, "message": "wm: Screenshot user-selectable region on Ctrl-Shift-F5.\n\nI am tired of scp-ing screenshots and running Gimp to crop\nthem whenever I\u0027m filing a bug. This adds a --region flag\nto the screenshot program, triggering an interactive mode\nwhere a box can be dragged to take a screenshot. Escape\naborts.\n\nI think that the usual way to do rubber-banding is by\ngrabbing the server and painting on the root window with an\ninverting GC, but I don\u0027t think that that\u0027ll work with a\ncompositing window manager. This code just uses four\nwindows to draw black and white borders around the region\ninstead.\n\nBUG\u003dnone\nTEST\u003dmanual\n\nChange-Id: If6ebc4efe09413542a8d8f7b131dae8111c5c814\nReviewed-on: http://gerrit.chromium.org/gerrit/4198\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "a2bc12e3761d2c1d41b69c2a334af60262e7bd4c", "tree": "1d8bde533e7d3058440b568d5e3a7588d3afa621", "parents": [ "2194f53ad0936787bcab17cad6db20b29a3441a9" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jul 12 00:26:04 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jul 15 16:04:13 2011" }, "message": "wm: Make layout code take panel dock size into account.\n\nThe (unfinished) panel docking code is still disabled by\ndefault (see --allow_panels_to_be_detached), but this\nupdates the new layout code to take the dock sizes into\naccount. (The old layout code already supported this; I\njust didn\u0027t bother porting it).\n\nBUG\u003dchromium-os:16616\nTEST\u003dadded; also did manual testing\n\nChange-Id: Icc0d27576e57ada12186352b399eabdf65c58de0\nReviewed-on: http://gerrit.chromium.org/gerrit/4069\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "2194f53ad0936787bcab17cad6db20b29a3441a9", "tree": "5f875f0bb46b3e21cc8a7d7d3d54024e12cd5739", "parents": [ "9312fc4dd583aaa56a12679cd189e3b4b5e46e9e" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jul 14 18:50:15 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jul 14 19:30:13 2011" }, "message": "wm: Avoid animating Views login after WebUI is ready.\n\nI don\u0027t think that the original intent was to mix WebUI and\nViews login windows, but that seems to be what we\u0027re doing\nnow. This change tracks the \"WebUI is ready\" state so we\ndon\u0027t do initialization for both WebUI and Views if a Views\nwindow gets mapped later.\n\nBUG\u003dchromium-os:1706\nTEST\u003dxiyuan says it works\n\nChange-Id: Ibe9824a83f1fcf3471310ce91a03d58ab0ea4ad2\nReviewed-on: http://gerrit.chromium.org/gerrit/4103\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "9312fc4dd583aaa56a12679cd189e3b4b5e46e9e", "tree": "901fa5c608022ca0f6e527b73c39082e0968c57c", "parents": [ "94b8bab01e506a0e6a513a335fc52e236526e529" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jul 11 23:16:37 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jul 12 23:37:24 2011" }, "message": "wm: Avoid crash when recycled windows are configured.\n\nThis avoids an infrequent failed assert that I believe is\nhappening when a window is mapped and has its visibility set\nbefore getting unmapped and configured.\n\nBUG\u003dchromium-os:17376\nTEST\u003dadded\n\nChange-Id: I0b2144a0f0ffe7bc49cf0bea9e7b8c75acf2cac3\nReviewed-on: http://gerrit.chromium.org/gerrit/3902\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "94b8bab01e506a0e6a513a335fc52e236526e529", "tree": "7dc0fb37079e7e15ee1f25c340efb18de7b51f95", "parents": [ "530b1b920dd7e54f2fe277f82dbd2c3b510156a3" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jul 08 01:15:35 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jul 11 16:07:50 2011" }, "message": "wm: Avoid crash when browser is unmapped before transients.\n\nThis avoids a crash when a browser gets unmapped before its\ntransient windows.\n\nBUG\u003dchromium-os:17377\nTEST\u003dadded\n\nChange-Id: Id9fb78e952848cc63d7df4e3c7359d480ad453a0\nReviewed-on: http://gerrit.chromium.org/gerrit/3771\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "530b1b920dd7e54f2fe277f82dbd2c3b510156a3", "tree": "4267431023d68716371e0e95d352e55b10d51697", "parents": [ "8740631ef712295295f02bcb0b5a4b78a09377e0" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jul 07 21:25:00 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jul 08 00:27:43 2011" }, "message": "wm: Refocus window after screen unlock.\n\nWe weren\u0027t doing anything with the input focus after the\nscreen locker window got unmapped. This wasn\u0027t super\nobvious since the focus would just follow the pointer until\nthe next time we explicitly assigned it.\n\nBUG\u003dnone\nTEST\u003dmanual; also added a test\n\nChange-Id: I0ee92b85dd0608f2401b5a45314e09bf22a99295\nReviewed-on: http://gerrit.chromium.org/gerrit/3754\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "8740631ef712295295f02bcb0b5a4b78a09377e0", "tree": "2c98417823efeaf695bcfe95fb94a1691b5f0794", "parents": [ "e74fc273e0d4f8a7e8f14f0c9b708e70e89c167c" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jul 07 00:10:15 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jul 08 00:26:13 2011" }, "message": "wm: Improve handling of non-Chrome windows.\n\nWhen there\u0027s a Chrome window on the left side of the screen\nand a terminal window on the right, refrain from hiding the\nChrome window\u0027s status area.\n\nAlso send a delete request to the focused window on\nCtrl-Shift-W if it isn\u0027t a Chrome window. This provides a\nway to close e.g. terminals containing hanging SSH sessions.\nI\u0027m still a bit concerned that Ctrl-Shift-W will be easy to\naccidentally type when holding Shift to type a capitalized\nword and then hitting Ctrl-W to delete it, but Ctrl-Shift-W\nmatches CHrome\u0027s \"close window\" binding, and I can\u0027t think\nof anything better. We\u0027ll see...\n\nBUG\u003dchromium-os:17236,chromium-os:10023\nTEST\u003dadded tests\n\nChange-Id: If0aa1cb959f38df1f0eaa23c39cac8625aab5777\nReviewed-on: http://gerrit.chromium.org/gerrit/3697\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "e74fc273e0d4f8a7e8f14f0c9b708e70e89c167c", "tree": "af291c1ffa1c5ab4555f2b188727a3c0484b3de2", "parents": [ "6d34fc5faee63fb2a42a3771c57422c6d6a62f61" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jul 01 00:48:22 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jul 07 01:27:21 2011" }, "message": "wm: Save screenshots directly to file shelf.\n\nWrite Ctrl-F5 screenshots to /home/chronos/user/Downloads\ninstead of to /home/chronos/user/Downloads/Screenshots.\n\nBUG\u003dchromium-os:16883\nTEST\u003dmanual: hit Ctrl-F5, then Ctrl-O\n\nChange-Id: I11bd524c36ffccb8ff5082a0a8a779976432161d\nReviewed-on: http://gerrit.chromium.org/gerrit/3528\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "6d34fc5faee63fb2a42a3771c57422c6d6a62f61", "tree": "6ffe98ea6d9985b2689db56954e779c8fd953305", "parents": [ "cdd42fffa569ef7f301eb5d104e2bfc8d44c3ff9" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 06 15:47:47 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Jul 06 19:24:07 2011" }, "message": "wm: Replace system() calls with fork-exec.\n\nThis replaces the previous system() calls with a manual\nfork() and exec().\n\nBUG\u003dchromium-os:16153\nTEST\u003dmanual: launched a terminal and checked that /proc listed the expected FDs and that there wasn\u0027t a zombie hanging around after the terminal exited\n\nChange-Id: Ib70ea1dc6f687bb32eaf6da69a2f7527290c03b8\nReviewed-on: http://gerrit.chromium.org/gerrit/2766\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "cdd42fffa569ef7f301eb5d104e2bfc8d44c3ff9", "tree": "d7f65a4c1e763b2fa6e038598abb57c00a938b6f", "parents": [ "675ff2d5d110cfb3d92bd805d92f2d3785cde5d3" ], "author": { "name": "Nikita Kostylev", "email": "nkostylev@chromium.org", "time": "Fri Jul 01 21:56:53 2011" }, "committer": { "name": "Nikita Kostylev", "email": "nkostylev@chromium.org", "time": "Fri Jul 01 23:47:23 2011" }, "message": "Stack WebUI window to LAYER_LOGIN_WINDOW.\nLAYER_LOGIN_OTHER_WINDOW is used for info bubbles and dialogs.\n\nTested with http://codereview.chromium.org/7285029/\n\nBUG\u003dchromium-os:16177\nTEST\u003dManual. Network control window is positioned correctly.\n\nChange-Id: I0177dde54947a4032fe5f578c437e902003db248\nReviewed-on: http://gerrit.chromium.org/gerrit/3586\nTested-by: Nikita Kostylev \u003cnkostylev@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "675ff2d5d110cfb3d92bd805d92f2d3785cde5d3", "tree": "e9824612dc4dd4b16a7fdab2720a76d2e4b4486b", "parents": [ "f9120230b6b930361a8eafec1b46bde014dd9182" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jun 30 18:27:48 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jul 01 15:23:11 2011" }, "message": "wm: Fix float comparisons in compositor culling code.\n\nThe culling code does floating-point arithmetic and compares\nthe results directly against literals. Tests exercising\nthis code fail on some CPU architectures. This change\nfudges the literals enough to compensate for the\ndifferences.\n\nBUG\u003dnone\nTEST\u003dtests pass now; also ran the code and checked that it still appears to function properly\n\nChange-Id: Ic14d4d3df6595d7c84c02e7ba5df055b0ecc1728\nReviewed-on: http://gerrit.chromium.org/gerrit/3478\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "f9120230b6b930361a8eafec1b46bde014dd9182", "tree": "6eb59e23a945b8428a211029b7048895acb39355", "parents": [ "ea5d064515c4ddb8cfc94c7069130b6eb90a316e" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jun 30 01:18:26 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jun 30 16:02:19 2011" }, "message": "wm: Round animation_test values to ints.\n\nDespite using EXPECT_FLOAT_EQ(), we\u0027re seeing failures on\nother CPU architectures. The compositor rounds animation\nvalues to int as well, so having the test do this seems\nlegit.\n\nBUG\u003dnone\nTEST\u003dit passes now (other tests still fail)\n\nChange-Id: I3feb653b8467c0ad1d5f94649a48b108b3b55e83\nReviewed-on: http://gerrit.chromium.org/gerrit/3428\nReviewed-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "ea5d064515c4ddb8cfc94c7069130b6eb90a316e", "tree": "ebda34b967b719311023b1ac5b22e8d33e247244", "parents": [ "3dc9636f8dca8b1bf582d4aa64e23140ebc824a4" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Jun 29 15:22:49 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jun 30 00:10:08 2011" }, "message": "wm: Don\u0027t focus browsers in response to status area clicks.\n\nThis makes us fetch the _CHROME_STATUS_BOUNDS property to\nlearn about the bounds of a window\u0027s status area. We use\nthis to let the user click in an inactive browser\u0027s status\narea without focusing it.\n\nBUG\u003dchromium-os:17083\nTEST\u003dadded\n\nChange-Id: I6560c0495b94a2d421429652833300e39c390bde\nReviewed-on: http://gerrit.chromium.org/gerrit/3385\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\n" }, { "commit": "3dc9636f8dca8b1bf582d4aa64e23140ebc824a4", "tree": "d608688706a7311d58c50ed3f929838eb0cf4ae8", "parents": [ "8de41c2e007969d20472fc60f00f894a378d5fea" ], "author": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Wed Jun 29 05:11:04 2011" }, "committer": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Wed Jun 29 18:17:46 2011" }, "message": "wm: Fix actor clip rect accuracy.\n\nClip rects and bounds need to be rounded differently. Clip rects need to\nbe mapped to stage coordinates accurately while we need to be properly\nconservative when mapping actor bounds.\n\nBUG\u003dchromium-os:17043\nTEST\u003dNew unit test\n\nChange-Id: Ifc89862b9e52f2e1f364fcc0d562ae3ff1a0120a\nReviewed-on: http://gerrit.chromium.org/gerrit/3366\nTested-by: David Reveman \u003creveman@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "8de41c2e007969d20472fc60f00f894a378d5fea", "tree": "953f36e13a28aed49190802454a27c2f8b8800d0", "parents": [ "2a49e9d3b0f7dc3d8a060b16578d286a5809023b" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jun 28 17:35:48 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jun 28 19:50:26 2011" }, "message": "wm: Enable overlapping-windows mode.\n\nThis removes --multiple_windows\u003dfalse from\n/sbin/window-manager-session.sh.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual: built and ran it\n\nChange-Id: I6b7899448bf5c9aceb60d773345cc6298a09bfc3\nReviewed-on: http://gerrit.chromium.org/gerrit/3311\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "2a49e9d3b0f7dc3d8a060b16578d286a5809023b", "tree": "a91c725e8176044f487fb94b04fc7da64d68935e", "parents": [ "3ff0d5ff0ed5bd1d2d98c8c1505a5362a9292d90" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jun 28 01:29:30 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jun 28 19:47:34 2011" }, "message": "wm: Shrink the status area to 180 pixels.\n\nThis reduces the amount of space that we reserve onscreen\nfor Chrome\u0027s status area from 200 pixels to 180, which seems\nto still be enough when multiple input methods are enabled\nand leaves a bit more room for the active browser (the\nmaximum browser width was less than 1024 pixels on Alex and\nMario, otherwise).\n\nUnrelated, but also set names for a few compositing actors\nthat I missed before.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual: checked that unmaximized windows start out at 1024 pixels now\n\nChange-Id: I51c4136e628fe467f99efd63464d57eae00c0db8\nReviewed-on: http://gerrit.chromium.org/gerrit/3289\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "3ff0d5ff0ed5bd1d2d98c8c1505a5362a9292d90", "tree": "6fe319ec7f40f734fa311317b6e2b54e44135745", "parents": [ "57eeb9ba6af1eee0aca5550054dec0a36e4565fd" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jun 23 22:51:58 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 27 18:06:29 2011" }, "message": "wm: Support client requests to change layout modes.\n\nThis makes the window manager honor\nWM_IPC_MESSAGE_WM_SET_LAYOUT_MODE messages from Chrome\nasking it to switch layout modes (e.g. with maximized or\noverlapping windows). It also now sets a\n_CHROME_LAYOUT_MODE property on the root window that Chrome\ncan watch to track the current mode.\n\nI\u0027m also removing the Alt-Enter shortcut to toggle maximized\nmode, since it conflicts with Chrome\u0027s open-URL-in-new-tab\nomnibox shortcut. F5 still works for toggling modes.\n\nBUG\u003dchromium-os:13963,chromium-os:16818\nTEST\u003dmanual; also added tests\n\nChange-Id: Ic97808650aa84aa6472426a317e15bd0003328b0\nReviewed-on: http://gerrit.chromium.org/gerrit/3145\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "57eeb9ba6af1eee0aca5550054dec0a36e4565fd", "tree": "aff1109c777bdcb44168a46ba4dd7501b73948d6", "parents": [ "a9a6c3c2e978d18e5b0681d148e71f2dbcc4d076" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jun 24 20:31:53 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 27 17:44:01 2011" }, "message": "wm: Minor improvement to dimming of secondary browser.\n\nThis is small change to correct part of b604c918\u0027s behavior\nthat I found disorienting:\n\n 1. Open three browsers.\n 2. Activate second browser.\n 3. Hit Alt-Tab to switch to third browser.\n Second browser begins gradually dimming.\n 4. Hit Alt-Tab again to cycle to first browser.\n Second browser jumps to 90% brightness immediately.\n\nWith this change, the second browser instead continues\ngradually dimming in step 4.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual\n\nChange-Id: I90ebac2a11b3cc0326fddb7ba1e83f9c15755dd3\nReviewed-on: http://gerrit.chromium.org/gerrit/3187\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "a9a6c3c2e978d18e5b0681d148e71f2dbcc4d076", "tree": "49394814188cb5846ab1c6d85a4e5ad05dbc5010", "parents": [ "b604c918f5c807dcc8473fc9bd051447cb96a034" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jun 24 16:36:30 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jun 24 21:05:30 2011" }, "message": "wm: Avoid jank when switching layout modes.\n\nThis makes the window manager smarter about the order in\nwhich it resizes browser windows when switching from\noverlapping mode to maximized mode or vice versa. When\nswitching to maximized mode, we wait for the active browser\nto be fully covering the screen before configuring other\nbrowsers; when switching to overlapping, we wait for all of\nthe other browsers to be in place before resizing the active\nbrowser.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual; also added a test\n\nChange-Id: I4f107ddeddf6618e8ffbcd8d8f0c49f36c978046\nReviewed-on: http://gerrit.chromium.org/gerrit/3175\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "b604c918f5c807dcc8473fc9bd051447cb96a034", "tree": "8964ace3e804c07121eed49e9b4a0cb286e40854", "parents": [ "28ca158ecebd885b9a3cca9a17241d57e8ee0517" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jun 16 23:39:42 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jun 24 15:12:19 2011" }, "message": "wm: Gradually dim secondary browser window.\n\nWe dim the secondary (onscreen but unfocused) browser window\nto 90% brightness over ten seconds when it loses the focus.\nThis makes it easier to tell at a glance where the focus is.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual; also added expectations to existing layout tests\n\nChange-Id: Ida15b84a37a27db2b1c4b0753e5e7619b3e3da07\nReviewed-on: http://gerrit.chromium.org/gerrit/3132\nTested-by: David Reveman \u003creveman@chromium.org\u003e\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "28ca158ecebd885b9a3cca9a17241d57e8ee0517", "tree": "50b19e4d3d60db5b8eee754dfce96a1aad82d4bf", "parents": [ "3ceb9ffc750648edef0e43fbe8f540626f5b2480" ], "author": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Thu Jun 23 19:53:38 2011" }, "committer": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Thu Jun 23 21:21:31 2011" }, "message": "wm: Fix debug needle drawing.\n\nDisable partial updates in GL compositor when debug needle is enabled.\n\nBUG\u003dchromium-os:16908\nTEST\u003dmanual\n\nChange-Id: Iec71514fb8efe0fff59a28a07bdc43d9cd0a1d27\nReviewed-on: http://gerrit.chromium.org/gerrit/3120\nTested-by: David Reveman \u003creveman@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "3ceb9ffc750648edef0e43fbe8f540626f5b2480", "tree": "f1caa0d3b0d28ade300861c4d6e16154616658e4", "parents": [ "57eb34212ef535753ad256f83ca2849585058ba1" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Jun 22 23:28:58 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Jun 23 20:42:10 2011" }, "message": "wm: Add tests for multiple-window layout code.\n\nThis also fixes a small bug in the code that computes\npositions for offscreen windows, and removes the\n--show_window_edges flag (it\u0027s always on, now).\n\nBUG\u003dchromium-os:13963\nTEST\u003dadded\n\nChange-Id: Ib48bd88845a4f08402de2db41535f0f84f95b699\nReviewed-on: http://gerrit.chromium.org/gerrit/3103\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: David Reveman \u003creveman@chromium.org\u003e\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\n" }, { "commit": "57eb34212ef535753ad256f83ca2849585058ba1", "tree": "da7188cee7da0931e16d9a274f6dc27a82a91e3f", "parents": [ "f59cc171d7879738b5a1260c00c6346a091f50dd" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jun 17 04:13:04 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Jun 22 23:29:42 2011" }, "message": "wm: Make SetBounds() send a single ConfigureWindow request.\n\nThis avoids tickling a GTK+ bug that results in a window\u0027s\n_NET_WM_SYNC_REQUEST counter being updated before the window\nhas been repainted when a resize and move are done in quick\nsuccession.\n\nBUG\u003dchromium-os:13963,chromium-os:16716\nTEST\u003dmanual; also added a test\n\nChange-Id: Ie27ab75239799e0646eac49d77ce9e5f0f0a514d\nReviewed-on: http://gerrit.chromium.org/gerrit/2877\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "f59cc171d7879738b5a1260c00c6346a091f50dd", "tree": "897ef094f4b3e2bc461f18ac5945956fd3190182", "parents": [ "ad6b001e16d4dd6644f44fd437d0ba948888d034" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 20 19:39:20 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jun 21 18:10:15 2011" }, "message": "wm: Make F5 toggle maximized instead of cycling windows.\n\nThis makes the \"window switcher\" key toggle in and out of\nmaximized mode (at least when --multiple_windows is enabled;\nwhen it\u0027s disabled, the key still cycles through windows).\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual\n\nChange-Id: Iba7f52a4ef20a095e0a11981ae3ea413a7e3e5e9\nReviewed-on: http://gerrit.chromium.org/gerrit/2890\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "ad6b001e16d4dd6644f44fd437d0ba948888d034", "tree": "f8b9548d60a54996cffab24300884335fe45f436", "parents": [ "6f6ab96bde7c05380f027e8b39c91f062db7952a" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Jun 15 16:42:55 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 20 21:46:36 2011" }, "message": "wm: Improve stacking of browser shadows while maximized.\n\nEach browser window\u0027s shadow was previously always stacked\ndirectly beneath the browser window (and often above other\nbrowser windows). This was barely visible when cycling\nthrough windows and looked strange.\n\nWhen maximized, this change makes us instead stack each\nbrowser window\u0027s shadow at the bottom of the inactive\nbrowser layer, beneath all of the other browser windows.\n\nNote that there\u0027s an existing issue (rounding problem in the\ncompositor\u0027s animation code?) that sometimes results in a\nflickery black column of pixels between the two windows when\ncycling.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual: increased window-cycling animation duration to 2.5 seconds. also wrote a test.\n\nChange-Id: I2b66577afcad37d1033b5ce9e65b36f871d96d6a\nReviewed-on: http://gerrit.chromium.org/gerrit/2713\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "6f6ab96bde7c05380f027e8b39c91f062db7952a", "tree": "0a0e583bfe2f0b79a173ff26b774c6c9375a4c14", "parents": [ "fb174e01f461e0b359b416d3bf0019dabb23735e" ], "author": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Mon Jun 13 14:27:27 2011" }, "committer": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Mon Jun 20 18:32:31 2011" }, "message": "wm: Use Region for more precise partial screen updates.\n\nThis makes the partial update code in LayerVisitor use the Region data\ntype instead of a simple rectangle. The GL compositor takes advantage of\nthis and minimizes the redraw area.\n\nBUG\u003dchromium-os:16418\nTEST\u003dRealCompositorTest.PartialUpdates\n\nChange-Id: I5e31ceb0f63ffc0e8342317e7908d15e8106cb5e\nReviewed-on: http://gerrit.chromium.org/gerrit/2544\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: David Reveman \u003creveman@chromium.org\u003e\n" }, { "commit": "fb174e01f461e0b359b416d3bf0019dabb23735e", "tree": "a216f978300297a3b646566bd658ec0f03c09061", "parents": [ "14e5221818a40d047a41648b2fed63892c6f0402" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jun 14 20:45:47 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Jun 15 20:32:38 2011" }, "message": "wm: Add _NET_WM_PING response time histogram.\n\nThis creates an UMA histogram named\nWindowManager.ChromePingResponseTime containing response\ntimes from _NET_WM_PING requests sent to Chrome.\n\nBUG\u003dchromium-os:16003\nTEST\u003dmanual: logged reports and checked that the values were reasonable\n\nChange-Id: I22190cff18651eb94c4f3a08de6fc654ce45f1eb\nReviewed-on: http://gerrit.chromium.org/gerrit/2628\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "14e5221818a40d047a41648b2fed63892c6f0402", "tree": "88ca9175c8419acbfcfd0e23f8a6deab36a59e8c", "parents": [ "1b25b64846d89f4580f754c97b07e64e5f645cce" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jun 14 19:59:14 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jun 14 20:49:45 2011" }, "message": "wm: Re-add window-switching user action metrics.\n\nI dropped these calls in the rewrite of the layout code.\nI don\u0027t know that anyone is still looking at them, but I\nthink that it makes sense to hang on to them for now.\n\nBUG\u003dnone\nTEST\u003dnone (other than testing that it compiles; this is just a copy-and-paste of the previously-working code)\n\nChange-Id: I2038d72aaf4a199fe8315030a270db61194bf91e\nReviewed-on: http://gerrit.chromium.org/gerrit/2624\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "1b25b64846d89f4580f754c97b07e64e5f645cce", "tree": "de1d0b4326e7de2fbde1a4e91bc4cf58790fc49e", "parents": [ "7d23d4d8a6ab994a51e2050f62111a5f7237b9ed" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 08 22:35:30 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 13 23:56:39 2011" }, "message": "wm: Rewrite layout code to support multiple windows.\n\nThis is a shorter (and hopefully much simpler) rewrite of\nthe existing LayoutManager class, creatively named\nLayoutManager2. I\u0027ve removed the overview mode code and\nadded support for displaying multiple browser windows\nonscreen at once (currently disabled, as it needs more\npolish before seeing the light of day).\n\nThe philosophy for laying out individual windows has\nchanged. The old code contained a ToplevelWindow class that\nheld information about a Window\u0027s current state (e.g.\nactive, offscreen-to-left, etc.) and logic for transitioning\nbetween different states. Now, there\u0027s BrowserWindow, a\ndumb wrapper around a Window that just knows how to do\nsimple operations like changing the window\u0027s bounds or\nrestacking it as well as tracking fairly low-level state\n(e.g. what should the window\u0027s width be when it\u0027s not\nmaximized?). All of the smarts stay in LayoutManager2,\nwhich I think makes the code easier to follow and also makes\nit easier to coordinate animations of multiple windows at\nonce (resulting in e.g. less jank when Alt-Tab-ing).\n\nBUG\u003dchromium-os:13963,chromium-os:9054,chromium-os:4340\nTEST\u003dlots of manual testing; also tried to get LayoutManager2 test coverage roughly similar to what LayoutManager had; also ran smoke suite on a VM\n\nChange-Id: I58153c0ae5a650630fab34b23060740014e29d74\nReviewed-on: http://gerrit.chromium.org/gerrit/2259\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "7d23d4d8a6ab994a51e2050f62111a5f7237b9ed", "tree": "e9ece870dc0cc468e90b1e51dad538ab00029b55", "parents": [ "9da6ae6b4d84e4edbe8245fe50a0cea0d6d14276" ], "author": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Wed Jun 08 21:17:50 2011" }, "committer": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Fri Jun 10 18:37:11 2011" }, "message": "wm: Add occlusion culling to GL compositor.\n\nThis adds basic occlusion culling to the GL compositor. Each actor clip\nrect is rendered separately by setting the scissor box.\n\nBUG\u003dchromium-os:15942\nTEST\u003dManual\n\nChange-Id: I4ef18fdbeaa79a531fdf94f59bf8096e7d3a96d0\nReviewed-on: http://gerrit.chromium.org/gerrit/2353\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: David Reveman \u003creveman@chromium.org\u003e\n" }, { "commit": "9da6ae6b4d84e4edbe8245fe50a0cea0d6d14276", "tree": "75d9d107a005aa16fd0b93322b7f5cc58bb7b20b", "parents": [ "b8a8525d23c20242f159c6bd9fa9d15bf5a7c079" ], "author": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Thu Jun 09 21:41:44 2011" }, "committer": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Fri Jun 10 14:26:38 2011" }, "message": "wm: Add occlusion culling support.\n\nMakes LayerVisitor compute the visible region of each actor when\ntraversing the tree. This visible region can optionally be used by\ndrawing backends to avoid unnecessary drawing of occluded actor regions.\n\nBUG\u003dchromium-os:15942\nTEST\u003dNew Clipping unit tests\n\nChange-Id: If4e01f67eee813b1a395ed34f4be3974a6096aef\nReviewed-on: http://gerrit.chromium.org/gerrit/2403\nTested-by: David Reveman \u003creveman@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "b8a8525d23c20242f159c6bd9fa9d15bf5a7c079", "tree": "871820644d1ac0356cb5cffc78ef34c17945e83d", "parents": [ "1810f02a70df56eae99f86f68a95b3acb65c5296" ], "author": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Wed Jun 08 06:00:45 2011" }, "committer": { "name": "David Reveman", "email": "reveman@chromium.org", "time": "Fri Jun 10 14:19:08 2011" }, "message": "wm: Add Region class.\n\nThis adds a thin C++ wrapper around the Xlib region code and relevant\nunit tests.\n\nBUG\u003dchromium-os:15942\nTEST\u003dNew region unit tests\n\nChange-Id: Ic1ec544b4d1beb4a2b5a8e743e6611aa60daa75f\nReviewed-on: http://gerrit.chromium.org/gerrit/2303\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: David Reveman \u003creveman@chromium.org\u003e\n" }, { "commit": "1810f02a70df56eae99f86f68a95b3acb65c5296", "tree": "9e39ecb7b6a3f7de0c613a8dc36c61ad9afa9dd3", "parents": [ "41571cc29c5479a92246f0813a658f527fc34834" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 06 17:20:34 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Jun 07 18:09:00 2011" }, "message": "wm: Stack an input window under focused modal dialogs.\n\nThis prevents windows in the background from receiving\nevents from the pointer and prevents the cursor from\nchanging if the user e.g. moves the pointer over a panel\u0027s\nresize handle.\n\nBUG\u003dchromium-os:9054\nTEST\u003dmanual (opened a modal dialog and checked that i couldn\u0027t interact with other windows); also wrote a new test and removed an obsolete existing test\n\nChange-Id: I234f6f4c33a465fa40395723bfe102f28d0e90f9\nReviewed-on: http://gerrit.chromium.org/gerrit/2189\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "41571cc29c5479a92246f0813a658f527fc34834", "tree": "4c04626c9208d087687d7512372f11816e4e7f52", "parents": [ "f394d66753162e97e3c5f41b67594c2d00ca409a" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 06 16:04:49 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 06 21:06:04 2011" }, "message": "wm: Fix compilation errors in gcc-4.6.\n\nThis moves RealCompositor::QuadActor\u0027s destructor and\nanother method into real_compositor.cc and adds a missing\ninclude. This ought to fix an \"invalid application of\n\u0027sizeof\u0027 to incomplete type \u0027window_manager::TextureData\u0027\"\nerror.\n\nI\u0027m also removing some unused variables from LayoutManager.\n\nBUG\u003dchromium-os:16054\nTEST\u003dbuilds under gcc-4.6.0\n\nChange-Id: Iac10e2c893db7516770818ed4fadcd2bb9cb0525\nReviewed-on: http://gerrit.chromium.org/gerrit/2163\nReviewed-by: asharif \u003casharif@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "f394d66753162e97e3c5f41b67594c2d00ca409a", "tree": "c507b1c18ed1c2cb8318da12ac5561f1228a6f0d", "parents": [ "893da818104799e7c143c5a48d91ec1cc341a4f3" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 15 01:14:09 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 06 15:57:31 2011" }, "message": "wm: Add flaky TexturePixmapActor::Clone().\n\nThis adds a simple implementation to clone an actor that\u0027s\ntracking a pixmap. The cloned actor won\u0027t get updates; I\u0027m\njust using this in some experimental, off-by-default code.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual testing in conjunction with another change\n\nChange-Id: Ia85ae0a044350693ab0cce01a682b058cb7e4ca2\nReviewed-on: http://gerrit.chromium.org/gerrit/2132\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "893da818104799e7c143c5a48d91ec1cc341a4f3", "tree": "07c5bbbb7bd31e95f8ec5fd37ab3d1a51398e7de", "parents": [ "45dd4fa358610a48787e1cfda954eb5d12f821bf" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri May 20 21:10:50 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Jun 06 15:54:15 2011" }, "message": "wm: Add several testing methods.\n\nThis adds TestWindowIsAboveOtherWindow() and\nIntArrayPropertyContains() to BasicWindowManagerTest.\n\nBUG\u003dchromium-os:13963\nTEST\u003dusing these methods in new tests\n\nChange-Id: Iddef1d494a6e476336241b1bd0320bdb54801fc0\nReviewed-on: http://gerrit.chromium.org/gerrit/2160\nReviewed-by: David Reveman \u003creveman@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "45dd4fa358610a48787e1cfda954eb5d12f821bf", "tree": "d7f1ca361cd0f052f226bd8825cd10d7b25e4efc", "parents": [ "d3419d8331db51ecbfccfacf45a66406496aa5f2" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jun 03 22:46:45 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Sun Jun 05 22:18:59 2011" }, "message": "wm: Handle faked screen resizes.\n\nThis adds support for a BOGUS_SCREEN_RESIZES macro that can\nbe defined on hardware where we\u0027re unable to actually resize\nthe screen and instead send synthetic ConfigureNotify events\nabout the root window. We need to clear the stage before we\nresize it in this case; otherwise, we\u0027ll end up permanently\ndisplaying whatever what was last drawn there.\n\nBUG\u003dchrome-os-partner:3988\nTEST\u003dmanual testing with a little X program that sends synthetic ConfigureNotify events about the root window\n\nChange-Id: I2ea453132eadb766234574d3211f117863d97699\nReviewed-on: http://gerrit.chromium.org/gerrit/2125\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "d3419d8331db51ecbfccfacf45a66406496aa5f2", "tree": "aff90ab429df208c8f9c9039c97c701f298be762", "parents": [ "2f6d9acc9b6af1d81e6a6d17d03870a97642ffc2" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jun 03 19:15:23 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Jun 03 23:10:47 2011" }, "message": "wm: Improve TransientWindowCollection stacking.\n\nThis makes TransientWindowCollection\u0027s constructor take a\nvariable describing whether the transient windows should be\nstacked directly above their owner or in the transient\nwindow layer (previously, this was specified whenever adding\na new window or restacking all the windows, which didn\u0027t\nmake much sense).\n\nI\u0027m also removing the concept of an alternate window to\nstack the transients above -- I initially added this for\npanels but it\u0027s not being used anymore.\n\nFinally, I\u0027m fixing a bug where we could incorrectly stack a\ntransient window that should be at the bottom of the\ncollection at the top of the transient window layer instead.\n\nBUG\u003dchromium-os:13963\nTEST\u003dran existing tests and added a new test\n\nChange-Id: I5243dcabf5e4e8bc276c6b55a718c053291fe124\nReviewed-on: http://gerrit.chromium.org/gerrit/2099\nReviewed-by: Greg Spencer \u003cgspencer@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "2f6d9acc9b6af1d81e6a6d17d03870a97642ffc2", "tree": "fc3694023e435af6935f0404f009a9d377ad1cea", "parents": [ "cc07e9a9a8cdcc38de84c9551ec75a85b9ebea0d" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Jun 01 21:59:49 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Jun 01 23:59:06 2011" }, "message": "wm: More testing cleanup.\n\nThis makes some testing code more debuggable: rather than\njust calling EXPECT_*() inside of helper functions, we also\nreturn bool so the caller can use its own EXPECT_TRUE() to\nlog the line number of the failure.\n\nI\u0027m also fixing the _NET_CLIENT_LIST_STACKING test. We\nupdate the property in response to ConfigureNotify events,\nbut the test wasn\u0027t sending these; it was just relying on\nthe fact that the initial stacking of windows matched the\ndesired order.\n\nBUG\u003dchromium-os:13963\nTEST\u003dran them\n\nChange-Id: I16536c4dae016c5d6689c84c4a47ea16380fec1e\nReviewed-on: http://gerrit.chromium.org/gerrit/1915\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "cc07e9a9a8cdcc38de84c9551ec75a85b9ebea0d", "tree": "ca3cc8c7a90e0412a43b13359a0bfe3d06f9fad3", "parents": [ "40fa1bdc99438cd74021841aa8c27f479afa8b94" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue May 31 18:32:12 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue May 31 20:56:11 2011" }, "message": "wm: Reland window move/resize change.\n\nThis reverts commit\n40fa1bdc99438cd74021841aa8c27f479afa8b94, relanding\nc3d869929f26a1cd02b7a464083aeddd18b0642b. I\u0027ve fixed an\nissue with the deprecated move/resize interface in the\nWindow class.\n\nOriginal description:\n\nI had previously written tricky code that kept track of the\ngravity used during a resize and tried to use that to make\nan informed decision about how to update the actor\u0027s\nposition. This falls down when using SetBounds() to do more\ncomplicated simultaneous move/resizes where none of the\nwindow\u0027s edges remains fixed.\n\nMuch simpler is to track a window\u0027s requested composited\nposition but hold off entirely on updating the actor\u0027s\nposition until the actor\u0027s size matches that of the\nunderlying X window.\n\nBUG\u003dchromium-os:13963\nTEST\u003dadded; also tried it and didn\u0027t notice anything being obviously broken\n\nChange-Id: Ifdfe1040b3bd336c507874a7901c4b24988e8e78\nReviewed-on: http://gerrit.chromium.org/gerrit/1838\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Greg Spencer \u003cgspencer@chromium.org\u003e\n" }, { "commit": "40fa1bdc99438cd74021841aa8c27f479afa8b94", "tree": "70510577150d4820fbe32b5aa34288d132a4678d", "parents": [ "c3d869929f26a1cd02b7a464083aeddd18b0642b" ], "author": { "name": "xiyuan", "email": "xiyuan@chromium.org", "time": "Sat May 28 06:10:25 2011" }, "committer": { "name": "Xiyuan Xia", "email": "xiyuan@chromium.org", "time": "Sat May 28 06:14:52 2011" }, "message": "Revert \"wm: Make window move/resize code simpler and more robust.\"\n\nThis reverts commit c3d869929f26a1cd02b7a464083aeddd18b0642b.\n\nBUG\u003dnone\nTEST\u003dWindowTest.SimultaneousMoveAndResize should pass.\n\nChange-Id: I765325410cc5c6aa8ae9aebb13950741cc072e8f\nReviewed-on: http://gerrit.chromium.org/gerrit/1779\nTested-by: David James \u003cdavidjames@chromium.org\u003e\nReviewed-by: David James \u003cdavidjames@chromium.org\u003e\n" }, { "commit": "c3d869929f26a1cd02b7a464083aeddd18b0642b", "tree": "f7b21246b011787fde5170680aa2170fd78bc726", "parents": [ "e12ac2787cb3f25f5a65ae40927629968015637b" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue May 24 21:40:49 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri May 27 23:29:19 2011" }, "message": "wm: Make window move/resize code simpler and more robust.\n\nI had previously written tricky code that kept track of the\ngravity used during a resize and tried to use that to make\nan informed decision about how to update the actor\u0027s\nposition. This falls down when using SetBounds() to do more\ncomplicated simultaneous move/resizes where none of the\nwindow\u0027s edges remains fixed.\n\nMuch simpler is to track a window\u0027s requested composited\nposition but hold off entirely on updating the actor\u0027s\nposition until the actor\u0027s size matches that of the\nunderlying X window.\n\nBUG\u003dchromium-os:13963\nTEST\u003dadded; also tried it and didn\u0027t notice anything being obviously broken\n\nChange-Id: Ibeaba33397dcac76f8ed655506e47d781c975d6f\nReviewed-on: http://gerrit.chromium.org/gerrit/1637\nReviewed-by: Greg Spencer \u003cgspencer@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "e12ac2787cb3f25f5a65ae40927629968015637b", "tree": "70510577150d4820fbe32b5aa34288d132a4678d", "parents": [ "e19c1f0753374f255b31ef0a6dc729845ecb05be" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu May 19 20:55:02 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 25 23:55:54 2011" }, "message": "wm: Login-related test improvements.\n\nMake BasicWindowManagerTest::GetCompositedWindowBounds()\nreturn the actor\u0027s actual current bounds rather than the\ncomposited bounds from the Window object. This exposed a\nbug in a login test that was testing for no-longer-current\nbehavior (but doing it incorrectly and hence still passing).\n\nBUG\u003dchromium-os:13963\nTEST\u003dran tests\n\nChange-Id: I74bc6ec12672a1ea2bdddd09dd7b9fef42b6badd\nReviewed-on: http://gerrit.chromium.org/gerrit/1204\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "e19c1f0753374f255b31ef0a6dc729845ecb05be", "tree": "5c1e08c5f937b398a295b25c600b7374107db4fe", "parents": [ "cf6a6274478f256ecfe4afd5ab7881a688c63061" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu May 05 16:48:42 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 25 23:51:11 2011" }, "message": "wm: Add parameter for click-to-focus passthrough.\n\nThis adds a parameter to\nFocusManager::UseClickToFocusForWindow() to control whether\nthe click that focuses a window is passed through to the\nclient or not.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual: tested in conjunction with another change\n\nChange-Id: I3c99f3bbda6ffe145cab092be074ce59224bfbfd\nReviewed-on: http://gerrit.chromium.org/gerrit/1225\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "cf6a6274478f256ecfe4afd5ab7881a688c63061", "tree": "c46f6687eb052ba131ed48bd5e4b0c951c8fc117", "parents": [ "7d4401a12182704c6a21b10a91bf71bf213cfe7f" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 25 22:03:10 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 25 23:45:32 2011" }, "message": "wm: Don\u0027t mess with override-redirect transient windows.\n\nPanelManager previously didn\u0027t ignore override-redirect\nwindows, resulting in it sending delete requests to ones\nthat were marked as being transient for panels (such as the\nstatus bubble). This causes crashes in Chrome.\n\nI\u0027m also fixing some other configuration requests that we\ncould send for override-redirect window in some cases.\n\nBUG\u003dchromium-os:15422\nTEST\u003dadded a test; also manually tested with steps from bug\n\nChange-Id: Idf09fd053f1f7e09bc3ac1180bc288790fc07f6b\nReviewed-on: http://gerrit.chromium.org/gerrit/1575\nReviewed-by: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "7d4401a12182704c6a21b10a91bf71bf213cfe7f", "tree": "4a40da8477d13d8a7c2627e9f450182318d2dd72", "parents": [ "221b83a228946e27fc4792c69ee3ea66b4192284" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 25 20:15:03 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 25 20:24:16 2011" }, "message": "wm: Set root window\u0027s cursor at startup.\n\nChrome used to do this, but it was removed by\nhttp://codereview.chromium.org/6973029/, which unified some\nlogin code. Our X server is patched to clear the root\nwindow\u0027s cursor at startup. As a result, windows that\ndidn\u0027t have a cursor set were inheriting the empty cursor\nfrom the root. Setting the cursor in the window manager (as\nwe used to do a long time ago) fixes this.\n\nBUG\u003dchromium-os:15767\nTEST\u003dmanual: did a regular build; checked that the cursor is still hidden at startup and that it appears as soon as i move it and doesn\u0027t disappear when moved over certain windows\n\nChange-Id: I5737f34856fbfbd7ff75e7d9ddc861f2e57280b8\nReviewed-on: http://gerrit.chromium.org/gerrit/1559\nReviewed-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "221b83a228946e27fc4792c69ee3ea66b4192284", "tree": "795f6b6eebc57064f1fa7c78bbf4600980cf2b8a", "parents": [ "0b46eb01ef8c32fda271fe2203464278dd3d4394" ], "author": { "name": "Diego Elio Pettenò", "email": "flameeyes@chromium.org", "time": "Tue May 24 10:28:05 2011" }, "committer": { "name": "Diego Elio Pettenò", "email": "flameeyes@chromium.org", "time": "Wed May 25 16:47:04 2011" }, "message": "Respect PKG_CONFIG variable if set in the environment.\n\nThis is required for the new cross-compilation support using pkg-config\nwrappers instead of changing the pkg-config files themselves.\n\nBUG\u003dnone\nTEST\u003demerge-arm-generic with and without pkg-config wrappers\n\nChange-Id: Ia0b12e6537dab93f445d1500b4f70d36b5ea1a47\nReviewed-on: http://gerrit.chromium.org/gerrit/1445\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Diego Elio Pettenò \u003cflameeyes@chromium.org\u003e\n" }, { "commit": "0b46eb01ef8c32fda271fe2203464278dd3d4394", "tree": "1656ad7e4d9d3cfc70033dd106cf3a2012551d0f", "parents": [ "71d2fe13c7c88afd8c39ded8e7a7ed032daa3c29" ], "author": { "name": "Ryan Harrison", "email": "rharrison@chromium.org", "time": "Thu May 12 14:19:40 2011" }, "committer": { "name": "Ryan Harrison", "email": "rharrison@chromium.org", "time": "Wed May 25 15:10:44 2011" }, "message": "Add detection and handling for WebUI login.\n\nThis adds support for WebUI based login. It detects the creation of a chromeos::WM_IPC_WINDOW_LOGIN_WEBUI type window. When this occurs an alternate handling path is used, since the standard set of login windows will not be generated.\n\nBUG\u003dnone\nTEST\u003dAdded tests to login_controller_test.cc and manually tested on device.\n\nChange-Id: Ib1584b5191d0a8210d546a90be2d4ee9f350dd86\nReviewed-on: http://gerrit.chromium.org/gerrit/759\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nReviewed-by: Nikita Kostylev \u003cnkostylev@chromium.org\u003e\nTested-by: Ryan Harrison \u003crharrison@chromium.org\u003e\n" }, { "commit": "71d2fe13c7c88afd8c39ded8e7a7ed032daa3c29", "tree": "7918f9128db61459f7431f6ab82ba02a235cc524", "parents": [ "6cca1f7f0ff04097df47784dbec70b176441a66b" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 18 01:31:54 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 18 22:28:54 2011" }, "message": "wm: Fix random issues I ran into while porting tests.\n\nThis fixes some problems that I saw while running the\nexisting tests against the new layout code that I\u0027m working\non.\n\n- LayoutManager was doing some work for PanelManager\u0027s\n transient windows that it shouldn\u0027t (mapping them and\n stacking them).\n- WindowManager was destroying ModalityHandler before some\n of the EventConsumers that might depend on it.\n- One of the WindowManager tests was depending on a key\n binding installed by LayoutManager, which is a bit ugly.\n I\u0027ve made it use one of the WindowManager keybindings\n instead.\n- Transient dialogs were getting stacked directly above the\n panels to which they belonged, making it possible for\n a second panel to be stacked above the dialog (which\n looked pretty strange).\n\nBUG\u003dchromium-os:13963\nTEST\u003dran them\n\nChange-Id: I545c8813551ae17fd502345294cd9f998348ea30\nReviewed-on: http://gerrit.chromium.org/gerrit/1137\nReviewed-by: Greg Spencer \u003cgspencer@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "6cca1f7f0ff04097df47784dbec70b176441a66b", "tree": "6f2a79918f11e036968df525037d559ca29b201c", "parents": [ "4ef6ab8fdc9b58e4daf01da6c34ab56d3da6d851" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu May 12 22:01:51 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 18 00:04:35 2011" }, "message": "wm: Reduce jank when panels are first created.\n\nThis change makes us:\n- avoid displaying a panel until the content window\u0027s pixmap\n has been loaded (otherwise, there\u0027s a chance that there\n will be some frames where we draw the titlebar but not the\n content)\n- resize the titlebar window to match the content window\u0027s\n width as soon as the content window is mapped (otherwise,\n it usually get resized in the middle of the\n sliding-onscreen animation, which makes us skip the\n animation)\n\nBUG\u003dchromium-os:14717\nTEST\u003dadded a test; also opened panels and checked that the titlebar and content now slide up together instead of the titlebar appearing first\n\nChange-Id: I8dde497a6098fc837fc1b93b833726dccf3118ca\nReviewed-on: http://gerrit.chromium.org/gerrit/805\nReviewed-by: Daniel Erat \u003cderat@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "4ef6ab8fdc9b58e4daf01da6c34ab56d3da6d851", "tree": "366c97595143c3b1b991db3a10f80816e08c7e9b", "parents": [ "7c7f955dc790396452d6786a78c1c8b0b4954880" ], "author": { "name": "Chris Masone", "email": "cmasone@chromium.org", "time": "Thu May 12 20:04:53 2011" }, "committer": { "name": "Chris Masone", "email": "cmasone@chromium.org", "time": "Sat May 14 18:10:22 2011" }, "message": "[window_manager] Roll forward to new libchrome\n\nBUG\u003dchromium-os:14304\nTEST\u003dbuild, unit tests\n\nChange-Id: I8e08e3eedb22c6441b9289bbba775e16a63f3ac7\nReviewed-on: http://gerrit.chromium.org/gerrit/825\nReviewed-by: Chris Masone \u003ccmasone@chromium.org\u003e\nTested-by: Chris Masone \u003ccmasone@chromium.org\u003e\n" }, { "commit": "7c7f955dc790396452d6786a78c1c8b0b4954880", "tree": "1d2f0d6626ff6cfa6b066ebd4f2d674df330acd7", "parents": [ "b791aa34aa47f471a50cf68d0a647edfc65d07b0" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri May 06 22:20:33 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue May 10 14:51:43 2011" }, "message": "wm: Add Window::SetBounds().\n\nThis is currently just a simple way to do a simultaneous\nmove and resize. I will probably improve it after I remove\nthe legacy interface in the Window class that requires\nmanaging the client and composited windows separately.\n\nBUG\u003dchromium-os:13963\nTEST\u003dusing it in conjunction with an in-progress change\n\nChange-Id: Ia31472c3ab1aa576bf379f1c96d76ab7d2b9929d\nReviewed-on: http://gerrit.chromium.org/gerrit/565\nReviewed-by: Greg Spencer \u003cgspencer@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "b791aa34aa47f471a50cf68d0a647edfc65d07b0", "tree": "6ee65279a08da6f477f5d82ff8171418e729612b", "parents": [ "e058958c3891a1ad7fe18698d0d173a06d2f42fd" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue May 10 01:24:51 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue May 10 14:47:30 2011" }, "message": "wm: Center panels\u0027 transient windows onscreen.\n\nThe window manager was formerly trying to center them over\nthe panel in question (while keeping them onscreen), but\nthis can look buggy when a transient window is larger than\nthe panel that owns it.\n\nBUG\u003dchromium-os:14361\nTEST\u003dupdated existing tests; also manual testing (focused a panel, hit Ctrl-O, and observed that the file picker dialog was centered onscreen)\n\nChange-Id: I1d4dbb70d5963eac626f676e6607d7075780b354\nReviewed-on: http://gerrit.chromium.org/gerrit/576\nReviewed-by: Greg Spencer \u003cgspencer@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "e058958c3891a1ad7fe18698d0d173a06d2f42fd", "tree": "f6291565004e098342b825ffb46fa9d9d1699432", "parents": [ "d5058580b425462f5badd2c813c1c1c2f951410e" ], "author": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Mon May 09 21:36:35 2011" }, "committer": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Mon May 09 21:37:19 2011" }, "message": "Fix build.\n\nChange-Id: Iac14b769335d0d488dde60c2ebebf7b7eb13eeac\nReviewed-on: http://gerrit.chromium.org/gerrit/551\nReviewed-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\nTested-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\n" }, { "commit": "d5058580b425462f5badd2c813c1c1c2f951410e", "tree": "a6078a3924187992096358dcffa1dfc3de35085a", "parents": [ "fc291b2a3a4822dbb49a0f3d4bfa264b3b3b1152" ], "author": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Sat May 07 00:42:45 2011" }, "committer": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Mon May 09 21:09:31 2011" }, "message": "Add pageflip support to the window manager.\n\nChange-Id: I9e79634853d81130b83080d1ee623b922036f4b7\nReviewed-on: http://gerrit.chromium.org/gerrit/482\nReviewed-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\nTested-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\n" }, { "commit": "fc291b2a3a4822dbb49a0f3d4bfa264b3b3b1152", "tree": "53953f90fd2951a0b69ac4fc65fdffd1a3f6b45c", "parents": [ "e426196fb149cc112bc86822ddfba40f4bfd1772" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri May 06 01:03:34 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri May 06 16:26:20 2011" }, "message": "wm: Recenter login wizard window on screen resize.\n\nWe were previously updating the position of login entries,\nbut not doing anything similar for the window used for the\nOOBE and picture-taking.\n\nBUG\u003dchromium-os:13848\nTEST\u003dmanual: checked that oobe window is recentered on monitor hotplug; also added a unit test\n\nChange-Id: I32d952fda82486e86a185d65353f1f2f118d4e41\nReviewed-on: http://gerrit.chromium.org/gerrit/411\nReviewed-by: Nikita Kostylev \u003cnkostylev@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "e426196fb149cc112bc86822ddfba40f4bfd1772", "tree": "8b85a15be7eb5f007a7d6e8dd6742d545559b3ac", "parents": [ "9ffb8d1094b566db7dea2954689f6dba17de28f5" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu May 05 21:19:54 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri May 06 16:23:36 2011" }, "message": "wm: Don\u0027t mask new portion of overlay on screen resize.\n\nThis fixes a bug where the code to enable or disable\ncompositing was leaving part of the compositing overlay\nwindow masked out (via the shape extension) after a screen\nresize. This change makes us instead clear the shaped\nregion when compositing is enabled so that we don\u0027t need to\nworry about updating the region after every resize.\n\nBUG\u003dchromium-os:14951\nTEST\u003dmanual (plugged/unplugged larger external monitor while a context menu was open and checked that the screen was resized as expected) and added a unit test\n\nChange-Id: I24ca27933e194bc62087fdfb716171e92caa8401\nReviewed-on: http://gerrit.chromium.org/gerrit/408\nReviewed-by: Stéphane Marchesin \u003cmarcheu@chromium.org\u003e\nTested-by: Daniel Erat \u003cderat@chromium.org\u003e\n" }, { "commit": "9ffb8d1094b566db7dea2954689f6dba17de28f5", "tree": "289b48de39ccd7d491d39167bde4e1fc89875211", "parents": [ "8eda2b25c0f8bbeee943bf02c9f3d020ab7d4d09" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu May 05 00:53:00 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu May 05 18:10:59 2011" }, "message": "wm: Handle missing UnmapNotify events.\n\nSome crash reports and warning messages make me suspect that\nwe\u0027re sometimes not seeing UnmapNotify events for mapped\nwindows before they get destroyed. This can lead to all\nkinds of problems; in this particular case, FocusManager\nappears to be dereferencing a stale pointer to a Window\nobject. This change makes us try to handle this case as\ngracefully as we can.\n\nBUG\u003dchromium-os:13792\nTEST\u003dwrote a test (but note that there are no repro steps for this; it\u0027s a pretty uncommon crash)\n\nChange-Id: Ic11b1c9a54eab92fb680aa9c2f2b75477cdb08dc\n" }, { "commit": "8eda2b25c0f8bbeee943bf02c9f3d020ab7d4d09", "tree": "4fb5ede0a385cc5b6971145ec33cef3c29e515fa", "parents": [ "81f9db90175ab71ffff87ff265a7cfdfe1aae9a3" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 04 01:02:13 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed May 04 01:03:23 2011" }, "message": "wm: Display tooltips while screen is locked.\n\nThis makes the window manager composite windows with a\n_NET_WM_WINDOW_TYPE_TOOLTIP atom in their\n_NET_WM_WINDOW_TYPE property while the screen is locked. We\nformerly only composited screen locker windows and\ninfo bubbles that had specifically asked to be composited.\n\nBUG\u003dchromium-os:6833\nTEST\u003dadded a unit test; also manually checked that statusbar tooltips are now shown while the screen is locked\n\nChange-Id: I6b47a54fb60a4487fbb8b2cf0fac344ca69a7855\n" }, { "commit": "81f9db90175ab71ffff87ff265a7cfdfe1aae9a3", "tree": "a065567746a6c638f954307c5394292e8af54643", "parents": [ "6e40119596c4ebaf9e55fbfe5e20a7e0fd212600" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon May 02 17:35:29 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon May 02 17:35:29 2011" }, "message": "wm: Update a lot of code to use structs from geometry.h.\n\nI\u0027m updating most of the code here, with a few exceptions:\n- Compositor (I\u0027ll do this in a separate change)\n- deprecated Window::MoveClient() and MoveComposited()\n methods\n- LayoutManager (I have a simplified rewrite of this\n in-progress for http://crosbug.com/13963)\n\nMost of this change is completely mechanical, but I\u0027m also\nsimplifying how we handle moving override-redirect windows\u0027\ncompositing actors to the correct place onscreen and showing,\nhiding, and restacking them: instead of doing this manually\nin the WindowManager class, it\u0027s done in\nWindow::HandleConfigureNotify() and friends.\n\nBUG\u003dchromium-os:1822\nTEST\u003dran existing tests\n\nReview URL: http://codereview.chromium.org/6902072\n\nChange-Id: I597e258ebf9382a84f98cc62b0bc2241330bd40b\n" }, { "commit": "6e40119596c4ebaf9e55fbfe5e20a7e0fd212600", "tree": "50505383d3bfee0a1666c79de2f6a22e5c001452", "parents": [ "1688513e3fff78a09d579c24c8841d8e40f60052" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon May 02 17:29:02 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon May 02 17:29:02 2011" }, "message": "wm: Add a way for classes to listen for modality changes.\n\nThis adds a ModalityChangeListener interface that classes\ncan implement to get notifications from ModalityHandler\nwhenever we focus or unfocus a modal window. I\u0027m not wiring\nthis up to LayoutManager yet, but I\u0027m using it in the new\nimplementation so we can e.g. disable keyboard shortcuts\nwhile a panel has modal dialog up.\n\nBUG\u003dchromium-os:13963,chromium-os:9054\nTEST\u003dadded, also built and tried it\n\nReview URL: http://codereview.chromium.org/6893045\n\nChange-Id: Ie1ef0aee637f58cc58175a8e152a01884e2e5463\n" }, { "commit": "1688513e3fff78a09d579c24c8841d8e40f60052", "tree": "8faa26ec7671940081396de731b851a6b77939ba", "parents": [ "bc8453ae04342d837f8cabda93d05df0e6e79671" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 29 01:08:37 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 29 01:08:37 2011" }, "message": "chromeos-wm: Remove crosh-related files.\n\nI\u0027ve moved these into the crosh.git repository.\n\nChange-Id: I7d8b98bf99bd494672824bbb1a272634f979a8e8\n\nBUG\u003dchromium-os:7741\nTEST\u003dbuilt chromeos-wm\n\nReview URL: http://codereview.chromium.org/6904114\n" }, { "commit": "bc8453ae04342d837f8cabda93d05df0e6e79671", "tree": "1fe58f54d7393fa1fda8c46e5f6aa759f41517de", "parents": [ "d03b8feb6ce479d5fc071da055ebeed47faf337d" ], "author": { "name": "Elly Jones", "email": "ellyjones@google.com", "time": "Thu Apr 28 19:19:58 2011" }, "committer": { "name": "Elly Jones", "email": "ellyjones@google.com", "time": "Thu Apr 28 19:19:58 2011" }, "message": "crosh: Improve the ssh command.\n\nAdd support for -D, -L, -N, and -i, per review from drewry@google.com; rewrite\nthe ssh command so we don\u0027t have to parse ssh command-line options.\n\nChange-Id: I281493c11d0bad43610520eafd8e475b76e94ddc\n\nBUG\u003dNone\nTEST\u003dAdhoc\nRun it :)\n\nSigned-off-by: Elly Jones \u003cellyjones@chromium.org\u003e\nSigned-off-by: Will Drewry \u003cwad@chromium.org\u003e\n\nReview URL: http://codereview.chromium.org/6880253\n" }, { "commit": "d03b8feb6ce479d5fc071da055ebeed47faf337d", "tree": "309fc44c2e2b4fa8f31f459e51e62474c24b7ba1", "parents": [ "856e4b56e71e464cf3b8e5bcaaaac67f4586b0df" ], "author": { "name": "Darin Petkov", "email": "petkov@chromium.org", "time": "Wed Apr 27 23:50:24 2011" }, "committer": { "name": "Darin Petkov", "email": "petkov@chromium.org", "time": "Wed Apr 27 23:50:24 2011" }, "message": "Provide an \"autest\" crosh command.\n\nIt initiates an update check to the Omaha test server.\n\nBUG\u003dchromium-os:14567\nTEST\u003dran on the device\n\nChange-Id: Ibdc6d143cbac110b0b2d9cabfc58458aa809dff0\n\nReview URL: http://codereview.chromium.org/6893070\n" }, { "commit": "856e4b56e71e464cf3b8e5bcaaaac67f4586b0df", "tree": "cd6faebca4c5814dd6644e4eb0ba206b6253cbca", "parents": [ "f6a5c06746a1b6af4ad38854a19424cf905b8ef2" ], "author": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Wed Apr 27 20:23:39 2011" }, "committer": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Wed Apr 27 20:23:39 2011" }, "message": "Use NEAREST filtering in the GL backend when the transform is 1:1.\n\nAll GPUs exhibit some form of non-identityness when doing linear filtering with a 1:1 transform (usually due to rounding in the interpolation). This is visible in http://tft.vanity.dk/monitorTest_scale.html ; when compositing is enabled some more artifacts appear.\n\nChange-Id: I29d2a201c119ab94cd4eeede46bd4e97ae573571\n\nBUG\u003dchromeos-partner:2927\nTEST\u003dWent to http://tft.vanity.dk/monitorTest_scale.html, the artifacts dont come \u0026 go as compositing is disabled/enabled. There are permanent artifacts but that\u0027s another bug.\n\nReview URL: http://codereview.chromium.org/6893061\n" }, { "commit": "f6a5c06746a1b6af4ad38854a19424cf905b8ef2", "tree": "7c0a999a6a459866def4a5be36ba45ba0a69c9fc", "parents": [ "74a1a4cf6ac159b181ed8785e4608210286f086a" ], "author": { "name": "rginda", "email": "rginda@chromium.org", "time": "Mon Apr 25 23:11:33 2011" }, "committer": { "name": "rginda", "email": "rginda@chromium.org", "time": "Mon Apr 25 23:11:33 2011" }, "message": "crosh: ignore sigint\n\nChange-Id: Iefc3518e1819377b9700edbc3999d83b84019ee0\n\nBUG\u003dchromium-os:13120\nTEST\u003dmanual test in chroot\n\nReview URL: http://codereview.chromium.org/6893009\n" }, { "commit": "74a1a4cf6ac159b181ed8785e4608210286f086a", "tree": "e3f1debfce7028da84bcf3ee69f9fce3f9e0e51d", "parents": [ "6e9cbde4577ea6952f9b801351d13918a8d2b446" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Apr 25 22:42:35 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Mon Apr 25 22:42:35 2011" }, "message": "wm: Add ResizeBox class.\n\nThis adds a new class (just a simple wrapper around\nImageGrid) that can be used to display a box while resizing\nan object and makes the panel code use it. Before, we just\ndrew a plain blue box without any borders.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanual testing (resized a panel)\n\nReview URL: http://codereview.chromium.org/6905004\n\nChange-Id: I1583b2e4d991783972a667aefb16c791a1f9ea38\n" }, { "commit": "6e9cbde4577ea6952f9b801351d13918a8d2b446", "tree": "d18c49a91d3aa6a30e3d6936cc47728c4facc5aa", "parents": [ "6e0ce4e5aa6907e7f4e454a5cdd3e62903fe9c4e" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 22 19:29:46 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 22 19:29:46 2011" }, "message": "wm: Synchronize all animations added in the same frame.\n\nWhen scheduling a new animation, we used to use the current\ntime as the animation\u0027s starting time. This made it\nimpossible to reliably make multiple animations proceed in\nlockstep, as there\u0027s an unavoidable delay between when each\nanimation is scheduled. As a result, we\u0027d end up with ugly\neffects like the small empty black gap that\u0027d often be\nvisible between windows in the Alt-Tab animation. (Note that\nthe black gap still exists after this change, but it\u0027s now an\nartifact of the way that the current LayoutManager does\nanimations rather than inherent to the compositor -- the gap\nis gone in my in-progress LayoutManager rewrite).\n\nThis change makes us cache a timestamp the first time that\nan animation is added between frames and reuse it for all\nsubsequently-added animations so they\u0027ll all be\nsynchronized.\n\nChange-Id: I0182a0622cbb84541035535142df0c75e05b937b\n\nBUG\u003dchromium-os:13963\nTEST\u003dadded a test; also manual inspection that there\u0027s no empty gap visible between windows on alt-tab with my not-yet-committed LayoutManager rewrite\n\nReview URL: http://codereview.chromium.org/6880138\n" }, { "commit": "6e0ce4e5aa6907e7f4e454a5cdd3e62903fe9c4e", "tree": "bdfb8f7056ea744f796f46d0dab837098b65c8fe", "parents": [ "407476128cc7a9f359718451530a780bf6013dd9" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 22 17:18:29 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 22 17:18:29 2011" }, "message": "wm: Add ScopedCompositingRequest.\n\nThis adds an object that registers a request to force\ncompositing in its constructor and withdraws it in its\ndestructor. This simplifies some code that I\u0027m writing.\n\nChange-Id: I8652cdc2809c594092cfc59f531260eff9ad823a\n\nBUG\u003dchromium-os:13963\nTEST\u003dbuilt and ran it\n\nReview URL: http://codereview.chromium.org/6900010\n" }, { "commit": "407476128cc7a9f359718451530a780bf6013dd9", "tree": "f807fed67fea9c3b760b3e2c34c28074a733fb06", "parents": [ "b7fdd469751430ff451ff2f027e0e5b4161b5fde" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 22 00:57:36 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 22 00:57:36 2011" }, "message": "wm: Notify on all fetched pixmaps instead of just initial.\n\nThe WindowManager class used to only notify event consumers\nwhen a window\u0027s initial pixmap was fetched. This change\nmakes it also notify them when the pixmap has been reset\nafter a resize.\n\nBUG\u003dchromium-os:13963\nTEST\u003dupdated and ran existing tests\n\nReview URL: http://codereview.chromium.org/6873080\n\nChange-Id: I96c88af268f84c8038f1f009517c4507317a38c3\n" }, { "commit": "b7fdd469751430ff451ff2f027e0e5b4161b5fde", "tree": "87d0c5aae8643eb375ddcfff6bc0c15c88c70c33", "parents": [ "bda18ae86e05d7e21c45fa3fcf81279cc4b6573d" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 22 00:33:47 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Fri Apr 22 00:33:47 2011" }, "message": "wm: Fix window_manager_test breakage from bda18ae8.\n\nA test was depending on a key binding that got removed.\n\nChange-Id: I98d518bfa869270a72c6774230db0f7fdc07b075\n\nBUG\u003dnone\nTEST\u003dtests pass now\n\nReview URL: http://codereview.chromium.org/6900007\n" }, { "commit": "bda18ae86e05d7e21c45fa3fcf81279cc4b6573d", "tree": "125800432e31e7ceedf1302988d6ee76c3a156fb", "parents": [ "4095c66714c5deacfc923edae8ceb61bcc582e4b" ], "author": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Fri Apr 22 00:23:40 2011" }, "committer": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Fri Apr 22 00:23:40 2011" }, "message": "Stop calling monitor_reconfigure from the window manager.\n\nChange-Id: I000a1166e63281574d2ea06470cdd7a9f3790f81\n\nBUG\u003dNone.\nTEST\u003dCompiled and ran the WM on mario.\n\nReview URL: http://codereview.chromium.org/6896008\n" }, { "commit": "4095c66714c5deacfc923edae8ceb61bcc582e4b", "tree": "e14518fea3b22ddb13064233c8f10b45242540fa", "parents": [ "f5525b9d5d00d8adf83e5c6ddc4975003d52155f" ], "author": { "name": "Ken Mixter", "email": "kmixter@google.com", "time": "Wed Apr 20 03:12:27 2011" }, "committer": { "name": "Ken Mixter", "email": "kmixter@google.com", "time": "Wed Apr 20 03:12:27 2011" }, "message": "crosh: automatically restart entd when providing a new extension CA\n\nChange-Id: I0dd394e15a41f7dc381ce902a31a3f425dad0887\n\nBUG\u003dnone\nTEST\u003d\n1) remove current CA\n2) log in\n3) verify entd does not start and options is unusable\n4) open crosh\n5) do enterprise_ca_approve\n6) verfy entd has restarted and options is usable without logging out\n\nReview URL: http://codereview.chromium.org/6878066\n" }, { "commit": "f5525b9d5d00d8adf83e5c6ddc4975003d52155f", "tree": "ad7e62fec9d6625b77c4f1ee549b5fb2a4cd69d3", "parents": [ "c5bfee682e187073f06cecfc3ae848aa4db5b6b7" ], "author": { "name": "Ken Mixter", "email": "kmixter@google.com", "time": "Wed Apr 20 01:01:58 2011" }, "committer": { "name": "Ken Mixter", "email": "kmixter@google.com", "time": "Wed Apr 20 01:01:58 2011" }, "message": "chromeos-wm: Add cros secure_certificates flag to test pkcs11 in chrome\n\nEnabling this \"lab\" changes Chrome, entd, and crytohome behavior so\nthat Chrome can use opencryptoki to store certificates.\n\nChange-Id: Iadc1b2c52388b7a239b9ce7eb0ca676111db9d24\n\nBUG\u003dnone\nTEST\u003d\nsecure_certificates on - enables\nsecure_certificates off - disables\nsecure_certificates - displays current status\n\nReview URL: http://codereview.chromium.org/6881063\n" }, { "commit": "c5bfee682e187073f06cecfc3ae848aa4db5b6b7", "tree": "f063b55792e0e9ae41776fc59aa0461caa8bed5e", "parents": [ "15a080f6e9ca4d92c64f174f5d5ba8c452c84e56" ], "author": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Wed Apr 20 00:33:50 2011" }, "committer": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Wed Apr 20 00:33:50 2011" }, "message": "Remove color calibration from the window manager.\n\nChange-Id: Icc60772afef57afd0ed114ebc4b6d4d246a1a7af\n\nBUG\u003dchromium-os:10138\nTEST\u003d\n\nReview URL: http://codereview.chromium.org/6865032\n" }, { "commit": "15a080f6e9ca4d92c64f174f5d5ba8c452c84e56", "tree": "281283d54fc6e3592e37662b1efc5f23a36299cf", "parents": [ "5354d11193e8acac4b7d54e8c32e6baf8cc7224f" ], "author": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Thu Apr 14 03:14:20 2011" }, "committer": { "name": "Stéphane Marchesin", "email": "marcheu@chromium.org", "time": "Thu Apr 14 03:14:20 2011" }, "message": "Disable unredirection during screen resizes.\n\nChange-Id: I200aae31b4fc0853ec05c7ba31b71e58924c5f2d\n\nBUG\u003dNone\nTEST\u003dPlug/unplug an external screen, the screen shouldn\u0027t stay black after plug/unplug.\n\nReview URL: http://codereview.chromium.org/6853005\n" }, { "commit": "5354d11193e8acac4b7d54e8c32e6baf8cc7224f", "tree": "8d17430a60555a265a5475c840a9bb8be27c2065", "parents": [ "5559b6a5620839ab731247dc51a4e9619bf6ef60" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Apr 14 01:48:23 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Apr 14 01:48:23 2011" }, "message": "wm: Disable Ctrl-Alt-T until first browser window is up.\n\nThere\u0027s a weird state the first time a new user logs in\nwhere the _CHROME_LOGGED_IN property is set on the root\nwindow but the camera wizard is still being shown. This\nchange moves the Ctrl-Alt-T shortcut for opening a terminal\nfrom WindowManager to LayoutManager, so we can disable it\nuntil the user has finished taking their picture and a\nbrowser window is being shown.\n\nChange-Id: I4c1ddf3349cfcc5662306e1f3d5a607c6eff5304\n\nBUG\u003dchromium-os:12118\nTEST\u003dlogged in with a new user and checked that ctrl-alt-t did nothing on the camera screen but worked afterwards\n\nReview URL: http://codereview.chromium.org/6854010\n" }, { "commit": "5559b6a5620839ab731247dc51a4e9619bf6ef60", "tree": "cfce527874dc50e2ff4536aeb9411fcb963f0ba9", "parents": [ "5de3686a6d04a4de06e0c3745685e2f450a9f4a3" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Apr 14 00:47:36 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Apr 14 00:47:36 2011" }, "message": "wm: Clean up command-running code.\n\nThis just factors out the code that we use to run commands\nso I can move the terminal hotkey into LayoutManager in a\nlater change.\n\nChange-Id: I441c8aafa34d3173d4a1a6582d12e123ed1cb1b2\n\nBUG\u003dchromium-os:12118\nTEST\u003dchecked that we still run commands correctly\n\nReview URL: http://codereview.chromium.org/6854007\n" }, { "commit": "5de3686a6d04a4de06e0c3745685e2f450a9f4a3", "tree": "f132e58126207c2efe7773e35daa2cf41723de12", "parents": [ "c9b778659d2032967bf310d81f2358eee381dac4" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Apr 14 00:17:56 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Thu Apr 14 00:17:56 2011" }, "message": "wm: Use DLOG instead of LOG for Xlib errors.\n\nIn general, these come from unavoidable (at least without\ngrabbing the server all the time) races. There\u0027s pretty\nmuch no way to avoid them when a window gets unmapped.\n\nAlso avoid an extra round-trip to the X server to get a\ntimestamp that we don\u0027t use when we\u0027re closing a window that\ndoesn\u0027t have any transients.\n\nChange-Id: I3ab374e9f0c4f9d0baf14a4bdc91786acaa5afe9\n\nBUG\u003dchromium-os:8450\nTEST\u003dchecked that we don\u0027t log as many errors in non-debug builds; ran existing tests\n\nReview URL: http://codereview.chromium.org/6831006\n" }, { "commit": "c9b778659d2032967bf310d81f2358eee381dac4", "tree": "7ee6b813b5a012e121a01da25778cfc45d5755d0", "parents": [ "75394db6b7197ddffd56f241bbdf51ca9fb4d282" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Apr 13 23:18:25 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Apr 13 23:18:25 2011" }, "message": "wm: Add support for forcing compositing.\n\nThings are currently glitchy if we exit the non-composited\nmode by resizing a fullscreen window to instead just cover a\nportion of the screen, since the X window often gets resized\nbefore we get a chance to redraw and show the composited\nscene.\n\nThis change adds an IncrementCompositingRequests() method to\nWindowManager that can be used to force us to composite (and\nthat triggers a single composited draw if we\u0027re not already\ncompositing). This can be called before we do a resize to\nensure that the ugliness that goes on in the uncomposited\nworld isn\u0027t visible onscreen. At this point, we\u0027ll continue\ncompositing while we wait for the resized window to be\nrepainted by the client.\n\nBUG\u003dchromium-os:13963\nTEST\u003dmanually tested it with the new layout code that i\u0027m working on and checked that there\u0027s no ugly flicker when i go from maximized to non-maximized mode; also added some tests\n\nReview URL: http://codereview.chromium.org/6843001\n\nChange-Id: I05cab9fa1e0080d261a6484c2734f618cf70e6e7\n" }, { "commit": "75394db6b7197ddffd56f241bbdf51ca9fb4d282", "tree": "84ae87e5bc31a29cb04edf85c4cce0774c063a82", "parents": [ "55d4b5e43857215cbaefb4a7b4f5a85cfa5426a4" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Apr 13 23:08:29 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Wed Apr 13 23:08:29 2011" }, "message": "wm: Fix bug where transients can end up in wrong position.\n\nThis fixes a bug where we weren\u0027t updating a window\u0027s\ncomposited position correctly in response to\nConfigureRequest events that came in before the window was\nmapped. This was unnoticeable for most windows, but became\nan issue for transient windows after I changed\nTransientWindowCollection to use windows\u0027 composited (rather\nthan X) positions to determine their offsets from their\nowners in d1e1347a.\n\nChange-Id: I9da8a5a253490ee1e1680b5a705348939e943ccf\n\nBUG\u003dchromium-os:14075\nTEST\u003dmanual; also added a test\n\nReview URL: http://codereview.chromium.org/6851004\n" }, { "commit": "55d4b5e43857215cbaefb4a7b4f5a85cfa5426a4", "tree": "5fa6aeb07044001fb856565e02831b1d18de886c", "parents": [ "006a45521c7c211326c0734bbd3baa7a5428150e" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Apr 12 22:49:13 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Apr 12 22:49:13 2011" }, "message": "wm: Support keeping shadows under windows while restacking.\n\nWhen restacking a window, StackingManager previously only\nsupported putting its shadow on the bottom of a layer. This\nchanges adds support for keeping the shadow directly under\nthe window -- previously, we just reached around\nStackingManager and messed directly with the Window object\nwhen we needed to do this.\n\nI also added some enums to replace ambiguous bool arguments\nand added some more tests.\n\nChange-Id: Iab104024425badd1c1fa8c20df89dc4e1941c601\n\nBUG\u003dnone\nTEST\u003dadded; also did manual testing and didn\u0027t notice anything different\n\nReview URL: http://codereview.chromium.org/6831002\n" }, { "commit": "006a45521c7c211326c0734bbd3baa7a5428150e", "tree": "1a538ba90f3e1fb0d847f57051496591bed32600", "parents": [ "606180ea7d7d973f00ef7c140e264a77bafdacb8" ], "author": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Apr 12 21:57:52 2011" }, "committer": { "name": "Daniel Erat", "email": "derat@chromium.org", "time": "Tue Apr 12 21:57:52 2011" }, "message": "wm: Refactor Shadow class into ImageGrid.\n\nI\u0027m going to need scalable 3x3 grids of images for drawing\ntranslucent resize guides that look nicer than the simple\nsolid rectangles that we use currently. This is pretty\nclose to what we use for drop shadows, so I\u0027ve refactored\nthat code so that it can be used elsewhere.\n\nBUG\u003dnone\nTEST\u003dadded a bunch of tests, also built and ran it and checked that shadows look the same as before\n\nReview URL: http://codereview.chromium.org/6810036\n\nChange-Id: Iad8edef6238efd2c5bfa3b43ae4f14682c2ba2cd\n" } ], "next": "606180ea7d7d973f00ef7c140e264a77bafdacb8" }