)]}' { "log": [ { "commit": "090ccef246326b8b576b66b6154be094a992b7fe", "tree": "4a9833594f3e5841240eb014e7042d9e3d0e79e8", "parents": [ "d1587b96938b86b3cf944867a79e0ec592262a9d" ], "author": { "name": "Roland Bock", "email": "rbock@google.com", "time": "Thu Jun 18 16:09:15 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 19 18:06:30 2026" }, "message": "login: Remove traces of ChromAD\n\nAll ChromAD devices have been migrated long ago.\n\nBUG\u003db:263367348\nTEST\u003dNone, removing defunct code\n\nChange-Id: I340fe740710ef0fcdc2a54fb847024e8cbfcb90e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7957324\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Felipe Andrade \u003cfsandrade@chromium.org\u003e\nCommit-Queue: Roland Bock \u003crbock@google.com\u003e\nTested-by: Roland Bock \u003crbock@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6b613ac50aac06960880d45a735ef2f14b62ea2b\n" }, { "commit": "d1587b96938b86b3cf944867a79e0ec592262a9d", "tree": "31e2627ffc07603eb3f4d9111f7bf63046898015", "parents": [ "3d190a9e0c84bc9bae0fcb8e92660f9e4cba18c8" ], "author": { "name": "John Admanski", "email": "jadmanski@google.com", "time": "Wed May 06 20:51:11 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 07 22:08:08 2026" }, "message": "libbrillo: Reject LVM command arguments that don\u0027t round trip\n\nThis restricts the LvmCommandRunner::RunCommand operation to only\nsupport commands where the arguments won\u0027t be transformed by the\njoin+resplit operation that happens (i.e. one arg will be interpreted as\none arg). This is intended to prevent argument injection. What this\nmeans is that these command arguments must either use no whitespace or\nquotes, or they must be completely pre-quoted.\n\nBUG\u003db:510067752\nTEST\u003dunit tests\n\nChange-Id: Ia98f322d63f7d3cdb860373e3f99ecae92a8fc97\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7823495\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nCommit-Queue: John Admanski \u003cjadmanski@chromium.org\u003e\nTested-by: John Admanski \u003cjadmanski@chromium.org\u003e\nReviewed-by: Aashay Shringarpure \u003caashay@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8ce289db870d6af65728334fbc34198cf3e2e0fd\n" }, { "commit": "3d190a9e0c84bc9bae0fcb8e92660f9e4cba18c8", "tree": "4c06b01be5a43939bd3c3b9fb8af97a60f2f500c", "parents": [ "baf883421b0e0a99851ed8cb055f57bdcb9d2468" ], "author": { "name": "Nathan Muggli", "email": "nmuggli@google.com", "time": "Wed May 06 18:23:44 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 07 01:54:03 2026" }, "message": "libbrillo: Update logging include files\n\nSome of the logging framework has moved from base/logging.h to\nbase/logging/logging_settings.h. Update the appropriate includes.\n\nBUG\u003db:465651491\nTEST\u003dCQ\n\nChange-Id: Ic6a0a9470166e9ac3eaee87f15b504a1a88ee707\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7823488\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nTested-by: Nathan Muggli \u003cnmuggli@google.com\u003e\nCommit-Queue: Nathan Muggli \u003cnmuggli@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e67643c64a105f6f744b007eb857f381ace07e8e\n" }, { "commit": "baf883421b0e0a99851ed8cb055f57bdcb9d2468", "tree": "bf7ab5e5d432c9f3fde7b87e2ef6f337011f887e", "parents": [ "89253c41b30571289c5deb1771614c1becdee831" ], "author": { "name": "Di Wu", "email": "diwux@google.com", "time": "Thu Apr 09 05:18:58 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 17 01:47:30 2026" }, "message": "libbrillo: Use std::to_underlying instead of base::to_underlying\n\nReplace base::to_underlying with std::to_underlying in libbrillo. The\nplatform2 toolchain now supports C++23.\n\nBUG\u003db:470854927\nTEST\u003dCQ\n\nCq-Depend: chromium:7741160\nChange-Id: I7c1c552d8e6989691f07619eae09802b8c8cebde\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7742400\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nCommit-Queue: Di Wu \u003cdiwux@google.com\u003e\nTested-by: Di Wu \u003cdiwux@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ef6bed77c64ab66d0b1c2cfeaf1a749b3610ac0c\n" }, { "commit": "89253c41b30571289c5deb1771614c1becdee831", "tree": "d719b169c07d1823db191b1e93c70f0a32e96749", "parents": [ "258d5195d518b1463a6d298a7e7c960de9d33847" ], "author": { "name": "Brett Brotherton", "email": "bbrotherton@google.com", "time": "Thu Apr 02 16:33:40 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 07 13:02:23 2026" }, "message": "libbrillo: Migrate NOTREACHED_IN_MIGRATION to NOTREACHED\n\nBUG\u003db:379735176\nTEST\u003dCQ\n\nChange-Id: I1488cc277e9fbe4e4f2277216e7133a37616cdff\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7727323\nTested-by: Brett Brotherton \u003cbbrotherton@google.com\u003e\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nCommit-Queue: Brett Brotherton \u003cbbrotherton@google.com\u003e\nAuto-Submit: Brett Brotherton \u003cbbrotherton@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5813947e09552c381216610f2b90c0499511b2c0\n" }, { "commit": "258d5195d518b1463a6d298a7e7c960de9d33847", "tree": "e3213d95a4adba84deba43550b1766277ed6fa14", "parents": [ "c5ab8f60b5fc2e8e2c3ca5d70a9febe8b3b0eb3e" ], "author": { "name": "Di Wu", "email": "diwux@google.com", "time": "Sun Mar 29 23:02:04 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 02 10:53:06 2026" }, "message": "libbrillo: stop using HexEncode(ptr, size)\n\nSwitch the libbrillo callers to the public span/string_view-based\nHexEncode APIs so they no longer depend on the compatibility patch\nexposing the pointer-based overload.\n\nBUG\u003db:497207816\nTEST\u003dCQ\n\nChange-Id: I97e5ab26ca7c17381b1c51e3ea7f1ae55707ee56\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7707038\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nCommit-Queue: Di Wu \u003cdiwux@google.com\u003e\nTested-by: Di Wu \u003cdiwux@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0a5495544c6ba4ea509aba7fb9510108cfcc10dc\n" }, { "commit": "c5ab8f60b5fc2e8e2c3ca5d70a9febe8b3b0eb3e", "tree": "ad2d4995c3867cc99b673d2633c499c444c2ea03", "parents": [ "6dd1f8e01c62c3aceb683b605d62486397dee478" ], "author": { "name": "Di Wu", "email": "diwux@google.com", "time": "Fri Mar 27 09:15:36 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 30 20:36:04 2026" }, "message": "libbrillo: stop using private base::File raw I/O\n\nSwitch the remaining libbrillo callers to the public span-based File\nAPIs so they no longer depend on the compatibility patch exposing raw\nbase::File overloads.\n\nBUG\u003db:491074491\nTEST\u003dCQ\n\nChange-Id: Ia3ebbf1b6e72239252100ee16e0f96abb31d9bba\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7707339\nReviewed-by: Victor Gabriel Savu \u003cvsavu@google.com\u003e\nTested-by: Di Wu \u003cdiwux@google.com\u003e\nCommit-Queue: Di Wu \u003cdiwux@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 35a38d8b18c92f9eb9c5fae310c2bc51233143b4\n" }, { "commit": "6dd1f8e01c62c3aceb683b605d62486397dee478", "tree": "34dbbecd1f2d50ed86e1a97bac4c1c33a7c02286", "parents": [ "c03c9af209988dcfdde38b43fc8fcd7f300c32ec" ], "author": { "name": "Di Wu", "email": "diwux@google.com", "time": "Thu Mar 12 08:08:35 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 13 02:03:54 2026" }, "message": "libbrillo: stop using private base::File current-pos reads\n\nSwitch libbrillo callers to the public span-based base::File read APIs.\nThis is part of the platform2 migration away from the local libchrome\ncompatibility patch that restores ReadAtCurrentPos(char*, int).\n\nBUG\u003db:491074491\nTEST\u003dCQ\n\nChange-Id: I7ff8cf909cd2ec7f1b584db16e6af223ee6be46e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7660601\nTested-by: Di Wu \u003cdiwux@google.com\u003e\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nCommit-Queue: Di Wu \u003cdiwux@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8aa125503011bd1d6de1bcd90b0c3a8542f9c4e5\n" }, { "commit": "c03c9af209988dcfdde38b43fc8fcd7f300c32ec", "tree": "96e603dcf63794aa4813a0c3e349329a83806479", "parents": [ "bc21ff323d07d1b1560a0d31baaf2001ca8aca97" ], "author": { "name": "Nathan Muggli", "email": "nmuggli@google.com", "time": "Mon Mar 09 18:27:05 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 12 18:04:45 2026" }, "message": "platform2: Migrate base::Value::List|Dict\n\nbase::Value::List migrated to base::ListValue\nbase::Value::Dict migrated to base::DictValue\n\nThe upstream change that migrated these values: crrev.com/c/6331103\nThe upstream change that removed the aliases: crrev.com/c/7513889\n\nLSC doc: go/chromeos-lsc-base-value-list-dict\n\nBUG\u003db:480097637\nTEST\u003dCQ\n\nChange-Id: I46507d67b79dc53e3a9ea27cbb9057071db96e3c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7649578\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nAuto-Submit: Nathan Muggli \u003cnmuggli@google.com\u003e\nOwners-Override: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Nathan Muggli \u003cnmuggli@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 03438781b145f1a2e18d659cd577a6077e7065a6\n" }, { "commit": "bc21ff323d07d1b1560a0d31baaf2001ca8aca97", "tree": "5ac4c0b93ab3144dc5a4e84defefe0cd5106793f", "parents": [ "38b97fe7e7041d982eebc411d68a9f0da39c98f8" ], "author": { "name": "Kevin Lin", "email": "kevinptt@chromium.org", "time": "Sat Mar 07 17:43:42 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 09 05:32:38 2026" }, "message": "Fix include for trace events in brillo/tracing.cc\n\nChanged `#include \u003cbase/trace_event/trace_log.h\u003e` to `#include \u003cbase/trace_event/trace_event.h\u003e` as the latter is the correct header for using `base::TrackEvent` functionality.\n\nBUG\u003db:488338226\nTEST\u003dCQ\nChange-Id: I081ca93b747f826f904dd6136986199e96d2b19e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7646368\nCommit-Queue: Kevin Lin \u003ckevinptt@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Kevin Lin \u003ckevinptt@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 81d0c1f5881d700303012d7d23d8e87f3957a339\n" }, { "commit": "38b97fe7e7041d982eebc411d68a9f0da39c98f8", "tree": "e5fb88430559842a7792818af91e90b3c3d4ca04", "parents": [ "3102017801a549d22fabff58ec54a98d3601c96f" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Tue Feb 17 13:50:13 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 03 08:55:07 2026" }, "message": "libbrillo: http: Remove curl_easy_error outer wrapping\n\nRemove the backward-compat \"curl_easy_error\"/\"curl_multi_error\" outer\nerror layers from AddEasyCurlError/AddMultiCurlError. All consumers\nnow use ClassifyTransportError() to read the kTransportErrorDomain\nentry directly.\n\nBUG\u003db:463098734\nTEST\u003dFEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/libbrillo\nTEST\u003dFEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/shill\n\nChange-Id: I48255c1a08558ec3165896173924d8178e167fd2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7581699\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nTested-by: Maksim Sisov \u003cmsisov@igalia.com\u003e\nReviewed-by: Hugo Benichi \u003chugobenichi@google.com\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f9bbe7201b6de4f350758a2df2d5953a7b414142\n" }, { "commit": "3102017801a549d22fabff58ec54a98d3601c96f", "tree": "902ca866237b4dd2ebff47359557d548465b17e6", "parents": [ "5583aa5df59b11be49f5f26e71c78a896ff8f193" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Tue Feb 17 13:29:36 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 26 16:17:31 2026" }, "message": "libbrillo: http: Chain TransportError in AddEasyCurlError\n\nModify AddEasyCurlError to produce a two-layer error chain: an inner\nkTransportErrorDomain error (with enum name string like \"kDnsFailure\")\nwrapped by the existing outer curl_easy_error. This allows both old\nand new consumers to coexist during migration:\n\n chain: curl_easy_error(\"6\") -\u003e transport_error(\"kDnsFailure\")\n Old callers: check GetDomain() \u003d\u003d \"curl_easy_error\" -\u003e still works\n New callers: ClassifyTransportError() -\u003e reads transport_error\n\nAlso replace curl_init_failed error sites with AddTransportError using\nTransportError::kBackendFailed.\n\nBUG\u003db:463098734\nTEST\u003dFEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/libbrillo\n\nChange-Id: I232b6d8ce3fb63b12559238344e08737917b1cf8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7581695\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Hugo Benichi \u003chugobenichi@google.com\u003e\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nTested-by: Maksim Sisov \u003cmsisov@igalia.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f46838be0ab55fd0fb6979b678be8a69dfbc5da6\n" }, { "commit": "5583aa5df59b11be49f5f26e71c78a896ff8f193", "tree": "6293ca696721f760085804c588b652189ff6425b", "parents": [ "c5e798386d13df9d954940b5a4f24c98a588ee78" ], "author": { "name": "Maksim Sisov", "email": "msisov@igalia.com", "time": "Tue Feb 17 13:21:33 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 26 16:17:24 2026" }, "message": "libbrillo: http: Add TransportError enum and classifier\n\nConsumers (http_request.cc, hosts_connectivity_diagnostics_util.cc)\nparse raw \"curl_easy_error\" strings from brillo::Error to identify\ntransport failures, coupling them to libcurl. This commit adds a\nTransportError enum so consumers can classify transport errors\nwithout knowing the underlying HTTP library.\n\nMigration is done across separate commits:\n 1. Add TransportError enum + classifier (this commit)\n 2. Chain TransportError in AddEasyCurlError\n 3. Migrate shill consumers to ClassifyTransportError()\n 4. Remove the curl_easy_error compatibility wrapper\n\n- Add TransportError enum with 14 values (kUnknown..kBackendFailed)\n- Add ClassifyTransportError() returning std::optional\u003cTransportError\u003e;\n returns std::nullopt when no kTransportErrorDomain entry is found\n- Add AddTransportError() to construct kTransportErrorDomain errors\n- Add TransportErrorToString() for human-readable error names\n- Add unit tests covering all code paths and boundary cases\n\nClassifyTransportError uses FindErrorOfDomain to traverse the\nbrillo::Error chain, so it works whether the kTransportErrorDomain\nerror is outermost (final state) or wrapped inside a curl_easy_error\n(during migration). The abstract layer does not include curl headers.\n\nBUG\u003db:463098734\nTEST\u003dFEATURES\u003d\"test\" emerge-${BOARD} chromeos-base/libbrillo\n\nChange-Id: I2ff03eab7cf0f0cd5d431010cd5b804d8372c5b2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7581694\nReviewed-by: Andreea Costinas \u003cacostinas@google.com\u003e\nTested-by: Maksim Sisov \u003cmsisov@igalia.com\u003e\nCommit-Queue: Maksim Sisov \u003cmsisov@igalia.com\u003e\nReviewed-by: Sergey Poromov \u003cporomov@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e2ee61ebebe30c28cc7cf6a90b549a6d72367489\n" }, { "commit": "c5e798386d13df9d954940b5a4f24c98a588ee78", "tree": "ca4414b90f568a30921fc78584fb207de5641f1f", "parents": [ "a61558a98ba08ca0b8734a8b181146d53ff98497" ], "author": { "name": "John Admanski", "email": "jadmanski@google.com", "time": "Tue Feb 10 21:49:09 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 11 18:18:46 2026" }, "message": "libbrillo: Reduce SafeFD error logging\n\nThis changes some of the SafeFD checks to only log conditionally, when\nthe checks failing are actually considered to be errors. The checks\nfailing can actually be normal behavior, e.g. if you\u0027re creating a new\ndirectory with a target owner that differs from the owner of its parent\ndirectory.\n\nIn particular, cryptohome mounting operations tend to produce a lot of\n\"owner uid is 0 instead of nnn\" ERROR logs which has led to a non-zero\nnumber of bug reports as well as being distracting when investigating\nother (unrelated) bugs.\n\nFIXED\u003db:483432889\nTEST\u003dunit tests\n\nChange-Id: Ie4ab778ad6bc06c2d10e0bac17b72b61dd7a6d87\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7562455\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\nTested-by: John Admanski \u003cjadmanski@chromium.org\u003e\nReviewed-by: Jorge Lucangeli Obes \u003cjorgelo@chromium.org\u003e\nCommit-Queue: John Admanski \u003cjadmanski@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4020484207649734f8ffa30dc4eff5c1957c88e8\n" }, { "commit": "a61558a98ba08ca0b8734a8b181146d53ff98497", "tree": "959584b03f8cbd2bdefad8323bd3fa694440520e", "parents": [ "ebfc3a1531b47c8eaed7a048b4499800b052b1dc" ], "author": { "name": "Nathan Muggli", "email": "nmuggli@google.com", "time": "Tue Jan 06 21:14:09 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 07 00:25:03 2026" }, "message": "libbrillo: Add includes of callbacks for libchrome uprev\n\nBUG\u003db:469885510\nTEST\u003dCQ\n\nChange-Id: I960c0b4726d48bfdff52a990d8236a8e51317a38\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7402672\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nCommit-Queue: Nathan Muggli \u003cnmuggli@google.com\u003e\nTested-by: Nathan Muggli \u003cnmuggli@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 81d6dc802bf4a364c4675e8968bd26ef41ef5573\n" }, { "commit": "ebfc3a1531b47c8eaed7a048b4499800b052b1dc", "tree": "d2ed7d62d98128515e70f6464deabdcdb98463d8", "parents": [ "9d38f869563cb18a2b0f421582b3e4168b9f728a" ], "author": { "name": "Vitaly Buka", "email": "vitalybuka@chromium.org", "time": "Sun Dec 21 03:15:35 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 23 11:20:21 2025" }, "message": "libbrillo: Fix undefined behavior caused by test in operator\u0026\n\nThe test casting -1 to SomeFlagsEnum, however it\u0027s\nundefined behavior if underlying type is not specified.\n\nWithout the patch testing with -fsanitize\u003denum reports:\n\n```\nenum_flags.h:92:54: runtime error: load of value 4294967295, which is not a valid value for type \u0027const brillo::SomeFlagsEnum\u0027\n #0 0x7f4836eb60a1 in operator\u0026\u003cbrillo::SomeFlagsEnum\u003e enum_flags.h:92:54\n #1 0x7f4836eb60a1 in brillo::EnumFlagsTest_BinaryBehaviorOfSimpleOperations_Test::TestBody() enum_flags_test.cc:171:32\n```\n\nBUG\u003dNone\nTEST\u003denum_flags_test.cc\n\nChange-Id: I95bd987ad5df6eda2616a5aacd277a3c5b54c84e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7288724\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nTested-by: Vitaly Buka \u003cvitalybuka@chromium.org\u003e\nAuto-Submit: Vitaly Buka \u003cvitalybuka@chromium.org\u003e\nCommit-Queue: Vitaly Buka \u003cvitalybuka@chromium.org\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 63be858ab0310754467cc305c94136e617174568\n" }, { "commit": "9d38f869563cb18a2b0f421582b3e4168b9f728a", "tree": "e57a5206689689bb1184497bc2cd95fe52bc0330", "parents": [ "638196eade6c970db67bdb72af2f14e046cadac1" ], "author": { "name": "Kevin Lin", "email": "kevinptt@google.com", "time": "Fri Nov 21 06:58:59 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 27 13:17:53 2025" }, "message": "libbrillo: Use base:: instead of base::internal:: for numeric members\n\nIn CL:7145230, some numeric functions/types are moved from\nbase::internal:: to base::. This CL modifies the usage accordingly.\n\nBUG\u003dNone\nTEST\u003dCQ\n\nCq-Depend: chromium:7176627\nChange-Id: I9ad210c9ec2348eecd4abe98a090dc704202958f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7181633\nTested-by: Kevin Lin \u003ckevinptt@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Kevin Lin \u003ckevinptt@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 22af6289eb78f7882cebdfc872dc96dfbe51ba92\n" }, { "commit": "638196eade6c970db67bdb72af2f14e046cadac1", "tree": "63d81b2167c02d34bb50ec3efe7330ad993bc9d0", "parents": [ "42bc463af2b75077c142bdd705d363f28864f601" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Wed Nov 19 04:14:18 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 26 04:07:44 2025" }, "message": "Avoid remaining deprecated Do* methods on MockObjectProxy\n\nThey will be removed from libchrome soon. Use the\ncorresponding functions without \"Do\" prefix instead.\n\nThis is the last CL in the series.\n\nBUG\u003db:453531230\nTEST\u003dcros_sdk FEATURES\u003dtest emerge-hatch chromeos-login\nTEST\u003dcros_sdk FEATURES\u003dtest emerge-hatch libbrillo\nTEST\u003dcros_sdk FEATURES\u003dtest emerge-hatch patchpanel\n\nDisallow-Looks-For-Green: True\nDisallow-Recycled-Builds: test-failures\nChange-Id: I232dd63323d75d89d5ca8971fbc4498db12334b9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7171499\nReviewed-by: Ningyuan Wang \u003cningyuan@google.com\u003e\nTested-by: Kevin Lin \u003ckevinptt@chromium.org\u003e\nTested-by: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 61cce3ecbd3a2a0ff3556376b02bd4b01a0010ce\n" }, { "commit": "42bc463af2b75077c142bdd705d363f28864f601", "tree": "bffef532b5761a126cc57c4611a165a23dc34104", "parents": [ "4e26ed0abba04a4a97c72db24f53f7b7e6cf7aa1" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Fri Nov 14 03:58:39 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 17 09:56:31 2025" }, "message": "libbrillo: Avoid deprecated Do* methods on MockObjectProxy\n\nThey will be removed from libchrome soon. Use the corresponding\nfunctions without \"Do\" prefix instead.\n\nBUG\u003db:453531230\nTEST\u003dcros_sdk FEATURES\u003dtest emerge-hatch libbrillo\n\nChange-Id: I248566b85a7d9e4cbd9ef11c650daa6d62f42f51\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7155127\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Georg Neis \u003cneis@chromium.org\u003e\nCommit-Queue: Georg Neis \u003cneis@chromium.org\u003e\nAuto-Submit: Georg Neis \u003cneis@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ea203e825a83d68a952855efd7627269bd9d110b\n" }, { "commit": "4e26ed0abba04a4a97c72db24f53f7b7e6cf7aa1", "tree": "aafb279f86f70806ca4f57a9cf7c3dbfc8ef04ae", "parents": [ "101896faa22aee16bf344109983fbda90e3a7ab7" ], "author": { "name": "Nathan Muggli", "email": "nmuggli@google.com", "time": "Fri Nov 07 00:31:34 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 13 00:08:59 2025" }, "message": "libbrillo: Pass Bus::Options by value with std::move\n\nCL:7056670 modified the dbus::Bus ctor to accept the Options parameter\nby value instead of const ref. Make similar updates here so a patch in\nlibchrome can be removed.\n\nBUG\u003db:454152943\nTEST\u003dCQ\n\nChange-Id: I9c76d9a3be1a0274a27117754849f8ee1f6acf11\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7130039\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nTested-by: Nathan Muggli \u003cnmuggli@google.com\u003e\nCommit-Queue: Nathan Muggli \u003cnmuggli@google.com\u003e\nAuto-Submit: Nathan Muggli \u003cnmuggli@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d3e65f065b980fee07ae435650332ef7ab02e576\n" }, { "commit": "101896faa22aee16bf344109983fbda90e3a7ab7", "tree": "71c141f8b2070275d04c71dbf193694852bfc3bc", "parents": [ "46ac93e8c4966f98f58f226b78e6fb4abe34aebc" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Tue Sep 09 08:10:57 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 23 04:02:35 2025" }, "message": "Migrate to dbus::CallMethodWithErrorResponse\n\ndbus::CallMethodWithErrorCallback is deprecated and will soon be removed\nfrom libchrome. Use CallMethodWithErrorResponse instead.\n\nBUG\u003db:436722113\nTEST\u003dFEATURES\u003dtest emerge-hatch libbrillo trunks crash-reporter vtpm vm_host_tools dlp\n\nChange-Id: I40458f4b9dbec2e741329e9a553bb2f6b965f394\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6929083\nTested-by: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Aida Zolić \u003caidazolic@chromium.org\u003e\nCommit-Queue: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Troy Wang \u003ctroywang@google.com\u003e\nReviewed-by: Junichi Uekawa \u003cuekawa@chromium.org\u003e\nReviewed-by: Vadim Bendebury \u003cvbendeb@google.com\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f9533897ac2b2ab98d696685ebef0b3cd0069ebd\n" }, { "commit": "46ac93e8c4966f98f58f226b78e6fb4abe34aebc", "tree": "6fd49cd8dea35c76fa41a81b7db2756968dcea4e", "parents": [ "a1f7765f8f9b0b9e9537c03c937f2db7ac30cd20" ], "author": { "name": "Wei-Luan Wang", "email": "weiluanwang@google.com", "time": "Tue Oct 21 03:45:06 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 23 01:00:08 2025" }, "message": "libbrillo: Migrate PopArrayOfBytes to returning base::span\n\nBUG\u003db:438875824\nTEST\u003dCQ\n\nCq-Depend: chromium:7065651\nChange-Id: Icb5ec6ed768669af0d52453c82eeb51dfced6d76\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7065532\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nCommit-Queue: Wei-Luan Wang \u003cweiluanwang@google.com\u003e\nTested-by: Wei-Luan Wang \u003cweiluanwang@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f08d0ecc5c643b2d66aa1152c4d2943f485d10fb\n" }, { "commit": "a1f7765f8f9b0b9e9537c03c937f2db7ac30cd20", "tree": "d50223507d990cac34ac03ddedf6b74c4dd3cb0a", "parents": [ "336ce69a7028e3bf9463877b6692c0fd9ea3c70f" ], "author": { "name": "Ryo Hashimoto", "email": "hashimoto@google.com", "time": "Thu Oct 02 07:21:23 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 02 23:38:26 2025" }, "message": "libbrillo: Explicitly specify JSON parsing options\n\nBUG\u003db:448525509\nTEST\u003dbuild\n\nChange-Id: I651e1df6a49edfbda44d64b7c05b01c9a2c8e2db\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7005626\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nTested-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e6a2c26f6fd07b2ebe87454289fe6acfe39cba42\n" }, { "commit": "336ce69a7028e3bf9463877b6692c0fd9ea3c70f", "tree": "ae6230585bd1f8b946258df28f2f9a05b7378dee", "parents": [ "6d0cb298f1f3f296a748916ab7af7e191ef1a242" ], "author": { "name": "Cici Ruan", "email": "cuicuiruan@google.com", "time": "Tue May 13 19:38:02 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 22 14:46:32 2025" }, "message": "platform2: update for libchrome uprev\n\nlibbrillo: update the include file due to moving file in crrev.com/c/6497859.\ncommon-mk: add a new mojom generated header file due to libchrome uprev\ncrrev.com/c/6536195.\n\nBUG\u003dNone\nTEST\u003dCQ\n\nCq-Depend: chromium:6536195\nChange-Id: I77c397ee0a2ac18c0df2a31da7b9d86560d185fe\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6542537\nReviewed-by: Leandro Lovisolo \u003clovisolo@google.com\u003e\nTested-by: Brett Brotherton \u003cbbrotherton@google.com\u003e\nReviewed-by: Di Wu \u003cdiwux@google.com\u003e\nReviewed-by: Roland Bock \u003crbock@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: aace9a0b19e922f7c57f6e061bbcb8bbad1233e0\n" }, { "commit": "6d0cb298f1f3f296a748916ab7af7e191ef1a242", "tree": "c56b5f9c4d0559e747516981793cd65a140a2655", "parents": [ "0445c38090f620ba9d0393565f68d26a5c633277" ], "author": { "name": "Allen Shih", "email": "allenshihmc@google.com", "time": "Thu May 08 09:46:37 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 19 07:01:39 2025" }, "message": "libbrillo: Introduce EncodeHWID\n\nImplements EncodeHWID() to encode HWID strings. This function converts\nthe given binary payload string to base8192-encoded string, prepends the\ngiven HWID prefix (model name, RLZ code and optional configless field)\nand appends the calculated checksum to produce the fully formed HWID\nstring.\n\nBUG\u003db:367899338\nTEST\u003dFEATURES\u003dtest emerge-${BOARD} libbrillo\n\nChange-Id: I951b7dbda293e1aeb69dc56c64a0d6cf5097df9b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6529702\nTested-by: Allen Shih \u003callenshihmc@chromium.org\u003e\nCommit-Queue: Allen Shih \u003callenshihmc@chromium.org\u003e\nReviewed-by: Yu-An Wang \u003cwyuang@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1bc6786aaa67b8c9bcf1242f2b9200ab145d788b\n" }, { "commit": "0445c38090f620ba9d0393565f68d26a5c633277", "tree": "11cefbdbfe3bc4a4113af94c702d93c3dc385d27", "parents": [ "445fefdb162bffeac2c1632328632fdaa5672a14" ], "author": { "name": "Allen Shih", "email": "allenshihmc@google.com", "time": "Tue May 06 05:09:59 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 19 07:01:32 2025" }, "message": "libbrillo: Handle configless field in CalculateChecksum\n\nModify CalculateChecksum to correctly parse and calculate the checksum\nof HWIDs that include an optional configless field.\n\nBUG\u003db:367899338\nTEST\u003dFEATURES\u003dtest emerge-${BOARD} libbrillo rmad\n\nChange-Id: I74efd39d89151b6dd93be97e461924e8c306df82\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6515512\nReviewed-by: Jeff Lin \u003cjeffulin@google.com\u003e\nCommit-Queue: Allen Shih \u003callenshihmc@chromium.org\u003e\nTested-by: Allen Shih \u003callenshihmc@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3bacd22a350b7fc769bc69837fee10467aebb8ea\n" }, { "commit": "445fefdb162bffeac2c1632328632fdaa5672a14", "tree": "b43519084387ac7393cdd5174379ee65a6643bb1", "parents": [ "7d95dc4c21ddb7677f0daef72e389addf81b01c3" ], "author": { "name": "Allen Shih", "email": "allenshihmc@google.com", "time": "Fri May 02 06:30:41 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 19 07:01:26 2025" }, "message": "libbrillo: rmad: Move CalculateChecksum to libbrillo\n\nHardware Verifier will leverage HwidUtils::CalculateChecksum to\ncalculate the checksum of HWID at runtime. To make it accessible by\nother packages, this CL moves the CalculateChecksum utility function\nfrom rmad to libbrillo.\n\nBUG\u003db:367899338\nTEST\u003dFEATURES\u003dtest emerge-${BOARD} rmad libbrillo\n\nChange-Id: I84468b25fde57d77e7271313ad8bbc6caff455dc\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6515032\nReviewed-by: Jeff Lin \u003cjeffulin@google.com\u003e\nTested-by: Allen Shih \u003callenshihmc@chromium.org\u003e\nCommit-Queue: Allen Shih \u003callenshihmc@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 77d6c72157500252546c721e2c3b620fa801e1c0\n" }, { "commit": "7d95dc4c21ddb7677f0daef72e389addf81b01c3", "tree": "39932e81709cb4ab611c72f3ad8d45d00dedf861", "parents": [ "b3eb4842dd46b23c18e939186fd3fee3b9aeaeb7" ], "author": { "name": "Allen Shih", "email": "allenshihmc@google.com", "time": "Fri May 02 07:48:43 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 13 05:39:20 2025" }, "message": "libbrillo: Handle configless field in DecodeHWID\n\nModify DecodeHWID to correctly parse and decode HWIDs that include an\noptional configless field.\n\nAlso, updates the test cases of DecodeHWID to make the checksum valid.\nThis does not change the behavior of the test, but is intended to make\nthe test more consistent with the name of the test case\n\"DecodeValidHWIDSuccess\"\n\nBUG\u003db:367899338\nTEST\u003dFEATURES\u003dtest emerge-${BOARD} libbrillo\n\nChange-Id: I69ed7cd5e4abeed6c040c3e0efc143c30a02f03a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6508008\nTested-by: Allen Shih \u003callenshihmc@chromium.org\u003e\nCommit-Queue: Allen Shih \u003callenshihmc@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 663adb507143b92b2feb9c183e662af606cdb9a8\n" }, { "commit": "b3eb4842dd46b23c18e939186fd3fee3b9aeaeb7", "tree": "d486637c6fa5b81b51438924c10fd8b7b855e43c", "parents": [ "0f2b462ee2baba638e8d8fa92679b443d995b15b" ], "author": { "name": "Allen Shih", "email": "allenshihmc@google.com", "time": "Thu Apr 17 05:22:34 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 13 05:39:13 2025" }, "message": "libbrillo: libsegmentation: Move DecodeHWID to libbrillo\n\nHardware Verifier will leverage FeatureManagementUtil::DecodeHWID to\ndecode a HWID string at runtime. To make it accessible by other\npackages, this CL moves the DecodeHWID utility function from\nlibsegmentation to libbrillo.\n\nBUG\u003db:367899338\nTEST\u003dFEATURES\u003dtest emerge-${BOARD} libsegmentation libbrillo\n\nChange-Id: I208a063befaae4ace797676119613a05f3c09bd5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6467248\nTested-by: Allen Shih \u003callenshihmc@chromium.org\u003e\nReviewed-by: Gwendal Grignou \u003cgwendal@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Allen Shih \u003callenshihmc@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 87ce1a1de4c03f66df4525a7f9943d80fca62e4c\n" }, { "commit": "0f2b462ee2baba638e8d8fa92679b443d995b15b", "tree": "bd8c2adc720cb7d6d47d8f85dd6b01ae879169e6", "parents": [ "e55a7efd54c3c1ddd2d6c2bf4d5ee1eb66a72aad" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Wed Apr 30 04:38:09 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 09 03:49:29 2025" }, "message": "Migrate base::numerics uses for libchrome change\n\nbase::numerics::* functions have been aliases to base::* for a while.\nThe base::numerics namespace has now been removed from Chromium[1] and\nlibchrome will follow soon.\n\nThis CL does \"s/base::numerics::/base::/g\".\n\n[1]https://chromium-review.googlesource.com/c/chromium/src/+/6489568\n\nBUG\u003db:414697720\nTEST\u003dCQ\n\nChange-Id: Ibef746c1461378b8da410da24f85dd67f7271b2c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6496252\nReviewed-by: Brian Granaghan \u003cgranaghan@google.com\u003e\nTested-by: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Troy Wang \u003ctroywang@google.com\u003e\nCommit-Queue: ChromeOS Auto Retry \u003cchromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com\u003e\nReviewed-by: John L Chen \u003czuan@chromium.org\u003e\nReviewed-by: Chih-Yu Huang \u003cakahuang@chromium.org\u003e\nAuto-Submit: Georg Neis \u003cneis@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6e409c99e167758fe5dc190edb161511de19a0b9\n" }, { "commit": "e55a7efd54c3c1ddd2d6c2bf4d5ee1eb66a72aad", "tree": "f10ce771af1f92c3a8f77e90f02b4ecf8544e471", "parents": [ "b9809cba18115e4ad337fb4c99f1924b3a07a045" ], "author": { "name": "Cici Ruan", "email": "cuicuiruan@google.com", "time": "Tue Dec 17 21:51:30 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 09 06:45:45 2025" }, "message": "Platform2: replace base::make_span by base::span\n\nbase::make_span is removed in crrev.com/c/6066402.\n- s/base::make_span/base::span/g\n- s/base::as_bytes(base::span(\\(.*\\)))/base::as_byte_span(\\1)/g\n- Adjust above change for some data type unmatch.\n- Removed some usages of base::span when it is not necessary.\n\nBUG\u003db:382374535\nTEST\u003dCQ\nCq-Depend: chromium:6112755\n\nChange-Id: I8089005ccf8cee9cad3d7ced93d28e1dd4ce4119\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6100527\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nOwners-Override: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Jett Rink \u003cjettrink@google.com\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Jorge Lucangeli Obes \u003cjorgelo@chromium.org\u003e\nTested-by: Cici Ruan \u003ccuicuiruan@google.com\u003e\nReviewed-by: Michael Slutskii \u003cslutskii@google.com\u003e\nReviewed-by: Kevin Lin \u003ckevinptt@chromium.org\u003e\nAuto-Submit: Cici Ruan \u003ccuicuiruan@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 123e4bdfde85ccd18465bec3b9fdbfb785f81c3b\n" }, { "commit": "b9809cba18115e4ad337fb4c99f1924b3a07a045", "tree": "f06ae86a893201326fc03b856234598bb9785c89", "parents": [ "808bef1fdb69fd021944edf68fa4f554ebd07eff" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Mar 14 03:50:27 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 14 08:41:13 2025" }, "message": "libbrillo: enum_flags_test: fix typo\n\nThey have the same integer value which is why the test passed.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I0b97c6db302f2962b28468b13b9e5df652ac8293\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6356024\nCommit-Queue: ChromeOS Auto Retry \u003cchromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d9ee910c456140b3283d78b48995a409d330ff8d\n" }, { "commit": "808bef1fdb69fd021944edf68fa4f554ebd07eff", "tree": "c4aefe0eaf4ef59da3e19e76846b517a4b8761eb", "parents": [ "311c711f10915611b8b88dce9ab0d8b3d76899e1" ], "author": { "name": "Hugo Benichi", "email": "hugobenichi@google.com", "time": "Sun Feb 09 06:26:48 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 10 15:58:00 2025" }, "message": "libbrillo: http: less verbose requests\n\nOnly print in logs the result of a curl http request if the status code\nis a client error code (4xx) or a server error code (5xx).\n\nHandling the status code as an erorr or success should be preferably\nleft to the client application. For example, receiving a 200 or 302\nto a captive portal detection probe is a successful outcome.\n\nBUG\u003db:370371604\nTEST\u003dFEATURES\u003dtest emerge-$BOARD libbrillo shill; deployed, checked\nnetwork validation logs in /var/log/net.log; CQ.\n\nChange-Id: I6febe80852559e8296d9f1260790be7f65700dc2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6245955\nTested-by: Hugo Benichi \u003chugobenichi@google.com\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nAuto-Submit: Hugo Benichi \u003chugobenichi@google.com\u003e\nCommit-Queue: ChromeOS Auto Retry \u003cchromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com\u003e\nCommit-Queue: Eric Caruso \u003cejcaruso@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c56f318c0d29b3935f9be577cc71c0a381a0f244\n" }, { "commit": "311c711f10915611b8b88dce9ab0d8b3d76899e1", "tree": "181839613089b6d2ef725e2d901664070969b063", "parents": [ "5ac4bc099160be4c9ccb700ceab7695c60814d6a" ], "author": { "name": "Gwendal Grignou", "email": "gwendal@chromium.org", "time": "Thu Dec 05 19:44:53 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 20 02:28:41 2024" }, "message": "libbrillo: Remove verbose log info\n\nThis is expected when clobbering, trying to remove cryptohome LV.\n\nBUG\u003dnone\nTEST\u003dCheck messages:\n\"Logical volume\u003d... does not match pattern\u003dcryptohome*\" are gone.\n\nChange-Id: I6b11856f699f85fb0a946a63e0d80985aa24593b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6093194\nCommit-Queue: ChromeOS Auto Retry \u003cchromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com\u003e\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nTested-by: Gwendal Grignou \u003cgwendal@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f8f5912cc76549509256dc809af608bfa50a7041\n" }, { "commit": "5ac4bc099160be4c9ccb700ceab7695c60814d6a", "tree": "b93ca31dca582bd7c557782ae7e9c61d5b2f802f", "parents": [ "268455ad97fea2b779556d3dd176830f28f26c32" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Thu Dec 05 08:44:10 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 12 18:13:42 2024" }, "message": "login: Use FakeSystemUtils in ResilientPolicyStore.\n\nAnd fix path injection for testing.\nAlso the test expects non-real behavior and written on top of the\nassumption. This CL removes such assumption.\n\nBUG\u003db:380997377\nTEST\u003dTryjob\n\nChange-Id: Idb21a94a8a67765caf41c2cd3ec09eff9077e67b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6073326\nReviewed-by: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nTested-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7645c9b760223e5242befffa5ea83c6a769b0436\n" }, { "commit": "268455ad97fea2b779556d3dd176830f28f26c32", "tree": "41208a31e23f8f96fb0b32047f8c7d7d01988cbb", "parents": [ "c793612d6d39f8e003ba31b0869a99d7f93c811f" ], "author": { "name": "Owners Cleanup", "email": "swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com", "time": "Sat Dec 07 14:42:39 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 09 17:08:21 2024" }, "message": "[owners] Remove emaxx@chromium.org from libbrillo/brillo/grpc/OWNERS\n\nThis suggested change is automatically generated based on group\nmemberships and affiliations.\nIf this change is unnecessary or in error, vote the lowest CR value\n(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to\napprove this change. You may also abandon this change.\n\nSee the owner\u0027s recent activity for context:\nhttps://chromium-review.googlesource.com/q/emaxx@chromium.org\n\nTo report an issue, file a bug in the Infra\u003eCodereview component.\n\nChange-Id: Ib95efe36cd23e6deab2d1c0ffb8d4e400f484aae\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6078946\nAuto-Submit: Owners Cleanup \u003cswarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 41eacafc3e04a0334e4d313fa1f62b46786a386f\n" }, { "commit": "c793612d6d39f8e003ba31b0869a99d7f93c811f", "tree": "663c3d9b073608e6192b5e062c76391fc7250a81", "parents": [ "87285fcf63211eb406e4c10c426cd10770a731fe" ], "author": { "name": "Owners Cleanup", "email": "swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com", "time": "Sat Dec 07 14:42:48 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 09 13:45:53 2024" }, "message": "[owners] Remove emaxx@chromium.org from libbrillo/policy/OWNERS\n\nThis suggested change is automatically generated based on group\nmemberships and affiliations.\nIf this change is unnecessary or in error, vote the lowest CR value\n(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to\napprove this change. You may also abandon this change.\n\nSee the owner\u0027s recent activity for context:\nhttps://chromium-review.googlesource.com/q/emaxx@chromium.org\n\nTo report an issue, file a bug in the Infra\u003eCodereview component.\n\nChange-Id: I80fb9e4c867397b457e1bd0a0e41ab3af95fd0a1\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6078922\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nAuto-Submit: Owners Cleanup \u003cswarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com\u003e\nCommit-Queue: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f192e7f54e299e7567ca538e53111d5c7bb15432\n" }, { "commit": "87285fcf63211eb406e4c10c426cd10770a731fe", "tree": "2adfbf5f57695a430f8c30a7d6ae35b00a60a87e", "parents": [ "d21d617c8f58c79c9979d2b352a0e2b1391de9d0" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Thu Nov 07 06:33:49 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 13 22:19:52 2024" }, "message": "libbrillo: Introduce WriteFileAtomically.\n\nThis CL introduces a new function WriteFileAtomically.\nIt is almost WriteToFileAtomic, but it can specify uid/gid to own\nthe file.\nExisting WriteToFileAtomic* can be replaced by the new function,\nbut that\u0027ll be done in another CL.\n\nBUG\u003db:289228842\nTEST\u003dTryjob\n\nChange-Id: I6c9a551cf74f51faa484d46a0e76277fefedc796\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6002241\nTested-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Jorge Lucangeli Obes \u003cjorgelo@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4f260f6cd34eb5769f98df9055eb32ac9d24e2a8\n" }, { "commit": "d21d617c8f58c79c9979d2b352a0e2b1391de9d0", "tree": "6cb419c018bb4aa62aa5b98d5b4815a92b0413c1", "parents": [ "c9c3326e03f407bac35660bd2cdd3c2b8923a661" ], "author": { "name": "mlcui", "email": "mlcui@google.com", "time": "Tue Nov 12 00:39:03 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 12 16:51:46 2024" }, "message": "libbrillo: Fix unsafety in operator~ in enum_flags.h\n\nValid values for an enum must be the smallest and largest values of a\nbit-field that can store the minimum and maximum values of the enum.\n\nHowever, enum_flags.h\u0027s `operator~` returned values for enums which are\noutside of the value. This causes ASAN errors, see attached bug.\n\nFix this by returning the underlying type from `operator~`, and allowing\n`operator\u0026` to take in the underlying type too. This fixes the\naforementioned ASAN errors.\n\nBUG\u003db:329990991\nTEST\u003dCQ\n\nChange-Id: I6a6a2100c2f7f77f2f3a97ebda7a016b26b6adde\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6014058\nCommit-Queue: Eric Caruso \u003cejcaruso@chromium.org\u003e\nAuto-Submit: Michael Cui \u003cmlcui@google.com\u003e\nTested-by: Michael Cui \u003cmlcui@google.com\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b33ece9ff2e0aa4c1368e9f7f2005c3a4ba8d413\n" }, { "commit": "c9c3326e03f407bac35660bd2cdd3c2b8923a661", "tree": "b554ee6dab60c4cbc9831fddb2f1e4c71960e3f5", "parents": [ "06b1a1eeab7dba509b6115e5a8db52873bc57c95" ], "author": { "name": "Betul", "email": "betuls@google.com", "time": "Fri Nov 08 18:32:46 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 08 19:57:53 2024" }, "message": "libbrillo: Remove betuls from namespace owners\n\nBUG\u003dnone.\nTEST\u003dCq passes.\n\nChange-Id: I2c0c0bf94c0661777d55b04cf46b8241d0805e96\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/6005430\nReviewed-by: Jorge Lucangeli Obes \u003cjorgelo@chromium.org\u003e\nReviewed-by: John Admanski \u003cjadmanski@chromium.org\u003e\nTested-by: Betul Soysal \u003cbetuls@google.com\u003e\nCommit-Queue: Betul Soysal \u003cbetuls@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a85d59c0d633b8d82d575c5e28fe1ed44349258d\n" }, { "commit": "06b1a1eeab7dba509b6115e5a8db52873bc57c95", "tree": "6d444001ec8f4fdcdf0e8c91d7f0cc7969f0e460", "parents": [ "314d43471eea854bfeebbf0c8e74c1e13fe7aa77" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Thu Oct 17 22:08:32 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Oct 28 17:09:07 2024" }, "message": "libbrillo: IncludeBraces LSC\n\nThis removes the IncludeBraces workaround from .clang-tidy in this\nproject, and runs `cros format` to bring files in line with\nChromium\u0027s new style.\n\nFor more information on this LSC, see go/cros-insert-braces-lsc.\n\nTo reproduce _just_ this CL, inside of the chroot, run:\n $ ${toolchain_utils}/py/bin/llvm_tools/insert_braces.py \\\n --start-project\u003dlibbrillo \\\n -n 1 \\\n --platform2-commit\u003d97a4f98645710e007b3897c8b091fddc93a647be\n\nTo reproduce the stack this was a part of, you can run the same\ncommand, but with `--start-project` set to heartd/ and\n-n set to 15.\n\nBUG\u003db:370478040\nTEST\u003dCQ\n\nChange-Id: I553820d8765f89fb9566c0716ba7a98692b55069\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5940110\nOwners-Override: James Hawkins \u003cjhawkins@chromium.org\u003e\nCommit-Queue: James Hawkins \u003cjhawkins@chromium.org\u003e\nTested-by: James Hawkins \u003cjhawkins@chromium.org\u003e\nReviewed-by: James Hawkins \u003cjhawkins@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fc2a7599e58d05f9f5d6dc3229dcad70bb7b4b13\n" }, { "commit": "314d43471eea854bfeebbf0c8e74c1e13fe7aa77", "tree": "0d1af927f7055205a07b8f10c66c32290ee73895", "parents": [ "b560aeea64ff6e2923c6ef4c2109cfa2df4a8e95" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Wed Sep 18 21:25:16 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 15 13:28:42 2024" }, "message": "step 1 of adding `InsertBraces: true` to global clang-format\n\nThis is phase one of a large-scale change. Please see the corresponding\nLSC documentation for more information: go/cros-insert-braces-lsc\n\nBUG\u003db:319265940, b:370478040\nTEST\u003dafter running `cros format` before this change, running\nTEST\u003d`cros format` again with this CL produces no diff.\n\nChange-Id: I41f786fa3518893f571100543ebe2ab2fabb585f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5874280\nCommit-Queue: George Burgess \u003cgbiv@chromium.org\u003e\nOwners-Override: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: George Burgess \u003cgbiv@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8331610aca70da9cfbbf7ddefe61e7272419ee33\n" }, { "commit": "b560aeea64ff6e2923c6ef4c2109cfa2df4a8e95", "tree": "3c97630671adb511551b965d6eda8349dbf8115e", "parents": [ "dfa7719392fa6f09dbb8599033b07714ed6572d5" ], "author": { "name": "Jason Jeremy Iman", "email": "jasongustaman@google.com", "time": "Thu Oct 10 04:55:24 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 11 11:45:48 2024" }, "message": "libbrillo: Avoid crashing when variants data is unset\n\nWhen a D-Bus message with variants data type is sent with null value,\nthe handling process crashes. This happens because of invalid memory\naccess when trying to check for the variants actual data type.\n\nThis patch disables the variant data type getter.\n\nBUG\u003db:372580011\nTEST\u003dCQ\n\nChange-Id: Ib16a6240d35fba3ef81ac35d39a1ec873674367c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5922154\nCommit-Queue: Jason Iman \u003cjasongustaman@chromium.org\u003e\nTested-by: Jason Iman \u003cjasongustaman@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f174dad3bcab4ae4d834887c087e30224ac75ab3\n" }, { "commit": "dfa7719392fa6f09dbb8599033b07714ed6572d5", "tree": "c55fbe309bfc68e81e3518dd20f912397e10ef98", "parents": [ "77054abc7b82d839c76c303d4b20e93fd54b2068" ], "author": { "name": "Jeff Lin", "email": "jeffulin@google.com", "time": "Thu Sep 26 09:31:03 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 09 13:04:46 2024" }, "message": "Apply attributes on functions\u0027 declarations\n\nThis CL places attributes to functions\u0027 declarations to prevent GCC\ninterprets attributes like [[gnu::format(...)]] as attributes on the\nfunctions\u0027 types. [[gnu::format(...)]] is being introduced by\nCL:5851576, which is included by libchrome uprev r1359642 (CL:5890188).\n\nBUG\u003dNone\nTEST\u003dFEATURES\u003d\"test\" emerge-nissa libbrillo device_management cryptohome\nTEST\u003dCQ\n\nDisallow-Recycled-Builds: test-failures\nChange-Id: I73e60faf290de7186b48769cce943e0285b937bb\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5891204\nReviewed-by: Md Sadman Sakib \u003csadmansakib@google.com\u003e\nCommit-Queue: Brett Brotherton \u003cbbrotherton@google.com\u003e\nReviewed-by: Betul Soysal \u003cbetuls@google.com\u003e\nTested-by: Cici Ruan \u003ccuicuiruan@google.com\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Yi Chou \u003cyich@google.com\u003e\nReviewed-by: John L Chen \u003czuan@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0a8d0a57e523fc15df8bc93a683b64611b037770\n" }, { "commit": "77054abc7b82d839c76c303d4b20e93fd54b2068", "tree": "9da157c6550c239c14d58ec246ad6af9382121d9", "parents": [ "85bb4e00597ee6ba2d191ef3ab9b1d97b20bc265" ], "author": { "name": "Igor", "email": "igorcov@chromium.org", "time": "Tue Sep 10 14:07:45 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 17 13:53:34 2024" }, "message": "libbrillo: Avoid deleting policy files when policy key fails to load\n\nIf for some reason the policy key fails to load, previously we were\ndeleting the device policy files from disk. With this change we will\ngive the device another chance after reboot. If reboot succeeds the\ndevice policy files will be used. If it fails, they will go through\nvalidation after enrollment recovery when the new key is persisted.\n\nBUG\u003db:231677312\nTEST\u003dUnit tests\n\nChange-Id: I43ff3b207202dcc176c0aece154075309b3c08de\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5850974\nTested-by: Igor \u003cigorcov@chromium.org\u003e\nReviewed-by: Victor Gabriel Savu \u003cvsavu@google.com\u003e\nCommit-Queue: Igor \u003cigorcov@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a111204c686441a1fed7d4491a572ef1a2c744a8\n" }, { "commit": "85bb4e00597ee6ba2d191ef3ab9b1d97b20bc265", "tree": "67e69393a0f1f725980c92977e2915903dfa79aa", "parents": [ "ddceaf97fbafa468a3d04027dc715eac4726896f" ], "author": { "name": "Ren-Pei Zeng", "email": "kamesan@google.com", "time": "Mon Sep 16 11:14:27 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 16 15:26:25 2024" }, "message": "libbrillo: Use base::StringPrintf with constexpr format string\n\nhttps://crrev.com/c/5855070 will disallow non-constexpr format.\n\nBUG\u003db:367200458\nTEST\u003dCQ\n\nChange-Id: I89c2b9418dcb7dbac53b8f4eb23d0439dfb3db8b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5865449\nTested-by: Ren-Pei Zeng \u003ckamesan@chromium.org\u003e\nCommit-Queue: Ren-Pei Zeng \u003ckamesan@chromium.org\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 61c48d60724b695b511e8d5122f18b4ffb2a4f5e\n" }, { "commit": "ddceaf97fbafa468a3d04027dc715eac4726896f", "tree": "242cb72a36aa6fbb33e1b4f73a2e268f609906a1", "parents": [ "9738b487df0a0097dd6af8f6008bacd5e8b54bad" ], "author": { "name": "Nathan Muggli", "email": "nmuggli@google.com", "time": "Wed Aug 28 21:06:38 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 30 04:37:20 2024" }, "message": "libbrillo: Migrate away from deprecated base::WriteFile\n\nThe three-arg WriteFile method is being deprecated. Move away from this\nso libchrome can get upreved.\n\nAlso applied some `cros format` changes.\n\nBUG\u003db:361493046\nTEST\u003dFEATURES\u003dtest emerge libbrillo\n\nChange-Id: I902fb66ee5f32d426d389e645bf9f3f6393e6ed6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5824376\nTested-by: Nathan Muggli \u003cnmuggli@google.com\u003e\nCommit-Queue: Nathan Muggli \u003cnmuggli@google.com\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bbbbcc41e2fd25b33fe415d436c127884002e821\n" }, { "commit": "9738b487df0a0097dd6af8f6008bacd5e8b54bad", "tree": "7896b7f4002c653f699cda8a47d6b26672211ecb", "parents": [ "6b37bf75d5b60a789c919794622a4f30bdd238cb" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Wed Aug 28 02:47:17 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 28 06:49:43 2024" }, "message": "libbrillo: Remove buggy and unused function MurmurHash3_x64_128\n\nBUG\u003db:332184363\nTEST\u003dCQ\n\nChange-Id: I7e8c152947560cab657c87a4f013b27eb1d9f582\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5820791\nCommit-Queue: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nAuto-Submit: Georg Neis \u003cneis@chromium.org\u003e\nTested-by: Georg Neis \u003cneis@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ada343274b0cbd3c70669ef5b607c2c4d3af4508\n" }, { "commit": "6b37bf75d5b60a789c919794622a4f30bdd238cb", "tree": "3284dded68efe04374adc9a1450d2a174d1dff37", "parents": [ "a65fd7f7e2e6f761d530172dc813b57321a8174c" ], "author": { "name": "Byron Lee", "email": "byronlee@google.com", "time": "Fri Aug 09 10:41:00 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 12 03:11:09 2024" }, "message": "Replace NOTREACHED w/ NOTREACHED_IN_MIGRATION\n\n.. as NOTREACHED is now fatal.\n\nLSC doc: http://goto.google.com/cros-fatal-notreached\n\nRun script: for f in $(ag -l \"NOTREACHED()\"); do sed -i \\\n \u0027s/NOTREACHED()/NOTREACHED_IN_MIGRATION()/g\u0027 $f; done\n\nBUG\u003db:356312475\nTEST\u003dCQ + builders\n\nChange-Id: I17f3c88eaee3199484a371f8301ffeb07eb9e0dd\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5750481\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nOwners-Override: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Byron Lee \u003cbyronlee@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Byron Lee \u003cbyronlee@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e67d58d688edfa1c811f1620ec5460f15c7937da\n" }, { "commit": "a65fd7f7e2e6f761d530172dc813b57321a8174c", "tree": "72eceb5520a0f3ad84496a37bc42c479ca64c8d1", "parents": [ "d098844f9de5830ceb4ed987014cd8a5dc005a8b" ], "author": { "name": "Ryo Hashimoto", "email": "hashimoto@chromium.org", "time": "Tue Jul 23 10:58:32 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 24 02:24:19 2024" }, "message": "libbrillo: Stop using base::SupportsWeakPtr in ExportedObjectManager\n\nbase::SupportsWeakPtr is being removed.\n\nBUG\u003db:352788923\nTEST\u003dCQ\n\nChange-Id: I0a4c168bd5bb1d4b5184a24938c6d00fb47349b9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5733974\nTested-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fd16fbcf0cee5b15545b5839c897210d54d396a6\n" }, { "commit": "d098844f9de5830ceb4ed987014cd8a5dc005a8b", "tree": "319693d408a48f6cd8e33235e7f11ff1a14d4c40", "parents": [ "7d34a84493da6adaa80340133003ec8462a505fd" ], "author": { "name": "Ryo Hashimoto", "email": "hashimoto@chromium.org", "time": "Tue Jul 23 03:04:17 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 24 02:22:28 2024" }, "message": "libbrillo: Stop using base::SupportsWeakPtr in UsbDevice\n\nBUG\u003db:352788923\nTEST\u003dCQ\n\nChange-Id: I5eaa539853e04d6d3054a3e30fa42839c60cc8bd\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5733214\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nTested-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 27785ede1206e849e35c31f9a807c13ef22b1b87\n" }, { "commit": "7d34a84493da6adaa80340133003ec8462a505fd", "tree": "20923687dc63e1744e8d404b0778fc61203552fb", "parents": [ "172cbe12693cc56534dec2b83c524d67df8461b2" ], "author": { "name": "Ryo Hashimoto", "email": "hashimoto@chromium.org", "time": "Mon Jul 22 09:29:16 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 23 06:40:25 2024" }, "message": "libbrillo: Stop using base::SupportsWeakPtr\n\nbase::SupportsWeakPtr is being removed.\n\nBUG\u003db:352788923\nTEST\u003dCQ\n\nChange-Id: I1e744d80f85c17050b6eb2d95a5f0e21788614f6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5725616\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 46f1bba21a1c1033ee3c06b939cd9d88466bc98f\n" }, { "commit": "172cbe12693cc56534dec2b83c524d67df8461b2", "tree": "32a1563cb3dfcd86fa11a4b10c09e636f334d299", "parents": [ "bbc0112c5ab4a372a765b8da59bb69564e61ba16" ], "author": { "name": "Satoru Takabayashi", "email": "satorux@chromium.org", "time": "Thu Jul 04 02:06:05 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 05 03:47:05 2024" }, "message": "libbrillo: Prevent the loss of large log messages\n\nsyslog() loses large log messages [1] which makes debugging\nsometimes difficult (ex. when you want to log the content of\na file for debugging). Truncate the message to ~8K [2] to\nprevent it from happening.\n\n[1] syslog() internally writes to /dev/log unix domain socket\nwith the buffer size of 208KiB on jacuzzi.\n[2] This roughly matches the truncation behavior of rsyslogd.\n\nBUG\u003db:351047463\nTEST\u003dcros_sdk FEATURES\u003dtest emerge-hatch libbrillo\n\nChange-Id: I11d2b7bf788c49d97242fd6c9052b152197a204c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5677690\nTested-by: Satoru Takabayashi \u003csatorux@chromium.org\u003e\nCommit-Queue: Satoru Takabayashi \u003csatorux@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a6a1f66430c1e2349b54ca97ffe33d51a776c538\n" }, { "commit": "bbc0112c5ab4a372a765b8da59bb69564e61ba16", "tree": "1f07b93ca38b906339747fabd152af2c6c676031", "parents": [ "d59d46461ac1cc22b9f7f43dc304a58b9560fe37" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Fri Jun 21 05:00:47 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 03 04:03:12 2024" }, "message": "Migrate to span-based overload of base::ReadFromFD, part 1\n\nThe one taking char* and size_t will be removed, see\nhttps://chromium-review.googlesource.com/c/chromium/src/+/5604926.\n\nBUG\u003db:348072164\nTEST\u003dcq\n\nChange-Id: I34f44e9c7acf70e1ec4b97205cbd049b1bbacea9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5647249\nAuto-Submit: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Georg Neis \u003cneis@chromium.org\u003e\nTested-by: Georg Neis \u003cneis@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c71115c0aafd036e3400aabba6014e0d72c7f239\n" }, { "commit": "d59d46461ac1cc22b9f7f43dc304a58b9560fe37", "tree": "43a01f218bca040277e20ef4d02c897179b10295", "parents": [ "17f9b845a9aa93c27f1b75f1b53e292256217f68" ], "author": { "name": "Owners Cleanup", "email": "swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com", "time": "Sun Jun 09 17:14:30 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 20 17:27:48 2024" }, "message": "Remove pmarko@chromium.org from libbrillo/brillo/grpc/OWNERS\n\nThis suggested change is automatically generated based on group\nmemberships and affiliations.\nIf this change is unnecessary or in error, vote the lowest CR value\n(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to\napprove this change. You may also abandon this change.\n\nSee the owner\u0027s recent activity for context:\nhttps://chromium-review.googlesource.com/q/pmarko@chromium.org\n\nTo report an issue, file a bug in the Infra\u003eCodereview component.\n\nChange-Id: I5b976e4ab6681da484199ed8ea8c33b8d3428360\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5611799\nAuto-Submit: Owners Cleanup \u003cswarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com\u003e\nReviewed-by: Maksim Ivanov \u003cemaxx@chromium.org\u003e\nTested-by: Maksim Ivanov \u003cemaxx@chromium.org\u003e\nCommit-Queue: Maksim Ivanov \u003cemaxx@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 42f5a9c765f47a5624d63d3f1e687a890d3c49e6\n" }, { "commit": "17f9b845a9aa93c27f1b75f1b53e292256217f68", "tree": "3a361ceb5bf09768767edae19633d2ca1d4465fd", "parents": [ "3b99da26675fe7b6e6a7ddf585fef20e2f90f6dd" ], "author": { "name": "Alexis Savery", "email": "asavery@google.com", "time": "Wed May 15 07:39:57 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 19 04:15:45 2024" }, "message": "libbrillo: Add userdb methods to get users and groups\n\nAdd functions to get vector of uids and vector of gids present\non the device.\n\nThese APIs are used in this spaced CL:\nhttps://chromium-review.googlesource.com/c/chromiumos/platform2/+/5569529\n\nBUG\u003db:338092935\nTEST\u003ddbus-send --system --print-reply --dest\u003dorg.chromium.Spaced\n /org/chromium/Spaced org.chromium.Spaced.GetQuotaOverallUsagePrettyPrint\n string:\"/mnt/stateful_partition/\"\n\nChange-Id: Ibf8dc34fa9e37b31fd0564c1dd0f3ff70baa2209\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5541733\nCommit-Queue: Alexis Savery \u003casavery@chromium.org\u003e\nTested-by: Alexis Savery \u003casavery@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c9cef8dda198197e2a910de1b081d8ed14b00592\n" }, { "commit": "3b99da26675fe7b6e6a7ddf585fef20e2f90f6dd", "tree": "1c0e44e04479c6ffa557d0d111488123d32f6d3a", "parents": [ "6d3566a272a0023054aa73c1b9d23bc38f7c8844" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Thu May 09 03:46:45 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 11 11:40:12 2024" }, "message": "chromeos-dbus-binding: Implement adapter method generation.\n\nThis CL introduces the new adapter method generation.\nCurrently, all message handling is done in some complex callback stack,\nso it was difficult to find, e.g., what method is failing if\nread argument is something unexpected.\n\nWith this change, we expect the method name will be appeard\nin the stack trace on crashing.\n\nNote: there seems some issue (UB) on generated code, but because of\nthe bot dependency issue, it looks like difficult to run UB-san\nwithout landing the change. To break the circular dependency,\nthis CL lands the feature to generate the code, but guarded\nunder the flag.\n\nBUG\u003db/289932268\nTEST\u003dTryjob\n\nChange-Id: I49b15e0ad2a1be34774a0acf1839151fb74bc623\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5584441\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Grace Cham \u003chscham@chromium.org\u003e\nTested-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 67db3a3877f0736e9afa28b42d2f5937d343c815\n" }, { "commit": "6d3566a272a0023054aa73c1b9d23bc38f7c8844", "tree": "99f878b47bfebf735999a4eab83b287e812fbdd2", "parents": [ "c5691e4348dc1dbbf00467f3f41621c83ae40dfd" ], "author": { "name": "Owners Cleanup", "email": "swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com", "time": "Sun Jun 09 17:14:40 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 10 16:06:29 2024" }, "message": "Remove pmarko@chromium.org from libbrillo/policy/OWNERS\n\nThis suggested change is automatically generated based on group\nmemberships and affiliations.\nIf this change is unnecessary or in error, vote the lowest CR value\n(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to\napprove this change. You may also abandon this change.\n\nSee the owner\u0027s recent activity for context:\nhttps://chromium-review.googlesource.com/q/pmarko@chromium.org\n\nTo report an issue, file a bug in the Infra\u003eCodereview component.\n\nChange-Id: Id427545fbe03c366c1cb44098c73743082596218\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5610995\nTested-by: Igor \u003cigorcov@chromium.org\u003e\nReviewed-by: Igor \u003cigorcov@chromium.org\u003e\nAuto-Submit: Owners Cleanup \u003cswarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com\u003e\nCommit-Queue: Igor \u003cigorcov@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 776f570810f92080556bfc31cd176a8a02974111\n" }, { "commit": "c5691e4348dc1dbbf00467f3f41621c83ae40dfd", "tree": "72ecb2aad8ee3bb79df2ab07438285899201bf81", "parents": [ "e74ddba5af8243dd2d272988fa2679f9e49661f9" ], "author": { "name": "Jeroen Dhollander", "email": "jeroendh@google.com", "time": "Thu Jun 06 11:33:22 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 10 16:06:23 2024" }, "message": "Remove Arc Kiosk\n\nARC kiosk support is being removed since the last device that supported\nit went EOL.\n\nBug: 336756417\nChange-Id: Ia2780e4e78551fba74eb3aaa9ab2760f17a2b757\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5600885\nReviewed-by: Leonid Baraz \u003clbaraz@chromium.org\u003e\nReviewed-by: Ryan Borzello \u003crborzello@google.com\u003e\nCommit-Queue: Jeroen Dhollander \u003cjeroendh@google.com\u003e\nTested-by: Jeroen Dhollander \u003cjeroendh@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: eb3492c4a77f6701e03d2a7f6c34d61597293325\n" }, { "commit": "e74ddba5af8243dd2d272988fa2679f9e49661f9", "tree": "d9c5e37d850d589c7f1bee68d235913a0611004d", "parents": [ "ab8d9a1e15c2db187fd775e3ae1fa93e897a4e02" ], "author": { "name": "Damien Dejean", "email": "damiendejean@google.com", "time": "Fri Mar 29 10:18:16 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 22 03:24:21 2024" }, "message": "patchpanel: add brillo-http PrepareTagSocket API\n\nAdd a PrepareTagSocket() call to request the application of a traffic\nannotation to a socket owned by a libbrillo-http Transport. A callback\nis registered to the Transport, it will be called when the socket is\ncreated but before the first connection. Then a TagSocket call is done\nto apply the socket annotation.\n\nAs a synchronous TagSocket call may cause a deadlock between the caller and\nthe callee, it is asynchronous for now. It may lead to a situation where\nthe socket start being used before the TagSocket call is processed. It\nwill be addressed in a subsequent CL.\n\nBUG\u003db:331620358\nTEST\u003dFEATURES\u003d\"test\" emerge-$BOARD patchpanel patchpanel-client\n\nChange-Id: Idcb79c0ed6b1956342bf4582de8dbead412aa0eb\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5407696\nCommit-Queue: Damien Dejean \u003cdamiendejean@google.com\u003e\nTested-by: Damien Dejean \u003cdamiendejean@google.com\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nReviewed-by: Cassie Wang \u003ccassiewang@google.com\u003e\nReviewed-by: Hugo Benichi \u003chugobenichi@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 586820cc64aaa14900ea2092a206ccff5becea1b\n" }, { "commit": "ab8d9a1e15c2db187fd775e3ae1fa93e897a4e02", "tree": "ea5da8cc5fce842b587ffec813532550a9d52d34", "parents": [ "6c8360b8b95a0e990bc278c569110dd31e958690" ], "author": { "name": "Wei-Luan Wang", "email": "weiluanwang@google.com", "time": "Tue May 21 09:19:13 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 22 02:08:10 2024" }, "message": "libbrillo: Update argument of base::RandBytes\n\nSince the pointer version is deprecated, update to use the span version\ninstead.\n\nBUG\u003db:340376465\nTEST\u003dFEATURES\u003dtest emerge-volteer libbrillo\n\nChange-Id: I2f25b45d6fd99f4cc624f89c4752b4c1c6a5bf18\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5552937\nCommit-Queue: Wei-Luan Wang \u003cweiluanwang@google.com\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nTested-by: Wei-Luan Wang \u003cweiluanwang@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f5b7a1a316feab90c41933eb58fdfbe998e52068\n" }, { "commit": "6c8360b8b95a0e990bc278c569110dd31e958690", "tree": "47b97d30c1534818c65bca126edea79a677ece28", "parents": [ "7a730fa76630f0e3103adfb8d7821243ada5fd2e" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Wed May 15 11:55:20 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 21 11:51:49 2024" }, "message": "libbrillo: Remove IsEnterpriseManaged\n\nWe had two functions to check if a device is enrolled:\nIsEnterpriseManaged (using policy file) and IsEnterpriseEnrolled (using\ninstall attributes). Remove IsEnterpriseManaged because checking install\nattributes is preferred.\n\nSimplify device policy tests by unifying some setup code.\n\nBUG\u003db:340424959\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic libbrillo\n\nChange-Id: I052b1525f5c4e8285a09d87f154973c25386e27f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5538276\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nCommit-Queue: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Igor \u003cigorcov@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 75ec59c2abab795b457ed1521219c98ce25df1ba\n" }, { "commit": "7a730fa76630f0e3103adfb8d7821243ada5fd2e", "tree": "48dc4bcff1277649fe405fa008af5aecbc6046b5", "parents": [ "e86248edb25ebae49bde5155266f5cbb18ce4ccd" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Wed May 15 11:50:51 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 17 15:55:02 2024" }, "message": "libbrillo: optional for USB allowlist\n\nUse optional instead of ptr return style for the function that reads USB\nallowlist policy.\n\nWhile at it, rename that function be called allowlist instead of\nwhitelist. The policy has been renamed a while ago.\n\nBUG\u003db:184745765\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic libbrillo permission_broker\n\nChange-Id: I37f4687cacaec8b24bdcc19cf3843291050583d6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5538275\nCommit-Queue: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nReviewed-by: Victor Gabriel Savu \u003cvsavu@google.com\u003e\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e9684639eb1917ba8216a2ba833005b6c86d0040\n" }, { "commit": "e86248edb25ebae49bde5155266f5cbb18ce4ccd", "tree": "47bbd9a44a2623b23da066b4df8986e8cbd635b9", "parents": [ "4e5e8bca4d17488dafd98faf20fab231799d36bf" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Wed May 15 12:08:12 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 17 15:26:52 2024" }, "message": "libpolicy: Optional return for api id policy\n\nUse optional values instead of a pointer to return the value of the\napi id policy.\u0013\n\nBUG\u003db:184745765\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic libbrillo u2fd\n\nChange-Id: Id51cfb530c1ab17e6550f1a64407602c5ccf9809\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5537960\nCommit-Queue: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Yi Chou \u003cyich@google.com\u003e\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Victor Gabriel Savu \u003cvsavu@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 55a13132259dadc7208205349729cec5256fa590\n" }, { "commit": "4e5e8bca4d17488dafd98faf20fab231799d36bf", "tree": "225de8edaf0925310e1ea5bdcb952c829793c87a", "parents": [ "3711eeb0c27e58454948eaa37da71538159992e2" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Wed May 15 12:01:38 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 17 09:05:42 2024" }, "message": "libpolicy: Optional return for second factor auth\n\nUse optional values instead of a pointer to return the value of the\nsecond factor authentication policy.\n\nBUG\u003db:184745765\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic libbrillo u2fd\n\nChange-Id: Iafb8cf2d52e5d623098dfc2f8d658055ed01b608\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5538277\nCommit-Queue: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Igor \u003cigorcov@chromium.org\u003e\nReviewed-by: Yi Chou \u003cyich@google.com\u003e\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bf5c77bee82abfe2e3b7a51ac1871c3ec4a362e1\n" }, { "commit": "3711eeb0c27e58454948eaa37da71538159992e2", "tree": "2b43f378fc43d412a51c08557d5d854e420d93f5", "parents": [ "34289002e059d59764dc51a14f18bd5898d8faa0" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Tue May 14 06:08:50 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 17 05:49:30 2024" }, "message": "cryptohome: Use std::optional for ephemeral policy\n\nUse optional values instead of pointers to read the policy settings for\nephemeral users.\n\nBUG\u003db:184745765\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic libbrillo chromeos-base/cryptohome\n\nChange-Id: I044e19ff83eadea2bfa987a185ad2f729d962dbd\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5535333\nReviewed-by: Gwendal Grignou \u003cgwendal@chromium.org\u003e\nReviewed-by: Sergey Poromov \u003cporomov@chromium.org\u003e\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nCommit-Queue: Miriam Polzer \u003cmpolzer@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4d0ae2645c1b27f4a13791b06ce8f1086c02a7b6\n" }, { "commit": "34289002e059d59764dc51a14f18bd5898d8faa0", "tree": "0d25fe467eaccd3065a7699657906b6257d43e52", "parents": [ "6ca918940edf255b72b944d4a3c20825504929ec" ], "author": { "name": "Byron Lee", "email": "byronlee@google.com", "time": "Tue May 14 09:48:05 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 15 00:57:15 2024" }, "message": "libbrillo: Update argument of base::RandBytes\n\nSince the pointer version is deprecated, update to use the span version\ninstead.\n\nBUG\u003db:340376465\nTEST\u003dFEATURES\u003dtest emerge-volteer libbrillo\n\nChange-Id: I2155fce758a1378068cd74ed302f7572f3f4de4c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5535873\nTested-by: Byron Lee \u003cbyronlee@chromium.org\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nCommit-Queue: Byron Lee \u003cbyronlee@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9cbee710df1eb80b3a8964d6474983c54415f309\n" }, { "commit": "6ca918940edf255b72b944d4a3c20825504929ec", "tree": "0c91a53059094fd673bf88465870e47bd204fb67", "parents": [ "e0af6600e4e00c9f4649c3a64aee73484a364f54" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Thu May 09 04:08:36 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 09 14:08:37 2024" }, "message": "libbrillo: Introduce ToDBusError.\n\nGetDBusError looked a bit \"unnatural\", because it returned ErrorResponse,\ninstead of DBusError, for historical reasons. Also, it was not just\na simple getter, but a converting function with some complexity.\n\nThis CL introduces ToDBusError to resolve these points.\nGetDBusError is replaced by ToDBusError.\nAlso, CreateDBusErrorResponse does not play any critical roll,\nErrorResponse::FromMethodCall is just inlined together.\n\nBUG\u003db:338002690\nTEST\u003dTryjob\n\nChange-Id: I4ec16a42c717cec87f2d69eed098988bae56c3c7\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5527838\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nTested-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ad51a649ab486cd638bfa3ea6c8cb89af50a55d6\n" }, { "commit": "e0af6600e4e00c9f4649c3a64aee73484a364f54", "tree": "d52addc2ccdaeb4fa21db220aa1e8890d91c2aa6", "parents": [ "9c0547bf042923256640e80499e5d503b732a555" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Wed May 01 17:28:09 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 07 08:31:18 2024" }, "message": "brillo: Replace AppendValueToWriter and PopValueFromReader\n\nThey are replaced by WriteDBusArgs/ReadDBusArgs to prepare\nof reducing redundant overloads.\n\nBUG\u003db:289932268\nTEST\u003dTryjob\n\nChange-Id: I5c89b032cfcf248cd27c5834309cfb24b75d1bd2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5506133\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Jeff Lin \u003cjeffulin@google.com\u003e\nTested-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Yi Chou \u003cyich@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b4e8c3125566e70f46512595bbc3a8a2584459b6\n" }, { "commit": "9c0547bf042923256640e80499e5d503b732a555", "tree": "0de07c317fcc045da0b9dc86059194c3cd301260", "parents": [ "b1a7d8f3dd1751f8484ee854e5889923fe75a5e4" ], "author": { "name": "Gwendal Grignou", "email": "gwendal@chromium.org", "time": "Sat Apr 06 00:35:09 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 29 21:14:28 2024" }, "message": "libbrillo: blk_dev: Add info to error messages\n\nRemove duplicate error message when task name can not be set.\nAdd |name| to error message to better understand failures.\n\nBUG\u003db:333148074\nTEST\u003dtast run cryptohome.AutomaticCleanupManyUsers.20_users\n\nChange-Id: I4ad6513b1b669a0bcb9fc1275e4720cd879bf80f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5437057\nCommit-Queue: Gwendal Grignou \u003cgwendal@chromium.org\u003e\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nTested-by: Gwendal Grignou \u003cgwendal@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d5fe7e83c6db3d42b1f3269fecf06ed1540752b9\n" }, { "commit": "b1a7d8f3dd1751f8484ee854e5889923fe75a5e4", "tree": "4bdf83c6f94fde1ca5f85d579cb5a83df3bbc0a4", "parents": [ "aeeca1c747bc946882b08af881cadce2a0703e71" ], "author": { "name": "Dmitry Torokhov", "email": "dtor@chromium.org", "time": "Tue Apr 23 20:38:54 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 24 00:18:54 2024" }, "message": "libbrillo: grpc: remove timing checks from AsyncGrpcClientServerTest.RpcServerStartedAfter\n\nBecause we can not control the load of the device executing tests we can\nnot guarantee that the test will finish within the given time frame.\nInstead of simply increasing the timeout remove the check, and only\ntest that communication eventually succeeds.\n\nBUG\u003db:333412847\nTEST\u003dcros_run_unit_tests --board\u003dbrya --packages\u003dlibbrillo\n\nChange-Id: I6a4ca0efe746ee1a7869c44805af856ffe4396a6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5479867\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nCommit-Queue: Dmitry Torokhov \u003cdtor@chromium.org\u003e\nTested-by: Dmitry Torokhov \u003cdtor@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4f1c2fb894864bbfd6e97462840cbaaaec31c710\n" }, { "commit": "aeeca1c747bc946882b08af881cadce2a0703e71", "tree": "12f1bf03f6b6c1b7ba511b3eb1c7402d6a085007", "parents": [ "70fbb0a90add4d023ce0c9e8205ef3eb6e00018f" ], "author": { "name": "Oleh Lamzin", "email": "lamzin@google.com", "time": "Thu Apr 18 07:54:24 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 18 09:55:55 2024" }, "message": "Remove lamzin@ from libbrillo/grpc library\n\nRemove lamzin@ from libbrillo/grpc library due to switching\nto Android Auto org.\n\nChange-Id: I93e18ce78bf90ecd4bcb82d57ea906f9d67d115e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5463502\nAuto-Submit: Oleh Lamzin \u003clamzin@google.com\u003e\nTested-by: Oleh Lamzin \u003clamzin@google.com\u003e\nCommit-Queue: Maksim Ivanov \u003cemaxx@chromium.org\u003e\nCommit-Queue: Oleh Lamzin \u003clamzin@google.com\u003e\nReviewed-by: Maksim Ivanov \u003cemaxx@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2098ac9f8a4f7d9557e505c7cbf855794635ab96\n" }, { "commit": "70fbb0a90add4d023ce0c9e8205ef3eb6e00018f", "tree": "687e3499e6cd7c39475d61e01b2ee1b4cb2a66a7", "parents": [ "2e916191632da1f4c94c289efb2d78f4e8f12798" ], "author": { "name": "Damien Dejean", "email": "damiendejean@google.com", "time": "Mon Mar 25 15:27:28 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 17 19:56:10 2024" }, "message": "libbrillo: add sockopt function to transport.\n\nAdd the possibility for a Transport user to add a callback to set\noptions on a created socket. The callback is called after socket\ncreation but before connection.\n\nBUG\u003db:331620358\nTEST\u003dFEATURES\u003d\"test\" emerge-$BOARD chromeos-base/libbrillo\n\nChange-Id: Ie794dc7992a15f0c811787bad1bba73c8c7d5679\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5407694\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Damien Dejean \u003cdamiendejean@google.com\u003e\nReviewed-by: Hugo Benichi \u003chugobenichi@google.com\u003e\nCommit-Queue: Damien Dejean \u003cdamiendejean@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bf88c41a1e276581d33315065a388fe336a7f848\n" }, { "commit": "2e916191632da1f4c94c289efb2d78f4e8f12798", "tree": "e81de7fd30382155883ce1ecc62a7589efa552c5", "parents": [ "eed77a851979b914afc06bdf63ce08e8ec8d2f24" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Wed Apr 10 10:40:23 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 11 05:44:09 2024" }, "message": "libbrillo: cleans up dbus_signature by C++20\n\nNow std::to_array, std::remove_cvref_t and concept is available.\nCleans dbus_signature implementation by them.\n\nBUG\u003db:284979778\nTEST\u003dTryjob\n\nChange-Id: Id2d31daff4cef0f011faf8945bd0f8b14dd8ed1f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5442574\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5de1921707afe37c17ec98c33ea8291a626dbc86\n" }, { "commit": "eed77a851979b914afc06bdf63ce08e8ec8d2f24", "tree": "5dba5c249a63f580ba9eb0be6efb98f3816b3e6b", "parents": [ "e5957087d5dea98238c9c758545862b866f30317" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Mon Apr 08 16:50:16 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 10 07:49:08 2024" }, "message": "libbrillo: Remove D-Bus auto variant unwrapping from libbrillo.\n\nThe behavior is no longer used, which is verified by crash reports.\nRemove it for simplicity and better maintenance.\n\nBUG\u003db:289932268\nTEST\u003dTryjob.\n\nChange-Id: Id14984741f0eb38dc5249bbd1628d3772a967af1\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5435095\nTested-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0436250356508256d3994d20fb227a1cc5b8ce49\n" }, { "commit": "e5957087d5dea98238c9c758545862b866f30317", "tree": "43c98c1fd7d139eb0a3533cb4108f34252c0d978", "parents": [ "81aa8db8c26ff4b1271daecd6aa503a4f6e94e50" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Fri Mar 29 07:30:31 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 03 23:50:59 2024" }, "message": "Replace uses of base::ByteSwapToLE*\n\nThese functions are being removed from libchrome. Use functions from\nbase/numerics/byte_conversions.h instead.\n\nBUG\u003db:331327202\nTEST\u003dCQ\n\nChange-Id: I9daf45e93784d46763e129725cd233d0b0a82b1c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5401291\nTested-by: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Andrey Pronin \u003capronin@chromium.org\u003e\nReviewed-by: Vadim Sukhomlinov \u003csukhomlinov@google.com\u003e\nCommit-Queue: Georg Neis \u003cneis@chromium.org\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4808c9caac718ae46b282af4f1882817e86ba600\n" }, { "commit": "81aa8db8c26ff4b1271daecd6aa503a4f6e94e50", "tree": "6130264f015b11e295673800b399fcb730227811", "parents": [ "d9e0d06c57602c5a5ef75001080b4e6df5af71d2" ], "author": { "name": "Georg Neis", "email": "neis@chromium.org", "time": "Thu Mar 28 04:44:18 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 28 08:32:16 2024" }, "message": "libbrillo: Eliminate use of base::MakeFixedFlatMapNonConsteval\n\nDefine the domain prefix map using base::MakeFixedFlatMap by storing\nconst char* instead of std::string.\n\nbase::MakeFixedFlatMapNonConsteval will be removed from libchrome.\n\nBUG\u003db:319370736, b:330800300\nTEST\u003dUSE\u003dtest cros_sdk emerge-hatch libbrillo\n\nChange-Id: I09920a26c72d4cae6533d4ba78d317e49e8e2c36\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5404647\nReviewed-by: Victor Gabriel Savu \u003cvsavu@google.com\u003e\nCommit-Queue: Georg Neis \u003cneis@chromium.org\u003e\nTested-by: Georg Neis \u003cneis@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f882be4ff3e336c2189fa63ef0bc32dca6800679\n" }, { "commit": "d9e0d06c57602c5a5ef75001080b4e6df5af71d2", "tree": "f661f499202faa9aa95751203966ae8608cf7a3b", "parents": [ "fef382ec90fb7b4c19edc83dfffc52de0cd4459c" ], "author": { "name": "Chinglin Yu", "email": "chinglinyu@chromium.org", "time": "Thu Mar 21 08:17:51 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 22 04:23:14 2024" }, "message": "libbrillo: disable flaky unit test\n\nDisable TracingTest.RunLoopTracing as it\u0027s flaky.\n\nBUG\u003db:298303538\nTEST\u003dCQ dry run\n\nChange-Id: Ie62a8c306425d17f51558947f3dcefd6aac0550d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5385207\nTested-by: Chinglin Yu \u003cchinglinyu@chromium.org\u003e\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nCommit-Queue: Chinglin Yu \u003cchinglinyu@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e59d78f9d86ed3c48b8325f55b7260b46b059f50\n" }, { "commit": "fef382ec90fb7b4c19edc83dfffc52de0cd4459c", "tree": "2ed6a397d456c18546d34a5b6d5f8ffada713667", "parents": [ "4b8c1338b83753e3df89c6dcceb9549954cd7342" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Wed Feb 28 10:47:32 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 21 17:52:04 2024" }, "message": "metrics: Use std::optional for metrics enabled\n\nUse optional values instead of pointers to read the metrics enabled\nowner setting.\n\nAlso move the default of having metrics enabled true on enterprise\nmanaged devices into the device policy implementation.\n\nBUG\u003db:184745765\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic metrics\n\nChange-Id: I936cf83adec24f7594b731e51e7ff3191f3c6578\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5372708\nCommit-Queue: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 007fbdcd3f53e924190e9300211c4e780ff40e42\n" }, { "commit": "4b8c1338b83753e3df89c6dcceb9549954cd7342", "tree": "edf2a7258ed9d3c44b6f473f06d10b2c33c0b064", "parents": [ "b9d068936357a837bd9fde603f556cf215b4ecc5" ], "author": { "name": "Gwendal Grignou", "email": "gwendal@chromium.org", "time": "Tue Mar 19 00:22:28 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 19 00:43:03 2024" }, "message": "OWNERS: sarthak preferred address is @google.com\n\nPrevent invalid code owner config files errors by replacing\nsarthak @chromium.org address with @google.com address.\n\nBUG\u003dnone\nTEST\u003dmechnanical change:\nsed -i \u0027s/sarthakkukreti@chromium.org/sarthakkukreti@google.com/\u0027 \\\n$(find . -name OWNERS\\* -exec grep -l sarthakkukreti@chromium.org {} \\+)\n\nChange-Id: Ib5ebfa38b52f11c4ad9911e312f4403e79d8dd5f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5379543\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nTested-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nCommit-Queue: Gwendal Grignou \u003cgwendal@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8336ed6e45132d2ed9af509b6735e3047064d99f\n" }, { "commit": "b9d068936357a837bd9fde603f556cf215b4ecc5", "tree": "831fd1af514ade90a7d0e3fe73789446884e7949", "parents": [ "6b3ced72e39524391ff3632457f7d82075b57c50" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Thu Mar 14 14:11:07 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 15 08:12:04 2024" }, "message": "libbrillo: Remove unused policy reading functions\n\nRemove policy reading functions that are not needed anymore.\n\nBUG\u003db:184745765\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic libbrillo\n\nChange-Id: Ide26dbc0fc2e639a9af94da36e02d1dacff28b6a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5361073\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nCommit-Queue: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Igor \u003cigorcov@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2ec48b899ec1826d36bf277ebeb12bb27b75d7be\n" }, { "commit": "6b3ced72e39524391ff3632457f7d82075b57c50", "tree": "bf3656652a5dd14945754281e6d4a84e0731b77d", "parents": [ "e923de901ec7ede367279bafcd5986d6d4401a4e" ], "author": { "name": "Artyom Chen", "email": "artyomchen@google.com", "time": "Mon Mar 11 15:20:05 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 13 16:00:13 2024" }, "message": "libbrillo: Use algorithm from device policy for signature validation\n\nInstead of hardcoded SHA1_RSA, use the algorithm from\n|policy_data_signature_type| for a blob signature validation during\nthe device policy loading.\n\nThis change is a prerequisite to the migration of the policy stack to\nSHA256_RSA on the client.\n\nBUG\u003db:229722926\nTEST\u003dcros_run_unit_tests --board\u003d\u003cBOARD\u003e --packages libbrillo\nTEST\u003dran chromeos device policy tests\n\nChange-Id: I04a08daf6aae3f0607d44075a00c142256b1381a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5361653\nReviewed-by: Igor \u003cigorcov@chromium.org\u003e\nTested-by: Artyom Chen \u003cartyomchen@google.com\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Artyom Chen \u003cartyomchen@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f7a5c2e009ab93265c1ec770af33497ae0288cf4\n" }, { "commit": "e923de901ec7ede367279bafcd5986d6d4401a4e", "tree": "4c68f07169b568e8b277e1e11fbee3e7d86c55c7", "parents": [ "e081a9aa48d2f7030c0bafe9942dbd8182b577c0" ], "author": { "name": "Igor", "email": "igorcov@chromium.org", "time": "Tue Mar 12 10:02:20 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 12 18:56:04 2024" }, "message": "libbrillo: Add requirement for DMToken presence\n\nThe enrolled devices must have the DMToken present as part of\npolicy data. If that doesn\u0027t happen, the device policy file\nhas to be skipped and the parsing should move to the next.\n\nBUG\u003db:231677312\nTEST\u003dcros_run_unit_tests --board\u003d${BOARD} --packages libbrillo\n\nChange-Id: I4da66542913b3029cb8736ba4b2befbb01c1efbc\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5361560\nCommit-Queue: Igor \u003cigorcov@chromium.org\u003e\nReviewed-by: Roland Bock \u003crbock@google.com\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Igor \u003cigorcov@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 45138ca0535c8a7c7d2cbb8cb1f1b951d8c210b4\n" }, { "commit": "e081a9aa48d2f7030c0bafe9942dbd8182b577c0", "tree": "32c925901d0b56d79bc8e12b0fef5b56339631dc", "parents": [ "b8e5791ec0cb1c282ef67a09039c08bca98a58ca" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Mon Mar 11 10:33:46 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 11 16:43:45 2024" }, "message": "Revert \"metrics: Use std::optional for metrics enabled\"\n\nRevert submission 5355928\n\nReason for revert: bypassed CQ\n\nReverted changes: /q/submissionid:5355928\n\nChange-Id: I87b42fa38503d13f3d63d101cb609610d0d432ae\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5360377\nAuto-Submit: Miriam Polzer \u003cmpolzer@google.com\u003e\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nOwners-Override: Dennis Kempin \u003cdenniskempin@google.com\u003e\nCommit-Queue: Dennis Kempin \u003cdenniskempin@google.com\u003e\nReviewed-by: Dennis Kempin \u003cdenniskempin@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9209381da6b4f6e415615e9ec92e09f8ff79ba9e\n" }, { "commit": "b8e5791ec0cb1c282ef67a09039c08bca98a58ca", "tree": "b4a16ba82da511d60fad60b808ef5cc64a618cdc", "parents": [ "cbed2aa2b594a62ca9dd51b1d8d8f9bfa87a3407" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Mon Mar 11 10:33:46 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 11 16:30:18 2024" }, "message": "Revert \"libbrillo: Remove reading of guest mode policy\"\n\nRevert submission 5355928\n\nReason for revert: bypassed CQ\n\nReverted changes: /q/submissionid:5355928\n\nChange-Id: I66db48eed089278cecb9da3c7003c0ed27badde8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5360376\nReviewed-by: Roland Bock \u003crbock@google.com\u003e\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nAuto-Submit: Miriam Polzer \u003cmpolzer@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3cb54477e75538efbf17c9f176415885ca0a1968\n" }, { "commit": "cbed2aa2b594a62ca9dd51b1d8d8f9bfa87a3407", "tree": "45760f35f0fe73e884ed6373245a99bb6f61be4b", "parents": [ "0b0a098231ee95bbe4e575837b06acda0c2284ad" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Fri Mar 08 10:58:12 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 11 10:29:29 2024" }, "message": "libbrillo: Remove reading of guest mode policy\n\nThe policy is not read anywhere in the OS, that is handled by Chrome.\nRemove unused functions.\n\nBUG\u003db:184745765\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic libbrillo\n\nChange-Id: I656ac6b3592ef513a52ab3c93f33a54adad3aa52\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5355928\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Roland Bock \u003crbock@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 690f439b6c4c6f33c9f0279da3923a48b6a1632f\n" }, { "commit": "0b0a098231ee95bbe4e575837b06acda0c2284ad", "tree": "b4a16ba82da511d60fad60b808ef5cc64a618cdc", "parents": [ "feeb96c827ce7333c8f81daccfa853fe3b7e597e" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Wed Feb 28 10:47:32 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 11 10:29:24 2024" }, "message": "metrics: Use std::optional for metrics enabled\n\nUse optional values instead of pointers to read the metrics enabled\nowner setting.\n\nAlso move the default of having metrics enabled true on enterprise\nmanaged devices into the device policy implementation.\n\nBUG\u003db:184745765\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic metrics\n\nChange-Id: I1a07ce3a50a445115512c1dc3b2a0d21dd359a6c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5329248\nReviewed-by: Ian Barkley-Yeung \u003ciby@chromium.org\u003e\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 38c5ce3ef6466713fbae1f17dd24fe0a9e04491d\n" }, { "commit": "feeb96c827ce7333c8f81daccfa853fe3b7e597e", "tree": "32c925901d0b56d79bc8e12b0fef5b56339631dc", "parents": [ "4efbc379d408d83e1712114706e16b0d5f0a04cd" ], "author": { "name": "Andre Braga", "email": "andrebraga@google.com", "time": "Mon Dec 04 13:13:37 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 08 00:47:34 2024" }, "message": "libbrillo: Add helper to check lockdown mode\n\nKernel lockdown [1] is enabled on ChromeOS Flex as one of the\nrequirements for UEFI secure boot. However, features such as elogtool\nin cros_minidiag [2] won\u0027t work with lockdown enabled, causing crash\nreport and log spam.\n\nSo, we add a method to check what lockdown mode is enabled (if any),\nallowing one to turn off features that won\u0027t work with kernel lockdown,\nor exit cleanly rather than crash.\n\nNote, this change is possible because securityfs is now mounted as\nreadonly, see Cq-Depend.\n\n[1]: https://man7.org/linux/man-pages/man7/kernel_lockdown.7.html\n[2]:https://crsrc.org/o/src/platform2/diagnostics/cros_minidiag/main.cc;l\u003d65;drc\u003da28cf6e42a1bd00986d656876fdcd9c9888cb19d\n\nBUG\u003db:306222271\nTEST\u003dcros_sdk P2_TEST_FILTER\u003d\"KernelLockdownUtil*\" cros_run_unit_tests --board\u003dreven --packages libbrillo\n\nCq-Depend: chromium:5082410\nChange-Id: Ic459e52759e17bd0d34e7832ac0089a5018684b7\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5017982\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Andre Braga \u003candrebraga@google.com\u003e\nReviewed-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\nCommit-Queue: Andre Braga \u003candrebraga@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0235418ee1ad00523c59cb5c59de9f7a68e1dca9\n" }, { "commit": "4efbc379d408d83e1712114706e16b0d5f0a04cd", "tree": "d78627f2b288a63ef0676157cdcf4d15811d4941", "parents": [ "9b76c3c939ccd59f66589ac933d2b8c6f03330b9" ], "author": { "name": "Sarthak Kukreti", "email": "sarthakkukreti@google.com", "time": "Wed Mar 06 01:22:26 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 07 21:11:12 2024" }, "message": "Reland \"libbrillo: Simplify storage balloon\"\n\nThis relands commit d8f1ed6fd0676109acf7c1e926cf3c99afe77838\nReverted originally due to b:328091818\n\nThis patch includes the original w/ a few bugfixes:\n1) Use WriteFileDescriptor instead of WriteFile for sysfs nodes\n2) Fix rootdev invocation by adding |dev|\n3) Fix check in maitred for nullptr StorageBalloon.\n\nOriginal change\u0027s description:\n\u003e libbrillo: Simplify storage balloon\n\u003e\n\u003e Use ext4 reserved clusters for ballooning, since storage ballooning\n\u003e is only used on ext4 today.\n\u003e\n\u003e In turn, this reduces the metadata overhead to zero and allows\n\u003e immediate balloon inflation and deletion. Additionally, we can\n\u003e get rid of the xattr hack that was added with REQ_OP_PROVISION\n\u003e in mind since the new storage balloon works with provision\n\u003e enabled.\n\u003e\n\u003e BUG\u003db:311963710\n\u003e TEST\u003dunittests\n\u003e\n\u003e Change-Id: I1115d718faf7738d203923e28f58f7ec7e862013\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4875024\n\u003e Commit-Queue: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\n\u003e Reviewed-by: Daniil Lunev \u003cdlunev@chromium.org\u003e\n\u003e Tested-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\n\u003e Reviewed-by: Junichi Uekawa \u003cuekawa@chromium.org\u003e\n\nBUG\u003db:311963710\nTEST\u003dunittests\nTEST\u003dbuild borealis rootfs, deploy and test on device\nTEST\u003dcorrelate df values on host and guest\n\nChange-Id: I4f2822d52f00e2f79b653015ff2c226a8785df2c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5347157\nAuto-Submit: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nTested-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nCommit-Queue: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nReviewed-by: Junichi Uekawa \u003cuekawa@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ca979c75fb2b6bbaa452949bddd2c94a2f33a774\n" }, { "commit": "9b76c3c939ccd59f66589ac933d2b8c6f03330b9", "tree": "1b7bc19335325b3be459915394fb4b6ef24b77ce", "parents": [ "e11969d6a3c46b30d63196a143b372e203331565" ], "author": { "name": "Martin Faltesek", "email": "mfaltesek@google.com", "time": "Thu Mar 07 18:43:36 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 07 19:44:33 2024" }, "message": "Revert \"libbrillo: Add requirement for DMToken presence\"\n\nThis reverts commit 28ca41a3a09534a7035d8c40c35d30b216e5d699.\n\nReason for revert: Causes snapshot failures:\n\u001b[0;31m[ FAILED ] \u001b[mLibpolicyTest.DevicePolicyAllSetTest\n\u001b[0;31m[ FAILED ] \u001b[mLibpolicyTest.DevicePolicyWhitelistTest\n\u001b[0;31m[ FAILED ] \u001b[mLibpolicyTest.DevicePolicyNoneSetTest\n\nOriginal change\u0027s description:\n\u003e libbrillo: Add requirement for DMToken presence\n\u003e\n\u003e The enrolled devices must have the DMToken present as part of\n\u003e policy data. If that doesn\u0027t happen, the device policy file\n\u003e has to be skipped and the parsing should move to the next.\n\u003e\n\u003e BUG\u003db:231677312\n\u003e TEST\u003dcros_run_unit_tests --board\u003d${BOARD} --packages libbrillo\n\u003e\n\u003e Change-Id: Ida2d011e3ffc7e2b55148f1b24b223ebb688e031\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5349638\n\u003e Reviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\n\u003e Commit-Queue: Igor \u003cigorcov@chromium.org\u003e\n\u003e Tested-by: Igor \u003cigorcov@chromium.org\u003e\n\u003e Reviewed-by: Roland Bock \u003crbock@google.com\u003e\n\nBUG\u003db:231677312\n\nChange-Id: I6a15caf5641a46144642f182cfb90e6e971fa4f9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5354046\nCommit-Queue: Martin Faltesek \u003cmfaltesek@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nTested-by: Martin Faltesek \u003cmfaltesek@google.com\u003e\nAuto-Submit: Martin Faltesek \u003cmfaltesek@google.com\u003e\nOwners-Override: Martin Faltesek \u003cmfaltesek@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b1872fe7e7fa01bdb660edd16cf15646f9644503\n" }, { "commit": "e11969d6a3c46b30d63196a143b372e203331565", "tree": "d63bbd46873f7e3a3b8e5d9e25c72f7460ad2fab", "parents": [ "cb8a4a3eac5559c392782e29eac5fc0c72054d11" ], "author": { "name": "Igor", "email": "igorcov@chromium.org", "time": "Wed Mar 06 11:29:08 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 07 15:33:04 2024" }, "message": "libbrillo: Add requirement for DMToken presence\n\nThe enrolled devices must have the DMToken present as part of\npolicy data. If that doesn\u0027t happen, the device policy file\nhas to be skipped and the parsing should move to the next.\n\nBUG\u003db:231677312\nTEST\u003dcros_run_unit_tests --board\u003d${BOARD} --packages libbrillo\n\nChange-Id: Ida2d011e3ffc7e2b55148f1b24b223ebb688e031\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5349638\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCommit-Queue: Igor \u003cigorcov@chromium.org\u003e\nTested-by: Igor \u003cigorcov@chromium.org\u003e\nReviewed-by: Roland Bock \u003crbock@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 28ca41a3a09534a7035d8c40c35d30b216e5d699\n" }, { "commit": "cb8a4a3eac5559c392782e29eac5fc0c72054d11", "tree": "1b7bc19335325b3be459915394fb4b6ef24b77ce", "parents": [ "201b310ebfd1dd7aaf6e912cbba21baca3622219" ], "author": { "name": "Artyom Chen", "email": "artyomchen@google.com", "time": "Wed Feb 28 17:52:38 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 07 14:15:11 2024" }, "message": "libbrillo: Generate policy files directly in libpolicy tests\n\nCurrently to modify libpolicy tests, we have to regenerate .bin policy\nfiles and check them in to repository to accommodate new test cases.\n\nSet up, sign, encode and persist device policy blobs directly from\nthe tests.\nThis makes test setup clearer and more visible. This makes it easier to\nadd new test cases.\n\nBUG\u003db:166398868\nTEST\u003dcros_run_unit_tests --board\u003d\u003cBOARD\u003e --packages libbrillo\n\nChange-Id: If235198352a2de620dc2ccd97cb3d50359fff75a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5324913\nCommit-Queue: Artyom Chen \u003cartyomchen@google.com\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Artyom Chen \u003cartyomchen@google.com\u003e\nReviewed-by: Igor \u003cigorcov@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 52a0ff9a2322c8cfc26e69fde3f110e158c20ee6\n" }, { "commit": "201b310ebfd1dd7aaf6e912cbba21baca3622219", "tree": "5922913df0fb85dadc97860919f88561b08b0e55", "parents": [ "fa622c5c18dd205ca6f0412609d7aa2dfc245f16" ], "author": { "name": "Sarthak Kukreti", "email": "sarthakkukreti@google.com", "time": "Mon Mar 04 20:09:12 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 05 20:37:31 2024" }, "message": "Revert \"libbrillo: Simplify storage balloon\"\n\nThis reverts commit d8f1ed6fd0676109acf7c1e926cf3c99afe77838.\n\nReason for revert: breaks Borealis boot: b/328091818\n\nOriginal change\u0027s description:\n\u003e libbrillo: Simplify storage balloon\n\u003e\n\u003e Use ext4 reserved clusters for ballooning, since storage ballooning\n\u003e is only used on ext4 today.\n\u003e\n\u003e In turn, this reduces the metadata overhead to zero and allows\n\u003e immediate balloon inflation and deletion. Additionally, we can\n\u003e get rid of the xattr hack that was added with REQ_OP_PROVISION\n\u003e in mind since the new storage balloon works with provision\n\u003e enabled.\n\u003e\n\u003e BUG\u003db:311963710\n\u003e TEST\u003dunittests\n\u003e\n\u003e Change-Id: I1115d718faf7738d203923e28f58f7ec7e862013\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4875024\n\u003e Commit-Queue: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\n\u003e Reviewed-by: Daniil Lunev \u003cdlunev@chromium.org\u003e\n\u003e Tested-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\n\u003e Reviewed-by: Junichi Uekawa \u003cuekawa@chromium.org\u003e\n\nBUG\u003db:328091818\n\nChange-Id: I9d659f1fb0f837a614ae1a223e23a4b7d2190fd4\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5341061\nReviewed-by: Juston Li \u003cjustonli@google.com\u003e\nReviewed-by: Junichi Uekawa \u003cuekawa@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nTested-by: Juston Li \u003cjustonli@google.com\u003e\nTested-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nReviewed-by: Daniil Lunev \u003cdlunev@chromium.org\u003e\nCommit-Queue: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5bce37d8dd7045abb049a03f5e3bc642137e4204\n" }, { "commit": "fa622c5c18dd205ca6f0412609d7aa2dfc245f16", "tree": "b7fcb6de8e95fe790a4b541181bf188dac249572", "parents": [ "90bd3e329d2822cecf93418909a5614adac683c6" ], "author": { "name": "Sarthak Kukreti", "email": "sarthakkukreti@google.com", "time": "Mon Mar 04 20:08:27 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 05 20:37:21 2024" }, "message": "Revert \"libbrillo: Use WriteFileDescriptor for writing to sysfs inodes\"\n\nThis reverts commit efe15e3be9afde0c01605b3f05242e24bd4defb0.\n\nReason for revert: breaks Borealis boot: b/328091818\n\nOriginal change\u0027s description:\n\u003e libbrillo: Use WriteFileDescriptor for writing to sysfs inodes\n\u003e\n\u003e base::WriteFile uses O_CREAT which fails for existing files.\n\u003e Instead, switch to using WriteFileDescriptor.\n\u003e\n\u003e BUG\u003db:311963710\n\u003e TEST\u003dunittests\n\u003e\n\u003e Change-Id: I93282a0f8c43a8b67f46eeeca354f36ac727b7ba\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5324719\n\u003e Auto-Submit: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\n\u003e Commit-Queue: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\n\u003e Tested-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\n\u003e Reviewed-by: Daniil Lunev \u003cdlunev@chromium.org\u003e\n\nBUG\u003db:311963710\n\nChange-Id: I82af0196dda2e2ea8473360712c499340f52e5a6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5341271\nCommit-Queue: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nReviewed-by: Daniil Lunev \u003cdlunev@chromium.org\u003e\nTested-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nReviewed-by: Juston Li \u003cjustonli@google.com\u003e\nTested-by: Juston Li \u003cjustonli@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2f17e3bb6d423026c1e4a61fd028b188bb18d552\n" }, { "commit": "90bd3e329d2822cecf93418909a5614adac683c6", "tree": "e09d072493178429ea3769e300c75bb214688178", "parents": [ "69ed63d47d54bcd7b7ed0652ea1fb0231b4737e8" ], "author": { "name": "Allen Webb", "email": "allenwebb@google.com", "time": "Thu Feb 29 22:17:49 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 04 19:41:04 2024" }, "message": "libbrillo: SafeFD: do not trigger errors on success in DeletePath\n\nThis changes the implementation of DeletePath to avoid logging errors\nwhen nothing went wrong.\n\nBUG\u003db:321589731\nTEST\u003dFEATURES\u003dtest emerge-${BOARD} libbrillo\n\nChange-Id: I58339e236703415c9953ebbb96e3cacb7249b73f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5333233\nCommit-Queue: Allen Webb \u003callenwebb@google.com\u003e\nTested-by: Allen Webb \u003callenwebb@google.com\u003e\nReviewed-by: John Admanski \u003cjadmanski@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 17015b119ce4f4a17e68e12392f0517dc9b1105f\n" }, { "commit": "69ed63d47d54bcd7b7ed0652ea1fb0231b4737e8", "tree": "29a4dc31fc2e4212613c00438ae7cbe0eb4750ff", "parents": [ "7a1eb3d3a3ce77e08a17f362aa8db14d51fe0318" ], "author": { "name": "Allen Webb", "email": "allenwebb@google.com", "time": "Thu Feb 29 18:25:24 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 04 19:40:58 2024" }, "message": "libbrillo: SafeFD: provide SafeFD::Stat\n\nAdd SafeFD::Stat and refactor to use it where appropriate. It will be\nalso be used in the follow-up CL.\n\nBUG\u003db:321589731\nTEST\u003dFEATURES\u003dtest emerge-${BOARD} libbrillo\n\nChange-Id: I006c7d73175cde2bab2bdacf25ef473c928a8f60\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5333232\nReviewed-by: John Admanski \u003cjadmanski@chromium.org\u003e\nCommit-Queue: Allen Webb \u003callenwebb@google.com\u003e\nTested-by: Allen Webb \u003callenwebb@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ff33e83b53aa5c7a8a9fe24b53c60063fd3a5492\n" }, { "commit": "7a1eb3d3a3ce77e08a17f362aa8db14d51fe0318", "tree": "aeb0ffda20088956a71df3c88ef7c3b3c3615b61", "parents": [ "e0ec1b8b0ef2000077124cecf8f0517bb7b77764" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Tue Jan 16 14:24:27 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 29 15:12:04 2024" }, "message": "libbrillo: Ptr return to expected\n\nStart converting libpolicy from pointer and bool return values to using\nbase::expected.\n\nBUG\u003db:184745765\nTEST\u003dFEATURES\u003dtest emerge-amd64-generic libbrillo\n\nChange-Id: I4c258c3f4dfca36cf7749e77ace0e3d09379229e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5201405\nTested-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nCommit-Queue: Miriam Polzer \u003cmpolzer@google.com\u003e\nReviewed-by: Jeroen Dhollander \u003cjeroendh@google.com\u003e\nReviewed-by: Igor \u003cigorcov@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9cd7e7c2847d407e1c51557e4b1da5bdc5816d1c\n" }, { "commit": "e0ec1b8b0ef2000077124cecf8f0517bb7b77764", "tree": "1e7409676f98ddac5fd37d7a4087c05d31328d7e", "parents": [ "59ebbd0a5c5ba49a8795bd30907423fd94ce09cd" ], "author": { "name": "Thomas Cedeno", "email": "thomascedeno@google.com", "time": "Mon Feb 05 16:06:32 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 29 01:41:36 2024" }, "message": "cryptohome: Workaround I/O processes blocking when keys evicted\n\nWhen a dmcrypt device is suspended all IO to that block will\nindefinitely run, and threads won\u0027t respond to signals. On dmcrypt\ndevice shutdown, remap the device to an error target underneath and\nhave it return error IO to existing file descriptors.\n\nBUG\u003db:316374336\nTEST\u003dLog in through chrome, powerd_dbus_suspend, inspect system state\nthrough dmsetup table, and suspend/shutdown again.\n\nChange-Id: I3d906c5b932fc65a294b1d51cda23846bef3b8d6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5268723\nReviewed-by: Betul Soysal \u003cbetuls@google.com\u003e\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nReviewed-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nTested-by: Thomas Cedeno \u003cthomascedeno@google.com\u003e\nCommit-Queue: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nAuto-Submit: Thomas Cedeno \u003cthomascedeno@google.com\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f14169b65cabd2fea0af1decadcfc3eeb14bbad0\n" }, { "commit": "59ebbd0a5c5ba49a8795bd30907423fd94ce09cd", "tree": "881eb77e78c9edb5c2c2ba4c91cf3d1fca36bf66", "parents": [ "c8f565cd4a440b52027c9290bea246f4b0e0c3d4" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Feb 27 18:44:28 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 28 23:16:48 2024" }, "message": "libbrillo: drop cryptohome sublib in the SDK\n\nThis isn\u0027t used in the SDK, so drop it for now.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: If4949c34662842091f8f722f3cb5c53bf79b3437\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5327749\nReviewed-by: Sarthak Kukreti \u003csarthakkukreti@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5f923859eaae80527425ae271bc2c33a2fcf14df\n" }, { "commit": "c8f565cd4a440b52027c9290bea246f4b0e0c3d4", "tree": "4dd01b92ad072d8d734b0e09e569e16f11b85ef0", "parents": [ "7b782eca14df24f3a569a6618074bfbffa85a348" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Tue Feb 20 17:18:28 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 28 19:56:03 2024" }, "message": "Remove CallDBusMethod from brillo.\n\nThat method is inefficient/unsafe, so remove it.\nThe only caller is featured. Unfortunately, it is not trivial\nto get rid of the case now, and rather it will need to redesign\nthe featured APIs.\nSo, instead, this CL moves the logic into featured\u0027s internal\nimplementation with TODO to get rid of it eventually, so that\nno new usage will be expected.\n\nBUG\u003db:289932268\nTEST\u003dRun unittest locally. Tryjob.\n\nChange-Id: I2ddb22ee6c85637344a2db04a64964a7d4d91af4\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5310694\nTested-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Miriam Zimmerman \u003cmutexlox@chromium.org\u003e\nReviewed-by: Hugo Benichi \u003chugobenichi@google.com\u003e\nReviewed-by: Dmitry Torokhov \u003cdtor@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e704b93f3678d303c8dd278ff9d4c9b94e4c1c60\n" } ], "next": "7b782eca14df24f3a569a6618074bfbffa85a348" }