|author||Dmitry Torokhov <firstname.lastname@example.org>||Fri Jun 14 21:43:43 2019|
|committer||chrome-bot <email@example.com>||Fri Jun 21 09:26:03 2019|
system_api: add explicit error code for license issues for Plugin VM It is beneficial to know whether certain operations failed because of invalid license or other reasons. BUG=b:133521686 TEST=Build Change-Id: I763706e9fefd0a476d7d82808f556911937b7335 Reviewed-on: https://chromium-review.googlesource.com/1660886 Tested-by: Dmitry Torokhov <firstname.lastname@example.org> Commit-Ready: Dmitry Torokhov <email@example.com> Legacy-Commit-Queue: Commit Bot <firstname.lastname@example.org> Reviewed-by: Timothy Loh <email@example.com> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: b1c3be8c490ea9a3a84569282f43238e284b6d71
This directory (
platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.