|author||Anand K Mistry <email@example.com>||Tue Jun 18 05:48:51 2019|
|committer||Commit Bot <firstname.lastname@example.org>||Thu Jun 20 01:52:13 2019|
system_api: Add options to save and restore SMB share password. This CL allows Chrome to request that the share password be saved to or restored from the profile's daemon-store directory. BUG=chromium:891462 TEST=emerge-chell system_api smbprovider + unit tests Change-Id: I62b816d01f2a9b08f353c5d3f1a05d4473e390b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1663747 Reviewed-by: Sam McNally <email@example.com> Tested-by: Anand Mistry <firstname.lastname@example.org> Commit-Queue: Jason Clinton <email@example.com> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: e8b7a53e0cb2730b24e78ce4912fa0eb8be72c94
This directory (
platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.