| commit | de260c6e536290fdfa197c3c3ccba279af9a72a7 | [log] [tgz] |
|---|---|---|
| author | Jameson Thies <jthies@google.com> | Wed Feb 14 23:20:39 2024 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Feb 23 00:05:16 2024 |
| tree | 5fbef6dfc63037b5f561959b7b5416febb09dec4 | |
| parent | 238214f2c5e95570c2b663fae2c279ce73e67b33 [diff] |
system_api: Add required enums to system_api for typecd data requests
Add required enums to enable D-Bus data requests for typecd. USBCMode is
used to represent the current state of a single port and Recipient is
used by request methods to specify if the data request targets the port,
partner or cable.
BUG=b:241786017
TEST=FEATURES=test emerge-${BOARD} chromeos-base/system_api
Change-Id: Ic1507d5b993c531ea5b8e7a1553c63eb77ed36c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5298322
Tested-by: Jameson Thies <jthies@google.com>
Reviewed-by: Benson Leung <bleung@google.com>
Commit-Queue: Jameson Thies <jthies@google.com>
NOKEYCHECK=True
GitOrigin-RevId: 1ea2268afdfbfad046deb1405ff1a24369401fe4
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.