| commit | 08f07891239dd470ca2667279ac40d32e9b3af35 | [log] [tgz] |
|---|---|---|
| author | Emil Mikulic <easy@google.com> | Tue Jun 28 01:45:10 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Jul 01 08:25:03 2022 |
| tree | e2f65fb0b0a93822d74a83d66fe3eb864d4928de | |
| parent | ce42313bd903e58e82e51ed2e0a5676d22395629 [diff] |
system_api: add comments for port numbers Clarify that kGarconPort is what garcon connects to, not listens on. No functional change. BUG=b:231500896 TEST=CQ Change-Id: I31f2a3e13ddcd0809efa0e6613701abff815bf87 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3708621 Reviewed-by: Fergus Dall <sidereal@google.com> Tested-by: Emil Mikulic <easy@google.com> Commit-Queue: Emil Mikulic <easy@google.com> Auto-Submit: Emil Mikulic <easy@google.com> NOKEYCHECK=True GitOrigin-RevId: a69c4fc8d337500a10a21e7fe4b3d1826e58bd39
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.