| commit | 13944455f2056bcbe2a888974b40eeb7da52ed0c | [log] [tgz] |
|---|---|---|
| author | Howard Yang <hcyang@google.com> | Wed Jun 15 10:05:05 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Sun Jun 19 19:33:05 2022 |
| tree | 7d405c7dcef037663cd759a975e23f70f26b91cc | |
| parent | 10cb87978b6ee625e60e3d0dd981d262f2cc0e96 [diff] |
crosh: Add builtin_corpssh command Add a command in crosh to enable/disable built-in gnubby's CorpSSH support (by default it's disabled). This implemented by calling the existing debugd API SetU2fFlags, as corp_protocol is the u2f flag used for controlling this feature. BUG=b:232887460 TEST=manually test that the command works. Disallow-Recycled-Builds: test-failures Change-Id: I842a98025a7a6c293ddcd587c11182c84a46b604 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3707018 Tested-by: Howard Yang <hcyang@google.com> Commit-Queue: Howard Yang <hcyang@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Yi Chou <yich@google.com> NOKEYCHECK=True GitOrigin-RevId: cab6f13c654c24a5aa7ca48fd9442a22ef816622
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.