|author||Emil Mikulic <email@example.com>||Thu Jun 16 07:42:00 2022|
|committer||Copybara-Service <firstname.lastname@example.org>||Fri Jul 01 08:54:44 2022|
vm_tools: vm_cicerone: send sftp_port to ash. Ash needs to know the port number so it can tell cros-disks to mount sshfs using that port. BUG=b:231500896 TEST=CQ Change-Id: I50f1bb575302d0417d06ef036a9bd841a13939ad Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3708623 Reviewed-by: David Munro <email@example.com> Tested-by: Emil Mikulic <firstname.lastname@example.org> Commit-Queue: Emil Mikulic <email@example.com> NOKEYCHECK=True GitOrigin-RevId: 68cb45097035d9c5b9e08a99515b333f3f452a76
This directory (
platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.