| commit | 31c86e0f43ec422958c4838bae3b297c8e2c5394 | [log] [tgz] |
|---|---|---|
| author | Jie Jiang <jiejiang@chromium.org> | Wed Jul 08 10:00:16 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Jul 16 00:57:55 2020 |
| tree | 91bdf8d25cf55c1fa864941e0ebefb348b671c4f | |
| parent | b582eea93ac1554fc88f2fc443f68080c1921012 [diff] |
system_api: Add TrafficCountersRequest/Response in patchpanel Exposes a pair of request and response for traffic counters implemented in patchpanel (which is not implemented yet). BUG=b:160112867 TEST=emerge-$BOARD system_api Change-Id: I9a7adda1635d59cc842a7c5ad8b3c26d5b4cdad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2286978 Tested-by: Jie Jiang <jiejiang@chromium.org> Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by: Matthew Wang <matthewmwang@chromium.org> Reviewed-by: Garrick Evans <garrick@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 6c97a92b35a124b3987776a88495bced8e0fcbd9
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.