|author||Olya Kalitova <email@example.com>||Mon Jul 20 10:29:21 2020|
|committer||Commit Bot <firstname.lastname@example.org>||Wed Jul 29 09:40:26 2020|
system_api: generate Plugin VM service Go proto binding Generates Go proto bindings for Plugin VM service to be used in Tast tests. BUG=chromium:1107876 TEST=build Change-Id: I25711be5411a56c84796c5bf28363656c9c412ee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2310169 Reviewed-by: Mike Frysinger <email@example.com> Tested-by: Olya Kalitova <firstname.lastname@example.org> Commit-Queue: Olya Kalitova <email@example.com> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: adb92062928102bd5f5c61641a7b426fff8c8304
This directory (
platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.