|author||Mike Frysinger <firstname.lastname@example.org>||Fri Jul 31 21:24:44 2020|
|committer||Mike Frysinger <email@example.com>||Tue Aug 04 15:15:51 2020|
common-mk: check-owners: drop noparents settings There is no top-level owners currently, so noparent isn't doing anything. It is causing problems though when we try to inherit the files in other subdirs which have parent owners. BUG=None TEST=upload still works Exempt-From-Owner-Approval: touching all the files! Change-Id: I314449a02300979ae52dffa754582bc0cfc321e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2332953 Reviewed-by: Stephane Belmon <firstname.lastname@example.org> Tested-by: Mike Frysinger <email@example.com> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 3bedb01f0bbf8767db84c3dace0a1a126ce304b5
This directory (
platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.