Remove borealis test plan BUG=b:473836046 TEST=CQ Change-Id: I13ac8659cb523a3de708ee8cfc968fda531f0a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/7517144 Reviewed-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> Commit-Queue: David Stevens <stevensd@chromium.org> Tested-by: David Stevens <stevensd@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 046745de561c0c175c30534adcc7205cc2bb43aa
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.