shill: wifi: move RekeyInProgress property from Device to Service It (arguably) belongs there, and also needs to be there for tests to make better use of it. BUG=b:171086223 TEST=unit tests Change-Id: I77efdc21fe0f521e06b1f847e0e0471b19f4e6e7 Disallow-Recycled-Builds: hatch-cq, kevin-cq, kukui-cq, octopus-cq, scarlet-cq Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2594708 Commit-Queue: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> GitOrigin-RevId: 3ad7c5424eb72456ac7dff67b10a1afa414cba42
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.