commit | 5ec9bfcd3b7e33d78e76872b837d0683bd6c68f3 | [log] [tgz] |
---|---|---|
author | Clark Chung <clarkchung@google.com> | Thu May 21 10:17:57 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Tue May 26 19:42:43 2020 |
tree | 299e675936274071872b6bb33dab8c415f394888 | |
parent | f7fcc27f256f147cc85687be6b50ead3e2317ab3 [diff] |
system_api: add information field in probe results Add information message in probe results for Runtime Probe or Hardware Verifier to handle miscellaneous probe issues. For example, comp_group is used to group multiple probe statements to one identifier in order to handle different probe values of the same component in different firmware versions. BUG=b:155030911 TEST=manual test Change-Id: I6d27397599ec12e9b5f23d1f8df903b3812b1a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2212063 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Clark Chung <ckclark@chromium.org> Commit-Queue: Clark Chung <ckclark@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 54638904dae4c6eff8acd82c99967778d3b3d8ea
This directory (platform2/system_api
) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.