| commit | 6bf8fe794020283974d1adcbb4a42b452aeee481 | [log] [tgz] |
|---|---|---|
| author | Ryo Hashimoto <hashimoto@chromium.org> | Fri Jun 10 09:31:33 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Jun 17 01:08:12 2022 |
| tree | 51413af556c6c7c0ca99b05516e2fc34b14c5be2 | |
| parent | a97789ca4417e1a4943f8349a6d06690f5e6b8df [diff] |
Revert "concierge: Add Vsock Connection to ARCVM's LMKD" This reverts commit 156a8342e506465510a5c4e1797b0507fd23827f. Reason for revert: Causing shutdown hang b/229032436 Original change's description: > concierge: Add Vsock Connection to ARCVM's LMKD > > To better respond to quickly changing memory pressure situations in > ARCVM, concierge will maintain a vsock connection to LMKD. When LMKD > thinks it needs to kill, it will ask concierge to confirm this kill. > Based on the priority of the candidate process, concierge will either > deflate the virtio balloon of ARCVM to make room for the process, or > instruct LMKD to proceed with the kill. > > BUG=b:210075795 > TEST=CQ, cros_run_unit_tests --board volteer --packages > chromeos-base/vm_host_tools, manual local integration testing with > LMKD changes > > Change-Id: I375891b0f7ac6155ce67c23bf1e434647d1c0ace > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3510915 > Commit-Queue: Kameron Lutes <kalutes@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Tested-by: Kameron Lutes <kalutes@chromium.org> Bug: b:210075795 Change-Id: I1338f03c190fdf6f161a8d8dacb06350550b6e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3699764 Auto-Submit: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 947265bd3a3d374a037edb186fdd5354dc0c5e07
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.