| commit | 85d6b46cc2f0a15cd3815436ff4cefd4142c87f7 | [log] [tgz] |
|---|---|---|
| author | Cheng-Han Yang <chenghan@google.com> | Thu Jun 23 06:46:51 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Jun 27 15:30:39 2022 |
| tree | aedef360b714c4923828c06562c3e82d8f5f0005 | |
| parent | 87de17db3f400b8549181b7a6d42a4aea2047308 [diff] |
system_api: Add |ExternalDiskDetected| signal for rmad BUG=b:236798675 TEST=emerge-octopus chromeos-base/system_api Change-Id: I1b89c3325e5da1343232a53503060064c4b785e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3716439 Commit-Queue: Cheng-Han Yang <chenghan@chromium.org> Tested-by: Cheng-Han Yang <chenghan@chromium.org> Reviewed-by: Gene Chang <genechang@google.com> NOKEYCHECK=True GitOrigin-RevId: 8dbd54b5d27a1292e54511a8f8eab80f2e420986
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.