| commit | 7d8f33c777ede63382325990c42a041c8a62a515 | [log] [tgz] |
|---|---|---|
| author | Brian Norris <briannorris@chromium.org> | Sat Jun 06 00:40:28 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Jun 12 10:15:34 2020 |
| tree | f61429159117637f27b12a91392935f166a8ac13 | |
| parent | 4761ddce27a6ce349a2c458822e02b31bccd4930 [diff] |
shill: wifi: drop all 802.11w parsing, D-Bus property All 802.11w logic is unconditional in shill now (we tell wpa_supplicant to use it if the AP supports it), so we don't need any of this, apart from informational/debugging support. We already get this capability/required info from things like 'iw <dev> scan dump' (available in 'wifi_status' in feedback reports, for one) already. There's no client of the D-Bus property, so it's safe to drop immediately. BUG=chromium:219950 TEST=unit tests; `connectivity show Services` Change-Id: I44baa54671a2c2c7ed0b1faba25106382d820a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2238746 Tested-by: Brian Norris <briannorris@chromium.org> Reviewed-by: Matthew Wang <matthewmwang@chromium.org> Reviewed-by: Hugo Benichi <hugobenichi@google.com> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> Commit-Queue: Brian Norris <briannorris@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 32ad59fcf55f46f1d8dad02aa1bef279040523a5
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.