commit | 87de17db3f400b8549181b7a6d42a4aea2047308 | [log] [tgz] |
---|---|---|
author | Jintao Lin <jintaolin@chromium.org> | Tue May 31 03:59:16 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Sun Jun 26 05:16:15 2022 |
tree | 54817b26e115b03489b6da472729e755cb1aeeaa | |
parent | fc2dd44777bceefeaf7b8d290940d37ed698e9f6 [diff] |
system_api: Add tethering DBus properties BUG=b:225767403 TEST=cros-workon-${BOARD} start chromeos-base/system_api TEST=FEATURES=test emerge-${BOARD} chromeos-base/system_api Change-Id: I5bef18a23ca8d4e3e48d7add60c8eadc7e093add Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3678067 Tested-by: Jintao Lin <jintaolin@chromium.org> Reviewed-by: Hugo Benichi <hugobenichi@google.com> Commit-Queue: Jintao Lin <jintaolin@chromium.org> Reviewed-by: Matthew Wang <matthewmwang@chromium.org> NOKEYCHECK=True GitOrigin-RevId: b59da3208b4fb3261e451f2ff3d4ca4003724a5f
This directory (platform2/system_api
) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.