|author||Harvey Yang <email@example.com>||Tue Jul 21 02:57:08 2020|
|committer||Commit Bot <firstname.lastname@example.org>||Tue Aug 04 07:34:12 2020|
system_api: Add Iioservice DBus Constants This commit adds iioservice DBus constants to establish the mojo channel between iioservice and Chromium. BUG=b:162189963 TEST=builds and runs on octopus Change-Id: Ifa883fa89e3d00523ba680042f6bced144cdb9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2309410 Reviewed-by: Mike Frysinger <email@example.com> Reviewed-by: Cheng-Hao Yang <firstname.lastname@example.org> Reviewed-by: Heng-ruey Hsu <email@example.com> Tested-by: Cheng-Hao Yang <firstname.lastname@example.org> Commit-Queue: Cheng-Hao Yang <email@example.com> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: a218d04eef046b7520a3e5b43129c406a8342682
This directory (
platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.