| commit | 8948df0099fefebf0aa63f0adbd5a5f87135ae35 | [log] [tgz] |
|---|---|---|
| author | Curtis Malainey <cujomalainey@chromium.org> | Mon Jul 06 19:27:46 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Aug 14 03:41:47 2020 |
| tree | 73e9d0214443039e54e0c1929e170ac36daca106 | |
| parent | 63c9de2bf41a7221139de845687e5f2bf8364d05 [diff] |
system_api: remove mic position constant MicPositions are not used by anyone, so we are removing the whole system. BUG=b:159943667 TEST=Build test adhd Change-Id: I2e71d140851f9f7bb12ea84d92e0fdb4055ce7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2283849 Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Curtis Malainey <cujomalainey@chromium.org> Commit-Queue: Curtis Malainey <cujomalainey@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 5942a5d29b5d9e408c29142f1dbbae3216937494
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.