| commit | 98ffe74a1036ae363a12dc57d14dd88535504dcb | [log] [tgz] |
|---|---|---|
| author | Michael Checo <michaelcheco@google.com> | Tue Jun 21 17:52:30 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jul 07 22:28:43 2022 |
| tree | d7191b37371f6c392f8b546ffee3a93ad9f90592 | |
| parent | 95ba8b36c447f6e45b35363b6a1c53972d178661 [diff] |
rgbkbd: Add kFourZoneTwelveLed/kFourZoneFifteenLed to KeyboardCapabilities
BUG=b:214077425
TEST=cros_workon_make --board=${BOARD} chromeos-base/rgbkbd --test
Change-Id: Ic9f2a106e258d765a2eceda136440571ba7d9b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3717167
Tested-by: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Michael Checo <michaelcheco@google.com>
NOKEYCHECK=True
GitOrigin-RevId: ee1cef7c92e70e6bca89610804eae28249804137
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.