| commit | 9d2399ea2761ee51ef38af0b3ba31c5117b248e8 | [log] [tgz] |
|---|---|---|
| author | Joel Hockey <joelhockey@chromium.org> | Mon Jun 08 04:39:37 2020 |
| committer | Joel Hockey <joelhockey@chromium.org> | Tue Jun 09 09:56:06 2020 |
| tree | dc951ccc215d4c9120fcd7e4b9124fe14a050693 | |
| parent | 30a12396140637161f5557e300b7f514beefc7b5 [diff] |
system_api: Add seneschal share type ARCHIVE BUG=chromium:1091611 TEST=vm.CrostiniFiles Change-Id: I649a8470afd98a1173f565b866322ea4d1e7cc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2234375 Tested-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: François Degros <fdegros@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 58ce052e29b4bbf36bd86fa2ea60658c5878f62a
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.