| commit | ef46799ec27b5894cf8229c98e2a90942a2be403 | [log] [tgz] |
|---|---|---|
| author | Kevin Lin <kevinptt@chromium.org> | Wed Jun 17 11:17:33 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Jul 03 13:39:10 2020 |
| tree | 1020d8c2f3ebc74e886811116084257c56c5e646 | |
| parent | 3fe6a2b89cc177513fd8ce295af6993a60adc61f [diff] |
runtime_probe: add protobuf fields for edid This CL adds protobuf fields for edid, and also introduces categories display_panel. BUG=b:159197877 TEST=run hardware_verifier with generated payloads on DUT Change-Id: I8dad83b12f605cfc4a0c60f6d8e0a09c58604d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2251538 Tested-by: Kevin Lin <kevinptt@chromium.org> Auto-Submit: Kevin Lin <kevinptt@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Clark Chung <ckclark@chromium.org> Commit-Queue: Kevin Lin <kevinptt@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: c82d6d8e321f68b056238f372405b10e17a5686d
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.