| commit | f128b7f3cefbc3dd055eda6ae7e7744271de10e0 | [log] [tgz] |
|---|---|---|
| author | Kevin Lin <kevinptt@chromium.org> | Wed Jun 17 11:41:12 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Jun 25 09:37:38 2020 |
| tree | 7b075ed5e0b861266d64cf5a75534e56053f4b5a | |
| parent | 1609e471b69ac5a2bf6367036fb2d4944f7ade2d [diff] |
runtime_probe: add protobuf fields for memory This CL adds protobuf fields for memory, and also introduces category dram. BUG=b:159186984 TEST=run hardware_verifier with generated payloads on DUT Change-Id: I0096e33db9ae040adbd6ac914ce2033e4638a7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2256637 Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Clark Chung <ckclark@chromium.org> Tested-by: Clark Chung <ckclark@chromium.org> Commit-Queue: Clark Chung <ckclark@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: f893e46fb86e93ddd978c6545b58648ac0679195
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.