| commit | f7fcc27f256f147cc85687be6b50ead3e2317ab3 | [log] [tgz] |
|---|---|---|
| author | Amin Hassani <ahassani@chromium.org> | Sun May 24 21:10:32 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon May 25 01:42:51 2020 |
| tree | 6990fdc47ae2293b81e1c2449e5026de98dee938 | |
| parent | c98dff2475747ebeba85aad927e844ff238d314f [diff] |
system_api: Add missing signal DlcStateChanged in dlcservice We forgot this in crrev.com/c/2207631 BUG=chromium:1071260 TEST=CQ passes Change-Id: Iebf6543207d3120d327eec49621fb0e8e973404c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2214335 Reviewed-by: Amin Hassani <ahassani@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 18618dc7a1e57008429584cd5408407ac161bd97
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.