Google Git
Sign in
chromium / chromiumos / platform2 / system_api / refs/heads/main
commitdc5729d39a84b6630466d6a522ebff95580bbb32[log] [tgz]
authorYuanpeng Ni <yuanpengni@chromium.org>Tue Aug 16 21:27:24 2022
committerCopybara-Service <copybara-worker@google.com>Fri Aug 19 00:12:33 2022
treede0bfb1933a375984d9a9fecabe6b42c9e0981e9
parent067443a1a00e07982a21980baca35c20dc7cabe9 [diff]
system_api: Add ApplyDeferredUpdateAdvanced method and proto

Add the ApplyDeferredUpdateAdvanced method that takes an input proto to
configure the behavior of applying the deferred update.

BUG=b:240469388
TEST=CQ

Change-Id: I29af6a683684a424e6d9dae48334460e015948d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3831068
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
Tested-by: Yuanpeng Ni‎ <yuanpengni@chromium.org>
Commit-Queue: Yuanpeng Ni‎ <yuanpengni@chromium.org>
NOKEYCHECK=True
GitOrigin-RevId: 747a0c074a0a3bdf0fed348b192764833c96c102
2 files changed
tree: de0bfb1933a375984d9a9fecabe6b42c9e0981e9
  1. constants/
  2. dbus/
  3. mojo/
  4. src/
  5. switches/
  6. .gitignore
  7. BUILD.gn
  8. build.rs
  9. Cargo.toml
  10. LICENSE
  11. OWNERS
  12. README.md
  13. system_api.pc
README.md

This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.

This directory is only for things like headers and .proto files. No implementation should be added.

When writting a .proto file make sure to use:

option optimize_for = LITE_RUNTIME;

This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.

When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.